From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEF55C433E0 for ; Tue, 16 Feb 2021 09:42:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BE5564DE0 for ; Tue, 16 Feb 2021 09:42:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229903AbhBPJmP (ORCPT ); Tue, 16 Feb 2021 04:42:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:52836 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229713AbhBPJmL (ORCPT ); Tue, 16 Feb 2021 04:42:11 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7462C64E09; Tue, 16 Feb 2021 09:41:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613468488; bh=ymFlalVSZE6VvUvNX82uucfKhpqKL/xJZkolfuRFQfQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=hrQ/XJ/UOFNn31C0IOXrJGDZckwsx3OL2WsDqb+T1bTQydlo8pzsTIbTTjoBQ7ib4 olZ7U43phHxWbKexly6xYaIC1xIKidezSkFY6LLLDynYO1Goc/QLNtK4leGgNoNNbA N8/Ch9RXkQ5Ft2h5szM5LXeR6neqbzpsT+970sjg7BF007syqLH+J2wWmIlnBGRKUX 31+15m2RqN5uSKnYd+IuxVzaTFACpjCutYERYsESukRW0gv8E8xhOV/Rz0j2fLqvon z8nQBENypfgPKEa/uNVunaWg38ce3mG+Y37AWFjOreyZ7onBoIRjaG+IZ0zSHu94bM S1vpeCrz0fPLQ== Received: by mail-ot1-f50.google.com with SMTP id q4so8463433otm.9; Tue, 16 Feb 2021 01:41:28 -0800 (PST) X-Gm-Message-State: AOAM531tjXGVgHRyEzrTs9uW0wjped0nf217lmbNpr/wwEOCd1fTuzr8 OFoJ/Ctm/TEX5+f8xV2kL3GFQ7IJe0rBDve4+w4= X-Google-Smtp-Source: ABdhPJxiaMAcH5KZayQiwUcYPr4wMM3nIbzsy3wljGGJAybFgS6PcvoGnnAHy1bNygzh3LOoHKqncABSes1Q8IbFeJs= X-Received: by 2002:a9d:6c11:: with SMTP id f17mr14126556otq.210.1613468487646; Tue, 16 Feb 2021 01:41:27 -0800 (PST) MIME-Version: 1.0 References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-15-marcan@marcan.st> In-Reply-To: <20210215121713.57687-15-marcan@marcan.st> From: Arnd Bergmann Date: Tue, 16 Feb 2021 10:41:11 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 14/25] dt-bindings: interrupt-controller: Add DT bindings for apple-aic To: Hector Martin Cc: Linux ARM , Marc Zyngier , Rob Herring , Olof Johansson , Krzysztof Kozlowski , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , DTML , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 15, 2021 at 1:17 PM Hector Martin wrote: > + > + The 2nd cell contains the interrupt number. > + - HW IRQs: interrupt number > + - FIQs: > + - 0: physical HV timer > + - 1: virtual HV timer > + - 2: physical guest timer > + - 3: virtual guest timer I wonder if you could just model the FIQ as a single shared level interrupt (which is essentially what it is), and have every driver that uses it do a request_irq() on the same IRQ number. This would avoid having to come up with a fake binding for it, and simplify the implementation that then no longer has to peek into each interrupt source. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DFDBC433DB for ; Tue, 16 Feb 2021 09:43:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 210C264DDA for ; Tue, 16 Feb 2021 09:43:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 210C264DDA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bm1k5sk7kYcZdqx0o0S9d/pcbLm9aQ38dCIVAsqsvY4=; b=Im1mnF8x7RYmp1LdVAIFJb5/S z2i54+56TA+9mMHPz12lZ2yGB7QtaGQ5ajL5haJWRm/7KPSn0Ubn9NLKnL3Da1ITMCs1FLMxMAgDL Sl06SG1qoAh7Bdji+vYTf7jOn3BONYnZB/SV7g1ylQU3d3taVlM1Db9zVQ6RXNZHVek/f402Jf3dG ZiNGz6Mp4uKnymL6ngGEZmsEZtPAVWL8uo8N2cDVF9boVTKPrt3ZBZQlDxZPuwQ4WaHkYaPyXFRQy HIWwzNbWW6tZepn87yVf5ysSE60F+P6KZPS+/jF8kPOpaKcDI6o4l909XYT/UCL6R38BbOIpGX3I4 meiOe/Fgw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lBwrM-0002v3-V8; Tue, 16 Feb 2021 09:41:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lBwrK-0002uc-0E for linux-arm-kernel@lists.infradead.org; Tue, 16 Feb 2021 09:41:30 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 67F7B64DE0 for ; Tue, 16 Feb 2021 09:41:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613468488; bh=ymFlalVSZE6VvUvNX82uucfKhpqKL/xJZkolfuRFQfQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=hrQ/XJ/UOFNn31C0IOXrJGDZckwsx3OL2WsDqb+T1bTQydlo8pzsTIbTTjoBQ7ib4 olZ7U43phHxWbKexly6xYaIC1xIKidezSkFY6LLLDynYO1Goc/QLNtK4leGgNoNNbA N8/Ch9RXkQ5Ft2h5szM5LXeR6neqbzpsT+970sjg7BF007syqLH+J2wWmIlnBGRKUX 31+15m2RqN5uSKnYd+IuxVzaTFACpjCutYERYsESukRW0gv8E8xhOV/Rz0j2fLqvon z8nQBENypfgPKEa/uNVunaWg38ce3mG+Y37AWFjOreyZ7onBoIRjaG+IZ0zSHu94bM S1vpeCrz0fPLQ== Received: by mail-ot1-f47.google.com with SMTP id l23so8451433otn.10 for ; Tue, 16 Feb 2021 01:41:28 -0800 (PST) X-Gm-Message-State: AOAM532EXQQmq693va8TYWZIFhWe4cGMKyA06dAm5iO0tMdy/4Xr/XIr 2j3n2UxTOJUwQjAMctov3kmUzN/n2AOlwlgDAug= X-Google-Smtp-Source: ABdhPJxiaMAcH5KZayQiwUcYPr4wMM3nIbzsy3wljGGJAybFgS6PcvoGnnAHy1bNygzh3LOoHKqncABSes1Q8IbFeJs= X-Received: by 2002:a9d:6c11:: with SMTP id f17mr14126556otq.210.1613468487646; Tue, 16 Feb 2021 01:41:27 -0800 (PST) MIME-Version: 1.0 References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-15-marcan@marcan.st> In-Reply-To: <20210215121713.57687-15-marcan@marcan.st> From: Arnd Bergmann Date: Tue, 16 Feb 2021 10:41:11 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 14/25] dt-bindings: interrupt-controller: Add DT bindings for apple-aic To: Hector Martin X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210216_044130_124478_7FE43F19 X-CRM114-Status: GOOD ( 11.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Rob Herring , DTML , Tony Lindgren , Marc Zyngier , Linus Walleij , "linux-kernel@vger.kernel.org" , Krzysztof Kozlowski , Alexander Graf , Olof Johansson , Mohamed Mediouni , Stan Skowronek , Will Deacon , Linux ARM , Mark Kettenis Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 15, 2021 at 1:17 PM Hector Martin wrote: > + > + The 2nd cell contains the interrupt number. > + - HW IRQs: interrupt number > + - FIQs: > + - 0: physical HV timer > + - 1: virtual HV timer > + - 2: physical guest timer > + - 3: virtual guest timer I wonder if you could just model the FIQ as a single shared level interrupt (which is essentially what it is), and have every driver that uses it do a request_irq() on the same IRQ number. This would avoid having to come up with a fake binding for it, and simplify the implementation that then no longer has to peek into each interrupt source. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel