From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56454C433DB for ; Fri, 15 Jan 2021 12:05:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 096D62371F for ; Fri, 15 Jan 2021 12:05:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730388AbhAOMFv (ORCPT ); Fri, 15 Jan 2021 07:05:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:33044 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726278AbhAOMFu (ORCPT ); Fri, 15 Jan 2021 07:05:50 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id CEAC5238EB for ; Fri, 15 Jan 2021 12:05:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610712308; bh=3V9YgqwfCB9ETu7vLXXaseU8NA9t72oMsp6sjmLYI4Q=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=HUb+cSyHFudL1n0aRcQCKP9IbSE9++VdVFL/NMkaWcC5fzHtTosni2avPTVPydhKL 5i4P9f7U3z+sB6nkAj6eGCDXnv3GuB+70YsYUWfq0qcbindDBbzFLzP9tWwApkLNHd acXap9ET5i/9XA1lRAYRn/Re6yQPY7qhMqpWP++FaQLkC9+1h27BC37VFU7uwj8+Xo chVtfya1zstM6CvsB/fIZtdOLapsZknEFjdCwv/JMZ2KgaUydwofdk/JtoMZPcQ8WN ha4FMRoc3APG0n1JysMdkn8MM/nq3YXbapcAXm5sWU/Zu9EkJopQpkGJrc5NT6h/8z 5DFxy4fU9kEVw== Received: by mail-ot1-f46.google.com with SMTP id b24so8312100otj.0 for ; Fri, 15 Jan 2021 04:05:08 -0800 (PST) X-Gm-Message-State: AOAM532kKyeFe/9TutznCkCy8QZAF0PoGWMnIA3epSKjRATDmfxQvqsi +nS037xbIi9A60XjVMVWwWtThEUaSI3S6fBP3uM= X-Google-Smtp-Source: ABdhPJwDY0gtt9AZV/Oq8OAS9zQr424m/yvdwXMVC3cBMuaELzC4yGMUUWhDHXq8OJLgz0w6Q1ZXl+uSsK9+FqZ9ECA= X-Received: by 2002:a9d:7a4b:: with SMTP id z11mr7991233otm.305.1610712307942; Fri, 15 Jan 2021 04:05:07 -0800 (PST) MIME-Version: 1.0 References: <60013F54.9050305@hisilicon.com> <14914300-b98a-fc60-fc06-0a6d62729d8e@huawei.com> In-Reply-To: <14914300-b98a-fc60-fc06-0a6d62729d8e@huawei.com> From: Arnd Bergmann Date: Fri, 15 Jan 2021 13:04:51 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v2] Old platforms: bring out your dead To: "Leizhen (ThunderTown)" Cc: Wei Xu , Linux ARM , Linux Kernel Mailing List , Krzysztof Adamski , Oleksij Rempel , Baruch Siach , Russell King - ARM Linux , Daniel Tang , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Jamie Iles , Barry Song , Viresh Kumar , Linus Walleij , Jonas Jensen , Marc Gonzalez , Hartley Sweeten , Lubomir Rintel , Neil Armstrong , Shawn Guo , Alex Elder , Alexander Shiyan , Koen Vandeputte , Hans Ulli Kroll , Vladimir Zapolskiy , Steven Rostedt , Yoshinori Sato , Mark Salter , Michael Ellerman , Geert Uytterhoeven , Thomas Bogendoerfer , Tony Prisk , Krzysztof Halasa Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 15, 2021 at 12:09 PM Leizhen (ThunderTown) wrote: > On 2021/1/15 17:26, Arnd Bergmann wrote: > > On Fri, Jan 15, 2021 at 8:08 AM Wei Xu wrote: > >> On 2021/1/14 0:14, Arnd Bergmann wrote: > >>> On Fri, Jan 8, 2021 at 11:55 PM Arnd Bergmann wrote: > >>> * mmp -- added in 2009, DT support is active, but board files might go > >>> * cns3xxx -- added in 2010, last fixed in 2019, probably no users left > >>> * hisi (hip01/hip05) -- servers added in 2013, replaced with arm64 in 2016 > >> > >> I think it is OK to drop the support of the hip01(arm32) and hip05(arm64). > >> Could you also help to drop the support of the hip04(arm32) which I think nobody use as well? > > > > Thank you for your reply! I actually meant to write hip04 instead of hip05, > > so I was only asking about the two 32-bit targets. I would expect that > > hip05 still has a few users, but wouldn't mind removing that as well if you > > are sure there are none. > > > > Since Zhen Lei is starting to upstream Kunpeng506 and Kunpeng509 > > support, can you clarify how much reuse of IP blocks there is between > > hip04 and those? In particular, hip04 has custom code for (at least) > > platmcpm, clk, irqchip, ethernet, and hw_rng, probably more as those > > were only the ones I see on a quick grep. > > > > If we remove hip04, should we remove all these drivers right away, > > or keep some of them around? > > I think the drivers should be kept. Ok, will do. > Currently, at least hip04_eth.c and irq-hip04.c are used. These drivers > were originally written for Hip04, but the drivers used by other boards > maybe similar to them. Therefore, these drivers are extended without > adding new drivers. Right, so the other chips just use compatible="hisilicon,hip04-intc" etc. in their device trees? Is there a public copy of the dts files somewhere that I can use for cross-referencing? Sorry if I'm messing up the timeline for your upstreaming plans. It might actually be easier to leave hip01 and hip04 in the tree for the moment until you have upstreamed the other SoC support, and then we clean up by removing the unused bits afterwards. I'll leave it to you both to tell me which way is easier for you. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29CBCC433E0 for ; Fri, 15 Jan 2021 12:06:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C08CA23128 for ; Fri, 15 Jan 2021 12:06:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C08CA23128 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Q0Jh+zqKNROxA5muACceVZXa2NXxm+aollyf1fAns3w=; b=cM6vehbOHC7PjGpjzjdtDrrte DjSprHPX3AiB+82T3y/JKCS+5fS/BZwm/B5fFIReVnof0XJEAep1/FQiZGgy+Fuk8qsDFaecudm2J h3B1pyhq7D1Ntu4rdSnimzoGr/Dkyi4nxS3hLJZMakJmaAhOP+f2yPJ5m7iX9h7o/CGulcFUBBHuj qSmO8uyEHlaoVWMhULuF04A0nm7Z4wHhIQibC8oswFuAY0/tGRa08BlLILZiihUP/pkcvaaMlsMZc m/UrVI7ngMe3jTcInqvjcM9Eq60tuC9q20GIIGjeB79NLaOuHquK/Pk1FeYUTZiQCA5vMAAwUGLv6 prOC/dYqA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l0Nqp-0006Eb-GN; Fri, 15 Jan 2021 12:05:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l0Nqn-0006Do-Hr for linux-arm-kernel@lists.infradead.org; Fri, 15 Jan 2021 12:05:10 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 967E423128 for ; Fri, 15 Jan 2021 12:05:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610712308; bh=3V9YgqwfCB9ETu7vLXXaseU8NA9t72oMsp6sjmLYI4Q=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=HUb+cSyHFudL1n0aRcQCKP9IbSE9++VdVFL/NMkaWcC5fzHtTosni2avPTVPydhKL 5i4P9f7U3z+sB6nkAj6eGCDXnv3GuB+70YsYUWfq0qcbindDBbzFLzP9tWwApkLNHd acXap9ET5i/9XA1lRAYRn/Re6yQPY7qhMqpWP++FaQLkC9+1h27BC37VFU7uwj8+Xo chVtfya1zstM6CvsB/fIZtdOLapsZknEFjdCwv/JMZ2KgaUydwofdk/JtoMZPcQ8WN ha4FMRoc3APG0n1JysMdkn8MM/nq3YXbapcAXm5sWU/Zu9EkJopQpkGJrc5NT6h/8z 5DFxy4fU9kEVw== Received: by mail-ot1-f52.google.com with SMTP id r9so8250261otk.11 for ; Fri, 15 Jan 2021 04:05:08 -0800 (PST) X-Gm-Message-State: AOAM532vZv4wRTg0gE5hNvwGsoxTEqarpJIjq1PqCxnyrvvx38CQF8Ky CDXD4P7Qpdj9E9agYQ4xudT4uSufQrUNjLScrYM= X-Google-Smtp-Source: ABdhPJwDY0gtt9AZV/Oq8OAS9zQr424m/yvdwXMVC3cBMuaELzC4yGMUUWhDHXq8OJLgz0w6Q1ZXl+uSsK9+FqZ9ECA= X-Received: by 2002:a9d:7a4b:: with SMTP id z11mr7991233otm.305.1610712307942; Fri, 15 Jan 2021 04:05:07 -0800 (PST) MIME-Version: 1.0 References: <60013F54.9050305@hisilicon.com> <14914300-b98a-fc60-fc06-0a6d62729d8e@huawei.com> In-Reply-To: <14914300-b98a-fc60-fc06-0a6d62729d8e@huawei.com> From: Arnd Bergmann Date: Fri, 15 Jan 2021 13:04:51 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v2] Old platforms: bring out your dead To: "Leizhen (ThunderTown)" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210115_070509_791236_8A995C63 X-CRM114-Status: GOOD ( 27.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Baruch Siach , Geert Uytterhoeven , Neil Armstrong , Viresh Kumar , Linus Walleij , Daniel Tang , Jamie Iles , Krzysztof Adamski , Alexander Shiyan , Michael Ellerman , Russell King - ARM Linux , Wei Xu , Oleksij Rempel , Alex Elder , Marc Gonzalez , Hans Ulli Kroll , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Steven Rostedt , Vladimir Zapolskiy , Lubomir Rintel , Krzysztof Halasa , Koen Vandeputte , Linux ARM , Barry Song , Thomas Bogendoerfer , Yoshinori Sato , Linux Kernel Mailing List , Jonas Jensen , Tony Prisk , Hartley Sweeten , Mark Salter , Shawn Guo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 15, 2021 at 12:09 PM Leizhen (ThunderTown) wrote: > On 2021/1/15 17:26, Arnd Bergmann wrote: > > On Fri, Jan 15, 2021 at 8:08 AM Wei Xu wrote: > >> On 2021/1/14 0:14, Arnd Bergmann wrote: > >>> On Fri, Jan 8, 2021 at 11:55 PM Arnd Bergmann wrote: > >>> * mmp -- added in 2009, DT support is active, but board files might go > >>> * cns3xxx -- added in 2010, last fixed in 2019, probably no users left > >>> * hisi (hip01/hip05) -- servers added in 2013, replaced with arm64 in 2016 > >> > >> I think it is OK to drop the support of the hip01(arm32) and hip05(arm64). > >> Could you also help to drop the support of the hip04(arm32) which I think nobody use as well? > > > > Thank you for your reply! I actually meant to write hip04 instead of hip05, > > so I was only asking about the two 32-bit targets. I would expect that > > hip05 still has a few users, but wouldn't mind removing that as well if you > > are sure there are none. > > > > Since Zhen Lei is starting to upstream Kunpeng506 and Kunpeng509 > > support, can you clarify how much reuse of IP blocks there is between > > hip04 and those? In particular, hip04 has custom code for (at least) > > platmcpm, clk, irqchip, ethernet, and hw_rng, probably more as those > > were only the ones I see on a quick grep. > > > > If we remove hip04, should we remove all these drivers right away, > > or keep some of them around? > > I think the drivers should be kept. Ok, will do. > Currently, at least hip04_eth.c and irq-hip04.c are used. These drivers > were originally written for Hip04, but the drivers used by other boards > maybe similar to them. Therefore, these drivers are extended without > adding new drivers. Right, so the other chips just use compatible="hisilicon,hip04-intc" etc. in their device trees? Is there a public copy of the dts files somewhere that I can use for cross-referencing? Sorry if I'm messing up the timeline for your upstreaming plans. It might actually be easier to leave hip01 and hip04 in the tree for the moment until you have upstreamed the other SoC support, and then we clean up by removing the unused bits afterwards. I'll leave it to you both to tell me which way is easier for you. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel