From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E929C32771 for ; Thu, 9 Jan 2020 10:15:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D99C32072E for ; Thu, 9 Jan 2020 10:15:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728891AbgAIKP3 (ORCPT ); Thu, 9 Jan 2020 05:15:29 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:58619 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728588AbgAIKP3 (ORCPT ); Thu, 9 Jan 2020 05:15:29 -0500 Received: from mail-qt1-f175.google.com ([209.85.160.175]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.145]) with ESMTPSA (Nemesis) id 1M1pfy-1irghj1B7o-002ESQ for ; Thu, 09 Jan 2020 11:15:27 +0100 Received: by mail-qt1-f175.google.com with SMTP id d5so5432986qto.0 for ; Thu, 09 Jan 2020 02:15:27 -0800 (PST) X-Gm-Message-State: APjAAAWeEAe4ETeznO3GbdhuyZ3+xjhHJqjLRippVDnevcjJkxZg4QhD wtfUjSFLGUvAI0HZZzG7FINrClP6hWvJgWCY0v8= X-Google-Smtp-Source: APXvYqzHV85HzfRjo8JlOR7BQz04so9X1K640UDSw+epDZK35idc8VpNX/nwHxi15Ydw7e0XfccuvrKcfiArbEs3SrU= X-Received: by 2002:ac8:6153:: with SMTP id d19mr7257120qtm.18.1578564926199; Thu, 09 Jan 2020 02:15:26 -0800 (PST) MIME-Version: 1.0 References: <5c545c2866ba075ddb44907940a1dae1d823b8a1.1575019719.git.viresh.kumar@linaro.org> <20200109093442.4jt44eu2zlmjaq3f@vireshk-i7> In-Reply-To: <20200109093442.4jt44eu2zlmjaq3f@vireshk-i7> From: Arnd Bergmann Date: Thu, 9 Jan 2020 11:15:09 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] firmware: arm_scmi: Make scmi core independent of transport type To: Viresh Kumar Cc: Sudeep Holla , peng.fan@nxp.com, Vincent Guittot , Jassi Brar , "linux-kernel@vger.kernel.org" , Linux ARM Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:CqTd4qZC67ym+p5h/uuW+mbbanvKbbqb3v0pSh43/1kGmRagk8r 6PEoY7oAilBHDfDijR0paIm3JTh0IDt9JI7aq5z4ULVKYqzEvkltPyc94GZpvE7gmXV+p5g NZx0H6YG3EVWHVu0NgHbc57CJ2SObALV6jaF0XwBUEJDqhPWInsB+X0xYoR6qJPVAy22pTc Af9KjGmRHJZg0MY6jpx5A== X-UI-Out-Filterresults: notjunk:1;V03:K0:Im2U+1dhrSs=:Z+yOeBP8SvmRdTHVLpAC5J eRCxrCBqPSVZXrUleWcthJO2SChPPwRtGnbSkpjOJ1gr6n/s2w5advJ2OaxNkd1DmAUVp0+JN lHQAsfcmWJKxKAH9tU1WCxx3wvRkWv7z8qkQP719bhl6pm0ySMyuH/262isq80iLfGIBBAxOp 5dt2QZSIeYhR2DYnzTNKu5rD/PHG4x+YUI+ePCQYtLLt2UvJF3CfMDxnbLvT6fUD8PSTSB5Fl a/W2AHZ7NSB+ac2iIYVCKdcExUjKYHoG9n9kb7BiIuJ9dXoFfcQMx+4WHnH2dDkSXY+fG0M5y KgMR9NSQ69xFzW57OAWddRBiNkahGSDS9UzDlwvYpo8k3KHqInbkErTW6T8Kkl2Rfe5Bx5DJ9 GWzQZovYuAjb/BvqcX+HCRPsZmLxy33L8WyhCXl3EYZ9SuB5/LtKUYtN7+E+H0o0JtUJHKpl7 c3n4iPc9aKpn238bBAJoFBqns2C/CpgRa4/KryJfJ4Y0wzwW2AB+rJN9Akwyt2NAaPZQTivNC BLVWZ30bxqk55iiyo7kZEyoq0SAA8dQe6FgdhFN9jDaN4Ja/T7PgwQjjIqGr8JA5VsG3fh6m9 KeRcehVZuYWxH0QxUVsg3hEK4/hWmg6OWU21gQ1z7FQISVwaznE4BpZQotlP4S4FPrzXQGxLi ov+Ipmzhh8j6k50/lEbEOY7P7upflN6gJQ870PAyNgzgY8VmVZnCFICXO3TlBptdttnq/oAip 6UKxtVZlAn9j81rPhqDKOMMtITT/knoaNqf0DWwi+l4eyDTi4Qupqt/ZllpPIZqbdbASSmrKH E6lZ39L9WtGdmQf0S+4RAKR+rXez2RHanKBZ3SV4H94kNbOLu+348q0puG9XgA39keLCSLNE4 7c/qY/IvRkyHElxvgV2w== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 9, 2020 at 10:34 AM Viresh Kumar wrote: > On 09-01-20, 09:18, Arnd Bergmann wrote: > > On Fri, Nov 29, 2019 at 10:32 AM Viresh Kumar wrote: > > This looks odd: rather than guessing the transport type based on > > random DT properties, I would prefer to have it determined by > > the device compatible string, and have different drivers bind > > to one of them each, with each driver linking against a common > > base implementation, either as separate modules or in one file. > > Since there are no platforms using the scmi binding in mainline kernel > for now, it won't be difficult to add new compatible strings. So > should this be done like: > > compatible = "arm,scmi", "arm,scmi-mailbox"; > > or just > compatible = "arm,scmi-mailbox"; I would keep compatibility with the existing binding and make a plain "arm,scmi" mean the version with the mailbox, while for new transports, I would require them to have both the existing compatible string and a more specific one. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C8D8C33CA1 for ; Thu, 9 Jan 2020 10:15:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F24BC206ED for ; Thu, 9 Jan 2020 10:15:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N1/Z09Va" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F24BC206ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7MAeQxhT2aOUx4scpncZAy5P/7Tjnli5Tr4OHzNR8Rc=; b=N1/Z09Vacp/D7n M+sp4Z5h3tvR4pCnT0YoChh0rOaNX/Pnr7wDdefjqQruejBjh0gBrBoAM0XG54WABnnqxn/Z4k58x hIsxui0NNCWXXnuSvDSWczES/z6e9Sr56ymLo7QzbpNTfc67I+i5AfWKn6SD20qtBCSDUmYWawCfu fLVeF0hsGmPqygb0L3fN/fYPEByOxzOvBukUARNpxBx0zf4AGOo8XquCgJVPiLK6FuIYipOcNu+OJ E13+STiZUeO3f4eXbYYlfBkpNCMRUBiNDQHhNPF8XuXgdQ3c03igBiR3htS/PGzKmL0iGieB6xCAy E4lugldde7elW/1KmSJA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipUqj-0000NB-Hz; Thu, 09 Jan 2020 10:15:33 +0000 Received: from mout.kundenserver.de ([212.227.126.133]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipUqf-0000ML-Mv for linux-arm-kernel@lists.infradead.org; Thu, 09 Jan 2020 10:15:31 +0000 Received: from mail-qt1-f176.google.com ([209.85.160.176]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MTOZQ-1jGsYF1D12-00TjSF for ; Thu, 09 Jan 2020 11:15:27 +0100 Received: by mail-qt1-f176.google.com with SMTP id 5so5417223qtz.1 for ; Thu, 09 Jan 2020 02:15:27 -0800 (PST) X-Gm-Message-State: APjAAAV50w/xW1jxi4lxi9Q6cztJ/NTdDlR0b7KGRA72+0OnB0dcapAX 7PTWLgqx2/D+KilxpozDqMMytWhZwqlUt+moQH8= X-Google-Smtp-Source: APXvYqzHV85HzfRjo8JlOR7BQz04so9X1K640UDSw+epDZK35idc8VpNX/nwHxi15Ydw7e0XfccuvrKcfiArbEs3SrU= X-Received: by 2002:ac8:6153:: with SMTP id d19mr7257120qtm.18.1578564926199; Thu, 09 Jan 2020 02:15:26 -0800 (PST) MIME-Version: 1.0 References: <5c545c2866ba075ddb44907940a1dae1d823b8a1.1575019719.git.viresh.kumar@linaro.org> <20200109093442.4jt44eu2zlmjaq3f@vireshk-i7> In-Reply-To: <20200109093442.4jt44eu2zlmjaq3f@vireshk-i7> From: Arnd Bergmann Date: Thu, 9 Jan 2020 11:15:09 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] firmware: arm_scmi: Make scmi core independent of transport type To: Viresh Kumar X-Provags-ID: V03:K1:p2+wwXXmWHaRhAuvMtfuxsbnbBnu4JY4YTawsutckm5ZE2oTmh7 gcAtKqBhgPb53BJhJ6yJl/6HwtR5LHpmrINxoDIPg/gC3f8tej88z83Yc0f1iouw2BgSBeq DjMsuABMFvcUDY2HC08sUjup43dKXVITP7eVqssTR7R3S2BBjBRJHutlS9JhWdHXjD2yKgk MrafgSROmQQKcAu738JDg== X-UI-Out-Filterresults: notjunk:1;V03:K0:hAFAjg5uYmY=:etowRwkc4YjS9NEN4lnHD4 QZiyoUMBY4y6W9QupSeOnj0moJzBsShDdDJRBdpysMF+6d1IBf/dxkN/zM9SsoKIOSy+8i/z9 V/JJEAoIYf02EMD5NzqWe619yWISNE+zYgui0CJaiFqC7oKnnTtAsxF2tSJRa++eHJE/UXkEs oLer8QiFV5PN86vREFq08NtDvbXb8h9NEH29eTkBycNF2uHIKy83JnAPi8vEEfh5NxdJ2iNxT JRZTLF0rCGAaZ4Cdf/P4+3OqA4K7MCnU7X8LwPuWJpDIEvgd/IhAlL5RHTXNVVLiTjvZTQdVx DlufM/5ajFry+RtBONb/e/VzWJVT9yousAyNECJi0GUKO9dkXClcPYZFlSCbEhVbsvGJnRfB9 TL7fIADH3FBWgo0oSxUyQX4+0tBFqun/e8zLETNcEyw/nTCFW+xE+fuIXfob5TbNzGcuKgiNl /MWLkAeXoDCfPo8Jj3aXHQ3EKUMyEWGRwwBvFZOjFmdH/itI5kdkL98wqqIrVYmoue5GGceMZ coU6xOMCiiKKzdUnUKP4mC3cKGF6BaHcGdUAwXCNknDzYdYEhh7gcuutr5jOKqZFEvf8G4zFv BfvyPJTn9K+b7o32o85YTMgqos7YHL/yD4fPPNZFeO3gFPiC6LteW+R4usQuW0DzkMEH8DHv9 F/Ct8Mnsu0mbBaa7FaPREWYBaQN1BMCIzwpuNYLzDqaduHChdUbBqZvKl4CVd8qhK+XuWOQrR SdNJzYAzD3EV3eiTNJBI3aVvn2QD/lK4KJ3ENW/H5r/h70AurDG2iCoFsstSkIVTlBTfhADzH 0asSPyMFv8BSjPn439KdfRM8raZysfjlbvD5YPTv4jSDlzA4cIMsMXT6RxPQrfpmZiZViutvo xLE/gRSDOJ98al0ww45Q== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200109_021530_042363_6C4EA9DB X-CRM114-Status: GOOD ( 12.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peng.fan@nxp.com, Jassi Brar , "linux-kernel@vger.kernel.org" , Sudeep Holla , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 9, 2020 at 10:34 AM Viresh Kumar wrote: > On 09-01-20, 09:18, Arnd Bergmann wrote: > > On Fri, Nov 29, 2019 at 10:32 AM Viresh Kumar wrote: > > This looks odd: rather than guessing the transport type based on > > random DT properties, I would prefer to have it determined by > > the device compatible string, and have different drivers bind > > to one of them each, with each driver linking against a common > > base implementation, either as separate modules or in one file. > > Since there are no platforms using the scmi binding in mainline kernel > for now, it won't be difficult to add new compatible strings. So > should this be done like: > > compatible = "arm,scmi", "arm,scmi-mailbox"; > > or just > compatible = "arm,scmi-mailbox"; I would keep compatibility with the existing binding and make a plain "arm,scmi" mean the version with the mailbox, while for new transports, I would require them to have both the existing compatible string and a more specific one. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel