From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3BAEC28CC0 for ; Wed, 29 May 2019 11:39:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A27BB2081C for ; Wed, 29 May 2019 11:39:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726702AbfE2LjY convert rfc822-to-8bit (ORCPT ); Wed, 29 May 2019 07:39:24 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:42493 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726256AbfE2LjY (ORCPT ); Wed, 29 May 2019 07:39:24 -0400 Received: by mail-qt1-f194.google.com with SMTP id s15so2039640qtk.9; Wed, 29 May 2019 04:39:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9E0nYfWPs7a74TGtkChwlvLkwZ7IjxPSqPdyj4RozG4=; b=n26CHIk0NmWec02CC2UJ6i3wzRBHUn5ezO0tG03QsrOvuXQdIUA4KAjnDIWClphj/Q Pjkcji9kBdzzT4tznmGCx4bjzJJMjEyrtu3G6MgdbWevwJaNL2uePHx4C19V6jTEMLCF ZveNdZ1naTCrav2uUXT1X9siMhuUKRUp8wbDz+SNV/eb+eUB0wsLUNlAKdEt8Lme3iJN OyrdWCVz3m/VSp/R6mtGn5O8GHCEM/587Ge9/BeqEQtQMjY9G7ztwOJtgAioi7+g8Z06 5KNvoo8JjSePzcaglPn11sUfSEXp4AoYuOJALtgg7r5STPkNzB2HnsFjJxtrBNfdhS5+ HR3A== X-Gm-Message-State: APjAAAVz18j43/zAYFqxbVBC60xmTbSH6QJCrZ8B0TPzCraG7NERxXOq tnU9FU1VljjyW4cpM3bxf2SWf4D3lPh5xlYRkE0= X-Google-Smtp-Source: APXvYqz0EPhnldcISbzSfPUtTKsPXrltcC2TURmwXZayJpn/3MgULMOLoAS863/SSr+U9BaN4sQZRsVuLkMYuNUzw/c= X-Received: by 2002:ac8:2433:: with SMTP id c48mr87599176qtc.18.1559129962985; Wed, 29 May 2019 04:39:22 -0700 (PDT) MIME-Version: 1.0 References: <20190528142424.19626-1-geert@linux-m68k.org> <20190528142424.19626-4-geert@linux-m68k.org> In-Reply-To: <20190528142424.19626-4-geert@linux-m68k.org> From: Arnd Bergmann Date: Wed, 29 May 2019 13:39:06 +0200 Message-ID: Subject: Re: [PATCH 3/5] net: sched: pie: Use ULL suffix for 64-bit constant To: Geert Uytterhoeven Cc: Igor Konopko , David Howells , "Mohit P . Tahiliani" , Takashi Sakamoto , Eran Ben Elisha , Matias Bjorling , Jiri Pirko , "David S . Miller" , Jamal Hadi Salim , Cong Wang , Clemens Ladisch , Jaroslav Kysela , Takashi Iwai , Joe Perches , Dan Carpenter , linux-block , Networking , linux-afs@lists.infradead.org, ALSA Development Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, May 28, 2019 at 4:24 PM Geert Uytterhoeven wrote: > > With gcc 4.1, when compiling for a 32-bit platform: > > net/sched/sch_pie.c: In function ‘drop_early’: > net/sched/sch_pie.c:116: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:138: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:144: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:147: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c: In function ‘pie_qdisc_enqueue’: > net/sched/sch_pie.c:173: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c: In function ‘calculate_probability’: > net/sched/sch_pie.c:371: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:372: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:377: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:382: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:397: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:398: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:399: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:407: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:414: warning: integer constant is too large for ‘long’ type > > Fix this by adding the missing "ULL" suffix. > > Fixes: 3f7ae5f3dc5295ac ("net: sched: pie: add more cases to auto-tune alpha and beta") > Signed-off-by: Geert Uytterhoeven I created patches for all instances of this issue at some point in the past, but did not send those as we raised the minimum compiler version to one that handles this in the expected way without a warning. Maybe you can just ignore these as well? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 3/5] net: sched: pie: Use ULL suffix for 64-bit constant Date: Wed, 29 May 2019 13:39:06 +0200 Message-ID: References: <20190528142424.19626-1-geert@linux-m68k.org> <20190528142424.19626-4-geert@linux-m68k.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20190528142424.19626-4-geert@linux-m68k.org> Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Igor Konopko , David Howells , "Mohit P . Tahiliani" , Takashi Sakamoto , Eran Ben Elisha , Matias Bjorling , Jiri Pirko , "David S . Miller" , Jamal Hadi Salim , Cong Wang , Clemens Ladisch , Jaroslav Kysela , Takashi Iwai , Joe Perches , Dan Carpenter , linux-block , Networking , linux-afs@lists.infradead.org, ALSA Development Mailing List , Linux List-Id: alsa-devel@alsa-project.org On Tue, May 28, 2019 at 4:24 PM Geert Uytterhoeven wrote: > > With gcc 4.1, when compiling for a 32-bit platform: > > net/sched/sch_pie.c: In function ‘drop_early’: > net/sched/sch_pie.c:116: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:138: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:144: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:147: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c: In function ‘pie_qdisc_enqueue’: > net/sched/sch_pie.c:173: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c: In function ‘calculate_probability’: > net/sched/sch_pie.c:371: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:372: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:377: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:382: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:397: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:398: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:399: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:407: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:414: warning: integer constant is too large for ‘long’ type > > Fix this by adding the missing "ULL" suffix. > > Fixes: 3f7ae5f3dc5295ac ("net: sched: pie: add more cases to auto-tune alpha and beta") > Signed-off-by: Geert Uytterhoeven I created patches for all instances of this issue at some point in the past, but did not send those as we raised the minimum compiler version to one that handles this in the expected way without a warning. Maybe you can just ignore these as well? Arnd