From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 071CFC48BC3 for ; Sat, 17 Feb 2024 05:42:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zNltzC+1aeZmwUuhhA7BX0Ifdbw1A9mhpoT0WFs8qMc=; b=GZluP4/kEUspUh E4o1JAVQEzLyuzt/Vjui128xN2S0pHEZWt5QPWn4aTFsAihpfxk6biUiRv+NlI5Rx78yB0stNHW09 peKA4AONB3ZVFJDPy8mrEzemAnYg9/0ZFDt7AhqVjLapC3+ijQKdBzV88j4OQTn7Mj+uDEgXbdrB4 2TfE0moa+ZrWF6sZfPVN4bMuQlJ9GLobRu2x0rtZSpaw03SwMxkWoI2Eqci53BD7VdJWMd05KBSJf Mj/4TaB8OXuXsrp+5ppmAvwFr4vBULi+0R5RUsgPZc69wvYy43XvX4MVp9qZwfGstUN4XQtQKS2KW Jhpj65he2uzbFIwykFGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rbDTK-00000004hYE-3A8w; Sat, 17 Feb 2024 05:42:46 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rbDTH-00000004hXH-1eSf for linux-riscv@lists.infradead.org; Sat, 17 Feb 2024 05:42:44 +0000 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-512a8e71331so16312e87.2 for ; Fri, 16 Feb 2024 21:42:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1708148561; x=1708753361; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Q2XJqDi+VWb+RWFjBl96LehTOOg8v5aVoczUYhI4x1E=; b=bwGRga9RR3VFjbFbgmLfSFRHWPhgMEYUaKid9x4UPsU0v+/AasVWxpAbNdpX4tXE+H jHCcth1ByM9euGdPWfVqxCitu+Uwrb2/tqQu9ykFqdeIQTTiHrn3hWmBqKfeOEeCB9tC 8KrUNOIb++VyVo3uOO23A6dayecGvLZLOn1edluzbvnJAmaDZfH4Nr2D4JyTN9Y8SYkS q1RGfsTTR33UMvG+KLXEfp/sJIEiB4l7h1ttSZ7t54PcQs369vKJ728PVZYvd8en5ww6 2mCIXxKIa0a0ex+avqPfTDV9D+1onSKWu5JYvjprBhHARocKN8ZjXGLtqXXf/YPXBhtP flug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708148561; x=1708753361; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q2XJqDi+VWb+RWFjBl96LehTOOg8v5aVoczUYhI4x1E=; b=C4f7uvI0yBl7qx0akNLCm6duXPoV9iWXX05wIBUk2qzF4C7CB/4Oj4w4iD0xRgSJA/ tihuczYcg2vSWgsJzgEclhELfMT148+DYSesHhQXDwBBMSF9TwEuGs6gv6XtibE9zjES ulay9pqvoFP+BIiR+s/xmRgE3/ZyL649RYX6cRsoVG27AoHlxKRUC5ms1iLajGtYYqy4 Rs5h+GUA7/2by7AMuAykFXzaIwb0Q6j6SxkHVQixbeDHcaS+9tY0XIleprVFIt1Q5M0s JZIolQeKvoel6PxNu/HKBLML7XSZ7rFDVRA5plYJfph4RULyXD187Wtzin+Fy8VQAw/d FSuw== X-Forwarded-Encrypted: i=1; AJvYcCVrYOghq7sBjEHVF/+yUY+xO9Syx+a8LjgSyAYYPzX+X3nuVKMDbGtzvFkFSFz68fZiUfFxP/wq64174u6hLUvSsIjPHgoT4iSgx0NsIRXF X-Gm-Message-State: AOJu0YxBrt3o9oyTGu0/oPHcMOJx25UoFGklTR5XZmwnLsjooDAjneVg HlJsFzkJsjkEqVTGFg6z+jnessI7dBCnOsNyFlKONhErG9VxmXkvpRWrjZJeTOu45dZJE7XiSYL mlOAZ4URzKpsyZIYXy/WW0d/5pCLJ76J309FYLA== X-Google-Smtp-Source: AGHT+IGNn3qXE8Q2rV0AbEGEYH7CRDHvt7ZbR9eJEmA9ut7fgUgx1eQcMY50Tzh0dWXfbhyTfzgBRj3nELnm/DfNA7E= X-Received: by 2002:a05:6512:526:b0:511:96d0:5ae1 with SMTP id o6-20020a056512052600b0051196d05ae1mr5084453lfc.40.1708148560820; Fri, 16 Feb 2024 21:42:40 -0800 (PST) MIME-Version: 1.0 References: <20240127161753.114685-1-apatel@ventanamicro.com> <20240127161753.114685-15-apatel@ventanamicro.com> <87jzn4ctks.ffs@tglx> <878r3kcg7e.ffs@tglx> In-Reply-To: <878r3kcg7e.ffs@tglx> From: Anup Patel Date: Sat, 17 Feb 2024 11:12:29 +0530 Message-ID: Subject: Re: [PATCH v12 14/25] irqchip/sifive-plic: Convert PLIC driver into a platform driver To: Thomas Gleixner X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240216_214243_483035_F6D1E381 X-CRM114-Status: GOOD ( 22.80 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marc Zyngier , Conor Dooley , Saravana Kannan , devicetree@vger.kernel.org, Anup Patel , Atish Patra , linux-kernel@vger.kernel.org, =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Rob Herring , Palmer Dabbelt , Krzysztof Kozlowski , Paul Walmsley , linux-riscv@lists.infradead.org, Frank Rowand , linux-arm-kernel@lists.infradead.org, Andrew Jones Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gU2F0LCBGZWIgMTcsIDIwMjQgYXQgMTo1MuKAr0FNIFRob21hcyBHbGVpeG5lciA8dGdseEBs aW51dHJvbml4LmRlPiB3cm90ZToKPgo+IE9uIEZyaSwgRmViIDE2IDIwMjQgYXQgMjI6NDEsIEFu dXAgUGF0ZWwgd3JvdGU6Cj4gPiBPbiBGcmksIEZlYiAxNiwgMjAyNCBhdCA5OjAz4oCvUE0gVGhv bWFzIEdsZWl4bmVyIDx0Z2x4QGxpbnV0cm9uaXguZGU+IHdyb3RlOgo+ID4+IEkgZG9uJ3QgdGhp bmsgdGhhdCByZW1vdmluZyB0aGUgc2V0dXAgcHJvdGVjdGlvbiBpcyBjb3JyZWN0Lgo+ID4+Cj4g Pj4gQXNzdW1lIHlvdSBoYXZlIG1heGNwdXM9TiBvbiB0aGUga2VybmVsIGNvbW1hbmQgbGluZSwg dGhlbiB0aGUgYWJvdmUKPiA+PiBmb3JfZWFjaF9vbmxpbmVfY3B1KCkgbG9vcCB3b3VsZCByZXN1 bHQgaW4gY3B1aHBfc2V0dXAgPT0gdHJ1ZSB3aGVuIHRoZQo+ID4+IGluc3RhbmNlcyBmb3IgdGhl IG5vdCBvbmxpbmVkIENQVXMgYXJlIHNldCB1cCwgbm8/Cj4gPgo+ID4gQSBwbGF0Zm9ybSBjYW4g aGF2ZSBtdWx0aXBsZSBQTElDIGluc3RhbmNlcyB3aGVyZSBlYWNoIFBMSUMKPiA+IGluc3RhbmNl IHRhcmdldHMgYSBzdWJzZXQgb2YgSEFSVHMgKG9yIENQVXMpLgo+ID4KPiA+IFByZXZpb3VzbHkg KGJlZm9yZSB0aGlzIHBhdGNoKSwgd2Ugd2VyZSBwcm9iaW5nIFBMSUMgdmVyeSBlYXJseSBzbyBv bgo+ID4gYSBwbGF0Zm9ybSB3aXRoIG11bHRpcGxlIFBMSUMgaW5zdGFuY2VzLCB3ZSBuZWVkIHRv IGVuc3VyZSB0aGF0IGNwdWhwCj4gPiBzZXR1cCBpcyBkb25lIG9ubHkgYWZ0ZXIgUExJQyBjb250 ZXh0IGFzc29jaWF0ZWQgd2l0aCBib290IENQVSBpcwo+ID4gaW5pdGlhbGl6ZWQgaGVuY2UgdGhl IHBsaWNfY3B1aHBfc2V0dXBfZG9uZSBjaGVjay4KPiA+Cj4gPiBUaGlzIHBhdGNoIGNvbnZlcnRz IFBMSUMgZHJpdmVyIGludG8gYSBwbGF0Zm9ybSBkcml2ZXIgc28gbm93IFBMSUMKPiA+IGluc3Rh bmNlcyBhcmUgcHJvYmVkIGFmdGVyIGFsbCBhdmFpbGFibGUgQ1BVcyBhcmUgYnJvdWdodC11cC4g SW4gdGhpcwo+ID4gY2FzZSwgdGhlIGNwdWhwIHNldHVwIG11c3QgYmUgZG9uZSBvbmx5IGFmdGVy IFBMSUMgY29udGV4dCBvZiBhbGwKPiA+IGF2YWlsYWJsZSBDUFVzIGFyZSBpbml0aWFsaXplZCBv dGhlcndpc2Ugc29tZSBvZiB0aGUgQ1BVcyBjcmFzaAo+ID4gaW4gcGxpY19zdGFydGluZ19jcHUo KSBkdWUgdG8gbGFjayBvZiBQTElDIGNvbnRleHQgaW5pdGlhbGl6YXRpb24uCj4KPiBZb3UncmUg bWlzc2luZyB0aGUgcG9pbnQuCj4KPiBBc3N1bWUgeW91IGhhdmUgOCBDUFVzIGFuZCAyIFBMSUMg aW5zdGFuY2VzIG9uZSBmb3IgQ1BVMC0zIGFuZCBvbmUgZm9yCj4gQ1BVNC03Lgo+Cj4gQWRkICJt YXhjcHVzPTQiIG9uIHRoZSBrZXJuZWwgY29tbWFuZCBsaW5lLCB0aGVuIG9ubHkgdGhlIGZpcnN0 IDQgQ1BVcwo+IGFyZSBicm91Z2h0IHVwLgo+Cj4gU28gYXQgcHJvYmUgdGltZSBjcHVfb25saW5l X21hc2sgaGFzIGJpdCAwLDEsMiwzIHNldC4KPgo+IFdoZW4gdGhlIGZpcnN0IFBMSUMgaXQgcHJv YmVkIHRoZSBsb29wIHdoaWNoIGNoZWNrcyB0aGUgY29udGV4dCBmb3IgZWFjaAo+IG9ubGluZSBD UFUgd2lsbCBub3QgY2xlYXIgY3B1aHBfc2V0dXAgYW5kIHRoZSBob3RwbHVnIHN0YXRlIGlzIGlu c3RhbGxlZC4KPgo+IE5vdyB0aGUgc2Vjb25kIFBMSUMgaXMgcHJvYmVkICh0aGUgb25lIGZvciB0 aGUgb2ZmbGluZSBDUFVzIDQtNykgYW5kIHRoZQo+IGxvb3Agd2lsbCBhZ2FpbiBub3QgY2xlYXIg Y3B1aHBfc2V0dXAgYW5kIGl0IHRyaWVzIHRvIGluc3RhbGwgdGhlIHN0YXRlCj4gYWdhaW4sIG5v PwoKQWhoLCB5ZXMuIEdvb2QgY2F0Y2guCgpGb3IgdGhlICJtYXhjcHVzIiBpbiBrZXJuZWwgY29t bWFuZC1saW5lLCB3ZSBjYW4ndCByZWx5IG9uIHRoZQpjcHVfb25saW5lX21hc2suIEkgd2lsbCBw cmVzZXJ2ZSB0aGUgcGxpY19jcHVocF9zZXR1cF9kb25lCmNoZWNrIGluIHRoZSBuZXh0IHJldmlz aW9uLgoKUmVnYXJkcywKQW51cAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF625C48BF6 for ; Sat, 17 Feb 2024 05:43:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DPeAkSc3nRaPCHC8Nkrb6mCIq78+21SfHNZy13rZmsE=; b=ih7aisEdjC7qZm ml+/g1pKFU0e0xEV5zU+obz0fnni1fd2lUNDQgblQjkVO8RnbUoMl9yok+u9EU/dl0LHPgK5huW2g TSc+6yF9kxRh9Y77z7kCE0OKL2XBLPhiApD9qUK6sXQJhlIvBhP8ZfyzL3Gx1dJGV7vVKb2T/K6II nxLOp01QE5P1eAZpTfuHFRwLnJ8TAnT/EoI65dx6mIkNH9w7lXsh2Bj+bjF/60Kf2WWqnnZGLETch ds0tGm7xKs/OQZ7SQETPxDpSmZ/4mYH7g0/X9dRV1ZfIRigKOEc6bGOUAP9yT27lpnimgdSI1M89D iB3YqcLdY+zIcGDE49zQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rbDTL-00000004hYS-2Rkm; Sat, 17 Feb 2024 05:42:47 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rbDTH-00000004hXG-1eYD for linux-arm-kernel@lists.infradead.org; Sat, 17 Feb 2024 05:42:44 +0000 Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-511ac32fe38so4066256e87.1 for ; Fri, 16 Feb 2024 21:42:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1708148561; x=1708753361; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Q2XJqDi+VWb+RWFjBl96LehTOOg8v5aVoczUYhI4x1E=; b=bwGRga9RR3VFjbFbgmLfSFRHWPhgMEYUaKid9x4UPsU0v+/AasVWxpAbNdpX4tXE+H jHCcth1ByM9euGdPWfVqxCitu+Uwrb2/tqQu9ykFqdeIQTTiHrn3hWmBqKfeOEeCB9tC 8KrUNOIb++VyVo3uOO23A6dayecGvLZLOn1edluzbvnJAmaDZfH4Nr2D4JyTN9Y8SYkS q1RGfsTTR33UMvG+KLXEfp/sJIEiB4l7h1ttSZ7t54PcQs369vKJ728PVZYvd8en5ww6 2mCIXxKIa0a0ex+avqPfTDV9D+1onSKWu5JYvjprBhHARocKN8ZjXGLtqXXf/YPXBhtP flug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708148561; x=1708753361; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q2XJqDi+VWb+RWFjBl96LehTOOg8v5aVoczUYhI4x1E=; b=guuwVUsp9j01jEfg3xB7tC1AtYLUeGWojtGFOSDkIn6tg5uJVQWBTGTEr6u2TLs4pe GbdqmE/FWa0+2xpZZmhxvERSS0GxLFt6FYZOC0YoUzL+6saWIzmPc8/HrXxvCmn3owDM +0FUqHkEuFo/Sn7uM0+lYxk6UXm1wGW3wLc+RoLh6VDS+tG3STXHreBTfqcG+SsORMI0 I/i6G6T+Z2al5eqqMRRPdurY6TUA0RAGWdkG92VZK8lJgoxkoHryAxf6+1xirI0K9XES gQKobdmf9GA8iW2NUIdFTO1+K5ZNaF5peWjEVQvewS1UC0kVZeWW7dxglo44wcn3ywdn N6Yg== X-Forwarded-Encrypted: i=1; AJvYcCXTTUvI/Uyb59WlelfLqdD6Q4Df65jRwj1T1a61Tg+BAjZx/ujl7fnaUBrFZnStCRQkhn7Xrtw7bm2v2Wq884cRPivzlPEqU9TPHPFs4oQ+Nj+d8x4= X-Gm-Message-State: AOJu0YzkUKQUYUtgRwbZ1Gel0Ty7+1brTdXQnRSsDjI+bxxsTAgI7hrj WVTQi4c/GpsQ7aURhagRt1XLRKs3OrrbItHX3kXMouJyV9h3aoU/rPkesz5u/bZFyEhwrFJsKXr ERpPLL/a8k665uM0oQhD6h0Q6d6Chp5jyVnQCvg== X-Google-Smtp-Source: AGHT+IGNn3qXE8Q2rV0AbEGEYH7CRDHvt7ZbR9eJEmA9ut7fgUgx1eQcMY50Tzh0dWXfbhyTfzgBRj3nELnm/DfNA7E= X-Received: by 2002:a05:6512:526:b0:511:96d0:5ae1 with SMTP id o6-20020a056512052600b0051196d05ae1mr5084453lfc.40.1708148560820; Fri, 16 Feb 2024 21:42:40 -0800 (PST) MIME-Version: 1.0 References: <20240127161753.114685-1-apatel@ventanamicro.com> <20240127161753.114685-15-apatel@ventanamicro.com> <87jzn4ctks.ffs@tglx> <878r3kcg7e.ffs@tglx> In-Reply-To: <878r3kcg7e.ffs@tglx> From: Anup Patel Date: Sat, 17 Feb 2024 11:12:29 +0530 Message-ID: Subject: Re: [PATCH v12 14/25] irqchip/sifive-plic: Convert PLIC driver into a platform driver To: Thomas Gleixner Cc: Anup Patel , Palmer Dabbelt , Paul Walmsley , Rob Herring , Krzysztof Kozlowski , Frank Rowand , Conor Dooley , Marc Zyngier , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Atish Patra , Andrew Jones , Sunil V L , Saravana Kannan , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240216_214243_483344_8A89322F X-CRM114-Status: GOOD ( 24.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBGZWIgMTcsIDIwMjQgYXQgMTo1MuKAr0FNIFRob21hcyBHbGVpeG5lciA8dGdseEBs aW51dHJvbml4LmRlPiB3cm90ZToKPgo+IE9uIEZyaSwgRmViIDE2IDIwMjQgYXQgMjI6NDEsIEFu dXAgUGF0ZWwgd3JvdGU6Cj4gPiBPbiBGcmksIEZlYiAxNiwgMjAyNCBhdCA5OjAz4oCvUE0gVGhv bWFzIEdsZWl4bmVyIDx0Z2x4QGxpbnV0cm9uaXguZGU+IHdyb3RlOgo+ID4+IEkgZG9uJ3QgdGhp bmsgdGhhdCByZW1vdmluZyB0aGUgc2V0dXAgcHJvdGVjdGlvbiBpcyBjb3JyZWN0Lgo+ID4+Cj4g Pj4gQXNzdW1lIHlvdSBoYXZlIG1heGNwdXM9TiBvbiB0aGUga2VybmVsIGNvbW1hbmQgbGluZSwg dGhlbiB0aGUgYWJvdmUKPiA+PiBmb3JfZWFjaF9vbmxpbmVfY3B1KCkgbG9vcCB3b3VsZCByZXN1 bHQgaW4gY3B1aHBfc2V0dXAgPT0gdHJ1ZSB3aGVuIHRoZQo+ID4+IGluc3RhbmNlcyBmb3IgdGhl IG5vdCBvbmxpbmVkIENQVXMgYXJlIHNldCB1cCwgbm8/Cj4gPgo+ID4gQSBwbGF0Zm9ybSBjYW4g aGF2ZSBtdWx0aXBsZSBQTElDIGluc3RhbmNlcyB3aGVyZSBlYWNoIFBMSUMKPiA+IGluc3RhbmNl IHRhcmdldHMgYSBzdWJzZXQgb2YgSEFSVHMgKG9yIENQVXMpLgo+ID4KPiA+IFByZXZpb3VzbHkg KGJlZm9yZSB0aGlzIHBhdGNoKSwgd2Ugd2VyZSBwcm9iaW5nIFBMSUMgdmVyeSBlYXJseSBzbyBv bgo+ID4gYSBwbGF0Zm9ybSB3aXRoIG11bHRpcGxlIFBMSUMgaW5zdGFuY2VzLCB3ZSBuZWVkIHRv IGVuc3VyZSB0aGF0IGNwdWhwCj4gPiBzZXR1cCBpcyBkb25lIG9ubHkgYWZ0ZXIgUExJQyBjb250 ZXh0IGFzc29jaWF0ZWQgd2l0aCBib290IENQVSBpcwo+ID4gaW5pdGlhbGl6ZWQgaGVuY2UgdGhl IHBsaWNfY3B1aHBfc2V0dXBfZG9uZSBjaGVjay4KPiA+Cj4gPiBUaGlzIHBhdGNoIGNvbnZlcnRz IFBMSUMgZHJpdmVyIGludG8gYSBwbGF0Zm9ybSBkcml2ZXIgc28gbm93IFBMSUMKPiA+IGluc3Rh bmNlcyBhcmUgcHJvYmVkIGFmdGVyIGFsbCBhdmFpbGFibGUgQ1BVcyBhcmUgYnJvdWdodC11cC4g SW4gdGhpcwo+ID4gY2FzZSwgdGhlIGNwdWhwIHNldHVwIG11c3QgYmUgZG9uZSBvbmx5IGFmdGVy IFBMSUMgY29udGV4dCBvZiBhbGwKPiA+IGF2YWlsYWJsZSBDUFVzIGFyZSBpbml0aWFsaXplZCBv dGhlcndpc2Ugc29tZSBvZiB0aGUgQ1BVcyBjcmFzaAo+ID4gaW4gcGxpY19zdGFydGluZ19jcHUo KSBkdWUgdG8gbGFjayBvZiBQTElDIGNvbnRleHQgaW5pdGlhbGl6YXRpb24uCj4KPiBZb3UncmUg bWlzc2luZyB0aGUgcG9pbnQuCj4KPiBBc3N1bWUgeW91IGhhdmUgOCBDUFVzIGFuZCAyIFBMSUMg aW5zdGFuY2VzIG9uZSBmb3IgQ1BVMC0zIGFuZCBvbmUgZm9yCj4gQ1BVNC03Lgo+Cj4gQWRkICJt YXhjcHVzPTQiIG9uIHRoZSBrZXJuZWwgY29tbWFuZCBsaW5lLCB0aGVuIG9ubHkgdGhlIGZpcnN0 IDQgQ1BVcwo+IGFyZSBicm91Z2h0IHVwLgo+Cj4gU28gYXQgcHJvYmUgdGltZSBjcHVfb25saW5l X21hc2sgaGFzIGJpdCAwLDEsMiwzIHNldC4KPgo+IFdoZW4gdGhlIGZpcnN0IFBMSUMgaXQgcHJv YmVkIHRoZSBsb29wIHdoaWNoIGNoZWNrcyB0aGUgY29udGV4dCBmb3IgZWFjaAo+IG9ubGluZSBD UFUgd2lsbCBub3QgY2xlYXIgY3B1aHBfc2V0dXAgYW5kIHRoZSBob3RwbHVnIHN0YXRlIGlzIGlu c3RhbGxlZC4KPgo+IE5vdyB0aGUgc2Vjb25kIFBMSUMgaXMgcHJvYmVkICh0aGUgb25lIGZvciB0 aGUgb2ZmbGluZSBDUFVzIDQtNykgYW5kIHRoZQo+IGxvb3Agd2lsbCBhZ2FpbiBub3QgY2xlYXIg Y3B1aHBfc2V0dXAgYW5kIGl0IHRyaWVzIHRvIGluc3RhbGwgdGhlIHN0YXRlCj4gYWdhaW4sIG5v PwoKQWhoLCB5ZXMuIEdvb2QgY2F0Y2guCgpGb3IgdGhlICJtYXhjcHVzIiBpbiBrZXJuZWwgY29t bWFuZC1saW5lLCB3ZSBjYW4ndCByZWx5IG9uIHRoZQpjcHVfb25saW5lX21hc2suIEkgd2lsbCBw cmVzZXJ2ZSB0aGUgcGxpY19jcHVocF9zZXR1cF9kb25lCmNoZWNrIGluIHRoZSBuZXh0IHJldmlz aW9uLgoKUmVnYXJkcywKQW51cAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07CAC149DE0 for ; Sat, 17 Feb 2024 05:42:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708148564; cv=none; b=tTuRJu9IaBVA8gFs1vhe+2vLJNTtzhMt5xKHX1OeUe0KhNFPhzj/OfBn5K8FaTDimVhQtU339Q2y+27KzVhpwbdTZ2Aw4QVgZmNTD6NCOFl3ZHxytvvEsMBZ2v3xK5bJ1w9zefpHM4CV5rp6Hltt6FxcWeJnDOIlM1yREEzLhI8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708148564; c=relaxed/simple; bh=Q2XJqDi+VWb+RWFjBl96LehTOOg8v5aVoczUYhI4x1E=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=FoW0ZCn9aS2qnnCvwZ2kHj/KejGu1kQpoefi+RI2KxFUBTIvy0soPjSaPl3sIkRUcNwH3o7pRPN8GAcns28avVZWxTccH9A58lJEjFz/F4fmjZBBBoje1vdCAhA6ovETDGlkLbhwJkipR5ScrdkV1UEITSD0KBYTjBVuIR3H3Ss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=K3G6Op5s; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="K3G6Op5s" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-511ac32fe38so4066255e87.1 for ; Fri, 16 Feb 2024 21:42:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1708148561; x=1708753361; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Q2XJqDi+VWb+RWFjBl96LehTOOg8v5aVoczUYhI4x1E=; b=K3G6Op5sje0wQ/2M8WNZ5+PUz2OXrBG5Tms28bIyeb2v4GJVfJ4KyZ9MP1ACdYQVuK NXK9XHOMf7mzge/ec2Bt0Pnj+mGTicMQiwDK1BpuN4sea8rn8CUi/Lgz8mcd5dEVcWP6 FcDPKWIL1d++2ihJoIcKsY1E72LfOPWSCEmRGrR5SzovEY+nQrD6okhGK1oe5Vp59Vwb KXbXL+12Bk85ythDrC8xuANCdnV4b2O51jW2vWYSqixnBZ1o62U+Jsx9UH5OLCf8jYZd 6HzRl5Y3c8TtHIscZ8B0QKnPwRPfg6ZnQIAw9cxZvE4SLc992z36RZKEOqP7PZ5VSZjl DJ3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708148561; x=1708753361; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q2XJqDi+VWb+RWFjBl96LehTOOg8v5aVoczUYhI4x1E=; b=lR2+LdU3m4KYN0Rhe5NTNQNvp2dkcbxPjgSqhA42BoUX9EXF7Be4UTnipLPLrN6jq4 jfNC2e31cC2b787zdjDxaHL5rVT6uAqA0WMcT5Zn7ygOHWJXdy3MJGkk9Rhloz0MOyBV scbvqW6rLo8m1/hEuBnWhg4IdRNiXMdiMGK3GAh2jrniYKBmotLFLKlEmby/j5XdI50L afYO/XUS24f7TyH5vjZTyK5/qfNcyOdGuSJOgvw0XLllZxZzP1e/JB1UbNqLuAUAVVgw GLHd1Fz7Dn2bNBY4m6nB5TMpLM8QD3pgy5U3gt1HnwDcNipVGe8lGBY9ngMXCKo+2ZXP rYnw== X-Forwarded-Encrypted: i=1; AJvYcCV0Q3onxixUOIMSS7vwO8ssOw6+74WMg+tsixtZpJr8wxUqZPBGHXVj0FfjaFCM8qFLOR1xcxaGoZ0MYlvA3P1EKOvrhCezPDLGsMrI X-Gm-Message-State: AOJu0YzLOn/PaI60GSA5mXmDnzy/MFZP5Y2qFA7mKbuz4HpT7/WN2+/P HQqKziCAvf4gDKByH+D3RxBeyu6UzHEtS9j3wKqflAPDaIJVC076u6Lcw1SvlPcT68IE/3NVqt3 7hN7yz5mXqoNEN+twIG6ji1+Lkkmly4Flm2GiLg== X-Google-Smtp-Source: AGHT+IGNn3qXE8Q2rV0AbEGEYH7CRDHvt7ZbR9eJEmA9ut7fgUgx1eQcMY50Tzh0dWXfbhyTfzgBRj3nELnm/DfNA7E= X-Received: by 2002:a05:6512:526:b0:511:96d0:5ae1 with SMTP id o6-20020a056512052600b0051196d05ae1mr5084453lfc.40.1708148560820; Fri, 16 Feb 2024 21:42:40 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240127161753.114685-1-apatel@ventanamicro.com> <20240127161753.114685-15-apatel@ventanamicro.com> <87jzn4ctks.ffs@tglx> <878r3kcg7e.ffs@tglx> In-Reply-To: <878r3kcg7e.ffs@tglx> From: Anup Patel Date: Sat, 17 Feb 2024 11:12:29 +0530 Message-ID: Subject: Re: [PATCH v12 14/25] irqchip/sifive-plic: Convert PLIC driver into a platform driver To: Thomas Gleixner Cc: Anup Patel , Palmer Dabbelt , Paul Walmsley , Rob Herring , Krzysztof Kozlowski , Frank Rowand , Conor Dooley , Marc Zyngier , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Atish Patra , Andrew Jones , Sunil V L , Saravana Kannan , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Feb 17, 2024 at 1:52=E2=80=AFAM Thomas Gleixner wrote: > > On Fri, Feb 16 2024 at 22:41, Anup Patel wrote: > > On Fri, Feb 16, 2024 at 9:03=E2=80=AFPM Thomas Gleixner wrote: > >> I don't think that removing the setup protection is correct. > >> > >> Assume you have maxcpus=3DN on the kernel command line, then the above > >> for_each_online_cpu() loop would result in cpuhp_setup =3D=3D true whe= n the > >> instances for the not onlined CPUs are set up, no? > > > > A platform can have multiple PLIC instances where each PLIC > > instance targets a subset of HARTs (or CPUs). > > > > Previously (before this patch), we were probing PLIC very early so on > > a platform with multiple PLIC instances, we need to ensure that cpuhp > > setup is done only after PLIC context associated with boot CPU is > > initialized hence the plic_cpuhp_setup_done check. > > > > This patch converts PLIC driver into a platform driver so now PLIC > > instances are probed after all available CPUs are brought-up. In this > > case, the cpuhp setup must be done only after PLIC context of all > > available CPUs are initialized otherwise some of the CPUs crash > > in plic_starting_cpu() due to lack of PLIC context initialization. > > You're missing the point. > > Assume you have 8 CPUs and 2 PLIC instances one for CPU0-3 and one for > CPU4-7. > > Add "maxcpus=3D4" on the kernel command line, then only the first 4 CPUs > are brought up. > > So at probe time cpu_online_mask has bit 0,1,2,3 set. > > When the first PLIC it probed the loop which checks the context for each > online CPU will not clear cpuhp_setup and the hotplug state is installed. > > Now the second PLIC is probed (the one for the offline CPUs 4-7) and the > loop will again not clear cpuhp_setup and it tries to install the state > again, no? Ahh, yes. Good catch. For the "maxcpus" in kernel command-line, we can't rely on the cpu_online_mask. I will preserve the plic_cpuhp_setup_done check in the next revision. Regards, Anup