From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 962D9C4332F for ; Wed, 25 May 2022 17:04:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245548AbiEYREE (ORCPT ); Wed, 25 May 2022 13:04:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245486AbiEYRED (ORCPT ); Wed, 25 May 2022 13:04:03 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 519D253E39 for ; Wed, 25 May 2022 10:04:00 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id s28so30839445wrb.7 for ; Wed, 25 May 2022 10:04:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=loFo61ZrCr4QaTZkLYB3/JVJBU50T2JZCagmaC/lyAw=; b=Z0B1Dtj6jth9CjXTTNew6KleYGbdoUTXOF3eLdqZhHVQRSY9Ky2118o70pkPI06R9P SCqgbQIPZdZ8A+6XSqyr1osIbRUQ8jpfM1SQtn6RlB5oIv/W8tbxbnvk+47CA+AWjest fU9lJTgzqMVV2QPEjcYrGH5PygljPkdVEauDmiwPjEtRcpCDBLpc0PmAXeWfj4pPKG7P pCI4ZM59v4xHiw267rYLRgaUgXjxAGW8u6XvjRKmXusnMKtuWVLzpPYgToPdkIedX47q k/L2+ukcxX0kz9hd85M5bc1W9/J2LevtOKtA1eKU2NrffXaDBmtVE2rifIsoXEy8zF78 gDxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=loFo61ZrCr4QaTZkLYB3/JVJBU50T2JZCagmaC/lyAw=; b=DDG2UdpOviqIoUt2GyVB4yMms6ICHM3XQRlEGr0N4aw5CImojxVw/YyXMHhTtdu7c9 lamwjsZqhuD1nhc7AseQgdetyKbFrhCp9ClWBjV+xjdrZz+YHrPMwMJvqyfEeuDyKuiN ekVk8g9Ht563FLrm8Qh74Ew/s3xCpOdeziW/n9ptthvpE5zT4Ym0QVeLCG56FB4cL2tp tPKutnVzDwGtyLdFiRXlDfa9DUIfM/V976qv0pX8p5bpIS569V/KMnKW/iTvvF7KVUnY O4nqW4HtJE6tfgILV++TNHyto1R81rDpsD6vnKH4xQJlUB+WP8NEEkJcjPgwyadjW8J8 BLAw== X-Gm-Message-State: AOAM532do3lRWPgRkfmEN5Q4ieTt/7VZJtpH3Z76gdbUiE5K3txd/cM8 3MLvneGKvA5kAxhF0EIlTfZI9uY4wqc6NHgpg9Lwdw== X-Google-Smtp-Source: ABdhPJzNHPfJp1XyqZV7qhrWcbxNk3IfEfV32VUdXbe3pQf8/N0AgRWU30h5jOGOB2lixvKXXGLLczV8CTTR/5Arbjg= X-Received: by 2002:a5d:5954:0:b0:20c:4d55:1388 with SMTP id e20-20020a5d5954000000b0020c4d551388mr28040155wri.90.1653498238868; Wed, 25 May 2022 10:03:58 -0700 (PDT) MIME-Version: 1.0 References: <20220406233648.21644-1-brad@pensando.io> <20220406233648.21644-5-brad@pensando.io> <20220412113739.xczqscungojcitrm@mobilestation> In-Reply-To: <20220412113739.xczqscungojcitrm@mobilestation> From: Brad Larson Date: Wed, 25 May 2022 10:03:48 -0700 Message-ID: Subject: Re: [PATCH 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC To: Serge Semin Cc: Serge Semin , Linux ARM , Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , Mark Brown , Adrian Hunter , Ulf Hansson , Olof Johansson , David Clear , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Sergey, On Tue, Apr 12, 2022 at 4:37 AM Serge Semin wrote: > > > [PATCH 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC > > I think you need to be more specific in the patch title to what bindings > you are adding the new compatible string. Something like this > "dt-bindings: spi: cdns: ..." > The same concerns the patch "[PATCH 03/11] dt-bindings: mmc: Add Pensando > Elba SoC binding". > Otherwise it isn't clear to what schema you are adding the Elba SoC > support to. Thanks for the review, I'll add more specifics to the bindings patch title. Regards, Brad From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A315C433F5 for ; Wed, 25 May 2022 17:05:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mRe5HDKhIuWXqJhS7FE9bIRFnVKmRMLSjZGdq4e5RKE=; b=IRNpQRVog7oGG6 3KQoFXbS9MqVK2hipNpb2qiCIxqO74D+HYOd46eDZE1ox+YQMGqANEzYl9Coe7CXZ1JNyduaJ/W+V RVJjLxuJmerhcpM2Lw9bFsqzqIeZj4c5w0ye5ghlK2BOnBkloGO7kg0+rHXRv43vsncgld5Vc2u3q Et+3iHskcQDaBbESPRM02gqU//7Bzikjd341BeWNiwjUmGfJV01rilwNTRvdFphrAQtVOSKrWI4Vt mc5+F7wujHSfXZRSjXLg2k4aeJrkoPOaUMQoxyG0eKggS7rZHcevPRpc8gkaMJ2V8eSg2mn5t1ohx VnEmqeMgnwu47MJuv80g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntuQV-00Bw5W-Vb; Wed, 25 May 2022 17:04:04 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntuQS-00Bw4X-UG for linux-arm-kernel@lists.infradead.org; Wed, 25 May 2022 17:04:02 +0000 Received: by mail-wr1-x430.google.com with SMTP id j25so6543132wrb.6 for ; Wed, 25 May 2022 10:03:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=loFo61ZrCr4QaTZkLYB3/JVJBU50T2JZCagmaC/lyAw=; b=Z0B1Dtj6jth9CjXTTNew6KleYGbdoUTXOF3eLdqZhHVQRSY9Ky2118o70pkPI06R9P SCqgbQIPZdZ8A+6XSqyr1osIbRUQ8jpfM1SQtn6RlB5oIv/W8tbxbnvk+47CA+AWjest fU9lJTgzqMVV2QPEjcYrGH5PygljPkdVEauDmiwPjEtRcpCDBLpc0PmAXeWfj4pPKG7P pCI4ZM59v4xHiw267rYLRgaUgXjxAGW8u6XvjRKmXusnMKtuWVLzpPYgToPdkIedX47q k/L2+ukcxX0kz9hd85M5bc1W9/J2LevtOKtA1eKU2NrffXaDBmtVE2rifIsoXEy8zF78 gDxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=loFo61ZrCr4QaTZkLYB3/JVJBU50T2JZCagmaC/lyAw=; b=vHqxzU89xbLCuFP3b8MzDfO36Dk1xfJRI1MA4s+ii607niI+ZTgzvsDBMTCI+wGqIk KThdHsK4hltenWbkyGYHcWg0iZR6DCJ4NYBohR1afUMPaD4jgs30DdwGkQGuVd9PNkgB b5Ngfx8sdafHOc5jPy7cXDWRo05BeOwlpDlI0bnRCqH84ltfwye+LyxJKqBwJnaVNlWq STad0mxw12/yVpaXS0Ly/AbnA6f55EZNZDMuJSz/8Y/Bqtr0pnbGByDqWLTKUbAkuT3z ee1o11FfFwym7rX9t155/kZEdIB/GW9XFtUpXJKhLvjwuvBKh9txyKdXSYz8Z2o7Epf2 xbSA== X-Gm-Message-State: AOAM530yEibSY6T9Ipa9d/kdojHxl+2/R4IV18w8AcwQquRpxk5sWmNW bqrC0fQN5v+SnhjneknUTtx+yrDWHpcH4JkfONZExw== X-Google-Smtp-Source: ABdhPJzNHPfJp1XyqZV7qhrWcbxNk3IfEfV32VUdXbe3pQf8/N0AgRWU30h5jOGOB2lixvKXXGLLczV8CTTR/5Arbjg= X-Received: by 2002:a5d:5954:0:b0:20c:4d55:1388 with SMTP id e20-20020a5d5954000000b0020c4d551388mr28040155wri.90.1653498238868; Wed, 25 May 2022 10:03:58 -0700 (PDT) MIME-Version: 1.0 References: <20220406233648.21644-1-brad@pensando.io> <20220406233648.21644-5-brad@pensando.io> <20220412113739.xczqscungojcitrm@mobilestation> In-Reply-To: <20220412113739.xczqscungojcitrm@mobilestation> From: Brad Larson Date: Wed, 25 May 2022 10:03:48 -0700 Message-ID: Subject: Re: [PATCH 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC To: Serge Semin Cc: Serge Semin , Linux ARM , Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , Mark Brown , Adrian Hunter , Ulf Hansson , Olof Johansson , David Clear , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220525_100401_011045_9F4D8BBA X-CRM114-Status: GOOD ( 13.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sergey, On Tue, Apr 12, 2022 at 4:37 AM Serge Semin wrote: > > > [PATCH 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC > > I think you need to be more specific in the patch title to what bindings > you are adding the new compatible string. Something like this > "dt-bindings: spi: cdns: ..." > The same concerns the patch "[PATCH 03/11] dt-bindings: mmc: Add Pensando > Elba SoC binding". > Otherwise it isn't clear to what schema you are adding the Elba SoC > support to. Thanks for the review, I'll add more specifics to the bindings patch title. Regards, Brad _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel