From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE87FC4338F for ; Mon, 23 Aug 2021 01:07:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF19961262 for ; Mon, 23 Aug 2021 01:07:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234525AbhHWBHp (ORCPT ); Sun, 22 Aug 2021 21:07:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234361AbhHWBHo (ORCPT ); Sun, 22 Aug 2021 21:07:44 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14166C061756 for ; Sun, 22 Aug 2021 18:07:03 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id n12so23614684edx.8 for ; Sun, 22 Aug 2021 18:07:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pjckf6bfV/IeJNN9n6MQVl/LTL3lu1yq7lS4IYzu/QM=; b=YXvUInxkTo+QS04+RTXnvdY5Tut9xBKcT9moQ79TGp2GjLkU/lF29770JsA6UY+UOn yjlARSI3QSab1F39xGyUm9LqcHKPE++VUejnLyKwbHAVdhKJnDNssxuQqlmSJhbAj2OT YxqGNv5II7hqHyRemXMsdL1BA/qgC6MEvPlCNcoHEhp6bZw3rOvoOzKVrjATtwfU9zue R0esUcu67bVhSd0ErcQC/7zaqVKqAAK4SPfsJQ+wsgTJKwMXBkS1CDhRG2++ClbJLMg2 f77F2jBXBEzMMA7p3ZzlFd9ahFPEAgnqx1ZNVe670GdAp6aOQ7bP8biCveNS+9nuRpn+ Dhfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pjckf6bfV/IeJNN9n6MQVl/LTL3lu1yq7lS4IYzu/QM=; b=glu5JrO4HoCIhV6hxIgLo3G+S+dIjoimCcZ3uBTvf1yBRhfSO4H3ejWIl6xHDJjbyY RUzoWYmSU8UppIQC/Shxzcyaa1cqFk2mzVIyGYrR5Vg9gg30s5Ry77Qkudm+Yv0ZNlMZ 7AT67mzXq6EDT8AJcLJoGu4lEa3R8AtU/rBCi8ysALw5EDwewM7F1BjtnIZ7LPqNBnbs 7o/IiqGe2+Iv2+IVELVSISlfYnLLtctsK6BBAyZ8KLO6aCRZe4jE4CzEt8EsEUUHA+aX OLfF5jRg5VlmMHSSbg5E0m65WrozPx1yt5IY67Iwd5IC6vD+kQpOAiJRXvikX0CN2W8h rBbw== X-Gm-Message-State: AOAM532Lhjp1ERvUtAAmcDPWwuFnQSrqeO36sSH/8/6swxeEMxpsIoHd WwXtLJvvan0AwVmrz60LB4ZjQ0EVJoYhEPDgHie2/g== X-Google-Smtp-Source: ABdhPJxLjyDYm7QVxm1dvdfIEw9t3Et/mk1X0dx98a7+Jgg205IWLNBlgQOSRuBoYLny9Mb7LfeCW8J2s/qhMUfMTOY= X-Received: by 2002:a05:6402:5208:: with SMTP id s8mr35097217edd.222.1629680821623; Sun, 22 Aug 2021 18:07:01 -0700 (PDT) MIME-Version: 1.0 References: <20210304034141.7062-1-brad@pensando.io> <20210304034141.7062-2-brad@pensando.io> In-Reply-To: From: Brad Larson Date: Sun, 22 Aug 2021 18:06:51 -0700 Message-ID: Subject: Re: [PATCH 1/8] gpio: Add Elba SoC gpio driver for spi cs control To: "Elliott, Robert (Servers)" Cc: "linux-arm-kernel@lists.infradead.org" , "arnd@arndb.de" , "linus.walleij@linaro.org" , "bgolaszewski@baylibre.com" , "broonie@kernel.org" , "fancer.lancer@gmail.com" , "adrian.hunter@intel.com" , "ulf.hansson@linaro.org" , "olof@lixom.net" , "linux-gpio@vger.kernel.org" , "linux-spi@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Elliott, On Thu, Mar 4, 2021 at 12:44 PM Elliott, Robert (Servers) wrote: [...] > > +config GPIO_ELBA_SPICS > > + bool "Pensando Elba SPI chip-select" > > + depends on ARCH_PENSANDO_ELBA_SOC > > + help > > + Say yes here to support the Pensndo Elba SoC SPI chip-select > > driver > > Pensndo should be Pensando Fixed the typo, thanks. > > diff --git a/drivers/gpio/gpio-elba-spics.c b/drivers/gpio/gpio-elba-spics.c > > + * Pensando Elba ASIC SPI chip select driver > ... > > +MODULE_LICENSE("GPL v2"); > > +MODULE_DESCRIPTION("Elba SPI chip-select driver"); > > I think it's conventional to include the company name there, so > start that with "Pensando Elba" Ok, thanks. BTW I deleted these lines as I should have used builtin_platform_driver() and not a loadable module. > Also, "SoC" and "ASIC" are sometimes included after Elba, but sometimes > are not. Consistency might be helpful. > > > +static const struct of_device_id ebla_spics_of_match[] = { > ... > > + .of_match_table = ebla_spics_of_match, > > ebla should be elba Fixed the typo and using SoC which is more accurate. Regards, Brad From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9581C4338F for ; Mon, 23 Aug 2021 01:09:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B417611C8 for ; Mon, 23 Aug 2021 01:09:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9B417611C8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pensando.io Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I8f4C6GcY0Bv46UaimQV6sVbGqQsvMx7lrxyCwsPuzg=; b=PGQlqLidAdl/Nr 5/x5A/CpGFrxz8xo3gJ7OZABzh679uUQZJkGGl5f+rGcSIureNmXV9iZoEF1KUhWdS108hVj2TTEg scyDyZTuOX9OFILp16aUxNnOztrtVLkHj1SHxbGQqgZ3NT3dgAy9CpLM1nQXSyQveO4qNf3ll9+7L LIWp4G8aeBS11XPBst6PsQqcuxg+gnj/I2qTnIyWyCdpFPhG2IFaAxKjTXg47HqfLFWeB1cbuKMDs zMgEK4GQtknQS31yXQ4Hl+uq1fobazpQSE5At4LmzWgManIdDV6aqNVUlsxnX0VxwoTLsjnfnW2op xcxonI3WQ+MQqaJcMpMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHyQf-00F0fT-HN; Mon, 23 Aug 2021 01:07:09 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHyQZ-00F0dQ-AY for linux-arm-kernel@lists.infradead.org; Mon, 23 Aug 2021 01:07:07 +0000 Received: by mail-ed1-x52c.google.com with SMTP id s25so10944695edw.0 for ; Sun, 22 Aug 2021 18:07:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pjckf6bfV/IeJNN9n6MQVl/LTL3lu1yq7lS4IYzu/QM=; b=YXvUInxkTo+QS04+RTXnvdY5Tut9xBKcT9moQ79TGp2GjLkU/lF29770JsA6UY+UOn yjlARSI3QSab1F39xGyUm9LqcHKPE++VUejnLyKwbHAVdhKJnDNssxuQqlmSJhbAj2OT YxqGNv5II7hqHyRemXMsdL1BA/qgC6MEvPlCNcoHEhp6bZw3rOvoOzKVrjATtwfU9zue R0esUcu67bVhSd0ErcQC/7zaqVKqAAK4SPfsJQ+wsgTJKwMXBkS1CDhRG2++ClbJLMg2 f77F2jBXBEzMMA7p3ZzlFd9ahFPEAgnqx1ZNVe670GdAp6aOQ7bP8biCveNS+9nuRpn+ Dhfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pjckf6bfV/IeJNN9n6MQVl/LTL3lu1yq7lS4IYzu/QM=; b=brNXfcJPPlT+RfzHCvwMiInciphQ+vjc1IIUduQdPVscNyL+U+k0OuRcscWAug25U4 qM1mLSubJB1sSPCPKm3/3+D3orI+Ds09WRVxz9kX62uPkc9HX1EoYi9cTq2B59fM7Km7 QKkRZwj9ItQuae2R7aeTO2vYHhX/SYCakqYxRVWlzFMzTF0KBSpMd/HuF9iQ3eDFgqID z/b48pp+OZdd7yy6ldqZPQtx1A8NZtQuHzgDrPDvgJBKVLodiG+Hke5zl+QLEmzvyWLi t9kQp9hP1waoGrk0d/sfNsOL7ybEbcu0zNLgpJNIG9hSBj+rf/iIft0/ZgzN2hxD9ZMO /FpA== X-Gm-Message-State: AOAM531NnDWg2REuhs2DKNVmyuA3j6GSf8bDmFnSRv1l0tBHdYiAZ5Kd BfCfkCcnUwr77qPDwNfehukcJ43cvoQLfYhGfm9BLw== X-Google-Smtp-Source: ABdhPJxLjyDYm7QVxm1dvdfIEw9t3Et/mk1X0dx98a7+Jgg205IWLNBlgQOSRuBoYLny9Mb7LfeCW8J2s/qhMUfMTOY= X-Received: by 2002:a05:6402:5208:: with SMTP id s8mr35097217edd.222.1629680821623; Sun, 22 Aug 2021 18:07:01 -0700 (PDT) MIME-Version: 1.0 References: <20210304034141.7062-1-brad@pensando.io> <20210304034141.7062-2-brad@pensando.io> In-Reply-To: From: Brad Larson Date: Sun, 22 Aug 2021 18:06:51 -0700 Message-ID: Subject: Re: [PATCH 1/8] gpio: Add Elba SoC gpio driver for spi cs control To: "Elliott, Robert (Servers)" Cc: "linux-arm-kernel@lists.infradead.org" , "arnd@arndb.de" , "linus.walleij@linaro.org" , "bgolaszewski@baylibre.com" , "broonie@kernel.org" , "fancer.lancer@gmail.com" , "adrian.hunter@intel.com" , "ulf.hansson@linaro.org" , "olof@lixom.net" , "linux-gpio@vger.kernel.org" , "linux-spi@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210822_180703_413316_6056CF68 X-CRM114-Status: GOOD ( 15.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Elliott, On Thu, Mar 4, 2021 at 12:44 PM Elliott, Robert (Servers) wrote: [...] > > +config GPIO_ELBA_SPICS > > + bool "Pensando Elba SPI chip-select" > > + depends on ARCH_PENSANDO_ELBA_SOC > > + help > > + Say yes here to support the Pensndo Elba SoC SPI chip-select > > driver > > Pensndo should be Pensando Fixed the typo, thanks. > > diff --git a/drivers/gpio/gpio-elba-spics.c b/drivers/gpio/gpio-elba-spics.c > > + * Pensando Elba ASIC SPI chip select driver > ... > > +MODULE_LICENSE("GPL v2"); > > +MODULE_DESCRIPTION("Elba SPI chip-select driver"); > > I think it's conventional to include the company name there, so > start that with "Pensando Elba" Ok, thanks. BTW I deleted these lines as I should have used builtin_platform_driver() and not a loadable module. > Also, "SoC" and "ASIC" are sometimes included after Elba, but sometimes > are not. Consistency might be helpful. > > > +static const struct of_device_id ebla_spics_of_match[] = { > ... > > + .of_match_table = ebla_spics_of_match, > > ebla should be elba Fixed the typo and using SoC which is more accurate. Regards, Brad _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel