From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9972C433F5 for ; Thu, 26 May 2022 00:27:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239416AbiEZA1r (ORCPT ); Wed, 25 May 2022 20:27:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241269AbiEZA1q (ORCPT ); Wed, 25 May 2022 20:27:46 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D36CA76E9 for ; Wed, 25 May 2022 17:27:45 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id v4-20020a1cac04000000b00397001398c0so2023288wme.5 for ; Wed, 25 May 2022 17:27:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GOl6uOgkcVMNPECHww0pzlplNgdMl8NRZo39BUzLuoA=; b=BHM0auJl9Sd5Dl2qJoFb/qdXLGW8QkdJbZjjrLo1TDFKx5fEHAlXZgFbC0cBhPOdAI 5xDvn/os9mSk3V1kxQ1KHgGhTHYaQaRkPFLEeXeTroCAeIt70xNw7V/WlqqtbHW/CRjT OnzERudLz6vFREv37wQlCLFnApPMsCvjHd54G8eeHnr70Fe/n2vEeoiT2vjnTTOI25Nl 0EpNn2dzHSOtEIGTKjyJHp0LZB9FmTKk43WKiVV/ApgMW0khwjaWbetLVYfhpG8LfPqF hAPRZH+uPbrzgpF/eGmx+c1QbbKX4kIKJoNfJJT7xoVRq4LPhj1f+Y715qT0z3Lh4lzh Lbvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GOl6uOgkcVMNPECHww0pzlplNgdMl8NRZo39BUzLuoA=; b=cKgDGEFPOG+K5c3SnJw/0lnjhUCTRTeVSUMkrb+YVPv+0jstxIDomCKizFokefROLl ulut6xxfiKSI3ADNhHYybkHCU4X50xSysl8hOTmvf9qbE4wb4HrF4+22oe+KbANTWr4v kss+k9Gq6qJIraTlAXSCvGk7cCu9HwQkZ+e5KZ5LrBc8l/X9tT4m8zZ50ZqndSN1kXJj TBCtMbQUITHxDeVcjp3cB0TpGhGPwjgDlg7Me6X6+pwuRHjaoDtvhVeREbFe4S7q0b3I DdDDTqpFLJISBAX8eThD8H7CXHn4vYCM3KmEFNe7rWeQ9UnS7okvdueN+Igla4JNSqGg YL7Q== X-Gm-Message-State: AOAM5307kD1z7vJ+0/tvHI1k7DGQD1KaLaWZEGuwXwp/WAfDBitfObTu i0rNdmFh8wGkgOb0NeqDFAECpxXhz4LVhz+DuRsrKA== X-Google-Smtp-Source: ABdhPJxVky3rKIS/oU7bSC8zBBvywZPXJjmvHSoT1fVc5JVZhyOfC8jBb/ONCY7sQEBc9th/majjmccCTzSpZD7nxWc= X-Received: by 2002:a05:600c:4f45:b0:397:710e:4c6e with SMTP id m5-20020a05600c4f4500b00397710e4c6emr4117893wmq.143.1653524863660; Wed, 25 May 2022 17:27:43 -0700 (PDT) MIME-Version: 1.0 References: <20220406233648.21644-1-brad@pensando.io> <20220406233648.21644-6-brad@pensando.io> <6769ea2d-9e6a-03b1-0e05-cb5b7379cb5e@linaro.org> In-Reply-To: <6769ea2d-9e6a-03b1-0e05-cb5b7379cb5e@linaro.org> From: Brad Larson Date: Wed, 25 May 2022 17:27:32 -0700 Message-ID: Subject: Re: [PATCH 05/11] dt-bindings: spi: dw: Add Pensando Elba SoC SPI Controller bindings To: Krzysztof Kozlowski Cc: Linux ARM , Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Adrian Hunter , Ulf Hansson , Olof Johansson , David Clear , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Krzysztof, On Thu, Apr 7, 2022 at 11:52 AM Krzysztof Kozlowski wrote: > > On 07/04/2022 01:36, Brad Larson wrote: > > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > @@ -37,6 +37,21 @@ allOf: > > else: > > required: > > - interrupts > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - pensando,elba-spi > > + then: > > + properties: > > + pensando,syscon-spics: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + Phandle to the system control device node which provides access to > > + the spics control register > > It looks you only need to poke one register from spics, so it could be > something like: > > items: > - items: > - description: Phandle to the system control device node > - description: spics control register offset This looks better, I'll change to this approach for updated patchset. Regards, Brad From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F020BC433F5 for ; Thu, 26 May 2022 00:29:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H4rjrdIfOsdYR3ddioWvG139eTIly2WR3XdXmMuSd/Q=; b=M9Wxo4UZRTHA48 9e0qDzJ+0efTJK/FcpV0YOmzzqgq6hPkOjXoeBXw6UoiOyP7HTjvU1ZEy6CGirRRx6h807psBd4v1 5O7Q9O5JpHmRycFWeI4Hx02DM2oxo0mNcySH0Mi8VklzqD0ouFIes5Ox8Si8KGCXB9cj367NjNB0N UfCA0yX3LtEATgenWTH1rEbiQtgIObaXQHhfBFuanGYkdfea03ZtOMj9h2URj9KjQkZXUI9TEYfcv 3j8iXoxrKLnr7ZSYBAxjgkjEiuPoIFJfHmL+RKuYpjhJ60v3sE+Zy2EZJoFrwkfbkAcEJLO8mY4B0 UbgrCsO6a7oc0taTXavw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nu1Lx-00D3MC-Ro; Thu, 26 May 2022 00:27:49 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nu1Lu-00D3L6-DA for linux-arm-kernel@lists.infradead.org; Thu, 26 May 2022 00:27:47 +0000 Received: by mail-wm1-x32c.google.com with SMTP id p19so155082wmg.2 for ; Wed, 25 May 2022 17:27:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GOl6uOgkcVMNPECHww0pzlplNgdMl8NRZo39BUzLuoA=; b=BHM0auJl9Sd5Dl2qJoFb/qdXLGW8QkdJbZjjrLo1TDFKx5fEHAlXZgFbC0cBhPOdAI 5xDvn/os9mSk3V1kxQ1KHgGhTHYaQaRkPFLEeXeTroCAeIt70xNw7V/WlqqtbHW/CRjT OnzERudLz6vFREv37wQlCLFnApPMsCvjHd54G8eeHnr70Fe/n2vEeoiT2vjnTTOI25Nl 0EpNn2dzHSOtEIGTKjyJHp0LZB9FmTKk43WKiVV/ApgMW0khwjaWbetLVYfhpG8LfPqF hAPRZH+uPbrzgpF/eGmx+c1QbbKX4kIKJoNfJJT7xoVRq4LPhj1f+Y715qT0z3Lh4lzh Lbvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GOl6uOgkcVMNPECHww0pzlplNgdMl8NRZo39BUzLuoA=; b=LxfiEVWEiI4N471tJBxkaqenrF/0jWctkxBIqJWxv2CnWO1MkrZYZKYbOoF7IPEedA G2hOnWIQKeHS049Np3tchoRLazgYitiHebx5u8HSaB9TIApmg2KvnJoCYmH371NG+xyM DDwhTMN07xvcOkoQsMQrG6toypZZD6d4YtVsE6Na7VLBucmIZPmbtt2mXkqb7HgvJoca aaHwfVQscPB8QyqwI/PTDaL7O3UPyYUX3tYbopZXrXJC5O1nai+l4tYhgQNItXNAIjVA Iu1uvDIfVs5CQLi9Ix8F60TQjcz/EBst7s6ecHS1ZOvyekNoM4TfP5X+fjsFbbbxLEQ2 bCgA== X-Gm-Message-State: AOAM533c+EB/xxy3UacyFOgNhZFvPIR987AYj8H3s0096bccyLuekKUS 1Oz/iVIcaYgPNBlVf2H2rwSD54cXAqgQyQ1YuHKuCA== X-Google-Smtp-Source: ABdhPJxVky3rKIS/oU7bSC8zBBvywZPXJjmvHSoT1fVc5JVZhyOfC8jBb/ONCY7sQEBc9th/majjmccCTzSpZD7nxWc= X-Received: by 2002:a05:600c:4f45:b0:397:710e:4c6e with SMTP id m5-20020a05600c4f4500b00397710e4c6emr4117893wmq.143.1653524863660; Wed, 25 May 2022 17:27:43 -0700 (PDT) MIME-Version: 1.0 References: <20220406233648.21644-1-brad@pensando.io> <20220406233648.21644-6-brad@pensando.io> <6769ea2d-9e6a-03b1-0e05-cb5b7379cb5e@linaro.org> In-Reply-To: <6769ea2d-9e6a-03b1-0e05-cb5b7379cb5e@linaro.org> From: Brad Larson Date: Wed, 25 May 2022 17:27:32 -0700 Message-ID: Subject: Re: [PATCH 05/11] dt-bindings: spi: dw: Add Pensando Elba SoC SPI Controller bindings To: Krzysztof Kozlowski Cc: Linux ARM , Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Adrian Hunter , Ulf Hansson , Olof Johansson , David Clear , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220525_172746_493399_3AD953C2 X-CRM114-Status: GOOD ( 13.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On Thu, Apr 7, 2022 at 11:52 AM Krzysztof Kozlowski wrote: > > On 07/04/2022 01:36, Brad Larson wrote: > > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > @@ -37,6 +37,21 @@ allOf: > > else: > > required: > > - interrupts > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - pensando,elba-spi > > + then: > > + properties: > > + pensando,syscon-spics: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + Phandle to the system control device node which provides access to > > + the spics control register > > It looks you only need to poke one register from spics, so it could be > something like: > > items: > - items: > - description: Phandle to the system control device node > - description: spics control register offset This looks better, I'll change to this approach for updated patchset. Regards, Brad _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel