From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sachin Kamat Subject: Re: [PATCH 1/1] ARM: Exynos: Add generic compatible string Date: Tue, 25 Feb 2014 08:33:04 +0530 Message-ID: References: <1392809645-631-1-git-send-email-sachin.kamat@linaro.org> <53075239.4010603@samsung.com> <2200834.G3JJLYQl5i@wuerfel> <53076F00.7000001@samsung.com> <53077160.5030202@samsung.com> <530BE557.20106@samsung.com> <530BE93F.2070904@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <530BE93F.2070904@gmail.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Tomasz Figa Cc: Kukjin Kim , Tomasz Figa , Arnd Bergmann , linux-arm-kernel , Mark Rutland , "devicetree@vger.kernel.org" , Ian Campbell , Rob Herring , Grant Likely , linux-samsung-soc , Olof Johansson List-Id: devicetree@vger.kernel.org On 25 February 2014 06:22, Tomasz Figa wrote: > On 25.02.2014 01:35, Kukjin Kim wrote: >> >> On 02/24/14 21:03, Sachin Kamat wrote: >>> >>> On 21 February 2014 21:01, Tomasz Figa wrote: >>>> >>>> On 21.02.2014 16:21, Tomasz Figa wrote: >>>>> >>>>> >>>>> On 21.02.2014 15:48, Arnd Bergmann wrote: >>>>>> >>>>>> >>>>>> On Friday 21 February 2014 14:18:49 Tomasz Figa wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>>> Now that we have a broader agreement on this, I think we can go >>>>>>>> ahead with the >>>>>>>> following steps as an initial approach: >>>>>>>> 1. Have a common machine file for both exynos4 and 5 files, >>>>>>>> mach-exynos-dt.c. >>>>>>>> 2. Introduce a generic compatible string "samsung,exynos". >> >> >> Well, I think, we need to consider to use compatible string >> "samsung,exynos" again because "exynos" name can be used on ARMv8 as >> well and I don't want to say that generic/common something is always >> good. So IMHO still using exynos4 and exynos5 would be better. > > > You can create a new compatible string (e.g. "samsung,exynos-armv8") for > ARMv8 Exynos if support for one in mainline shows up and/or simply use > another name for ARMv7 Exynos (e.g. "samsung,exynos-armv7"). I think "samsung,exynos-armv7" would be better in case we need to distinguish between v7 and v8. -- With warm regards, Sachin From mboxrd@z Thu Jan 1 00:00:00 1970 From: sachin.kamat@linaro.org (Sachin Kamat) Date: Tue, 25 Feb 2014 08:33:04 +0530 Subject: [PATCH 1/1] ARM: Exynos: Add generic compatible string In-Reply-To: <530BE93F.2070904@gmail.com> References: <1392809645-631-1-git-send-email-sachin.kamat@linaro.org> <53075239.4010603@samsung.com> <2200834.G3JJLYQl5i@wuerfel> <53076F00.7000001@samsung.com> <53077160.5030202@samsung.com> <530BE557.20106@samsung.com> <530BE93F.2070904@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 25 February 2014 06:22, Tomasz Figa wrote: > On 25.02.2014 01:35, Kukjin Kim wrote: >> >> On 02/24/14 21:03, Sachin Kamat wrote: >>> >>> On 21 February 2014 21:01, Tomasz Figa wrote: >>>> >>>> On 21.02.2014 16:21, Tomasz Figa wrote: >>>>> >>>>> >>>>> On 21.02.2014 15:48, Arnd Bergmann wrote: >>>>>> >>>>>> >>>>>> On Friday 21 February 2014 14:18:49 Tomasz Figa wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>>> Now that we have a broader agreement on this, I think we can go >>>>>>>> ahead with the >>>>>>>> following steps as an initial approach: >>>>>>>> 1. Have a common machine file for both exynos4 and 5 files, >>>>>>>> mach-exynos-dt.c. >>>>>>>> 2. Introduce a generic compatible string "samsung,exynos". >> >> >> Well, I think, we need to consider to use compatible string >> "samsung,exynos" again because "exynos" name can be used on ARMv8 as >> well and I don't want to say that generic/common something is always >> good. So IMHO still using exynos4 and exynos5 would be better. > > > You can create a new compatible string (e.g. "samsung,exynos-armv8") for > ARMv8 Exynos if support for one in mainline shows up and/or simply use > another name for ARMv7 Exynos (e.g. "samsung,exynos-armv7"). I think "samsung,exynos-armv7" would be better in case we need to distinguish between v7 and v8. -- With warm regards, Sachin