From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ob0-f179.google.com ([209.85.214.179]:52468 "EHLO mail-ob0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754103Ab3HBFG0 (ORCPT ); Fri, 2 Aug 2013 01:06:26 -0400 Received: by mail-ob0-f179.google.com with SMTP id fb19so408742obc.10 for ; Thu, 01 Aug 2013 22:06:26 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1375355972-25276-1-git-send-email-vikas.sajjan@linaro.org> References: <1375355972-25276-1-git-send-email-vikas.sajjan@linaro.org> Date: Fri, 2 Aug 2013 10:36:25 +0530 Message-ID: Subject: Re: [PATCH] drm/exynos: Add check for IOMMU while passing physically continous memory flag From: Sachin Kamat To: Vikas Sajjan Cc: linux-samsung-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, kgene.kim@samsung.com, inki.dae@samsung.com, arun.kk@samsung.com, patches@linaro.org, linaro-kernel@lists.linaro.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-media-owner@vger.kernel.org List-ID: Hi Vikas, On 1 August 2013 16:49, Vikas Sajjan wrote: > While trying to get boot-logo up on exynos5420 SMDK which has eDP panel > connected with resolution 2560x1600, following error occured even with > IOMMU enabled: > [0.880000] [drm:lowlevel_buffer_allocate] *ERROR* failed to allocate buffer. > [0.890000] [drm] Initialized exynos 1.0.0 20110530 on minor 0 > > This patch fixes the issue by adding a check for IOMMU. > > Signed-off-by: Vikas Sajjan > Signed-off-by: Arun Kumar > --- > drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c > index 8e60bd6..2a86666 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > > #include "exynos_drm_drv.h" > #include "exynos_drm_fb.h" > @@ -143,6 +144,7 @@ static int exynos_drm_fbdev_create(struct drm_fb_helper *helper, > struct platform_device *pdev = dev->platformdev; > unsigned long size; > int ret; > + unsigned int flag; > > DRM_DEBUG_KMS("surface width(%d), height(%d) and bpp(%d\n", > sizes->surface_width, sizes->surface_height, > @@ -166,7 +168,12 @@ static int exynos_drm_fbdev_create(struct drm_fb_helper *helper, > size = mode_cmd.pitches[0] * mode_cmd.height; > > /* 0 means to allocate physically continuous memory */ This comment is now wrongly placed. Please use EXYNOS_BO_CONTIG instead of 0 and get rid of this comment altogether. > - exynos_gem_obj = exynos_drm_gem_create(dev, 0, size); > + if (!is_drm_iommu_supported(dev)) > + flag = 0; > + else > + flag = EXYNOS_BO_NONCONTIG; > + > + exynos_gem_obj = exynos_drm_gem_create(dev, flag, size); > if (IS_ERR(exynos_gem_obj)) { > ret = PTR_ERR(exynos_gem_obj); > goto err_release_framebuffer; -- With warm regards, Sachin