All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ohad Ben-Cohen <ohad@wizery.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: iommu@lists.linux-foundation.org,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Alex Williamson <alex.williamson@redhat.com>,
	David Woodhouse <dwmw2@infradead.org>,
	David Brown <davidb@codeaurora.org>,
	joro@8bytes.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/10] iommu/omap: Use bus_set_iommu instead of register_iommu
Date: Mon, 26 Sep 2011 10:09:58 +0300	[thread overview]
Message-ID: <CAK=WgbbZKa2orya_ijJ3vBeyERN2FYCKaSyn8gs=qsqJRC=kbQ@mail.gmail.com> (raw)
In-Reply-To: <1316792756-3395-9-git-send-email-joerg.roedel@amd.com>

On Fri, Sep 23, 2011 at 6:45 PM, Joerg Roedel <joerg.roedel@amd.com> wrote:
> -       register_iommu(&omap_iommu_ops);
> +       bus_set_iommu(&platform_bus_type, &omap_iommu_ops);

I'm not sure it makes a lot of sense to bind the iommu ops to the platform bus.

Unlike the pci bus, the platform bus is not really a hardware bus:
it's some kind of a catch-all pseudo bus which is mostly used to to
describe a collection of autonomous peripherals on an SoC.

As a result, IOMMU users on an SoC might actually not belong to the
platform bus.

More specifically, I'm not sure how this would work out with the
upcoming generic IOMMU-based DMA API, which might be used by those
non-platform-bus users.

That said, the generic DMA API is not here yet, and nothing
immediately breaks for us by doing this change, so if this helps you
guys with the x86/pci iommu drivers than I'm ok with it: we can always
change/fix this later when real issues come up with this model.

  reply	other threads:[~2011-09-26  7:10 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-23 15:45 [PATCH 0/10 v3] IOMMU: Make iommu_ops per-bus_type Joerg Roedel
2011-09-23 15:45 ` [PATCH 01/10] iommu/core: Define iommu_ops and register_iommu only with CONFIG_IOMMU_API Joerg Roedel
2011-09-23 15:45 ` [PATCH 02/10] Driver core: Add iommu_ops to bus_type Joerg Roedel
2011-09-29 20:05   ` Greg KH
2011-09-30  6:24     ` Joerg Roedel
2011-09-30 13:58       ` Greg KH
2011-09-23 15:45 ` [PATCH 03/10] iommu/core: Add bus_type parameter to iommu_domain_alloc Joerg Roedel
2011-09-23 15:45 ` [PATCH 04/10] iommu/core: Convert iommu_found to iommu_present Joerg Roedel
2011-09-23 15:45 ` [PATCH 05/10] iommu/core: Use bus->iommu_ops in the iommu-api Joerg Roedel
2011-09-23 15:45 ` [PATCH 06/10] iommu/amd: Use bus_set_iommu instead of register_iommu Joerg Roedel
2011-09-23 15:45 ` [PATCH 07/10] iommu/vt-d: " Joerg Roedel
2011-09-23 15:45 ` [PATCH 08/10] iommu/omap: " Joerg Roedel
2011-09-26  7:09   ` Ohad Ben-Cohen [this message]
2011-09-26 12:22     ` Roedel, Joerg
2011-09-26 12:29       ` Ohad Ben-Cohen
2011-09-27 11:00         ` Roedel, Joerg
2011-09-27 11:10           ` Ohad Ben-Cohen
2011-09-27 11:20             ` KyongHo Cho
2011-09-29 20:04   ` Greg KH
2011-10-02 17:24     ` Ohad Ben-Cohen
2011-09-23 15:45 ` [PATCH 09/10] iommu/msm: " Joerg Roedel
2011-09-23 17:44   ` David Brown
2011-09-23 15:45 ` [PATCH 10/10] iommu/core: Remove global iommu_ops and register_iommu Joerg Roedel
  -- strict thread matches above, loose matches on Subject: below --
2011-09-22 16:14 [PATCH 0/10 v2] IOMMU: Make iommu_ops per-bus_type Joerg Roedel
2011-09-22 16:15 ` [PATCH 08/10] iommu/omap: Use bus_set_iommu instead of register_iommu Joerg Roedel
2011-09-07 15:41 [PATCH 0/10] IOMMU: Make iommu_ops per-bus_type Joerg Roedel
2011-09-07 15:41 ` [PATCH 08/10] iommu/omap: Use bus_set_iommu instead of register_iommu Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK=WgbbZKa2orya_ijJ3vBeyERN2FYCKaSyn8gs=qsqJRC=kbQ@mail.gmail.com' \
    --to=ohad@wizery.com \
    --cc=alex.williamson@redhat.com \
    --cc=davidb@codeaurora.org \
    --cc=dwmw2@infradead.org \
    --cc=gregkh@suse.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joerg.roedel@amd.com \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.