From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933761AbbFVM2E (ORCPT ); Mon, 22 Jun 2015 08:28:04 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:33940 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933691AbbFVM07 (ORCPT ); Mon, 22 Jun 2015 08:26:59 -0400 MIME-Version: 1.0 In-Reply-To: References: <1434102153-38581-1-git-send-email-Sreekanth.Reddy@avagotech.com> <1434102153-38581-17-git-send-email-Sreekanth.Reddy@avagotech.com> Date: Mon, 22 Jun 2015 17:56:58 +0530 Message-ID: Subject: Re: [PATCH 16/20] [SCSI] mpt3sas: Added support for customer specific branding From: Sreekanth Reddy To: "Martin K. Petersen" Cc: "jejb@kernel.org" , Christoph Hellwig , "linux-scsi@vger.kernel.org" , "James E.J. Bottomley" , Sathya Prakash , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 20, 2015 at 2:14 AM, Martin K. Petersen wrote: >>>>>> Sreekanth Reddy writes: > >> Added support for below customer specific brandings "VendorID" >> "DeviceID" "SubsystemVendor ID" "SubsystemDevice ID" Cisco Branding >> String 0x1000 0x97 0x1137 0x154 Cisco 9300-8i 12Gbps SAS HBA 0x1000 >> 0x97 0x1137 0x155 Cisco 12G Modular SAS Pass through Controller 0x1000 >> 0x97 0x1137 0x156 UCS C3X60 12G SAS Pass through Controller > > Same comment about not actually changing driver behavior. > > These changes belong in pci.ids, not in a driver. Yes Martin, I agree with you that these changes belong in pci.ids. But Customers are asking us to print the HBA branding name while loading the driver on their custom HBA's. > > -- > Martin K. Petersen Oracle Linux Engineering -- Regards, Sreekanth -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sreekanth Reddy Subject: Re: [PATCH 16/20] [SCSI] mpt3sas: Added support for customer specific branding Date: Mon, 22 Jun 2015 17:56:58 +0530 Message-ID: References: <1434102153-38581-1-git-send-email-Sreekanth.Reddy@avagotech.com> <1434102153-38581-17-git-send-email-Sreekanth.Reddy@avagotech.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-wi0-f172.google.com ([209.85.212.172]:33844 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933692AbbFVM1A (ORCPT ); Mon, 22 Jun 2015 08:27:00 -0400 Received: by wicnd19 with SMTP id nd19so74978074wic.1 for ; Mon, 22 Jun 2015 05:26:58 -0700 (PDT) In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "Martin K. Petersen" Cc: "jejb@kernel.org" , Christoph Hellwig , "linux-scsi@vger.kernel.org" , "James E.J. Bottomley" , Sathya Prakash , "linux-kernel@vger.kernel.org" On Sat, Jun 20, 2015 at 2:14 AM, Martin K. Petersen wrote: >>>>>> Sreekanth Reddy writes: > >> Added support for below customer specific brandings "VendorID" >> "DeviceID" "SubsystemVendor ID" "SubsystemDevice ID" Cisco Branding >> String 0x1000 0x97 0x1137 0x154 Cisco 9300-8i 12Gbps SAS HBA 0x1000 >> 0x97 0x1137 0x155 Cisco 12G Modular SAS Pass through Controller 0x1000 >> 0x97 0x1137 0x156 UCS C3X60 12G SAS Pass through Controller > > Same comment about not actually changing driver behavior. > > These changes belong in pci.ids, not in a driver. Yes Martin, I agree with you that these changes belong in pci.ids. But Customers are asking us to print the HBA branding name while loading the driver on their custom HBA's. > > -- > Martin K. Petersen Oracle Linux Engineering -- Regards, Sreekanth -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in