Re: [PATCH] mpi3mr: Fix W=1 compilation warnings

From: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	mpi3mr-drvr-developers <mpi3mr-linuxdrv.pdl@broadcom.com>,
	Kashyap Desai <kashyap.desai@broadcom.com>,
	Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] mpi3mr: Fix W=1 compilation warnings
Date: Tue, 29 Jun 2021 19:38:25 +0530	[thread overview]
Message-ID: <CAK=zhgqJuwk2=pbZQnCPyys8Rh+Bi0NT=W8Fa5+oYgweigJ1VQ@mail.gmail.com> (raw)
In-Reply-To: <yq1czs5l4uw.fsf@ca-mkp.ca.oracle.com>

[-- Attachment #1: Type: text/plain, Size: 735 bytes --]

On Tue, Jun 29, 2021 at 9:14 AM Martin K. Petersen
<martin.petersen@oracle.com> wrote:
>
>
> Sreekanth,
>
> > -     strncpy(drv_info->os_name, utsname()->sysname, sizeof(drv_info->os_name));
> > -     drv_info->os_name[sizeof(drv_info->os_name) - 1] = 0;
> > -     strncpy(drv_info->os_version, utsname()->release, sizeof(drv_info->os_version));
> > -     drv_info->os_version[sizeof(drv_info->os_version) - 1] = 0;
> > +     memcpy(drv_info->os_name, utsname()->sysname, sizeof(drv_info->os_name) - 1);
> > +     memcpy(drv_info->os_version, utsname()->release, sizeof(drv_info->os_version) - 1);
>
> strscpy()?

Agreed. Posted a new patch using strscpy().

Thanks,
Sreekanth
>
> --
> Martin K. Petersen      Oracle Linux Engineering

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]