From: Sreekanth Reddy <sreekanth.reddy@avagotech.com>
To: Joe Perches <joe@perches.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
jejb@kernel.org, linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Sathya Prakash <Sathya.Prakash@avagotech.com>,
Nagalakshmi Nandigama <Nagalakshmi.Nandigama@avagotech.com>,
linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [RESEND][PATCH 07/10][SCSI]mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support
Date: Tue, 12 Aug 2014 15:21:13 +0530 [thread overview]
Message-ID: <CAK=zhgrvTVoy8zvu21U00NQV53LSiK8HRMTFAarRHJLXqRJRiw@mail.gmail.com> (raw)
In-Reply-To: <1407836262.3141.16.camel@joe-AO725>
On Tue, Aug 12, 2014 at 3:07 PM, Joe Perches <joe@perches.com> wrote:
> On Tue, 2014-08-12 at 14:54 +0530, Sreekanth Reddy wrote:
>> So, the proposal is to allocate memory independently for each
>> Reply Queue and pass down all of the addresses to the firmware.
>> Then the firmware will just take each address and program the value
>> into the correct register.
>
> trivial note:
>
>> diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
> []
>> @@ -1179,17 +1184,22 @@ static int
>> _base_config_dma_addressing(struct MPT2SAS_ADAPTER *ioc, struct pci_dev *pdev)
>> {
>> struct sysinfo s;
>> - char *desc = NULL;
>> + u64 consistent_dma_mask;
>> +
>> + if (dma_mask)
>> + consistent_dma_mask = DMA_BIT_MASK(64);
>> + else
>> + consistent_dma_mask = DMA_BIT_MASK(32);
>>
>> if (sizeof(dma_addr_t) > 4) {
>> const uint64_t required_mask =
>> dma_get_required_mask(&pdev->dev);
>> if ((required_mask > DMA_BIT_MASK(32)) && !pci_set_dma_mask(pdev,
>> DMA_BIT_MASK(64)) && !pci_set_consistent_dma_mask(pdev,
>> - DMA_BIT_MASK(64))) {
>> + consistent_dma_mask)) {
>
> This would be easier to read if the embedded functions
> within the if were on separate lines like:
Accepted. next time onwards I will take care of this.
>
> if ((required_mask > DMA_BIT_MASK(32)) &&
> !pci_set_dma_mask(pdev, DMA_BIT_MASK(64)) &&
> !pci_set_consistent_dma_mask(pdev, consistent_dma_mask)) {
>
>
next prev parent reply other threads:[~2014-08-12 9:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 9:24 [RESEND][PATCH 07/10][SCSI]mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support Sreekanth Reddy
2014-08-12 9:37 ` Joe Perches
2014-08-12 9:51 ` Sreekanth Reddy [this message]
2014-08-21 20:35 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2014-08-23 15:04 [RESEND][PATCH 07/10] [SCSI] mpt2sas: " Sreekanth Reddy
2014-08-24 15:37 ` Christoph Hellwig
2014-06-25 10:34 [RESEND][PATCH 07/10][SCSI]mpt2sas: " Reddy, Sreekanth
2014-06-25 10:34 ` Reddy, Sreekanth
2014-07-22 3:10 ` Martin K. Petersen
2014-07-22 3:10 ` Martin K. Petersen
[not found] ` <CAK=zhgoQt5J=jh4jShAy5rBXNz34sN-tqf=uZDkY4zQJ9XhM5g@mail.gmail.com>
2014-07-23 1:25 ` Martin K. Petersen
2014-07-23 17:37 ` Sreekanth Reddy
2014-07-23 19:46 ` Martin K. Petersen
2014-07-25 12:57 ` Sreekanth Reddy
2014-07-25 19:43 ` Martin K. Petersen
2014-07-30 14:55 ` Sreekanth Reddy
2014-08-05 18:46 ` Martin K. Petersen
[not found] ` <CAK=zhgpqW-t11JKiBRRM7Z4TEMyaEUBX943qT8faaKPk6Pk4XA@mail.gmail.com>
[not found] ` <CAK=zhgpiyt9xukGCNDOpEDmWRwFSMCcEiUQ190BW0UgiLGVP6g@mail.gmail.com>
2014-08-11 13:17 ` Sreekanth Reddy
2014-08-12 2:32 ` Martin K. Petersen
2017-04-25 11:51 ` Sreekanth Reddy
2017-04-26 22:25 ` Martin K. Petersen
2017-04-26 22:25 ` Martin K. Petersen
2017-04-27 9:15 ` Kashyap Desai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK=zhgrvTVoy8zvu21U00NQV53LSiK8HRMTFAarRHJLXqRJRiw@mail.gmail.com' \
--to=sreekanth.reddy@avagotech.com \
--cc=JBottomley@parallels.com \
--cc=Nagalakshmi.Nandigama@avagotech.com \
--cc=Sathya.Prakash@avagotech.com \
--cc=hch@infradead.org \
--cc=jejb@kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.