From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B88AC3A5A0 for ; Mon, 19 Aug 2019 23:16:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D43422CF5 for ; Mon, 19 Aug 2019 23:16:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e6kUCEmy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728740AbfHSXQt (ORCPT ); Mon, 19 Aug 2019 19:16:49 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:43216 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728615AbfHSXQs (ORCPT ); Mon, 19 Aug 2019 19:16:48 -0400 Received: by mail-lj1-f195.google.com with SMTP id h15so3312510ljg.10 for ; Mon, 19 Aug 2019 16:16:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oG0ouUk/hZH8W/yX9VbEceq9eBiZaqn7FGbViL/YZkM=; b=e6kUCEmyQUsL4M+h5dCnLah/B2kT64l/6XXcvg72DsY2jmEA05aG3cl9WXl5p1xbcW umoZx6hutp16ozdT/hM6UWCuhYltuBYEyMedHuYVqDb9r3sKM9u6PgCCLDZZ5e70KZhN 3DE4s8Y442RtCPgz4etq6olnr9CJL51Hnd6sgUZIAPXJ1MTzSORjt6i7VdMenG7jIuTu xHQjPiyByCpnLosEy6Ztp++vkycDe+O+/6gJhG0ZVIt+AILpLEooU7hIhvCXge4hX/nr ytHMCvUGlEcl3L8kU8CvYXZuUkxesR5uronSqApkYROogywstwa5iUMRB37Gall4sB+j NMTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oG0ouUk/hZH8W/yX9VbEceq9eBiZaqn7FGbViL/YZkM=; b=jHyWt1Q45RNa9nTYvrDUXry7ryazCt7iGCh9g3NnERJLSoi3RoPNU6jzuXCsTZi7fU RC+mDm4qINm4Jf9BZuDQlvLDyN7Z2fAD5aCaDqFHKiz/gJkHyDPzO+RApSrgBsOzh00x 9MRmNTZ7TnOFU4GBymGsnCC+DXUsQ5h7eRtQCJT8HhM4LqnUuaHXjKeI9Ydw97xl9yVq QxoJO8MMmfUnoMOEnu5RVqxOpsNYLzGA18zlFIewg5syOHdtFDHMJO5Z/V62hOTK73Y6 Vye6zsuauc5CEf7OY1xu0nsr60/ArcUhTKhBuLxYaZ2W1IMIPKS7taitf5pEpeIlwcof mnFQ== X-Gm-Message-State: APjAAAWa2LpXKEHeCO0sob0TAhk4e5uJJIxZCSN8arCepDPkjb+D0z9l Zlfp1Vffu8gfS4xkaBtoMGh8G98+wh1Gj9aYQpY= X-Google-Smtp-Source: APXvYqyxWZP5xm/bTtjcVnR4ZifBaJLMCSfNfK3goU/H88QN/1ky0QE91bGsTRqkonh2328X1zsVN71bzufLqflGAwU= X-Received: by 2002:a2e:980d:: with SMTP id a13mr13962629ljj.145.1566256606356; Mon, 19 Aug 2019 16:16:46 -0700 (PDT) MIME-Version: 1.0 References: <20180223121456.GZ25201@hirez.programming.kicks-ass.net> <20180226203937.GA21543@tassilo.jf.intel.com> In-Reply-To: From: Josh Hunt Date: Mon, 19 Aug 2019 16:16:34 -0700 Message-ID: Subject: Re: Long standing kernel warning: perfevents: irq loop stuck! To: Thomas Gleixner Cc: Andi Kleen , Peter Zijlstra , Cong Wang , "Liang, Kan" , jolsa@redhat.com, bigeasy@linutronix.de, "H. Peter Anvin" , Ingo Molnar , x86 , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 19, 2019 at 2:17 PM Josh Hunt wrote: > > On Mon, Aug 12, 2019 at 12:42 PM Josh Hunt wrote: > > > > On Mon, Aug 12, 2019 at 12:34 PM Thomas Gleixner wrote: > > > > > > On Mon, 12 Aug 2019, Josh Hunt wrote: > > > > On Mon, Aug 12, 2019 at 10:55 AM Thomas Gleixner wrote: > > > > > > > > > > On Mon, 12 Aug 2019, Josh Hunt wrote: > > > > > > Was there any progress made on debugging this issue? We are still > > > > > > seeing it on 4.19.44: > > > > > > > > > > I haven't seen anyone looking at this. > > > > > > > > > > Can you please try the patch Ingo posted: > > > > > > > > > > https://lore.kernel.org/lkml/20150501070226.GB18957@gmail.com/ > > > > > > > > > > and if it fixes the issue decrease the value from 128 to the point where it > > > > > comes back, i.e. 128 -> 64 -> 32 ... > > > > > > > > > > Thanks, > > > > > > > > > > tglx > > > > > > > > I just checked the machines where this problem occurs and they're both > > > > Nehalem boxes. I think Ingo's patch would only help Haswell machines. > > > > Please let me know if I misread the patch or if what I'm seeing is a > > > > different issue than the one Cong originally reported. > > > > > > Find the NHM hack below. > > > > > > Thanks, > > > > > > tglx > > > > > > 8<---------------- > > > > > > diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c > > > index 648260b5f367..93c1a4f0e73e 100644 > > > --- a/arch/x86/events/intel/core.c > > > +++ b/arch/x86/events/intel/core.c > > > @@ -3572,6 +3572,11 @@ static u64 bdw_limit_period(struct perf_event *event, u64 left) > > > return left; > > > } > > > > > > +static u64 nhm_limit_period(struct perf_event *event, u64 left) > > > +{ > > > + return max(left, 128ULL); > > > +} > > > + > > > PMU_FORMAT_ATTR(event, "config:0-7" ); > > > PMU_FORMAT_ATTR(umask, "config:8-15" ); > > > PMU_FORMAT_ATTR(edge, "config:18" ); > > > @@ -4606,6 +4611,7 @@ __init int intel_pmu_init(void) > > > x86_pmu.pebs_constraints = intel_nehalem_pebs_event_constraints; > > > x86_pmu.enable_all = intel_pmu_nhm_enable_all; > > > x86_pmu.extra_regs = intel_nehalem_extra_regs; > > > + x86_pmu.limit_period = nhm_limit_period; > > > > > > mem_attr = nhm_mem_events_attrs; > > > > > Thanks Thomas. Will try this and let you know. > > > > -- > > Josh > > Thomas > > I found on my setup that setting the value to 32 was the lowest value > I could use to keep the problem from happening. Let me know if you > want me to send a patch with the updated value, etc. > > I saw in the original thread from Ingo and Vince that this was seen on > Haswell, but I checked our Haswell boxes and so far we have not > reproduced the problem there. > > -- > Josh I went ahead and sent this patch with the value set to 32: https://lore.kernel.org/lkml/1566256411-18820-1-git-send-email-johunt@akamai.com/T/#u I wasn't sure how/who to give credit to for the change, so please resubmit if what I did is incorrect or if you wanted to debug further. If you decide to resubmit the patch please add my tested-by and Bhupesh's reported-by. I'm able to reproduce the problem within about 2 hours if there's anything else you wanted to look into before going with this approach. Thanks! -- Josh