All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Colitti <lorenzo@google.com>
To: John Stultz <john.stultz@linaro.org>
Cc: David Ahern <dsa@cumulusnetworks.com>,
	David Miller <davem@davemloft.net>,
	Mateusz Bajorski <mateusz.bajorski@nokia.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Guodong Xu <guodong.xu@linaro.org>,
	Dmitry Shmidt <dimitrysh@google.com>,
	Chih-Hung Hsieh <chh@google.com>,
	Eric Caruso <ejcaruso@google.com>
Subject: Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace
Date: Mon, 1 Aug 2016 10:42:05 +0900	[thread overview]
Message-ID: <CAKD1Yr06yV+P7_WwaF+CXuzD9xHEHQYereL-1Ax0_8hLDTSMOQ@mail.gmail.com> (raw)
In-Reply-To: <CALAqxLWBFyS8VF02tBmAR-Zu1j6Nh7ETZFoWx1fzVgx81rUk1Q@mail.gmail.com>

On Sat, Jul 30, 2016 at 1:57 AM, John Stultz <john.stultz@linaro.org> wrote:
>
> With the patch reverted, and the system working,  I see:
>
> # ip rule ls
> 0:      from all lookup local
> 10000:  from all fwmark 0xc0000/0xd0000 lookup legacy_system
> 13000:  from all fwmark 0x10063/0x1ffff lookup local_network
> 13000:  from all fwmark 0x10065/0x1ffff lookup wlan0
> 14000:  from all oif wlan0 lookup wlan0
> 14000:  from all oif wlan0 lookup wlan0
> 15000:  from all fwmark 0x0/0x10000 lookup legacy_system
> 16000:  from all fwmark 0x0/0x10000 lookup legacy_network
> 17000:  from all fwmark 0x0/0x10000 lookup local_network
> 19000:  from all fwmark 0x64/0x1ffff lookup wlan0
> 19000:  from all fwmark 0x65/0x1ffff lookup wlan0
> 22000:  from all fwmark 0x0/0xffff lookup wlan0
> 32000:  from all unreachable


This is not correct, you're missing "uidrange 0-0" qualifiers on some
of the rules.

Does the kernel pass the networking unit tests at
https://source.android.com/devices/tech/config/kernel_network_tests.html
? If not, the Android network stack will not work correctly.

  parent reply	other threads:[~2016-08-01  1:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-29  4:18 [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace John Stultz
2016-07-29  4:20 ` David Miller
2016-07-29 14:12   ` David Ahern
2016-07-29 16:57     ` John Stultz
2016-07-29 19:10       ` David Ahern
2016-08-01  1:42       ` Lorenzo Colitti [this message]
2016-08-02 16:37         ` John Stultz
2016-08-02 17:03           ` John Stultz
2016-08-02 17:09             ` David Ahern
2016-08-02 17:51               ` John Stultz
2016-08-02 18:00                 ` David Miller
2016-08-02 18:22                   ` John Stultz
2016-08-02 18:28                     ` David Miller
2016-08-03  0:58                   ` Lorenzo Colitti
2016-08-03  1:04                     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKD1Yr06yV+P7_WwaF+CXuzD9xHEHQYereL-1Ax0_8hLDTSMOQ@mail.gmail.com \
    --to=lorenzo@google.com \
    --cc=chh@google.com \
    --cc=davem@davemloft.net \
    --cc=dimitrysh@google.com \
    --cc=dsa@cumulusnetworks.com \
    --cc=ejcaruso@google.com \
    --cc=guodong.xu@linaro.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mateusz.bajorski@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.