From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manish Badarkhe Subject: Re: [PATCH 1/5] ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons Date: Thu, 7 Feb 2013 12:06:25 +0530 Message-ID: References: <1360214129-4096-1-git-send-email-tushar.behera@linaro.org> <51134907.1050803@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <51134907.1050803@linaro.org> Sender: linux-samsung-soc-owner@vger.kernel.org To: Tushar Behera Cc: "Kumar, Anil" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" , "kgene.kim@samsung.com" , "patches@linaro.org" List-Id: devicetree@vger.kernel.org Hi Tushar On Thu, Feb 7, 2013 at 11:56 AM, Tushar Behera wrote: > On 02/07/2013 11:47 AM, Kumar, Anil wrote: >> On Thu, Feb 07, 2013 at 10:45:25, Tushar Behera wrote: >>> Added GPIO buttons DT node to Arndale board file. >>> >>> Signed-off-by: Tushar Behera >>> Signed-off-by: Sachin Kamat >>> --- >>> This series is based on for-next branch of Kukjin Kim's tree >>> and added on top of the below patch: >>> https://patchwork.kernel.org/patch/2042451/ >>> --- >>> arch/arm/boot/dts/exynos5250-arndale.dts | 48 ++++++++++++++++++++++++++++++ >>> 1 files changed, 48 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts >>> index 63572f9..9ce40df 100644 >>> --- a/arch/arm/boot/dts/exynos5250-arndale.dts >>> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts >>> @@ -119,4 +119,52 @@ >>> spi_2: spi@12d40000 { >>> status = "disabled"; >>> }; >>> + >>> + gpio_keys { >>> + compatible = "gpio-keys"; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >> >> Just want to understand why these properties are here? >> As these properties are for child dt node. But have not seen >> anyone is using here. >> > > That is how gpio_keys node entries are defined in other .dts files. I have gone through example for address-cells and size-cells in following link: http://devicetree.org/mediawiki/index.php?title=Device_Tree_Usage&stable=1#CPU_addressing which indicates that these fields are for child "reg". I think, here in child node there is no "reg". so there is no use of address-cells and size-cells propeties. Correct me if I am wrong here? Thanks Manish Badarkhe From mboxrd@z Thu Jan 1 00:00:00 1970 From: badarkhe.manish@gmail.com (Manish Badarkhe) Date: Thu, 7 Feb 2013 12:06:25 +0530 Subject: [PATCH 1/5] ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons In-Reply-To: <51134907.1050803@linaro.org> References: <1360214129-4096-1-git-send-email-tushar.behera@linaro.org> <51134907.1050803@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Tushar On Thu, Feb 7, 2013 at 11:56 AM, Tushar Behera wrote: > On 02/07/2013 11:47 AM, Kumar, Anil wrote: >> On Thu, Feb 07, 2013 at 10:45:25, Tushar Behera wrote: >>> Added GPIO buttons DT node to Arndale board file. >>> >>> Signed-off-by: Tushar Behera >>> Signed-off-by: Sachin Kamat >>> --- >>> This series is based on for-next branch of Kukjin Kim's tree >>> and added on top of the below patch: >>> https://patchwork.kernel.org/patch/2042451/ >>> --- >>> arch/arm/boot/dts/exynos5250-arndale.dts | 48 ++++++++++++++++++++++++++++++ >>> 1 files changed, 48 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts >>> index 63572f9..9ce40df 100644 >>> --- a/arch/arm/boot/dts/exynos5250-arndale.dts >>> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts >>> @@ -119,4 +119,52 @@ >>> spi_2: spi at 12d40000 { >>> status = "disabled"; >>> }; >>> + >>> + gpio_keys { >>> + compatible = "gpio-keys"; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >> >> Just want to understand why these properties are here? >> As these properties are for child dt node. But have not seen >> anyone is using here. >> > > That is how gpio_keys node entries are defined in other .dts files. I have gone through example for address-cells and size-cells in following link: http://devicetree.org/mediawiki/index.php?title=Device_Tree_Usage&stable=1#CPU_addressing which indicates that these fields are for child "reg". I think, here in child node there is no "reg". so there is no use of address-cells and size-cells propeties. Correct me if I am wrong here? Thanks Manish Badarkhe