From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EC6EC2D0CE for ; Tue, 21 Jan 2020 18:19:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51F7122522 for ; Tue, 21 Jan 2020 18:19:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lMMpm3vZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729080AbgAUSTR (ORCPT ); Tue, 21 Jan 2020 13:19:17 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:41053 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728186AbgAUSTQ (ORCPT ); Tue, 21 Jan 2020 13:19:16 -0500 Received: by mail-ed1-f68.google.com with SMTP id c26so3956487eds.8 for ; Tue, 21 Jan 2020 10:19:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gLheq0HdqUTiqpysx4xrBJXQzj1ZOZjBAEJlXpHvXC0=; b=lMMpm3vZ8wMxI2BDMNyKyd9/DyYUNVsDNMNJOReRs3/2q0nYoRakmtFh8x5EYJFLfJ xpQ6ZrFbakWj5bXBHl5SkGGFLuGt1w1qhGHp7cXozV+y2Lh19qx3yGnOPkxGGBFP6776 7KpP4TI4y2mFaCBSBCMaw8z5gmAmskldbeYK1VMnbQAGcToaLk8e3gIcjwk8pd+mswJL 3+C3DuPNDRI6h5JhfBjWt9f0tqKlQ7Po0vNP5FkWRUD7NiZRD+MyNWWRMRKaCmvCzJAm 6awfPqY307N4y6hWjiUF7XjNegev3OC3kDlJLeSnEQ3ktj/Jc6XVrJDd2mmc9l8shVKm RY9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gLheq0HdqUTiqpysx4xrBJXQzj1ZOZjBAEJlXpHvXC0=; b=HkHzjP/OPLey9OkNYbPX9CkTFE6nYt5sJPh+QkzBR2s8DbcgbD42eOUh4NJdP5Ag7t Z+Cs2bRkAbluY8Hh17WeJTCQE66EeB2Xley1JF7cWrEjeJUfaxJMeClMVGzzDgQBvAhW ab59NPVHuykXJVZmUbbFdz9t0w0mT5229uWhJtJY9GA+iSVUMtPZY8qmODcuG7sHvhfo yQQ2GtpW+e54ervnE00HLlIU0PfslALYiduJhORei9cOQ/J97a53+b0q5ytt7wtggDlE 7TT5/OYG8zddqZ5HFkbwR90HwBClSKeN+P1NZEq7fLhK3dBnEdze5OQ3dY79VT3El8dA eIlQ== X-Gm-Message-State: APjAAAUYEGCyBoEmjebyBfe2u0kTzL8nAJ1jpmxoZEWdE9z7X+4PcuBF dI553s0rRhIp5ShrkqT/H008c64gpaDCcZBR7LkEaA== X-Google-Smtp-Source: APXvYqye4Rk0fd+Lr0Qy3pe8yjxXCqM6sGWrir4DrbcZaM0QTB8GeXxQ5h8pLB9Mc3Ftziav9YfJUzW/+WVXX6ncwZE= X-Received: by 2002:a05:6402:3088:: with SMTP id de8mr5108502edb.332.1579630754711; Tue, 21 Jan 2020 10:19:14 -0800 (PST) MIME-Version: 1.0 References: <20191230012720.2368987-1-djogorchock@gmail.com> <20191230012720.2368987-12-djogorchock@gmail.com> In-Reply-To: From: Siarhei Vishniakou Date: Tue, 21 Jan 2020 10:19:03 -0800 Message-ID: Subject: Re: [PATCH v10 11/12] HID: nintendo: add IMU support To: Daniel Ogorchock Cc: Carl Mueller , Roderick Colenbrander , linux-input , Billy Laws , Benjamin Tissoires , Jiri Kosina , "Colenbrander, Roelof" , s.jegen@gmail.com Content-Type: text/plain; charset="UTF-8" Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi Daniel, I wonder if it would make sense to fold some of the patches into the first patch? As an example, the first patch essentially adds the basic joystick functionality, and at the same time it uses subcommands to communicate with the device, for things like retrieving the calibration data. Somewhere later in the patch series, there is a patch that improves subcommand reliability. Maybe the 'improve subcommands' patch can be combined with the first patch?