From mboxrd@z Thu Jan 1 00:00:00 1970 From: Qiang Yu Subject: Re: [PATCH RFC 06/24] drm/lima: add lima uapi header Date: Sun, 20 May 2018 15:22:08 +0800 Message-ID: References: <20180518092815.25280-1-yuq825@gmail.com> <20180518092815.25280-7-yuq825@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0382619960==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Marek Vasut Cc: Simon Shields , devicetree@vger.kernel.org, Connor Abbott , Neil Armstrong , Andrei Paulau <7134956@gmail.com>, dri-devel , Vasily Khoruzhick , Erico Nunes List-Id: devicetree@vger.kernel.org --===============0382619960== Content-Type: multipart/alternative; boundary="000000000000059764056c9e0b2d" --000000000000059764056c9e0b2d Content-Type: text/plain; charset="UTF-8" On Fri, May 18, 2018 at 5:33 PM, Marek Vasut wrote: > On 05/18/2018 11:27 AM, Qiang Yu wrote: > > Commit message is missing > > > Signed-off-by: Qiang Yu > > --- > > include/uapi/drm/lima_drm.h | 195 ++++++++++++++++++++++++++++++++++++ > > 1 file changed, 195 insertions(+) > > create mode 100644 include/uapi/drm/lima_drm.h > > > > diff --git a/include/uapi/drm/lima_drm.h b/include/uapi/drm/lima_drm.h > > new file mode 100644 > > index 000000000000..9df95e46fb2c > > --- /dev/null > > +++ b/include/uapi/drm/lima_drm.h > > Please convert this to the SPDX license identifiers, that is > > // SPDX... > > OK. > > @@ -0,0 +1,195 @@ > > +/* > > + * Copyright (C) 2017-2018 Lima Project > > + * > > + * Permission is hereby granted, free of charge, to any person > obtaining a > > + * copy of this software and associated documentation files (the > "Software"), > > + * to deal in the Software without restriction, including without > limitation > > + * the rights to use, copy, modify, merge, publish, distribute, > sublicense, > > + * and/or sell copies of the Software, and to permit persons to whom the > > + * Software is furnished to do so, subject to the following conditions: > > [...] > > > +#if defined(__cplusplus) > > +extern "C" { > > +#endif > > Is this C++ stuff needed ? > This file is used by both kernel and user space programs, so I added this following other xxx_drm.h files here. > > [...] > > > +#define LIMA_SUBMIT_FLAG_EXPLICIT_FENCE (1 << 0) > > +#define LIMA_SUBMIT_FLAG_SYNC_FD_OUT (1 << 1) > > BIT(0) and BIT(1) if applicable > I can use BIT() for kernel only files but not this user/kernel shared one, because I see BIT is defined in the kernel only, user need to define it if this file use it. > [...] > > -- > Best regards, > Marek Vasut > Regards, Qiang --000000000000059764056c9e0b2d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri, May 18, 2018 at 5:33 PM, Marek Vasut <marex@denx.de>= wrote:
On 05/18/2018 11:27 AM, Qiang Yu = wrote:

Commit message is missing

> Signed-off-by: Qiang Yu <yuq825= @gmail.com>
> ---
>=C2=A0 include/uapi/drm/lima_drm.h | 195 ++++++++++++++++++++++++++++++= ++++++
>=C2=A0 1 file changed, 195 insertions(+)
>=C2=A0 create mode 100644 include/uapi/drm/lima_drm.h
>
> diff --git a/include/uapi/drm/lima_drm.h b/include/uapi/drm/lima_drm.h=
> new file mode 100644
> index 000000000000..9df95e46fb2c
> --- /dev/null
> +++ b/include/uapi/drm/lima_drm.h

Please convert this to the SPDX license identifiers, that is

// SPDX...

OK.
=C2=A0
> @@ -0,0 +1,195 @@
> +/*
> + * Copyright (C) 2017-2018 Lima Project
> + *
> + * Permission is hereby granted, free of charge, to any person obtain= ing a
> + * copy of this software and associated documentation files (the &quo= t;Software"),
> + * to deal in the Software without restriction, including without lim= itation
> + * the rights to use, copy, modify, merge, publish, distribute, subli= cense,
> + * and/or sell copies of the Software, and to permit persons to whom = the
> + * Software is furnished to do so, subject to the following condition= s:

[...]

> +#if defined(__cplusplus)
> +extern "C" {
> +#endif

Is this C++ stuff needed ?
=C2=A0
Thi= s file is used by both kernel and user space programs, so I added this
following other xxx_drm.h files here.
=C2=A0

[...]

> +#define LIMA_SUBMIT_FLAG_EXPLICIT_FENCE (1 << 0)
> +#define LIMA_SUBMIT_FLAG_SYNC_FD_OUT=C2=A0 =C2=A0 (1 << 1)

BIT(0) and BIT(1) if applicable

= I can use BIT() for kernel only files but not this user/kernel shared one,<= /div>
because I see BIT is defined in the kernel only, user need to def= ine it if
this file use it.
=C2=A0
[...]

--
Best regards,
Marek Vasut

Regards,
Qiang=C2=A0

--000000000000059764056c9e0b2d-- --===============0382619960== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0382619960==--