From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FF26C282DA for ; Wed, 17 Apr 2019 02:42:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0FABC2075B for ; Wed, 17 Apr 2019 02:42:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dN0SwqMO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731034AbfDQCmZ (ORCPT ); Tue, 16 Apr 2019 22:42:25 -0400 Received: from mail-it1-f196.google.com ([209.85.166.196]:35010 "EHLO mail-it1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728108AbfDQCmY (ORCPT ); Tue, 16 Apr 2019 22:42:24 -0400 Received: by mail-it1-f196.google.com with SMTP id w15so2088135itc.0 for ; Tue, 16 Apr 2019 19:42:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qnGx+7684eAFRW7SlWLhhsj9k/GSxSFnEr2CP+sGGGQ=; b=dN0SwqMOuhUzMzZZPCz2HDl6oy6o7Xq+AywL7EZcBAmG/9GwdBJuR9FRLKAesNFxZx sdNQE5vT9ISdraFuu6/n8roQPwx3Qx2NYbf9oIw3bD7v3vwZCkfkcq+m4MHcLRNbsYZd j+M9IXIY+EuUjatzkAI7KyC84EiKkCI9XgM6KfeOMRZS+dUUYgqnG51yVifL8nlT2s8A kmozne3CsW0afUmeXuzrTtid75X/JVmQ+GybgRJ++DBQcK5+VSFGPCztwqTNY4ekiDUU 70f4abp1ZaFiU0Exo9CPCYNfc735m3VptWZwU87GwwINU0DkTjJrvPOpjXXk6+Ygo3P8 A0Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qnGx+7684eAFRW7SlWLhhsj9k/GSxSFnEr2CP+sGGGQ=; b=M5dv6UqekETmyB4B60oyCYAlB+c6/XPFQHJ/wHWpBf64a4sflR7DAQNrJfxgX+as/j mp12cr45fW7r1I5vc5cnSw49H1uDdUcB6t/Vkb2ZD1axOl8hEUFSxmrmEMeu0TR8SWmB Uld9NcpUsQx7/2BNT6UYhIUXblIGHBc80AZXFe9RUqobI9EA9DNyXjjsRKtWtPZmuNAF yDog+nEp13zpNaW37C6phVMn1s4zTDi27uKmb8fBYMX8NkAiYWqy9t1/OzQtKaN2AgDv XxCWO3A5CollnpAvQtK5zuMEY5dRmqcJNI4W7noQXLqxh9vwmG62PnUr97lJ0GEarD0Q PcDA== X-Gm-Message-State: APjAAAUZ0qURkgYI5MDNhg3TFcyrzZs4ZZiThK9s4iug9dQwY+ONPlyK SvRMowcN2UnXH6YJIx5CknHj35oHCgh/N4DZkEY= X-Google-Smtp-Source: APXvYqwCO3z++7DU3EBPgVyxcl8TU2oF0T/3n9FzuELK03VKHRm6fbVg8ouRv2a4Z0h69f4QuWVjodTDWMZbFoz9/ps= X-Received: by 2002:a02:90c6:: with SMTP id c6mr55903739jag.117.1555468943784; Tue, 16 Apr 2019 19:42:23 -0700 (PDT) MIME-Version: 1.0 References: <20190416144353.34024-1-yuehaibing@huawei.com> In-Reply-To: <20190416144353.34024-1-yuehaibing@huawei.com> From: Qiang Yu Date: Wed, 17 Apr 2019 10:42:12 +0800 Message-ID: Subject: Re: [PATCH -next] drm/lima: Make lima_sched_ops static To: Yue Haibing Cc: David Airlie , Daniel Vetter , Linux Kernel Mailing List , lima@lists.freedesktop.org, dri-devel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks, patch is: Reviewed-by: Qiang Yu I'll add a "Fix" tag and push it to drm-misc-next. Regards, Qiang On Tue, Apr 16, 2019 at 10:44 PM Yue Haibing wrote: > > From: YueHaibing > > Fix sparse warning: > > drivers/gpu/drm/lima/lima_sched.c:356:36: warning: > symbol 'lima_sched_ops' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > --- > drivers/gpu/drm/lima/lima_sched.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/lima/lima_sched.c b/drivers/gpu/drm/lima/lima_sched.c > index 97bd9c1..569f0a95 100644 > --- a/drivers/gpu/drm/lima/lima_sched.c > +++ b/drivers/gpu/drm/lima/lima_sched.c > @@ -353,7 +353,7 @@ static void lima_sched_free_job(struct drm_sched_job *job) > kmem_cache_free(pipe->task_slab, task); > } > > -const struct drm_sched_backend_ops lima_sched_ops = { > +static const struct drm_sched_backend_ops lima_sched_ops = { > .dependency = lima_sched_dependency, > .run_job = lima_sched_run_job, > .timedout_job = lima_sched_timedout_job, > -- > 2.7.4 > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Qiang Yu Subject: Re: [PATCH -next] drm/lima: Make lima_sched_ops static Date: Wed, 17 Apr 2019 10:42:12 +0800 Message-ID: References: <20190416144353.34024-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190416144353.34024-1-yuehaibing@huawei.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Yue Haibing Cc: David Airlie , dri-devel , Linux Kernel Mailing List , lima@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org VGhhbmtzLCBwYXRjaCBpczoKUmV2aWV3ZWQtYnk6IFFpYW5nIFl1IDx5dXE4MjVAZ21haWwuY29t PgoKSSdsbCBhZGQgYSAiRml4IiB0YWcgYW5kIHB1c2ggaXQgdG8gZHJtLW1pc2MtbmV4dC4KClJl Z2FyZHMsClFpYW5nCgpPbiBUdWUsIEFwciAxNiwgMjAxOSBhdCAxMDo0NCBQTSBZdWUgSGFpYmlu ZyA8eXVlaGFpYmluZ0BodWF3ZWkuY29tPiB3cm90ZToKPgo+IEZyb206IFl1ZUhhaWJpbmcgPHl1 ZWhhaWJpbmdAaHVhd2VpLmNvbT4KPgo+IEZpeCBzcGFyc2Ugd2FybmluZzoKPgo+IGRyaXZlcnMv Z3B1L2RybS9saW1hL2xpbWFfc2NoZWQuYzozNTY6MzY6IHdhcm5pbmc6Cj4gIHN5bWJvbCAnbGlt YV9zY2hlZF9vcHMnIHdhcyBub3QgZGVjbGFyZWQuIFNob3VsZCBpdCBiZSBzdGF0aWM/Cj4KPiBS ZXBvcnRlZC1ieTogSHVsayBSb2JvdCA8aHVsa2NpQGh1YXdlaS5jb20+Cj4gU2lnbmVkLW9mZi1i eTogWXVlSGFpYmluZyA8eXVlaGFpYmluZ0BodWF3ZWkuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vbGltYS9saW1hX3NjaGVkLmMgfCAyICstCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2Vy dGlvbigrKSwgMSBkZWxldGlvbigtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9s aW1hL2xpbWFfc2NoZWQuYyBiL2RyaXZlcnMvZ3B1L2RybS9saW1hL2xpbWFfc2NoZWQuYwo+IGlu ZGV4IDk3YmQ5YzEuLjU2OWYwYTk1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9saW1h L2xpbWFfc2NoZWQuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9saW1hL2xpbWFfc2NoZWQuYwo+ IEBAIC0zNTMsNyArMzUzLDcgQEAgc3RhdGljIHZvaWQgbGltYV9zY2hlZF9mcmVlX2pvYihzdHJ1 Y3QgZHJtX3NjaGVkX2pvYiAqam9iKQo+ICAgICAgICAga21lbV9jYWNoZV9mcmVlKHBpcGUtPnRh c2tfc2xhYiwgdGFzayk7Cj4gIH0KPgo+IC1jb25zdCBzdHJ1Y3QgZHJtX3NjaGVkX2JhY2tlbmRf b3BzIGxpbWFfc2NoZWRfb3BzID0gewo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9zY2hlZF9i YWNrZW5kX29wcyBsaW1hX3NjaGVkX29wcyA9IHsKPiAgICAgICAgIC5kZXBlbmRlbmN5ID0gbGlt YV9zY2hlZF9kZXBlbmRlbmN5LAo+ICAgICAgICAgLnJ1bl9qb2IgPSBsaW1hX3NjaGVkX3J1bl9q b2IsCj4gICAgICAgICAudGltZWRvdXRfam9iID0gbGltYV9zY2hlZF90aW1lZG91dF9qb2IsCj4g LS0KPiAyLjcuNAo+Cj4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVs