From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bpf-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 68C6BC3A59F
	for <bpf@archiver.kernel.org>; Wed, 23 Nov 2022 19:55:52 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S239529AbiKWTzu (ORCPT <rfc822;bpf@archiver.kernel.org>);
        Wed, 23 Nov 2022 14:55:50 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41688 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S238965AbiKWTzX (ORCPT <rfc822;bpf@vger.kernel.org>);
        Wed, 23 Nov 2022 14:55:23 -0500
Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1201BC4
        for <bpf@vger.kernel.org>; Wed, 23 Nov 2022 11:54:29 -0800 (PST)
Received: by mail-oi1-x235.google.com with SMTP id s206so20172591oie.3
        for <bpf@vger.kernel.org>; Wed, 23 Nov 2022 11:54:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=gSrw9jy1DdzW54uya3GLAzT+2OzZzkDqg6d87pvhaPs=;
        b=SAyowW6EeaGJkplgTyVYsNTgVZAj3MA2J302awudfKDjd5fS8bB3p1TBBDmTvaWmg0
         32OEuu1INff6VrcU9+xzLOtQEs7mbMft4spDWOxBlGx8ap7TbVuPHDRUxaPmRhVLyQMo
         L1+uFh8dK9K4YCABZ1L+GBC3932cxmZ8w1jVgYUR2u0iXOO69FPUdpZL+gV6j8vLzZhV
         ugxFbRuiOo4mBno+r83w1ZgP5cIDQKPhKgJpbGX8NUds2D7x18naTjdiPnU4288Lr7H8
         NYbZFr4ITE0I5AGGPF4oj26+HkbXCcNHTLE1sb5+guYANDen7ZHoDUK3caH0aXFnOaGK
         tbYA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=gSrw9jy1DdzW54uya3GLAzT+2OzZzkDqg6d87pvhaPs=;
        b=nQTYUd0mPaOLLljCkhxTTQFxGY7RoFMIBc/6aoCoZ/0tTASrK+W0krcy55bURU0Veh
         qWapJRXRc7SHKJ+7B/ODnq99zwu2y8Qqkcwy/xQW5mD/PUAu3isFLNRqdfDRK5o4JZol
         pclpiq38ATXvCWIHR2KEmO/PwJs7t7NYPsZY2Nm7Fw4W+8PKtzEMYRsK4T8YNNZ0lE0q
         /0BOdoPEmi7JxtjnYJWzjW+JHThNeBdsQzOgbPU+DxDwHMomVv1D+CWmYh57QTxTikAS
         bRhfaa/9emz3zArlm3OV8e7y8sKxcHVzTJ91Zdxl7V9MyQZ1mhKpLL8cnQNbh0/Fvr0O
         w7cw==
X-Gm-Message-State: ANoB5plXOBiTxPT/q2gArTONxizigwhd7gyJuDoDubBt2fMZIO5l00BH
        BhEVoPo67KvrBe6m2L1Ojhv7UCkw8JXJAEStOpsMnw==
X-Google-Smtp-Source: AA0mqf58BXp5+AhLwQziFGPiG4v1/XH+Cf8sshn7xXTcS5qy+Lwx5aKIXOwJyLY2Av5mDzybwp0vDHSZz4knu12MJt8=
X-Received: by 2002:aca:674c:0:b0:35b:79ca:2990 with SMTP id
 b12-20020aca674c000000b0035b79ca2990mr1938077oiy.125.1669233268889; Wed, 23
 Nov 2022 11:54:28 -0800 (PST)
MIME-Version: 1.0
References: <20221121182552.2152891-1-sdf@google.com> <20221121182552.2152891-9-sdf@google.com>
 <877czlvj9x.fsf@toke.dk> <CAKH8qBsSFg+3ULN-+aqabXZJRVwPtq9P71d0VZCuT2tMrx4DHw@mail.gmail.com>
 <20221123111712.1da24f54@kernel.org>
In-Reply-To: <20221123111712.1da24f54@kernel.org>
From:   Stanislav Fomichev <sdf@google.com>
Date:   Wed, 23 Nov 2022 11:54:18 -0800
Message-ID: <CAKH8qBv-tvmrE-YfrFFO6ivw-8uXCHFhT2g=5UeNuh3-W=CcZg@mail.gmail.com>
Subject: Re: [xdp-hints] [PATCH bpf-next v2 8/8] selftests/bpf: Simple program
 to dump XDP RX metadata
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= <toke@redhat.com>,
        bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
        andrii@kernel.org, martin.lau@linux.dev, song@kernel.org,
        yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org,
        haoluo@google.com, jolsa@kernel.org,
        David Ahern <dsahern@gmail.com>,
        Willem de Bruijn <willemb@google.com>,
        Jesper Dangaard Brouer <brouer@redhat.com>,
        Anatoly Burakov <anatoly.burakov@intel.com>,
        Alexander Lobakin <alexandr.lobakin@intel.com>,
        Magnus Karlsson <magnus.karlsson@gmail.com>,
        Maryam Tahhan <mtahhan@redhat.com>, xdp-hints@xdp-project.net,
        netdev@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <bpf.vger.kernel.org>
X-Mailing-List: bpf@vger.kernel.org

On Wed, Nov 23, 2022 at 11:17 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Wed, 23 Nov 2022 10:29:23 -0800 Stanislav Fomichev wrote:
> > > return ch.rx_count ?: ch.combined_count;
> > >
> > > works though :)
> >
> > Perfect, will do the same :-) Thank you for running and testing!
>
> The correct value is ch.rx_count + ch.combined_count
>
> We've been over this many times, I thought it was coded up in libbpf
> but I don't see it now :S

Yeah, can't find it. Also doesn't exist on libxdp/libxsk. Will apply
your fix, thank you!