Re: [PATCH v2 1/1] Jobs based on custom runners: add CentOS Stream 8

From: Willian Rampazzo <wrampazz@redhat.com>
To: Cleber Rosa <crosa@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>, "Kevin Wolf" <kwolf@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	qemu-block@nongnu.org, "Erik Skultety" <eskultet@redhat.com>,
	"Stefan Hajnoczi" <stefanha@gmail.com>,
	"Beraldo Leal" <bleal@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"John Snow" <jsnow@redhat.com>, "Hanna Reitz" <hreitz@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH v2 1/1] Jobs based on custom runners: add CentOS Stream 8
Date: Fri, 12 Nov 2021 15:35:40 -0300	[thread overview]
Message-ID: <CAKJDGDYihwY+pLrxQ=6j-GtAfc++1bKE8yWVcyqm9WZJyZ1daQ@mail.gmail.com> (raw)
In-Reply-To: <20211111160501.862396-2-crosa@redhat.com>

On Thu, Nov 11, 2021 at 1:06 PM Cleber Rosa <crosa@redhat.com> wrote:
>
> This introduces three different parts of a job designed to run
> on a custom runner managed by Red Hat.  The goals include:
>
>   a) propose a model for other organizations that want to onboard
>      their own runners, with their specific platforms, build
>      configuration and tests.
>
>   b) bring awareness to the differences between upstream QEMU and the
>      version available under CentOS Stream, which is "A preview of
>      upcoming Red Hat Enterprise Linux minor and major releases".
>
>   c) because of b), it should be easier to identify and reduce the gap
>      between Red Hat's downstream and upstream QEMU.
>
> The components of this custom job are:
>
>   I) OS build environment setup code:
>
>      - additions to the existing "build-environment.yml" playbook
>        that can be used to set up CentOS/EL 8 systems.
>
>      - a CentOS Stream 8 specific "build-environment.yml" playbook
>        that adds to the generic one.
>
>  II) QEMU build configuration: a script that will produce binaries with
>      features as similar as possible to the ones built and packaged on
>      CentOS stream 8.
>
> III) Scripts that define the minimum amount of testing that the
>      binaries built with the given configuration (point II) under the
>      given OS build environment (point I) should be subjected to.
>
>  IV) Job definition: GitLab CI jobs that will dispatch the build/test
>      jobs (see points #II and #III) to the machine specifically
>      configured according to #I.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>  .gitlab-ci.d/custom-runners.yml               |  29 +++
>  docs/devel/ci-jobs.rst.inc                    |   7 +
>  .../org.centos/stream/8/build-environment.yml |  51 +++++
>  .../ci/org.centos/stream/8/x86_64/configure   | 208 ++++++++++++++++++
>  .../org.centos/stream/8/x86_64/test-avocado   |  70 ++++++
>  scripts/ci/org.centos/stream/README           |  17 ++
>  scripts/ci/setup/build-environment.yml        |  38 ++++
>  7 files changed, 420 insertions(+)
>  create mode 100644 scripts/ci/org.centos/stream/8/build-environment.yml
>  create mode 100755 scripts/ci/org.centos/stream/8/x86_64/configure
>  create mode 100755 scripts/ci/org.centos/stream/8/x86_64/test-avocado
>  create mode 100644 scripts/ci/org.centos/stream/README
>

Maybe it is too late, but just for the records:

Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Tested-by: Willian Rampazzo <willianr@redhat.com>

CI job on a custom VM runner:
https://gitlab.com/willianrampazzo/qemu/-/jobs/1778451942