* [PATCH v2] docs/devel/testing.rst: Fix references to unit tests
@ 2021-03-18 17:44 Wainer dos Santos Moschetta
2021-03-18 17:50 ` Willian Rampazzo
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Wainer dos Santos Moschetta @ 2021-03-18 17:44 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, pbonzini, thuth, jsnow
With the recent move of the unit tests to tests/unit directory some
instructions under the "Unit tests" section became imprecise, which
are fixed by this change.
Fixes: da668aa15b99 ("tests: Move unit tests into a separate directory")
Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
v1->v2:
* Fixed typo on subject [jsnow]
* Replaced Related-to with Fixes [jsnow]
docs/devel/testing.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index 1434a50cc4..1da4c4e4c4 100644
--- a/docs/devel/testing.rst
+++ b/docs/devel/testing.rst
@@ -34,17 +34,17 @@ If you are writing new code in QEMU, consider adding a unit test, especially
for utility modules that are relatively stateless or have few dependencies. To
add a new unit test:
-1. Create a new source file. For example, ``tests/foo-test.c``.
+1. Create a new source file. For example, ``tests/unit/foo-test.c``.
2. Write the test. Normally you would include the header file which exports
the module API, then verify the interface behaves as expected from your
test. The test code should be organized with the glib testing framework.
Copying and modifying an existing test is usually a good idea.
-3. Add the test to ``tests/meson.build``. The unit tests are listed in a
+3. Add the test to ``tests/unit/meson.build``. The unit tests are listed in a
dictionary called ``tests``. The values are any additional sources and
dependencies to be linked with the test. For a simple test whose source
- is in ``tests/foo-test.c``, it is enough to add an entry like::
+ is in ``tests/unit/foo-test.c``, it is enough to add an entry like::
{
...
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] docs/devel/testing.rst: Fix references to unit tests
2021-03-18 17:44 [PATCH v2] docs/devel/testing.rst: Fix references to unit tests Wainer dos Santos Moschetta
@ 2021-03-18 17:50 ` Willian Rampazzo
2021-03-19 11:16 ` Thomas Huth
2021-03-23 22:49 ` John Snow
2 siblings, 0 replies; 4+ messages in thread
From: Willian Rampazzo @ 2021-03-18 17:50 UTC (permalink / raw)
To: Wainer dos Santos Moschetta
Cc: qemu-trivial, Paolo Bonzini, Thomas Huth, John Snow, qemu-devel
On Thu, Mar 18, 2021 at 2:49 PM Wainer dos Santos Moschetta
<wainersm@redhat.com> wrote:
>
> With the recent move of the unit tests to tests/unit directory some
> instructions under the "Unit tests" section became imprecise, which
> are fixed by this change.
>
> Fixes: da668aa15b99 ("tests: Move unit tests into a separate directory")
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> ---
> v1->v2:
> * Fixed typo on subject [jsnow]
> * Replaced Related-to with Fixes [jsnow]
>
> docs/devel/testing.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] docs/devel/testing.rst: Fix references to unit tests
2021-03-18 17:44 [PATCH v2] docs/devel/testing.rst: Fix references to unit tests Wainer dos Santos Moschetta
2021-03-18 17:50 ` Willian Rampazzo
@ 2021-03-19 11:16 ` Thomas Huth
2021-03-23 22:49 ` John Snow
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2021-03-19 11:16 UTC (permalink / raw)
To: Wainer dos Santos Moschetta, qemu-devel; +Cc: qemu-trivial, pbonzini, jsnow
On 18/03/2021 18.44, Wainer dos Santos Moschetta wrote:
> With the recent move of the unit tests to tests/unit directory some
> instructions under the "Unit tests" section became imprecise, which
> are fixed by this change.
>
> Fixes: da668aa15b99 ("tests: Move unit tests into a separate directory")
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> ---
Thanks, queued to my testing-next branch:
https://gitlab.com/thuth/qemu/-/commits/testing-next
Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] docs/devel/testing.rst: Fix references to unit tests
2021-03-18 17:44 [PATCH v2] docs/devel/testing.rst: Fix references to unit tests Wainer dos Santos Moschetta
2021-03-18 17:50 ` Willian Rampazzo
2021-03-19 11:16 ` Thomas Huth
@ 2021-03-23 22:49 ` John Snow
2 siblings, 0 replies; 4+ messages in thread
From: John Snow @ 2021-03-23 22:49 UTC (permalink / raw)
To: Wainer dos Santos Moschetta, qemu-devel; +Cc: qemu-trivial, pbonzini, thuth
On 3/18/21 1:44 PM, Wainer dos Santos Moschetta wrote:
> With the recent move of the unit tests to tests/unit directory some
> instructions under the "Unit tests" section became imprecise, which
> are fixed by this change.
>
> Fixes: da668aa15b99 ("tests: Move unit tests into a separate directory")
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> v1->v2:
> * Fixed typo on subject [jsnow]
> * Replaced Related-to with Fixes [jsnow]
>
> docs/devel/testing.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
> index 1434a50cc4..1da4c4e4c4 100644
> --- a/docs/devel/testing.rst
> +++ b/docs/devel/testing.rst
> @@ -34,17 +34,17 @@ If you are writing new code in QEMU, consider adding a unit test, especially
> for utility modules that are relatively stateless or have few dependencies. To
> add a new unit test:
>
> -1. Create a new source file. For example, ``tests/foo-test.c``.
> +1. Create a new source file. For example, ``tests/unit/foo-test.c``.
>
> 2. Write the test. Normally you would include the header file which exports
> the module API, then verify the interface behaves as expected from your
> test. The test code should be organized with the glib testing framework.
> Copying and modifying an existing test is usually a good idea.
>
> -3. Add the test to ``tests/meson.build``. The unit tests are listed in a
> +3. Add the test to ``tests/unit/meson.build``. The unit tests are listed in a
> dictionary called ``tests``. The values are any additional sources and
> dependencies to be linked with the test. For a simple test whose source
> - is in ``tests/foo-test.c``, it is enough to add an entry like::
> + is in ``tests/unit/foo-test.c``, it is enough to add an entry like::
>
> {
> ...
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-23 22:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-18 17:44 [PATCH v2] docs/devel/testing.rst: Fix references to unit tests Wainer dos Santos Moschetta
2021-03-18 17:50 ` Willian Rampazzo
2021-03-19 11:16 ` Thomas Huth
2021-03-23 22:49 ` John Snow
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.