From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83191C433EF for ; Wed, 6 Oct 2021 18:42:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5C63610CC for ; Wed, 6 Oct 2021 18:42:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E5C63610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:47094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYBsD-0006Zk-Ng for qemu-devel@archiver.kernel.org; Wed, 06 Oct 2021 14:42:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37142) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYBqH-0005E7-Mn for qemu-devel@nongnu.org; Wed, 06 Oct 2021 14:40:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:32436) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYBqB-0001rr-IJ for qemu-devel@nongnu.org; Wed, 06 Oct 2021 14:40:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633545630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Lstt+Pz4bOZvRVt5dNRZMoquSClJeUeQL4BcHrf2QRs=; b=NQKNXJr1mBjg9Ecc7tO7yzSJdaNUX1HWP19kMyKOIsjEPM1X02QAdM1Et04+KfHTm043ZO Z3QeP8ZVJo9SotsIsDEJ2/BLh7nJPe+PzFoHNdhmtFCpMadMUPjFhtUI2MBWseMNWKbtYe LpqP1AG2t7KAIaL/WEvmdqCsFSWKO00= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-62-mdGaimwqOd6VJOHnJFBFHg-1; Wed, 06 Oct 2021 14:40:27 -0400 X-MC-Unique: mdGaimwqOd6VJOHnJFBFHg-1 Received: by mail-pf1-f199.google.com with SMTP id z22-20020aa79596000000b0044c8c01b7a9so1835869pfj.5 for ; Wed, 06 Oct 2021 11:40:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Lstt+Pz4bOZvRVt5dNRZMoquSClJeUeQL4BcHrf2QRs=; b=3Oiot9GvtLys/8e0tIQ1H1fUdJ4AhSdpZI3MQ3IWPcgzIOOm/tFIQMMLHf+K7pZx05 TVuwGeIZYET0AcL0RtioH+Yjl0SFT8CnVUN+7gydTURf/3XEzcSX4dzIYuTOoQSVR+7J skjX+c2w/09THhwil5D6AvR3iXZEdejvYwO+rv/X0UO4dcx+aH0EHQojbqcdWH5PnFXX b8QHz/ZYBSxOOe54HrJoXXsFUZlrEuFBxNeRCOPile006vRSuMz/z5lNznkayfEM54hF p5jCGRu9FHt4KWGuHcO5HQ1JVt/9T1WQB1oV3KyKnnvnChardcPukvtOo25En5bAfi08 Jv+Q== X-Gm-Message-State: AOAM532O8+nW7IrQUpeZWWKrmExkHmtMCxyul+wzUfxN/4GthESPs/IS 0ciXsm+vcbjwZnW8I4MODWTY+fGqLcPGK7CwUcg0rhgb1sbH8BXHmoyKKrguW4Vb8e+T3amvvpW dnKVvsribSlR9iw0dw9PWpjQKlWTs8FA= X-Received: by 2002:a17:90a:8a18:: with SMTP id w24mr308192pjn.123.1633545625832; Wed, 06 Oct 2021 11:40:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwR65s/LHlMII84R9VplNt9bqEFbRvJDkEtnsdWd0Pu/Jl5BaRAPMxmLlJS66cHWB0kSo9s6F6BUX/PXLSNBuI= X-Received: by 2002:a17:90a:8a18:: with SMTP id w24mr308165pjn.123.1633545625531; Wed, 06 Oct 2021 11:40:25 -0700 (PDT) MIME-Version: 1.0 References: <20210924185506.2542588-1-crosa@redhat.com> <20210924185506.2542588-2-crosa@redhat.com> In-Reply-To: <20210924185506.2542588-2-crosa@redhat.com> From: Willian Rampazzo Date: Wed, 6 Oct 2021 15:39:59 -0300 Message-ID: Subject: Re: [PATCH 01/16] Acceptance Tests: bump Avocado requirement to 91.0 To: Cleber Rosa Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=wrampazz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=170.10.133.124; envelope-from=wrampazz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.05, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, Thomas Huth , Beraldo Leal , Yoshinori Sato , Pavel Dovgalyuk , =?UTF-8?B?QWxleCBCZW5uw6ll?= , qemu-devel , Wainer dos Santos Moschetta , Greg Kurz , Auger Eric , Kamil Rytarowski , =?UTF-8?Q?Herv=C3=A9_Poussineau?= , Reinoud Zandijk , David Gibson , Paolo Bonzini , Alexandre Iooss , Mahmoud Mandour , Ryo ONODERA , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Sep 24, 2021 at 3:57 PM Cleber Rosa wrote: > > Avocado 91.0, brings, among other changes, a switch to a new runner > implementation, known as "nrunner". While my personal testing shows > that it's suitable for running the QEMU tests, there are some > considerations that should be addressed before the change. > > For instance, the "nrunner" implementation will run tests in parallel > by default. With more tests running, and resources shared, some tests > may fail with timeouts on some environments. > > So, for now, let's bump the Avocado version to allow for the other > features to be used. And the "nrunner" implementation to be used by > those that choose to do so. > > More information can be found at the release notes at: > https://avocado-framework.readthedocs.io/en/latest/releases/91_0.html > > Signed-off-by: Cleber Rosa > --- > docs/devel/testing.rst | 12 ++++++++++++ > tests/Makefile.include | 2 ++ > tests/requirements.txt | 2 +- > 3 files changed, 15 insertions(+), 1 deletion(-) > > diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst > index 4a0abbf23d..2818c58ff8 100644 > --- a/docs/devel/testing.rst > +++ b/docs/devel/testing.rst > @@ -740,6 +740,18 @@ may be invoked by running: > > tests/venv/bin/avocado run $OPTION1 $OPTION2 tests/acceptance/ > > +Running tests in parallel > +------------------------- > + > +The current ``make check-acceptance`` target continues to use the > +Avocado runner implementation simply known as "runner". But, it's now > +possible to opt-in and choose the "nrunner" implementation, which, > +among other things, allows for parallel execution of tests: > + > +.. code:: > + > + make AVOCADO_RUNNER=nrunner check-acceptance The examples in the documentation are all setting the environment variable at the end of the `make` command. For consistency, I would move the definition of the AVOCADO_RUNNER to the end of the command. > + > Manual Installation > ------------------- > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 6e16c05f10..ac289a2e41 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -92,6 +92,7 @@ TESTS_RESULTS_DIR=$(BUILD_DIR)/tests/results > # Any number of command separated loggers are accepted. For more > # information please refer to "avocado --help". > AVOCADO_SHOW=app > +AVOCADO_RUNNER=runner > AVOCADO_TAGS=$(patsubst %-softmmu,-t arch:%, $(filter %-softmmu,$(TARGETS))) > > $(TESTS_VENV_DIR): $(TESTS_VENV_REQ) > @@ -128,6 +129,7 @@ check-acceptance: check-venv $(TESTS_RESULTS_DIR) get-vm-images > $(call quiet-command, \ > $(TESTS_VENV_DIR)/bin/python -m avocado \ > --show=$(AVOCADO_SHOW) run --job-results-dir=$(TESTS_RESULTS_DIR) \ > + --test-runner=$(AVOCADO_RUNNER) \ > --filter-by-tags-include-empty --filter-by-tags-include-empty-key \ > $(AVOCADO_TAGS) \ > $(if $(GITLAB_CI),,--failfast) tests/acceptance, \ > diff --git a/tests/requirements.txt b/tests/requirements.txt > index a21b59b443..40af24c664 100644 > --- a/tests/requirements.txt > +++ b/tests/requirements.txt > @@ -1,5 +1,5 @@ > # Add Python module requirements, one per line, to be installed > # in the tests/venv Python virtual environment. For more info, > # refer to: https://pip.pypa.io/en/stable/user_guide/#id1 > -avocado-framework==88.1 > +avocado-framework==91.0 > pycdlib==1.11.0 > -- > 2.31.1 > Apart from a tiny documentation change, the code is welcome as it allows using the new Avocado runner. Reviewed-by: Willian Rampazzo