From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59FA9C433DB for ; Wed, 24 Mar 2021 19:56:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9589161A24 for ; Wed, 24 Mar 2021 19:56:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9589161A24 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35640 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lP9c7-0002TW-Ip for qemu-devel@archiver.kernel.org; Wed, 24 Mar 2021 15:56:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lP9ah-0001uE-EY for qemu-devel@nongnu.org; Wed, 24 Mar 2021 15:54:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:45240) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lP9ae-0008OY-LL for qemu-devel@nongnu.org; Wed, 24 Mar 2021 15:54:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616615690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=syld4BFkeb6z4DHLkQeOb2hYHIlhBrBMOmwmlmvo3P8=; b=YAf/br6RAmM1O9lN5Zd/cxINq2MFmhxew9c70XY5ZJEZqRyHBoDA1QgbxUl/vSJKbkbvXa plvQOmtvS/P37ScBcYNdRcflTjnZJkQ+xjViYt8hmIVZg+JCqu/lTPiR5dBnIgP6cwzkh4 XI7Xsic7IXVKQ9rT43FLI5Gx4O/b9gA= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-530-EIBrdOqmMKuf7GI63hhEww-1; Wed, 24 Mar 2021 15:54:48 -0400 X-MC-Unique: EIBrdOqmMKuf7GI63hhEww-1 Received: by mail-vs1-f70.google.com with SMTP id p2so35431vsq.6 for ; Wed, 24 Mar 2021 12:54:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=syld4BFkeb6z4DHLkQeOb2hYHIlhBrBMOmwmlmvo3P8=; b=ub1SWniNh4KIfRP2DvO8zdKavOPCvY8Y4qlntTJNlz8mlpvS+GVYT9yPODdwN2yuCP o1eIptR+ZAc53iUZ5qvb1uaOeUna+IeXQGSVCeki6YLYJgjG/Gxbz6B07b7ot/z0OdE+ mnq3UOtN4vIUcC9fLfF/4aW6DWCFYrireNqFWCE/wzY2TmBqBHlmh9pCAcfZW3hJyQ82 GauxX/1pV5+9WK4Z4nyk7H+hTG98YIT3Ho2l5iGqOHaeyMy+KXtu4iu80lZ1dRqiUZ+G gI6GJ/J0AhS42/C8oHLL/b1MO+v6gSZhfLBXHd/1DQp8wegviB1VsQws0H4onA27C/Oo ulOQ== X-Gm-Message-State: AOAM531EOXw5cLaAluseWHAbCnnF1MMilmBG/1rkYrgrh9wyr/Eq3dju o3rWOO+fh3U9Id3Z6IDice7hfb0siqmg+ie3kxHygFh3ClOvVtPNPfXmKJXhvuc3o6AyMMyyIde AYj0i1u8XgJ1UdBIQVJi8zorZfXB1GrM= X-Received: by 2002:a67:3241:: with SMTP id y62mr3176378vsy.45.1616615688131; Wed, 24 Mar 2021 12:54:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzatgfNCCsrtdj18vED2mcVc0Ds7ZElGrypj8qYZ+t+lKFdJqHIf1ca0ctFtBgrfZ0ChPXuuU8irgZcN8NDqQM= X-Received: by 2002:a67:3241:: with SMTP id y62mr3176356vsy.45.1616615687761; Wed, 24 Mar 2021 12:54:47 -0700 (PDT) MIME-Version: 1.0 References: <20210323221539.3532660-1-crosa@redhat.com> <20210323221539.3532660-3-crosa@redhat.com> In-Reply-To: <20210323221539.3532660-3-crosa@redhat.com> From: Willian Rampazzo Date: Wed, 24 Mar 2021 16:54:22 -0300 Message-ID: Subject: Re: [PATCH v2 02/10] tests/acceptance/virtiofs_submounts.py: evaluate string not length To: Cleber Rosa Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=wrampazz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=63.128.21.124; envelope-from=wrampazz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Aleksandar Rikalo , Eduardo Habkost , =?UTF-8?B?QWxleCBCZW5uw6ll?= , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Wainer dos Santos Moschetta , qemu-devel , Willian Rampazzo , Eric Auger , John Snow , Thomas Huth , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Max Reitz , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Aurelien Jarno , Beraldo Leal Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Mar 23, 2021 at 7:15 PM Cleber Rosa wrote: > > If the vmlinuz variable is set to anything that evaluates to True, > then the respective arguments should be set. If the variable contains > an empty string, than it will evaluate to False, and the extra > arguments will not be set. > > This keeps the same logic, but improves readability a bit. > > Signed-off-by: Cleber Rosa > Reviewed-by: Beraldo Leal > --- > tests/acceptance/virtiofs_submounts.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Willian Rampazzo