All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willian Rampazzo <wrampazz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH] tests: Fix broken "make check-speed"
Date: Wed, 10 Mar 2021 13:08:37 -0300	[thread overview]
Message-ID: <CAKJDGDbd6sZ0swGju-rCv9Lf-ADU3Tg1zeDxO-nfgpVxoONb-Q@mail.gmail.com> (raw)
In-Reply-To: <7c6e59fd-913f-31ff-ae33-49186f9ddde1@redhat.com>

On Wed, Mar 10, 2021 at 1:04 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 10/03/21 16:49, Willian Rampazzo wrote:
> > On Wed, Mar 10, 2021 at 6:51 AM Thomas Huth <thuth@redhat.com> wrote:
> >>
> >> When running "make check-speed", currently nothing happens. This is
> >> because the redirection to "bench-speed" is not working as expected
> >> (since the bench-speed rule in the generated Makefile.mtest filters
> >> for "bench-speed" and "bench" in the MAKECMDGOALS variable).
> >> Fix it by calling "make bench-speed" instead of using a dependency.
> >>
> >> Signed-off-by: Thomas Huth <thuth@redhat.com>
> >> ---
> >>   tests/Makefile.include | 5 +++--
> >>   1 file changed, 3 insertions(+), 2 deletions(-)
> >>
> >
> > Reviewed-by: Willian Rampazzo <willianr@redhat.com>
> > Tested-by: Willian Rampazzo <willianr@redhat.com>
> >
>
> I don't object to the patch, but if no one has noticed in 6 months
> perhaps the target can go (replaced by "make bench"/"make bench-speed").
>

I was also thinking about it. If the target was not working and no one
complained, maybe remove it is just fine, so, +1 here for
removing/renaming.

> Paolo
>



  reply	other threads:[~2021-03-10 16:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10  9:49 [PATCH] tests: Fix broken "make check-speed" Thomas Huth
2021-03-10 15:49 ` Willian Rampazzo
2021-03-10 16:04   ` Paolo Bonzini
2021-03-10 16:08     ` Willian Rampazzo [this message]
2021-03-10 16:38       ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKJDGDbd6sZ0swGju-rCv9Lf-ADU3Tg1zeDxO-nfgpVxoONb-Q@mail.gmail.com \
    --to=wrampazz@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.