From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33E2FC636CA for ; Wed, 21 Jul 2021 09:12:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAB5461175 for ; Wed, 21 Jul 2021 09:12:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EAB5461175 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0ACBA6E851; Wed, 21 Jul 2021 09:12:33 +0000 (UTC) Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 64A3F6E851 for ; Wed, 21 Jul 2021 09:12:31 +0000 (UTC) Received: by mail-oi1-x22c.google.com with SMTP id t6so2250348oic.0 for ; Wed, 21 Jul 2021 02:12:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Yk0pURgu+qIZuk7Nbm3QZWwdVQxw26haEZdX4DxRtQo=; b=KshUNjkVZkOw/Hb1O9itdD1JHY0uOQQhG/8EPRsl597CR91dAvieYPXjTjnlzX1DPi V2MMs8InEPukBGQmtW+Ri38bq7HGDyoTTL3HCRwS5ulFxx4H0vEaTA/J4qTNHCODViAd txZNqfywHTNYytUDwYb/vmrJqqLGAsoKHsBa0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Yk0pURgu+qIZuk7Nbm3QZWwdVQxw26haEZdX4DxRtQo=; b=MhP775l60XEEIRYztqiq4r7pDpaLqru7aoY/DF4DPPYk8p0R51B9BhkeH+2LbAtHJd Cyre/a4rrsRsb0SoED14/qXBByTdi+UJ5MC0nWtyUZNu+pEZv8QqkERRyzmnKbjPxnmr 7welPZsPaDl3MrnKp2jFl0taGhYGPbrCy/BvlARBjpinGOO/xXrGvfZBHSKQYy0A9GjN ifrJGya6g9YkFX3D/QO0nW2QShVcSYEDWvQutQRvcmSEV6ZL6A+v670T1xSFt1CBxTpT L1El8XIj/fmPtlEJ8PmmFWrOqskXKSRb9CMf4Xrr2asrnIVDCfIgedhpuRdY3r+BS/1i LZFA== X-Gm-Message-State: AOAM530S6Dl0ourYQJsxJQi8EzzwhCivafRAM+ZZkHmg2hOnGAIVO9Lr QzOBj5ud+KO8JaCbAxQ59Q6lFEwKLYhMdIsarkCB9Ra50Z7zpw== X-Google-Smtp-Source: ABdhPJxyC2cVRm/X6VHhXUIc3dYl04Y6cXhr68BzX7L1h9a4CNz6rxR+pQuNsty36yHvKNZ6KwiWFmOrMnolRR48Qc4= X-Received: by 2002:aca:b902:: with SMTP id j2mr24571899oif.128.1626858750655; Wed, 21 Jul 2021 02:12:30 -0700 (PDT) MIME-Version: 1.0 References: <20210720181357.2760720-1-jason@jlekstrand.net> <20210720181357.2760720-5-jason@jlekstrand.net> <8c6a14f1-5b42-bca2-ee59-7274667e794c@amd.com> In-Reply-To: From: Daniel Vetter Date: Wed, 21 Jul 2021 11:12:19 +0200 Message-ID: Subject: Re: [Intel-gfx] [PATCH 4/6] drm/ttm: Force re-init if ttm_global_init() fails To: =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx , dri-devel , Jason Ekstrand Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Jul 21, 2021 at 11:08 AM Christian K=C3=B6nig wrote: > Am 21.07.21 um 11:06 schrieb Daniel Vetter: > > On Wed, Jul 21, 2021 at 8:36 AM Christian K=C3=B6nig > > wrote: > >> Am 20.07.21 um 20:13 schrieb Jason Ekstrand: > >>> If we have a failure, decrement the reference count so that the next > >>> call to ttm_global_init() will actually do something instead of assum= e > >>> everything is all set up. > >>> > >>> Signed-off-by: Jason Ekstrand > >>> Fixes: 62b53b37e4b1 ("drm/ttm: use a static ttm_bo_global instance") > >>> Reviewed-by: Christian K=C3=B6nig > >> I've just pushed this to drm-misc-fixes. > > Did you see patch 5/6 here which is also touching ttm? > > Nope, neither with my AMD nor with my GMail account. > > Looks like something is wrong with the distribution of mails over the > mailing list for a few days now. Ping admins on #freedesktop on oftc, they can usually chase where mails are stuck. It works all fine for me, but I've seen you complain that you didn't get all the msm patches too, so figured better I highlight in case it's lost. > Going to double check patchwork. https://lore.kernel.org/dri-devel/20210720181357.2760720-6-jason@jlekstrand= .net/ Cheers, Daniel > > Christian. > > > -Daniel > > > >> Thanks, > >> Christian. > >> > >>> --- > >>> drivers/gpu/drm/ttm/ttm_device.c | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>> diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/t= tm_device.c > >>> index 5f31acec3ad76..519deea8e39b7 100644 > >>> --- a/drivers/gpu/drm/ttm/ttm_device.c > >>> +++ b/drivers/gpu/drm/ttm/ttm_device.c > >>> @@ -100,6 +100,8 @@ static int ttm_global_init(void) > >>> debugfs_create_atomic_t("buffer_objects", 0444, ttm_debugfs_ro= ot, > >>> &glob->bo_count); > >>> out: > >>> + if (ret) > >>> + --ttm_glob_use_count; > >>> mutex_unlock(&ttm_global_mutex); > >>> return ret; > >>> } > >> _______________________________________________ > >> Intel-gfx mailing list > >> Intel-gfx@lists.freedesktop.org > >> https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fli= sts.freedesktop.org%2Fmailman%2Flistinfo%2Fintel-gfx&data=3D04%7C01%7Cc= hristian.koenig%40amd.com%7C05ff233273a54b987b6b08d94c26d0ac%7C3dd8961fe488= 4e608e11a82d994e183d%7C0%7C0%7C637624551867495341%7CUnknown%7CTWFpbGZsb3d8e= yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&am= p;sdata=3D70RYQ49Q58VED5jMpJ%2FW9Vy5imUndghFS0tQWIeD7dk%3D&reserved=3D0 > > > > > --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88328C12002 for ; Wed, 21 Jul 2021 09:12:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4ED6B61175 for ; Wed, 21 Jul 2021 09:12:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4ED6B61175 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E18216E84E; Wed, 21 Jul 2021 09:12:32 +0000 (UTC) Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5F1126E84E for ; Wed, 21 Jul 2021 09:12:31 +0000 (UTC) Received: by mail-oi1-x22c.google.com with SMTP id y66so2174556oie.7 for ; Wed, 21 Jul 2021 02:12:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Yk0pURgu+qIZuk7Nbm3QZWwdVQxw26haEZdX4DxRtQo=; b=KshUNjkVZkOw/Hb1O9itdD1JHY0uOQQhG/8EPRsl597CR91dAvieYPXjTjnlzX1DPi V2MMs8InEPukBGQmtW+Ri38bq7HGDyoTTL3HCRwS5ulFxx4H0vEaTA/J4qTNHCODViAd txZNqfywHTNYytUDwYb/vmrJqqLGAsoKHsBa0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Yk0pURgu+qIZuk7Nbm3QZWwdVQxw26haEZdX4DxRtQo=; b=c4GAhbJYHocFgkImQaxM9SU0xvIE+aO4DP+voyHZ5k4MfbKK5iSMatFd4S0wLp2cL4 Hsr2Da+LA4g462j7qmRbA/IybKjX6idcXB9dpffVobi4P6iSfxlGw2O00jy9FyOSb/th gATSJB2arKDXKpml9LzaUm2/WiA4Dz3SG6OyucSaVkaGrsH7zf/OdvE606RpJT1UReaA r9QK2miGQSV84vb6hGtxWYJD4Vks1eG8sOV/Nvq3qkI5Pi0rca3Bnju097CPBeJoRKV9 7hEhJ8NglFPqQYoHT0b7YERKZT/oVx/YMAxJioGsM137QGX+f6vEJJMLhR+4N16Svyjs iKkQ== X-Gm-Message-State: AOAM532OyyQjnn3EaBS2irXWhrtBQIOtgbx8Yxa6Q/LbQvEtQCosSXnw hNKlpBnDHF38HbLZdmXRJgdH6RaQXBdGXRII/Q9nbQ== X-Google-Smtp-Source: ABdhPJxyC2cVRm/X6VHhXUIc3dYl04Y6cXhr68BzX7L1h9a4CNz6rxR+pQuNsty36yHvKNZ6KwiWFmOrMnolRR48Qc4= X-Received: by 2002:aca:b902:: with SMTP id j2mr24571899oif.128.1626858750655; Wed, 21 Jul 2021 02:12:30 -0700 (PDT) MIME-Version: 1.0 References: <20210720181357.2760720-1-jason@jlekstrand.net> <20210720181357.2760720-5-jason@jlekstrand.net> <8c6a14f1-5b42-bca2-ee59-7274667e794c@amd.com> In-Reply-To: From: Daniel Vetter Date: Wed, 21 Jul 2021 11:12:19 +0200 Message-ID: To: =?UTF-8?Q?Christian_K=C3=B6nig?= Subject: Re: [Intel-gfx] [PATCH 4/6] drm/ttm: Force re-init if ttm_global_init() fails X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx , dri-devel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gV2VkLCBKdWwgMjEsIDIwMjEgYXQgMTE6MDggQU0gQ2hyaXN0aWFuIEvDtm5pZwo8Y2hyaXN0 aWFuLmtvZW5pZ0BhbWQuY29tPiB3cm90ZToKPiBBbSAyMS4wNy4yMSB1bSAxMTowNiBzY2hyaWVi IERhbmllbCBWZXR0ZXI6Cj4gPiBPbiBXZWQsIEp1bCAyMSwgMjAyMSBhdCA4OjM2IEFNIENocmlz dGlhbiBLw7ZuaWcKPiA+IDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+IHdyb3RlOgo+ID4+IEFt IDIwLjA3LjIxIHVtIDIwOjEzIHNjaHJpZWIgSmFzb24gRWtzdHJhbmQ6Cj4gPj4+IElmIHdlIGhh dmUgYSBmYWlsdXJlLCBkZWNyZW1lbnQgdGhlIHJlZmVyZW5jZSBjb3VudCBzbyB0aGF0IHRoZSBu ZXh0Cj4gPj4+IGNhbGwgdG8gdHRtX2dsb2JhbF9pbml0KCkgd2lsbCBhY3R1YWxseSBkbyBzb21l dGhpbmcgaW5zdGVhZCBvZiBhc3N1bWUKPiA+Pj4gZXZlcnl0aGluZyBpcyBhbGwgc2V0IHVwLgo+ ID4+Pgo+ID4+PiBTaWduZWQtb2ZmLWJ5OiBKYXNvbiBFa3N0cmFuZCA8amFzb25Aamxla3N0cmFu ZC5uZXQ+Cj4gPj4+IEZpeGVzOiA2MmI1M2IzN2U0YjEgKCJkcm0vdHRtOiB1c2UgYSBzdGF0aWMg dHRtX2JvX2dsb2JhbCBpbnN0YW5jZSIpCj4gPj4+IFJldmlld2VkLWJ5OiBDaHJpc3RpYW4gS8O2 bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4gPj4gSSd2ZSBqdXN0IHB1c2hlZCB0aGlz IHRvIGRybS1taXNjLWZpeGVzLgo+ID4gRGlkIHlvdSBzZWUgcGF0Y2ggNS82IGhlcmUgd2hpY2gg aXMgYWxzbyB0b3VjaGluZyB0dG0/Cj4KPiBOb3BlLCBuZWl0aGVyIHdpdGggbXkgQU1EIG5vciB3 aXRoIG15IEdNYWlsIGFjY291bnQuCj4KPiBMb29rcyBsaWtlIHNvbWV0aGluZyBpcyB3cm9uZyB3 aXRoIHRoZSBkaXN0cmlidXRpb24gb2YgbWFpbHMgb3ZlciB0aGUKPiBtYWlsaW5nIGxpc3QgZm9y IGEgZmV3IGRheXMgbm93LgoKUGluZyBhZG1pbnMgb24gI2ZyZWVkZXNrdG9wIG9uIG9mdGMsIHRo ZXkgY2FuIHVzdWFsbHkgY2hhc2Ugd2hlcmUKbWFpbHMgYXJlIHN0dWNrLiBJdCB3b3JrcyBhbGwg ZmluZSBmb3IgbWUsIGJ1dCBJJ3ZlIHNlZW4geW91IGNvbXBsYWluCnRoYXQgeW91IGRpZG4ndCBn ZXQgYWxsIHRoZSBtc20gcGF0Y2hlcyB0b28sIHNvIGZpZ3VyZWQgYmV0dGVyIEkKaGlnaGxpZ2h0 IGluIGNhc2UgaXQncyBsb3N0LgoKPiBHb2luZyB0byBkb3VibGUgY2hlY2sgcGF0Y2h3b3JrLgoK aHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvZHJpLWRldmVsLzIwMjEwNzIwMTgxMzU3LjI3NjA3MjAt Ni1qYXNvbkBqbGVrc3RyYW5kLm5ldC8KCkNoZWVycywgRGFuaWVsCgo+Cj4gQ2hyaXN0aWFuLgo+ Cj4gPiAtRGFuaWVsCj4gPgo+ID4+IFRoYW5rcywKPiA+PiBDaHJpc3RpYW4uCj4gPj4KPiA+Pj4g LS0tCj4gPj4+ICAgIGRyaXZlcnMvZ3B1L2RybS90dG0vdHRtX2RldmljZS5jIHwgMiArKwo+ID4+ PiAgICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspCj4gPj4+Cj4gPj4+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vdHRtL3R0bV9kZXZpY2UuYyBiL2RyaXZlcnMvZ3B1L2RybS90 dG0vdHRtX2RldmljZS5jCj4gPj4+IGluZGV4IDVmMzFhY2VjM2FkNzYuLjUxOWRlZWE4ZTM5Yjcg MTAwNjQ0Cj4gPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS90dG0vdHRtX2RldmljZS5jCj4gPj4+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS90dG0vdHRtX2RldmljZS5jCj4gPj4+IEBAIC0xMDAsNiAr MTAwLDggQEAgc3RhdGljIGludCB0dG1fZ2xvYmFsX2luaXQodm9pZCkKPiA+Pj4gICAgICAgIGRl YnVnZnNfY3JlYXRlX2F0b21pY190KCJidWZmZXJfb2JqZWN0cyIsIDA0NDQsIHR0bV9kZWJ1Z2Zz X3Jvb3QsCj4gPj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmZ2xvYi0+Ym9fY291 bnQpOwo+ID4+PiAgICBvdXQ6Cj4gPj4+ICsgICAgIGlmIChyZXQpCj4gPj4+ICsgICAgICAgICAg ICAgLS10dG1fZ2xvYl91c2VfY291bnQ7Cj4gPj4+ICAgICAgICBtdXRleF91bmxvY2soJnR0bV9n bG9iYWxfbXV0ZXgpOwo+ID4+PiAgICAgICAgcmV0dXJuIHJldDsKPiA+Pj4gICAgfQo+ID4+IF9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPj4gSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdAo+ID4+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+ PiBodHRwczovL25hbTExLnNhZmVsaW5rcy5wcm90ZWN0aW9uLm91dGxvb2suY29tLz91cmw9aHR0 cHMlM0ElMkYlMkZsaXN0cy5mcmVlZGVza3RvcC5vcmclMkZtYWlsbWFuJTJGbGlzdGluZm8lMkZp bnRlbC1nZngmYW1wO2RhdGE9MDQlN0MwMSU3Q2NocmlzdGlhbi5rb2VuaWclNDBhbWQuY29tJTdD MDVmZjIzMzI3M2E1NGI5ODdiNmIwOGQ5NGMyNmQwYWMlN0MzZGQ4OTYxZmU0ODg0ZTYwOGUxMWE4 MmQ5OTRlMTgzZCU3QzAlN0MwJTdDNjM3NjI0NTUxODY3NDk1MzQxJTdDVW5rbm93biU3Q1RXRnBi R1pzYjNkOGV5SldJam9pTUM0d0xqQXdNREFpTENKUUlqb2lWMmx1TXpJaUxDSkJUaUk2SWsxaGFX d2lMQ0pYVkNJNk1uMCUzRCU3QzEwMDAmYW1wO3NkYXRhPTcwUllRNDlRNThWRUQ1ak1wSiUyRlc5 Vnk1aW1VbmRnaEZTMHRRV0llRDdkayUzRCZhbXA7cmVzZXJ2ZWQ9MAo+ID4KPiA+Cj4KCgotLSAK RGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDov L2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==