From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Dave Airlie <airlied@redhat.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/omap: Use {} to zero initialize the mode
Date: Fri, 24 Jul 2020 22:10:03 +0200 [thread overview]
Message-ID: <CAKMK7uE2C_ySwjdqh_92hC4YamoyRUR=dFvH0yZ9u3a=0c=N=w@mail.gmail.com> (raw)
In-Reply-To: <20200724200410.GH6112@intel.com>
On Fri, Jul 24, 2020 at 10:04 PM Ville Syrjälä
<ville.syrjala@linux.intel.com> wrote:
>
> On Fri, Jul 24, 2020 at 09:43:45PM +0200, Daniel Vetter wrote:
> > On Fri, Jul 24, 2020 at 9:07 PM Ville Syrjala
> > <ville.syrjala@linux.intel.com> wrote:
> > >
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > The first member of drm_display_mode is no longer a structure, but
> > > the code is still using {{0}} to zero initialize it. Make that just
> > > {} so it works regardless of what lies inside.
> > >
> > > Cc: Dave Airlie <airlied@redhat.com>
> > > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > > Fixes: 42acb06b01b1 ("drm: pahole struct drm_display_mode")
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch.ch>
> >
> > This needs to go into drm-misc-next-fixes, looks like Maarten has
> > already forward it so you can push it there.
>
> Thanks for the review. Pushed.
>
> -> vacation
Enjoy!
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-07-24 20:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 19:07 [PATCH] drm/omap: Use {} to zero initialize the mode Ville Syrjala
2020-07-24 19:43 ` Daniel Vetter
2020-07-24 20:04 ` Ville Syrjälä
2020-07-24 20:10 ` Daniel Vetter [this message]
2020-07-24 21:06 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKMK7uE2C_ySwjdqh_92hC4YamoyRUR=dFvH0yZ9u3a=0c=N=w@mail.gmail.com' \
--to=daniel@ffwll.ch \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=tomi.valkeinen@ti.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.