From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Wed, 12 Jul 2017 15:07:42 +0000 Subject: Re: [PATCH] fbdev: Nuke FBINFO_MODULE Message-Id: List-Id: References: <20170706125735.28299-3-daniel.vetter@ffwll.ch> <1903695.PIoOfWhuj9@amdc3058> <20170712124214.t2i2ldlrwc5gf5aw@phenom.ffwll.local> <1734271.ijK3T0ECI9@amdc3058> In-Reply-To: <1734271.ijK3T0ECI9@amdc3058> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bartlomiej Zolnierkiewicz Cc: Daniel Vetter , Intel Graphics Development , Linux Fbdev development list , DRI Development On Wed, Jul 12, 2017 at 2:54 PM, Bartlomiej Zolnierkiewicz wrote: > On Wednesday, July 12, 2017 02:42:14 PM Daniel Vetter wrote: >> On Wed, Jul 12, 2017 at 12:41:34PM +0200, Bartlomiej Zolnierkiewicz wrote: >> > On Tuesday, July 11, 2017 04:52:19 PM Daniel Vetter wrote: >> > > Instead check info->ops->owner, which amounts to the same. >> > > >> > > Spotted because I want to remove the pile of broken and cargo-culted >> > > fb_info->flags assignments in drm drivers. >> > > >> > > v2: Fixup matrox (reported by kbuild). Also nuke FBINFO_FLAG_* defines >> > > that I've failed to spot. >> > > >> > > v3: Don't nuke FBINFO_FLAG_DEFAULT, that's used all over the place. >> > > >> > > Cc: Bartlomiej Zolnierkiewicz >> > > Cc: linux-fbdev@vger.kernel.org >> > > Signed-off-by: Daniel Vetter >> > >> > Acked-by: Bartlomiej Zolnierkiewicz >> >> Do you plan to pick these two patches up yourself, or do you expect me to >> merge them? > > Since the original patchset contained DRM changes (two last patches) > depending on fbdev changes (two first patches, the patch being discussed > was the second one) I assumed that you would like to take them all > through DRM tree. If this is not what is preferred, please tell me. There's no direct depency between 1&2 and 3&4, the only effect of merging them through separate trees is that the bootup logo might not show up when it's expected, until the trees are merged together. We could merge them through separate trees if you prefer that (I forgot to mention that in the cover letter), but I'm fine with putting them all into drm-misc with your ack for 4.14. Whatever you prefer, I don't mind either way. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] fbdev: Nuke FBINFO_MODULE Date: Wed, 12 Jul 2017 17:07:42 +0200 Message-ID: References: <20170706125735.28299-3-daniel.vetter@ffwll.ch> <1903695.PIoOfWhuj9@amdc3058> <20170712124214.t2i2ldlrwc5gf5aw@phenom.ffwll.local> <1734271.ijK3T0ECI9@amdc3058> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C233894D4 for ; Wed, 12 Jul 2017 15:07:44 +0000 (UTC) Received: by mail-it0-x242.google.com with SMTP id o202so2390830itc.1 for ; Wed, 12 Jul 2017 08:07:44 -0700 (PDT) In-Reply-To: <1734271.ijK3T0ECI9@amdc3058> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Bartlomiej Zolnierkiewicz Cc: Daniel Vetter , Intel Graphics Development , Linux Fbdev development list , DRI Development List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBKdWwgMTIsIDIwMTcgYXQgMjo1NCBQTSwgQmFydGxvbWllaiBab2xuaWVya2lld2lj ego8Yi56b2xuaWVya2llQHNhbXN1bmcuY29tPiB3cm90ZToKPiBPbiBXZWRuZXNkYXksIEp1bHkg MTIsIDIwMTcgMDI6NDI6MTQgUE0gRGFuaWVsIFZldHRlciB3cm90ZToKPj4gT24gV2VkLCBKdWwg MTIsIDIwMTcgYXQgMTI6NDE6MzRQTSArMDIwMCwgQmFydGxvbWllaiBab2xuaWVya2lld2ljeiB3 cm90ZToKPj4gPiBPbiBUdWVzZGF5LCBKdWx5IDExLCAyMDE3IDA0OjUyOjE5IFBNIERhbmllbCBW ZXR0ZXIgd3JvdGU6Cj4+ID4gPiBJbnN0ZWFkIGNoZWNrIGluZm8tPm9wcy0+b3duZXIsIHdoaWNo IGFtb3VudHMgdG8gdGhlIHNhbWUuCj4+ID4gPgo+PiA+ID4gU3BvdHRlZCBiZWNhdXNlIEkgd2Fu dCB0byByZW1vdmUgdGhlIHBpbGUgb2YgYnJva2VuIGFuZCBjYXJnby1jdWx0ZWQKPj4gPiA+IGZi X2luZm8tPmZsYWdzIGFzc2lnbm1lbnRzIGluIGRybSBkcml2ZXJzLgo+PiA+ID4KPj4gPiA+IHYy OiBGaXh1cCBtYXRyb3ggKHJlcG9ydGVkIGJ5IGtidWlsZCkuIEFsc28gbnVrZSBGQklORk9fRkxB R18qIGRlZmluZXMKPj4gPiA+IHRoYXQgSSd2ZSBmYWlsZWQgdG8gc3BvdC4KPj4gPiA+Cj4+ID4g PiB2MzogRG9uJ3QgbnVrZSBGQklORk9fRkxBR19ERUZBVUxULCB0aGF0J3MgdXNlZCBhbGwgb3Zl ciB0aGUgcGxhY2UuCj4+ID4gPgo+PiA+ID4gQ2M6IEJhcnRsb21pZWogWm9sbmllcmtpZXdpY3og PGIuem9sbmllcmtpZUBzYW1zdW5nLmNvbT4KPj4gPiA+IENjOiBsaW51eC1mYmRldkB2Z2VyLmtl cm5lbC5vcmcKPj4gPiA+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0 ZXJAaW50ZWwuY29tPgo+PiA+Cj4+ID4gQWNrZWQtYnk6IEJhcnRsb21pZWogWm9sbmllcmtpZXdp Y3ogPGIuem9sbmllcmtpZUBzYW1zdW5nLmNvbT4KPj4KPj4gRG8geW91IHBsYW4gdG8gcGljayB0 aGVzZSB0d28gcGF0Y2hlcyB1cCB5b3Vyc2VsZiwgb3IgZG8geW91IGV4cGVjdCBtZSB0bwo+PiBt ZXJnZSB0aGVtPwo+Cj4gU2luY2UgdGhlIG9yaWdpbmFsIHBhdGNoc2V0IGNvbnRhaW5lZCBEUk0g Y2hhbmdlcyAodHdvIGxhc3QgcGF0Y2hlcykKPiBkZXBlbmRpbmcgb24gZmJkZXYgY2hhbmdlcyAo dHdvIGZpcnN0IHBhdGNoZXMsIHRoZSBwYXRjaCBiZWluZyBkaXNjdXNzZWQKPiB3YXMgdGhlIHNl Y29uZCBvbmUpIEkgYXNzdW1lZCB0aGF0IHlvdSB3b3VsZCBsaWtlIHRvIHRha2UgdGhlbSBhbGwK PiB0aHJvdWdoIERSTSB0cmVlLiBJZiB0aGlzIGlzIG5vdCB3aGF0IGlzIHByZWZlcnJlZCwgcGxl YXNlIHRlbGwgbWUuCgpUaGVyZSdzIG5vIGRpcmVjdCBkZXBlbmN5IGJldHdlZW4gMSYyIGFuZCAz JjQsIHRoZSBvbmx5IGVmZmVjdCBvZgptZXJnaW5nIHRoZW0gdGhyb3VnaCBzZXBhcmF0ZSB0cmVl cyBpcyB0aGF0IHRoZSBib290dXAgbG9nbyBtaWdodCBub3QKc2hvdyB1cCB3aGVuIGl0J3MgZXhw ZWN0ZWQsIHVudGlsIHRoZSB0cmVlcyBhcmUgbWVyZ2VkIHRvZ2V0aGVyLiBXZQpjb3VsZCBtZXJn ZSB0aGVtIHRocm91Z2ggc2VwYXJhdGUgdHJlZXMgaWYgeW91IHByZWZlciB0aGF0IChJIGZvcmdv dAp0byBtZW50aW9uIHRoYXQgaW4gdGhlIGNvdmVyIGxldHRlciksIGJ1dCBJJ20gZmluZSB3aXRo IHB1dHRpbmcgdGhlbQphbGwgaW50byBkcm0tbWlzYyB3aXRoIHlvdXIgYWNrIGZvciA0LjE0LgoK V2hhdGV2ZXIgeW91IHByZWZlciwgSSBkb24ndCBtaW5kIGVpdGhlciB3YXkuCi1EYW5pZWwKLS0g CkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCis0MSAo MCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==