From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 35/58] drm/i915: introduce struct intel_set_config Date: Wed, 5 Sep 2012 21:27:13 +0200 Message-ID: References: <1345403595-9678-1-git-send-email-daniel.vetter@ffwll.ch> <1345403595-9678-36-git-send-email-daniel.vetter@ffwll.ch> <20120905093441.5fcef992@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ob0-f177.google.com (mail-ob0-f177.google.com [209.85.214.177]) by gabe.freedesktop.org (Postfix) with ESMTP id D240BA0A31 for ; Wed, 5 Sep 2012 12:27:13 -0700 (PDT) Received: by obbta17 with SMTP id ta17so972573obb.36 for ; Wed, 05 Sep 2012 12:27:13 -0700 (PDT) In-Reply-To: <20120905093441.5fcef992@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Wed, Sep 5, 2012 at 6:34 PM, Jesse Barnes wrote: > if (!config) > return; > ? > > My eyes always hurt a little when I see if blocks that take up the > whole function. :) Just a nit pick though. Yeah, looks better. Bikeshed applied locally since it resulted in some conflicts later on. -Daniel -- Daniel Vetter daniel.vetter@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch