From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932767AbcFORNT (ORCPT ); Wed, 15 Jun 2016 13:13:19 -0400 Received: from mail-ob0-f193.google.com ([209.85.214.193]:33583 "EHLO mail-ob0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932121AbcFORNR (ORCPT ); Wed, 15 Jun 2016 13:13:17 -0400 MIME-Version: 1.0 X-Originating-IP: [2a02:168:56b5:0:ac27:b86c:7764:9429] In-Reply-To: <20160615161758.GF9711@e106497-lin.cambridge.arm.com> References: <1466002295-24813-1-git-send-email-Liviu.Dudau@arm.com> <1466002295-24813-3-git-send-email-Liviu.Dudau@arm.com> <20160615152309.GI1338@phenom.ffwll.local> <20160615161758.GF9711@e106497-lin.cambridge.arm.com> From: Daniel Vetter Date: Wed, 15 Jun 2016 19:13:15 +0200 X-Google-Sender-Auth: yCMJ_uSCnZ9YWpeqCRoEiHKjAqg Message-ID: Subject: Re: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors To: Liviu Dudau Cc: David Airlie , Rob Herring , Brian Starkey , Emil Velikov , devicetree , DRI devel , LKML , David Brown , LAKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 15, 2016 at 6:17 PM, Liviu Dudau wrote: > On Wed, Jun 15, 2016 at 05:23:10PM +0200, Daniel Vetter wrote: >> On Wed, Jun 15, 2016 at 03:51:34PM +0100, Liviu Dudau wrote: >> > Add support for the new family of Display Processors from ARM Ltd. >> > This commit adds basic support for Mali DP500, DP550 and DP650 >> > parts, with only the display engine being supported at the moment. >> > >> > Cc: David Brown >> > Cc: Brian Starkey >> > >> > Signed-off-by: Liviu Dudau >> >> Small thing I noticed: drm_dev_register/connector_register_all should be >> the last step in your init code, and unregister the first. Atm it's >> somewhere in the middle. But perfectly fine to do that as a follow-up. > > I've tried that, but the connector and encoder that gets registered as part > of the component_bind_all() fails if there is no drm dev registered. You did > comment on the v4 version about that and I did test your idea, sorry for > forgeting to update you on that. Why does it fail? That shouldn't happen ... we need to be able to set up everything first, before we register. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors Date: Wed, 15 Jun 2016 19:13:15 +0200 Message-ID: References: <1466002295-24813-1-git-send-email-Liviu.Dudau@arm.com> <1466002295-24813-3-git-send-email-Liviu.Dudau@arm.com> <20160615152309.GI1338@phenom.ffwll.local> <20160615161758.GF9711@e106497-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160615161758.GF9711@e106497-lin.cambridge.arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Liviu Dudau Cc: devicetree , Emil Velikov , LKML , DRI devel , Rob Herring , LAKML List-Id: devicetree@vger.kernel.org T24gV2VkLCBKdW4gMTUsIDIwMTYgYXQgNjoxNyBQTSwgTGl2aXUgRHVkYXUgPExpdml1LkR1ZGF1 QGFybS5jb20+IHdyb3RlOgo+IE9uIFdlZCwgSnVuIDE1LCAyMDE2IGF0IDA1OjIzOjEwUE0gKzAy MDAsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4+IE9uIFdlZCwgSnVuIDE1LCAyMDE2IGF0IDAzOjUx OjM0UE0gKzAxMDAsIExpdml1IER1ZGF1IHdyb3RlOgo+PiA+IEFkZCBzdXBwb3J0IGZvciB0aGUg bmV3IGZhbWlseSBvZiBEaXNwbGF5IFByb2Nlc3NvcnMgZnJvbSBBUk0gTHRkLgo+PiA+IFRoaXMg Y29tbWl0IGFkZHMgYmFzaWMgc3VwcG9ydCBmb3IgTWFsaSBEUDUwMCwgRFA1NTAgYW5kIERQNjUw Cj4+ID4gcGFydHMsIHdpdGggb25seSB0aGUgZGlzcGxheSBlbmdpbmUgYmVpbmcgc3VwcG9ydGVk IGF0IHRoZSBtb21lbnQuCj4+ID4KPj4gPiBDYzogRGF2aWQgQnJvd24gPERhdmlkLkJyb3duQGFy bS5jb20+Cj4+ID4gQ2M6IEJyaWFuIFN0YXJrZXkgPEJyaWFuLlN0YXJrZXlAYXJtLmNvbT4KPj4g Pgo+PiA+IFNpZ25lZC1vZmYtYnk6IExpdml1IER1ZGF1IDxMaXZpdS5EdWRhdUBhcm0uY29tPgo+ Pgo+PiBTbWFsbCB0aGluZyBJIG5vdGljZWQ6IGRybV9kZXZfcmVnaXN0ZXIvY29ubmVjdG9yX3Jl Z2lzdGVyX2FsbCBzaG91bGQgYmUKPj4gdGhlIGxhc3Qgc3RlcCBpbiB5b3VyIGluaXQgY29kZSwg YW5kIHVucmVnaXN0ZXIgdGhlIGZpcnN0LiBBdG0gaXQncwo+PiBzb21ld2hlcmUgaW4gdGhlIG1p ZGRsZS4gQnV0IHBlcmZlY3RseSBmaW5lIHRvIGRvIHRoYXQgYXMgYSBmb2xsb3ctdXAuCj4KPiBJ J3ZlIHRyaWVkIHRoYXQsIGJ1dCB0aGUgY29ubmVjdG9yIGFuZCBlbmNvZGVyIHRoYXQgZ2V0cyBy ZWdpc3RlcmVkIGFzIHBhcnQKPiBvZiB0aGUgY29tcG9uZW50X2JpbmRfYWxsKCkgZmFpbHMgaWYg dGhlcmUgaXMgbm8gZHJtIGRldiByZWdpc3RlcmVkLiBZb3UgZGlkCj4gY29tbWVudCBvbiB0aGUg djQgdmVyc2lvbiBhYm91dCB0aGF0IGFuZCBJIGRpZCB0ZXN0IHlvdXIgaWRlYSwgc29ycnkgZm9y Cj4gZm9yZ2V0aW5nIHRvIHVwZGF0ZSB5b3Ugb24gdGhhdC4KCldoeSBkb2VzIGl0IGZhaWw/IFRo YXQgc2hvdWxkbid0IGhhcHBlbiAuLi4gd2UgbmVlZCB0byBiZSBhYmxlIHRvIHNldAp1cCBldmVy eXRoaW5nIGZpcnN0LCBiZWZvcmUgd2UgcmVnaXN0ZXIuCi1EYW5pZWwKLS0gCkRhbmllbCBWZXR0 ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCis0MSAoMCkgNzkgMzY1IDU3 IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel@ffwll.ch (Daniel Vetter) Date: Wed, 15 Jun 2016 19:13:15 +0200 Subject: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors In-Reply-To: <20160615161758.GF9711@e106497-lin.cambridge.arm.com> References: <1466002295-24813-1-git-send-email-Liviu.Dudau@arm.com> <1466002295-24813-3-git-send-email-Liviu.Dudau@arm.com> <20160615152309.GI1338@phenom.ffwll.local> <20160615161758.GF9711@e106497-lin.cambridge.arm.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jun 15, 2016 at 6:17 PM, Liviu Dudau wrote: > On Wed, Jun 15, 2016 at 05:23:10PM +0200, Daniel Vetter wrote: >> On Wed, Jun 15, 2016 at 03:51:34PM +0100, Liviu Dudau wrote: >> > Add support for the new family of Display Processors from ARM Ltd. >> > This commit adds basic support for Mali DP500, DP550 and DP650 >> > parts, with only the display engine being supported at the moment. >> > >> > Cc: David Brown >> > Cc: Brian Starkey >> > >> > Signed-off-by: Liviu Dudau >> >> Small thing I noticed: drm_dev_register/connector_register_all should be >> the last step in your init code, and unregister the first. Atm it's >> somewhere in the middle. But perfectly fine to do that as a follow-up. > > I've tried that, but the connector and encoder that gets registered as part > of the component_bind_all() fails if there is no drm dev registered. You did > comment on the v4 version about that and I did test your idea, sorry for > forgeting to update you on that. Why does it fail? That shouldn't happen ... we need to be able to set up everything first, before we register. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch