From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Thu, 15 Mar 2018 09:32:03 +0000 Subject: Re: fbcon non-desktop display use Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Charles Lohr , Linux Fbdev development list , Bartlomiej Zolnierkiewicz Cc: David Airlie , dri-devel On Thu, Mar 15, 2018 at 4:32 AM, Charles Lohr wrote: > There was a patch submitted by Keith Packard which prevents fbcon from using > non-desktop displays, but this breaks vive, and other HMD development/use on > embedded and other fbdev systems ( > https://patchwork.kernel.org/patch/10053989/ ). > > Even if the vive is the only device connected, it will still not permit it > to be operated. See https://github.com/linux-sunxi/linux-sunxi/issues/291 > for dri with a lot of debugging turned on. > > I can understand that most users would probably prefer that the vive isn't > automatically used if no other displays are available, however, the current > behavior prevents use of the vive on all devices that use fbdev for their > primary output. > > This patch allows enabling of non-desktop devices both as a kernel command > line as well as by setting > /sys/module/drm_kms_helper/parameters/drm_fbdev_permit_non_desktop. Why exactly are you developing new userspace on top of fbdev? fbdev never ever supported HMDs in any meaningful fashion (those things didn't exist 20 years ago when fbdev was designed), and we have fbdev in feature freeze mode since a few years now. Please explain a bit more about what exactly you're trying to do here, and what's running in userspace that makes you require fbdev. Adding fbdev lists&maintainer. Also please note that for graphics stuff we require a fully open sourced userspace side of the stack when adding new support, which this very much feels like. See: https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#open-source-userspace-requirements> > I've never sent an email to the kernel devel list, so I'm still a little > nervous. Especially because this is against a different branch, and I'm > starting to think that I should be messaging there, but this is something > that really needs to go upstream. Welcome to upstream! You're doing perfectly fine. We're trying really hard to be welcoming and respectful in the graphics subsystem, and have an enforced Code of Conduct to that effect: https://dri.freedesktop.org/docs/drm/gpu/introduction.html#code-of-conduct -Daniel > > Signed-off-by: > > diff --git a/drivers/gpu/drm/drm_fb_helper.c > b/drivers/gpu/drm/drm_fb_helper.c > index 035784ddd..8bfaf79ff 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -55,6 +55,11 @@ MODULE_PARM_DESC(drm_fbdev_overalloc, > "Overallocation of the fbdev buffer (%) [default=" > __MODULE_STRING(CONFIG_DRM_FBDEV_OVERALLOC) "]"); > > +static bool drm_fbdev_permit_non_desktop; > +module_param(drm_fbdev_permit_non_desktop, bool, 0644); > +MODULE_PARM_DESC(drm_fbdev_permit_non_desktop, > + "Allow the framebuffer to use non-desktop displays > [default=off]"); > + > static LIST_HEAD(kernel_fb_helper_list); > static DEFINE_MUTEX(kernel_fb_helper_lock); > > @@ -2109,7 +2114,7 @@ static bool drm_connector_enabled(struct drm_connector > *connector, bool strict) > { > bool enable; > > - if (connector->display_info.non_desktop) > + if (connector->display_info.non_desktop && > !drm_fbdev_permit_non_desktop) > return false; > > if (strict) > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: fbcon non-desktop display use Date: Thu, 15 Mar 2018 10:32:03 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-it0-x235.google.com (mail-it0-x235.google.com [IPv6:2607:f8b0:4001:c0b::235]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0632A6E7CF for ; Thu, 15 Mar 2018 09:32:04 +0000 (UTC) Received: by mail-it0-x235.google.com with SMTP id z143-v6so5818034itc.0 for ; Thu, 15 Mar 2018 02:32:04 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Charles Lohr , Linux Fbdev development list , Bartlomiej Zolnierkiewicz Cc: David Airlie , dri-devel List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBNYXIgMTUsIDIwMTggYXQgNDozMiBBTSwgQ2hhcmxlcyBMb2hyIDxsb2hyODVAZ21h aWwuY29tPiB3cm90ZToKPiBUaGVyZSB3YXMgYSBwYXRjaCBzdWJtaXR0ZWQgYnkgS2VpdGggUGFj a2FyZCB3aGljaCBwcmV2ZW50cyBmYmNvbiBmcm9tIHVzaW5nCj4gbm9uLWRlc2t0b3AgZGlzcGxh eXMsIGJ1dCB0aGlzIGJyZWFrcyB2aXZlLCBhbmQgb3RoZXIgSE1EIGRldmVsb3BtZW50L3VzZSBv bgo+IGVtYmVkZGVkIGFuZCBvdGhlciBmYmRldiBzeXN0ZW1zICgKPiBodHRwczovL3BhdGNod29y ay5rZXJuZWwub3JnL3BhdGNoLzEwMDUzOTg5LyApLgo+Cj4gRXZlbiBpZiB0aGUgdml2ZSBpcyB0 aGUgb25seSBkZXZpY2UgY29ubmVjdGVkLCBpdCB3aWxsIHN0aWxsIG5vdCBwZXJtaXQgaXQKPiB0 byBiZSBvcGVyYXRlZC4gIFNlZSBodHRwczovL2dpdGh1Yi5jb20vbGludXgtc3VueGkvbGludXgt c3VueGkvaXNzdWVzLzI5MQo+IGZvciBkcmkgd2l0aCBhIGxvdCBvZiBkZWJ1Z2dpbmcgdHVybmVk IG9uLgo+Cj4gSSBjYW4gdW5kZXJzdGFuZCB0aGF0IG1vc3QgdXNlcnMgd291bGQgcHJvYmFibHkg cHJlZmVyIHRoYXQgdGhlIHZpdmUgaXNuJ3QKPiBhdXRvbWF0aWNhbGx5IHVzZWQgaWYgbm8gb3Ro ZXIgZGlzcGxheXMgYXJlIGF2YWlsYWJsZSwgaG93ZXZlciwgdGhlIGN1cnJlbnQKPiBiZWhhdmlv ciBwcmV2ZW50cyB1c2Ugb2YgdGhlIHZpdmUgb24gYWxsIGRldmljZXMgdGhhdCB1c2UgZmJkZXYg Zm9yIHRoZWlyCj4gcHJpbWFyeSBvdXRwdXQuCj4KPiBUaGlzIHBhdGNoIGFsbG93cyBlbmFibGlu ZyBvZiBub24tZGVza3RvcCBkZXZpY2VzIGJvdGggYXMgYSBrZXJuZWwgY29tbWFuZAo+IGxpbmUg YXMgd2VsbCBhcyBieSBzZXR0aW5nCj4gL3N5cy9tb2R1bGUvZHJtX2ttc19oZWxwZXIvcGFyYW1l dGVycy9kcm1fZmJkZXZfcGVybWl0X25vbl9kZXNrdG9wLgoKV2h5IGV4YWN0bHkgYXJlIHlvdSBk ZXZlbG9waW5nIG5ldyB1c2Vyc3BhY2Ugb24gdG9wIG9mIGZiZGV2PyBmYmRldgpuZXZlciBldmVy IHN1cHBvcnRlZCBITURzIGluIGFueSBtZWFuaW5nZnVsIGZhc2hpb24gKHRob3NlIHRoaW5ncwpk aWRuJ3QgZXhpc3QgMjAgeWVhcnMgYWdvIHdoZW4gZmJkZXYgd2FzIGRlc2lnbmVkKSwgYW5kIHdl IGhhdmUgZmJkZXYKaW4gZmVhdHVyZSBmcmVlemUgbW9kZSBzaW5jZSBhIGZldyB5ZWFycyBub3cu IFBsZWFzZSBleHBsYWluIGEgYml0Cm1vcmUgYWJvdXQgd2hhdCBleGFjdGx5IHlvdSdyZSB0cnlp bmcgdG8gZG8gaGVyZSwgYW5kIHdoYXQncyBydW5uaW5nCmluIHVzZXJzcGFjZSB0aGF0IG1ha2Vz IHlvdSByZXF1aXJlIGZiZGV2LgoKQWRkaW5nIGZiZGV2IGxpc3RzJm1haW50YWluZXIuCgpBbHNv IHBsZWFzZSBub3RlIHRoYXQgZm9yIGdyYXBoaWNzIHN0dWZmIHdlIHJlcXVpcmUgYSBmdWxseSBv cGVuCnNvdXJjZWQgdXNlcnNwYWNlIHNpZGUgb2YgdGhlIHN0YWNrIHdoZW4gYWRkaW5nIG5ldyBz dXBwb3J0LCB3aGljaAp0aGlzIHZlcnkgbXVjaCBmZWVscyBsaWtlLiBTZWU6CgpodHRwczovL2Ry aS5mcmVlZGVza3RvcC5vcmcvZG9jcy9kcm0vZ3B1L2RybS11YXBpLmh0bWwjb3Blbi1zb3VyY2Ut dXNlcnNwYWNlLXJlcXVpcmVtZW50cz4KCj4gSSd2ZSBuZXZlciBzZW50IGFuIGVtYWlsIHRvIHRo ZSBrZXJuZWwgZGV2ZWwgbGlzdCwgc28gSSdtIHN0aWxsIGEgbGl0dGxlCj4gbmVydm91cy4gIEVz cGVjaWFsbHkgYmVjYXVzZSB0aGlzIGlzIGFnYWluc3QgYSBkaWZmZXJlbnQgYnJhbmNoLCBhbmQg SSdtCj4gc3RhcnRpbmcgdG8gdGhpbmsgdGhhdCBJIHNob3VsZCBiZSBtZXNzYWdpbmcgdGhlcmUs IGJ1dCB0aGlzIGlzIHNvbWV0aGluZwo+IHRoYXQgcmVhbGx5IG5lZWRzIHRvIGdvIHVwc3RyZWFt LgoKV2VsY29tZSB0byB1cHN0cmVhbSEgWW91J3JlIGRvaW5nIHBlcmZlY3RseSBmaW5lLiBXZSdy ZSB0cnlpbmcgcmVhbGx5CmhhcmQgdG8gYmUgd2VsY29taW5nIGFuZCByZXNwZWN0ZnVsIGluIHRo ZSBncmFwaGljcyBzdWJzeXN0ZW0sIGFuZApoYXZlIGFuIGVuZm9yY2VkIENvZGUgb2YgQ29uZHVj dCB0byB0aGF0IGVmZmVjdDoKCmh0dHBzOi8vZHJpLmZyZWVkZXNrdG9wLm9yZy9kb2NzL2RybS9n cHUvaW50cm9kdWN0aW9uLmh0bWwjY29kZS1vZi1jb25kdWN0Ci1EYW5pZWwKCgoKPgo+IFNpZ25l ZC1vZmYtYnk6Cj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIu Ywo+IGIvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+IGluZGV4IDAzNTc4NGRkZC4u OGJmYWY3OWZmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4gQEAgLTU1LDYgKzU1LDEx IEBAIE1PRFVMRV9QQVJNX0RFU0MoZHJtX2ZiZGV2X292ZXJhbGxvYywKPiAgICAgICAgICAgICAg ICAgICJPdmVyYWxsb2NhdGlvbiBvZiB0aGUgZmJkZXYgYnVmZmVyICglKSBbZGVmYXVsdD0iCj4g ICAgICAgICAgICAgICAgICBfX01PRFVMRV9TVFJJTkcoQ09ORklHX0RSTV9GQkRFVl9PVkVSQUxM T0MpICJdIik7Cj4KPiArc3RhdGljIGJvb2wgZHJtX2ZiZGV2X3Blcm1pdF9ub25fZGVza3RvcDsK PiArbW9kdWxlX3BhcmFtKGRybV9mYmRldl9wZXJtaXRfbm9uX2Rlc2t0b3AsIGJvb2wsIDA2NDQp Owo+ICtNT0RVTEVfUEFSTV9ERVNDKGRybV9mYmRldl9wZXJtaXRfbm9uX2Rlc2t0b3AsCj4gKyAg ICAgICAgICAgICAgICJBbGxvdyB0aGUgZnJhbWVidWZmZXIgdG8gdXNlIG5vbi1kZXNrdG9wIGRp c3BsYXlzCj4gW2RlZmF1bHQ9b2ZmXSIpOwo+ICsKPiAgc3RhdGljIExJU1RfSEVBRChrZXJuZWxf ZmJfaGVscGVyX2xpc3QpOwo+ICBzdGF0aWMgREVGSU5FX01VVEVYKGtlcm5lbF9mYl9oZWxwZXJf bG9jayk7Cj4KPiBAQCAtMjEwOSw3ICsyMTE0LDcgQEAgc3RhdGljIGJvb2wgZHJtX2Nvbm5lY3Rv cl9lbmFibGVkKHN0cnVjdCBkcm1fY29ubmVjdG9yCj4gKmNvbm5lY3RvciwgYm9vbCBzdHJpY3Qp Cj4gIHsKPiAgICAgICAgIGJvb2wgZW5hYmxlOwo+Cj4gLSAgICAgICBpZiAoY29ubmVjdG9yLT5k aXNwbGF5X2luZm8ubm9uX2Rlc2t0b3ApCj4gKyAgICAgICBpZiAoY29ubmVjdG9yLT5kaXNwbGF5 X2luZm8ubm9uX2Rlc2t0b3AgJiYKPiAhZHJtX2ZiZGV2X3Blcm1pdF9ub25fZGVza3RvcCkKPiAg ICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwo+Cj4gICAgICAgICBpZiAoc3RyaWN0KQo+Cj4K Pgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJp LWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo+ CgoKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlv bgorNDEgKDApIDc5IDM2NSA1NyA0OCAtIGh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=