From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/5] drm/i915: Parse EDID probed modes for DRRS support Date: Fri, 20 Dec 2013 15:05:37 +0100 Message-ID: References: <1387534258-5283-1-git-send-email-vandana.kannan@intel.com> <1387534258-5283-3-git-send-email-vandana.kannan@intel.com> <87d2krk8od.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ie0-f177.google.com (mail-ie0-f177.google.com [209.85.223.177]) by gabe.freedesktop.org (Postfix) with ESMTP id F3895FA1AA for ; Fri, 20 Dec 2013 06:05:38 -0800 (PST) Received: by mail-ie0-f177.google.com with SMTP id tp5so3099235ieb.36 for ; Fri, 20 Dec 2013 06:05:38 -0800 (PST) In-Reply-To: <87d2krk8od.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Fri, Dec 20, 2013 at 1:29 PM, Jani Nikula wrote: >> Signed-off-by: Pradeep Bhat >> Signed-off-by: Vandana Kannan >> Reviewed-by: Daniel Vetter >> Reviewed-by: Chris Wilson >> Reviewed-by: Jani Nikula > > I'm sorry, this is not true. Only I get to say when you can add my > Reviewed-by. Yeah, you can't just add review-by comments. In the linux kernel this has a very specific meaning and can't just get handed out for "has looked at the patches". For details of what a reviewed-by tag means please see the "Reviewer's statement of oversight" in Documentation/SubmittingPatches. I've noticed that you've also done this with Ville's r-b tag for the picture ratio patch, I'll send out a note that this r-b isn't legit. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch