From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B9DBC433E1 for ; Mon, 3 Aug 2020 08:45:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32FEA20678 for ; Mon, 3 Aug 2020 08:45:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="Hch2bh2t" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725965AbgHCIpU (ORCPT ); Mon, 3 Aug 2020 04:45:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725806AbgHCIpU (ORCPT ); Mon, 3 Aug 2020 04:45:20 -0400 Received: from mail-oi1-x242.google.com (mail-oi1-x242.google.com [IPv6:2607:f8b0:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23D72C061756 for ; Mon, 3 Aug 2020 01:45:19 -0700 (PDT) Received: by mail-oi1-x242.google.com with SMTP id k4so32638362oik.2 for ; Mon, 03 Aug 2020 01:45:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=gCUQRtjhgMP+4GbBlVgd/KVwJHXD6T5ihkhKQfTfDnU=; b=Hch2bh2tVN4GKSCCG47YFGcb33DidnAU0pRKNrC6oElbJ3glt2FoXG+13dUia3VYc/ D7B6Ra3TG2G4k8P1ViHNYEhdkuYmmYwHY3uCpoPmJz4tunDAm1LbIDEMrc0y5b6U3NvB INwJeEmQ9u/BXHXS33nqaRRqxkdRL7GWZ5NLE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=gCUQRtjhgMP+4GbBlVgd/KVwJHXD6T5ihkhKQfTfDnU=; b=RmCnAIJm4flhRm9Sz9g+NApnaeFSHzGeEw0du2ZBujSGIptcDJEnIO2F7k5BW92tVZ gnDDfUjdCVtZIoAnmoNdWUw5JvtZLXisDg065OFm5V2znazWphEaJzZdtSH0SzkLfrby vPc95gi/LHm5YJ4DHiJv1g/DDv+M14bQ2DQ7dL3DNsRcWDi/nvila/KyyCxnoF5J/DS7 IIei+U64xc71LQB0EZcUC8AUvWheX3lcW46WPKN0fzote5ZlEQ4qvAZc+9ApdN3lw5vb 9V+nKLOk5qgUig9gMPZkUBf2rhDK96Kvaw3jS31TOhSH1qa/IA9XC8pxMODnEHXVMAaR 80cQ== X-Gm-Message-State: AOAM533EefDe4RfP79qDc96bPff0q53ye2fVcnXvAoOlYsSUEOFRMGlz lF0vOn5TnRNqnPWvUaBLMfpi8vXZLqPjaHem8g9XMA== X-Google-Smtp-Source: ABdhPJyId8XExJYVy8L0eC778A06mCCWCXZXLWXucocgDo0ClcYsQp5fGA/P5XZTfEUbLvnRb5egClDmVXOjvoGR4Ag= X-Received: by 2002:aca:ab87:: with SMTP id u129mr11811035oie.128.1596444318309; Mon, 03 Aug 2020 01:45:18 -0700 (PDT) MIME-Version: 1.0 References: <659f8dcf-7802-1ca1-1372-eb7fefd4d8f4@kernel.org> <9fb43895-ca91-9b07-ebfd-808cf854ca95@nsfocus.com> <9386c640-34dd-0a50-5694-4f87cc600e0f@kernel.org> <20200803081823.GD493272@kroah.com> In-Reply-To: <20200803081823.GD493272@kroah.com> From: Daniel Vetter Date: Mon, 3 Aug 2020 10:45:07 +0200 Message-ID: Subject: Re: [PATCH] vgacon: fix out of bounds write to the scrollback buffer To: Greg KH Cc: Jiri Slaby , Linux Fbdev development list , Kyungtae Kim , Anthony Liguori , Bartlomiej Zolnierkiewicz , Linux kernel mailing list , DRI devel , "Srivatsa S. Bhat" , Solar Designer , Yang Yingliang , xiao.zhang@windriver.com, Linus Torvalds , =?UTF-8?B?5byg5LqR5rW3?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 3, 2020 at 10:26 AM Greg KH wrote: > > On Mon, Aug 03, 2020 at 10:08:43AM +0200, Jiri Slaby wrote: > > Hi, > > > > On 31. 07. 20, 7:22, =E5=BC=A0=E4=BA=91=E6=B5=B7 wrote: > > > Remove whitespace at EOL > > > > I am fine with the patch. However it should be sent properly (inline > > mail, having a PATCH subject etc. -- see > > Documentation/process/submitting-patches.rst). git send-email after git > > format-patch handles most of it. > > > > There is also question who is willing to take it? > > > > Bart? Greg? Should we route it via akpm, or will you Linus directly? (I > > can sign off and resend the patch which was attached to the mail I am > > replying to too, if need be.) > > I can take it, if Bart can't, just let me know. Yeah vt stuff and console drivers !=3D fbcon go through Greg's tree past few years ... Greg, should we maybe add a MAINTAINERS entry that matches on all things console? With tty/vt you definitely have the other side of that coin already :-) -Daniel --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Mon, 03 Aug 2020 08:45:07 +0000 Subject: Re: [PATCH] vgacon: fix out of bounds write to the scrollback buffer Message-Id: List-Id: References: <659f8dcf-7802-1ca1-1372-eb7fefd4d8f4@kernel.org> <9fb43895-ca91-9b07-ebfd-808cf854ca95@nsfocus.com> <9386c640-34dd-0a50-5694-4f87cc600e0f@kernel.org> <20200803081823.GD493272@kroah.com> In-Reply-To: <20200803081823.GD493272@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Greg KH Cc: Linux Fbdev development list , Kyungtae Kim , Solar Designer , Bartlomiej Zolnierkiewicz , Linus Torvalds , Linux kernel mailing list , DRI devel , =?UTF-8?B?5byg5LqR5rW3?= , Anthony Liguori , Yang Yingliang , xiao.zhang@windriver.com, Jiri Slaby , "Srivatsa S. Bhat" On Mon, Aug 3, 2020 at 10:26 AM Greg KH wrote: > > On Mon, Aug 03, 2020 at 10:08:43AM +0200, Jiri Slaby wrote: > > Hi, > > > > On 31. 07. 20, 7:22, 张云海 wrote: > > > Remove whitespace at EOL > > > > I am fine with the patch. However it should be sent properly (inline > > mail, having a PATCH subject etc. -- see > > Documentation/process/submitting-patches.rst). git send-email after git > > format-patch handles most of it. > > > > There is also question who is willing to take it? > > > > Bart? Greg? Should we route it via akpm, or will you Linus directly? (I > > can sign off and resend the patch which was attached to the mail I am > > replying to too, if need be.) > > I can take it, if Bart can't, just let me know. Yeah vt stuff and console drivers != fbcon go through Greg's tree past few years ... Greg, should we maybe add a MAINTAINERS entry that matches on all things console? With tty/vt you definitely have the other side of that coin already :-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECF54C433DF for ; Mon, 3 Aug 2020 08:45:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF06920678 for ; Mon, 3 Aug 2020 08:45:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="Hch2bh2t" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF06920678 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D78276E215; Mon, 3 Aug 2020 08:45:19 +0000 (UTC) Received: from mail-oi1-x242.google.com (mail-oi1-x242.google.com [IPv6:2607:f8b0:4864:20::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC8576E215 for ; Mon, 3 Aug 2020 08:45:18 +0000 (UTC) Received: by mail-oi1-x242.google.com with SMTP id e6so12398522oii.4 for ; Mon, 03 Aug 2020 01:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=gCUQRtjhgMP+4GbBlVgd/KVwJHXD6T5ihkhKQfTfDnU=; b=Hch2bh2tVN4GKSCCG47YFGcb33DidnAU0pRKNrC6oElbJ3glt2FoXG+13dUia3VYc/ D7B6Ra3TG2G4k8P1ViHNYEhdkuYmmYwHY3uCpoPmJz4tunDAm1LbIDEMrc0y5b6U3NvB INwJeEmQ9u/BXHXS33nqaRRqxkdRL7GWZ5NLE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=gCUQRtjhgMP+4GbBlVgd/KVwJHXD6T5ihkhKQfTfDnU=; b=qZgSjBluDUJ1OFcL5VUkwhPG1AfUL3anYh1Tdywr/NqSJkfkG/fzzAm/F+uWgpcboz fN8eHQtDMR3QyDmR4E/IE+Ef95uj1VUO1DrP/eRcn8t846e58C+mwfk+dYUHa/Yp2XSD RONVA6dtfIYu8/G5sFzyWDYWY333Dz28ThUXSeP3ufHp67gHvo8IFF8zEekXgBjMIZ/V SThMa40zNeXv2ltG5IgkK8Bk42A1H29LvGsj9Czie/9Bb6eaTo800HRVukSmdkmh+PVW jyrh1oTbUHs5Kqt3LfKLutMBKLKcOOcgrTuluVTIN7FyaEKIOV9r+UZJxS48RdL4PIo1 k42Q== X-Gm-Message-State: AOAM532pOZOor4hhq2A6nH9YVHRjkZBdlzUnfJgj5xCwsbF+kyZZKCGF 79I/Agac7WWpPlaIMnlTW5cJAmvMmniCeoVOU1QwIg== X-Google-Smtp-Source: ABdhPJyId8XExJYVy8L0eC778A06mCCWCXZXLWXucocgDo0ClcYsQp5fGA/P5XZTfEUbLvnRb5egClDmVXOjvoGR4Ag= X-Received: by 2002:aca:ab87:: with SMTP id u129mr11811035oie.128.1596444318309; Mon, 03 Aug 2020 01:45:18 -0700 (PDT) MIME-Version: 1.0 References: <659f8dcf-7802-1ca1-1372-eb7fefd4d8f4@kernel.org> <9fb43895-ca91-9b07-ebfd-808cf854ca95@nsfocus.com> <9386c640-34dd-0a50-5694-4f87cc600e0f@kernel.org> <20200803081823.GD493272@kroah.com> In-Reply-To: <20200803081823.GD493272@kroah.com> From: Daniel Vetter Date: Mon, 3 Aug 2020 10:45:07 +0200 Message-ID: Subject: Re: [PATCH] vgacon: fix out of bounds write to the scrollback buffer To: Greg KH X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Fbdev development list , Kyungtae Kim , Solar Designer , Bartlomiej Zolnierkiewicz , Linus Torvalds , Linux kernel mailing list , DRI devel , =?UTF-8?B?5byg5LqR5rW3?= , Anthony Liguori , Yang Yingliang , xiao.zhang@windriver.com, Jiri Slaby , "Srivatsa S. Bhat" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gTW9uLCBBdWcgMywgMjAyMCBhdCAxMDoyNiBBTSBHcmVnIEtIIDxncmVnQGtyb2FoLmNvbT4g d3JvdGU6Cj4KPiBPbiBNb24sIEF1ZyAwMywgMjAyMCBhdCAxMDowODo0M0FNICswMjAwLCBKaXJp IFNsYWJ5IHdyb3RlOgo+ID4gSGksCj4gPgo+ID4gT24gMzEuIDA3LiAyMCwgNzoyMiwg5byg5LqR 5rW3IHdyb3RlOgo+ID4gPiBSZW1vdmUgd2hpdGVzcGFjZSBhdCBFT0wKPiA+Cj4gPiBJIGFtIGZp bmUgd2l0aCB0aGUgcGF0Y2guIEhvd2V2ZXIgaXQgc2hvdWxkIGJlIHNlbnQgcHJvcGVybHkgKGlu bGluZQo+ID4gbWFpbCwgaGF2aW5nIGEgUEFUQ0ggc3ViamVjdCBldGMuIC0tIHNlZQo+ID4gRG9j dW1lbnRhdGlvbi9wcm9jZXNzL3N1Ym1pdHRpbmctcGF0Y2hlcy5yc3QpLiBnaXQgc2VuZC1lbWFp bCBhZnRlciBnaXQKPiA+IGZvcm1hdC1wYXRjaCBoYW5kbGVzIG1vc3Qgb2YgaXQuCj4gPgo+ID4g VGhlcmUgaXMgYWxzbyBxdWVzdGlvbiB3aG8gaXMgd2lsbGluZyB0byB0YWtlIGl0Pwo+ID4KPiA+ IEJhcnQ/IEdyZWc/IFNob3VsZCB3ZSByb3V0ZSBpdCB2aWEgYWtwbSwgb3Igd2lsbCB5b3UgTGlu dXMgZGlyZWN0bHk/IChJCj4gPiBjYW4gc2lnbiBvZmYgYW5kIHJlc2VuZCB0aGUgcGF0Y2ggd2hp Y2ggd2FzIGF0dGFjaGVkIHRvIHRoZSBtYWlsIEkgYW0KPiA+IHJlcGx5aW5nIHRvIHRvbywgaWYg bmVlZCBiZS4pCj4KPiBJIGNhbiB0YWtlIGl0LCBpZiBCYXJ0IGNhbid0LCBqdXN0IGxldCBtZSBr bm93LgoKWWVhaCB2dCBzdHVmZiBhbmQgY29uc29sZSBkcml2ZXJzICE9IGZiY29uIGdvIHRocm91 Z2ggR3JlZydzIHRyZWUgcGFzdApmZXcgeWVhcnMgLi4uCgpHcmVnLCBzaG91bGQgd2UgbWF5YmUg YWRkIGEgTUFJTlRBSU5FUlMgZW50cnkgdGhhdCBtYXRjaGVzIG9uIGFsbAp0aGluZ3MgY29uc29s ZT8gV2l0aCB0dHkvdnQgeW91IGRlZmluaXRlbHkgaGF2ZSB0aGUgb3RoZXIgc2lkZSBvZiB0aGF0 CmNvaW4gYWxyZWFkeSA6LSkKLURhbmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdp bmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==