From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF639C41604 for ; Wed, 7 Oct 2020 18:14:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B89A2168B for ; Wed, 7 Oct 2020 18:14:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="lyjVFBq/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728833AbgJGSOS (ORCPT ); Wed, 7 Oct 2020 14:14:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727458AbgJGSOR (ORCPT ); Wed, 7 Oct 2020 14:14:17 -0400 Received: from mail-oo1-xc42.google.com (mail-oo1-xc42.google.com [IPv6:2607:f8b0:4864:20::c42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97EB3C0613D3 for ; Wed, 7 Oct 2020 11:14:17 -0700 (PDT) Received: by mail-oo1-xc42.google.com with SMTP id h8so836771ooc.12 for ; Wed, 07 Oct 2020 11:14:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cQRYAtP+xjx5WuekS6OE0CV7kqmxj7BYflzO3gWdvvE=; b=lyjVFBq/8C4cx1xV9ChTXnV40ihqdqpwLDP0hKiWG7wMCAY1kcUxadTiFEkVrngi/w V9y6TiR2NUPQYfn7qatcnS2KH2rC4iURG1Imt+VcjCPG3gMt13p5HinunxSiaAfYb6mn oHrygbKnexw8amjrZlMfKtPR5lb/S9ssQU4cU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cQRYAtP+xjx5WuekS6OE0CV7kqmxj7BYflzO3gWdvvE=; b=dQ7qEbjFL4uxD4kp9W2ALdUoYgLmoQ2rFmuE6m1oUckgtH44LT1z27kovv8rn94ncR /KTscSQIs316VYQ7knEwxZjurJRe0rG2WvDmU7Xwzb0QEiDzmU5sCaY6Whw8ieu0T3WC 2Cq912nT9uyeyFIPCrvk8wYwD8Tc8LYV/SNVYl+zi1L67APMx10MK1+jB9RR2OYEpD5O uoyT4pEmJs8ZR3gBPp/kN63QkQC+5ERlL/uwJkaGKF7mh43E1VLWc4fUZaH0jhlWnsiu Wq4UlwEuqBZIdsmIr5OGH/RFkWysmhfaoP/jB+VAvVDKVXVt6IfirVyRzl9px46SYU/l OjEw== X-Gm-Message-State: AOAM531H9meDr9MWzSpaUNR8r8psdBf8/zjasbrfBXldAczm9YQbAXxx uxjPm8Lm1xQ3XgGZtF3OhiBffZQGSPMobyUbG8+Fjw== X-Google-Smtp-Source: ABdhPJzjOjAMzRbSVSt+lqfvvsdq1EBjj80477iZlPA7zPuN7ej1AyuyFSKWwEDM91Ycyft1zzLM1yCXh0Q5piW4a7o= X-Received: by 2002:a4a:e592:: with SMTP id o18mr2831112oov.28.1602094456975; Wed, 07 Oct 2020 11:14:16 -0700 (PDT) MIME-Version: 1.0 References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch> <20201007164426.1812530-14-daniel.vetter@ffwll.ch> <20201007173911.GX5177@ziepe.ca> In-Reply-To: <20201007173911.GX5177@ziepe.ca> From: Daniel Vetter Date: Wed, 7 Oct 2020 20:14:06 +0200 Message-ID: Subject: Re: [PATCH 13/13] vfio/type1: Mark follow_pfn as unsafe To: Jason Gunthorpe Cc: DRI Development , LKML , kvm@vger.kernel.org, Linux MM , Linux ARM , linux-samsung-soc , "open list:DMA BUFFER SHARING FRAMEWORK" , linux-s390@vger.kernel.org, Daniel Vetter , Kees Cook , Dan Williams , Andrew Morton , John Hubbard , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jan Kara , Alex Williamson , Cornelia Huck Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 7, 2020 at 7:39 PM Jason Gunthorpe wrote: > > On Wed, Oct 07, 2020 at 06:44:26PM +0200, Daniel Vetter wrote: > > The code seems to stuff these pfns into iommu pts (or something like > > that, I didn't follow), but there's no mmu_notifier to ensure that > > access is synchronized with pte updates. > > > > Hence mark these as unsafe. This means that with > > CONFIG_STRICT_FOLLOW_PFN, these will be rejected. > > > > Real fix is to wire up an mmu_notifier ... somehow. Probably means any > > invalidate is a fatal fault for this vfio device, but then this > > shouldn't ever happen if userspace is reasonable. > > > > Signed-off-by: Daniel Vetter > > Cc: Jason Gunthorpe > > Cc: Kees Cook > > Cc: Dan Williams > > Cc: Andrew Morton > > Cc: John Hubbard > > Cc: J=C3=A9r=C3=B4me Glisse > > Cc: Jan Kara > > Cc: Dan Williams > > Cc: linux-mm@kvack.org > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-samsung-soc@vger.kernel.org > > Cc: linux-media@vger.kernel.org > > Cc: Alex Williamson > > Cc: Cornelia Huck > > Cc: kvm@vger.kernel.org > > --- > > drivers/vfio/vfio_iommu_type1.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_= type1.c > > index 5fbf0c1f7433..a4d53f3d0a35 100644 > > --- a/drivers/vfio/vfio_iommu_type1.c > > +++ b/drivers/vfio/vfio_iommu_type1.c > > @@ -421,7 +421,7 @@ static int follow_fault_pfn(struct vm_area_struct *= vma, struct mm_struct *mm, > > { > > int ret; > > > > - ret =3D follow_pfn(vma, vaddr, pfn); > > + ret =3D unsafe_follow_pfn(vma, vaddr, pfn); > > if (ret) { > > bool unlocked =3D false; > > > > @@ -435,7 +435,7 @@ static int follow_fault_pfn(struct vm_area_struct *= vma, struct mm_struct *mm, > > if (ret) > > return ret; > > > > - ret =3D follow_pfn(vma, vaddr, pfn); > > + ret =3D unsafe_follow_pfn(vma, vaddr, pfn); > > } > > This is actually being commonly used, so it needs fixing. > > When I talked to Alex about this last we had worked out a patch series > that adds a test on vm_ops that the vma came from vfio in the first > place. The VMA's created by VFIO are 'safe' as the PTEs are never changed= . Hm, but wouldn't need that the semi-nasty vma_open trick to make sure that vma doesn't untimely disappear? Or is the idea to look up the underlying vfio object, and refcount that directly? -Daniel --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C28A4C4363C for ; Wed, 7 Oct 2020 18:16:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D11B2168B for ; Wed, 7 Oct 2020 18:16:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VpXcmfP3"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="lyjVFBq/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D11B2168B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PYtoCojb91k7693i4QvtVmd/zEl2vPrty87wK5qNWvo=; b=VpXcmfP39hb0AnncSwl1dxBir vsym6DbOV56QUj2Not+txoXehCFUqZvSSbOguK3tmufQja6JF+4c6R1Y+Ruu+aAqzadfHvHwfkt7L 061ua0Yc4yddfA9+4OvIqKkMhEQu5Rv35WajvCPZ1njRPoYLqv0UAZ/niD+UuNEE0o7qCpbAbDdEB elJhXzkTy6Kwpo4QImFZoQwdUFVq0V5OlRT3NR/2HADNVHA3Hmj2frqyvcJt/UFAkLo++at01xVKj hVm52oqepGUHBppWFkN8m5ibjWoz87OXe2hkfkjlchu9JZ8MQ28qXgYEAF91b5wd+Ta1im5wY3Qs2 DiJAH6zZw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQDxG-0004SN-KX; Wed, 07 Oct 2020 18:14:22 +0000 Received: from mail-yb1-xb44.google.com ([2607:f8b0:4864:20::b44]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQDxD-0004RI-SJ for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2020 18:14:20 +0000 Received: by mail-yb1-xb44.google.com with SMTP id c3so2550049ybl.0 for ; Wed, 07 Oct 2020 11:14:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cQRYAtP+xjx5WuekS6OE0CV7kqmxj7BYflzO3gWdvvE=; b=lyjVFBq/8C4cx1xV9ChTXnV40ihqdqpwLDP0hKiWG7wMCAY1kcUxadTiFEkVrngi/w V9y6TiR2NUPQYfn7qatcnS2KH2rC4iURG1Imt+VcjCPG3gMt13p5HinunxSiaAfYb6mn oHrygbKnexw8amjrZlMfKtPR5lb/S9ssQU4cU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cQRYAtP+xjx5WuekS6OE0CV7kqmxj7BYflzO3gWdvvE=; b=hFChAbQ4ZciZCJrAhwdHA7GYiJS8olWwu0LP5d7GKtqROqdgARYMZ3e4EJ9DNVTD9h z82vH1fBACgNgeDl+HcO5ifA83c3sxxqIvBQRfe2aR4+NCVeWp59VjfT+n9VUn/k0bjr WuhqTpuOLSvT0UWVwHx12tXw/tiegoeCxqby/vsB9EP75tMe7CaxqpMiguE4lC7XSOej IEyeYFInmVhi2qy2F4pTDbia8CtKq9vaf/gKikUigiGvkGWT8/QUvoBaNR8n5boFZAGn o5luQNrr7QaI8M3/gxDW+EK3+Oh/SrYn1H0FPvWpak1owd2lgMluwyElb6IYh3b+Sd0I Z2HA== X-Gm-Message-State: AOAM530Y/G5wO529jQ552J78UTayJ+LYgXWXQI8d4iJKk7E9+qRgXFKK QvfcV25VVAROHP1B/B2kte1FFe1dVd/kcxhm4mKPlofLmr98bA== X-Google-Smtp-Source: ABdhPJzjOjAMzRbSVSt+lqfvvsdq1EBjj80477iZlPA7zPuN7ej1AyuyFSKWwEDM91Ycyft1zzLM1yCXh0Q5piW4a7o= X-Received: by 2002:a4a:e592:: with SMTP id o18mr2831112oov.28.1602094456975; Wed, 07 Oct 2020 11:14:16 -0700 (PDT) MIME-Version: 1.0 References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch> <20201007164426.1812530-14-daniel.vetter@ffwll.ch> <20201007173911.GX5177@ziepe.ca> In-Reply-To: <20201007173911.GX5177@ziepe.ca> From: Daniel Vetter Date: Wed, 7 Oct 2020 20:14:06 +0200 Message-ID: Subject: Re: [PATCH 13/13] vfio/type1: Mark follow_pfn as unsafe To: Jason Gunthorpe X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201007_141419_939245_9B18717A X-CRM114-Status: GOOD ( 28.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, linux-samsung-soc , Jan Kara , Kees Cook , kvm@vger.kernel.org, John Hubbard , Cornelia Huck , LKML , DRI Development , Linux MM , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Alex Williamson , Daniel Vetter , Dan Williams , Andrew Morton , Linux ARM , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBPY3QgNywgMjAyMCBhdCA3OjM5IFBNIEphc29uIEd1bnRob3JwZSA8amdnQHppZXBl LmNhPiB3cm90ZToKPgo+IE9uIFdlZCwgT2N0IDA3LCAyMDIwIGF0IDA2OjQ0OjI2UE0gKzAyMDAs IERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPiBUaGUgY29kZSBzZWVtcyB0byBzdHVmZiB0aGVzZSBw Zm5zIGludG8gaW9tbXUgcHRzIChvciBzb21ldGhpbmcgbGlrZQo+ID4gdGhhdCwgSSBkaWRuJ3Qg Zm9sbG93KSwgYnV0IHRoZXJlJ3Mgbm8gbW11X25vdGlmaWVyIHRvIGVuc3VyZSB0aGF0Cj4gPiBh Y2Nlc3MgaXMgc3luY2hyb25pemVkIHdpdGggcHRlIHVwZGF0ZXMuCj4gPgo+ID4gSGVuY2UgbWFy ayB0aGVzZSBhcyB1bnNhZmUuIFRoaXMgbWVhbnMgdGhhdCB3aXRoCj4gPiBDT05GSUdfU1RSSUNU X0ZPTExPV19QRk4sIHRoZXNlIHdpbGwgYmUgcmVqZWN0ZWQuCj4gPgo+ID4gUmVhbCBmaXggaXMg dG8gd2lyZSB1cCBhbiBtbXVfbm90aWZpZXIgLi4uIHNvbWVob3cuIFByb2JhYmx5IG1lYW5zIGFu eQo+ID4gaW52YWxpZGF0ZSBpcyBhIGZhdGFsIGZhdWx0IGZvciB0aGlzIHZmaW8gZGV2aWNlLCBi dXQgdGhlbiB0aGlzCj4gPiBzaG91bGRuJ3QgZXZlciBoYXBwZW4gaWYgdXNlcnNwYWNlIGlzIHJl YXNvbmFibGUuCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZl dHRlckBpbnRlbC5jb20+Cj4gPiBDYzogSmFzb24gR3VudGhvcnBlIDxqZ2dAemllcGUuY2E+Cj4g PiBDYzogS2VlcyBDb29rIDxrZWVzY29va0BjaHJvbWl1bS5vcmc+Cj4gPiBDYzogRGFuIFdpbGxp YW1zIDxkYW4uai53aWxsaWFtc0BpbnRlbC5jb20+Cj4gPiBDYzogQW5kcmV3IE1vcnRvbiA8YWtw bUBsaW51eC1mb3VuZGF0aW9uLm9yZz4KPiA+IENjOiBKb2huIEh1YmJhcmQgPGpodWJiYXJkQG52 aWRpYS5jb20+Cj4gPiBDYzogSsOpcsO0bWUgR2xpc3NlIDxqZ2xpc3NlQHJlZGhhdC5jb20+Cj4g PiBDYzogSmFuIEthcmEgPGphY2tAc3VzZS5jej4KPiA+IENjOiBEYW4gV2lsbGlhbXMgPGRhbi5q LndpbGxpYW1zQGludGVsLmNvbT4KPiA+IENjOiBsaW51eC1tbUBrdmFjay5vcmcKPiA+IENjOiBs aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKPiA+IENjOiBsaW51eC1zYW1zdW5n LXNvY0B2Z2VyLmtlcm5lbC5vcmcKPiA+IENjOiBsaW51eC1tZWRpYUB2Z2VyLmtlcm5lbC5vcmcK PiA+IENjOiBBbGV4IFdpbGxpYW1zb24gPGFsZXgud2lsbGlhbXNvbkByZWRoYXQuY29tPgo+ID4g Q2M6IENvcm5lbGlhIEh1Y2sgPGNvaHVja0ByZWRoYXQuY29tPgo+ID4gQ2M6IGt2bUB2Z2VyLmtl cm5lbC5vcmcKPiA+IC0tLQo+ID4gIGRyaXZlcnMvdmZpby92ZmlvX2lvbW11X3R5cGUxLmMgfCA0 ICsrLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygt KQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3ZmaW8vdmZpb19pb21tdV90eXBlMS5jIGIv ZHJpdmVycy92ZmlvL3ZmaW9faW9tbXVfdHlwZTEuYwo+ID4gaW5kZXggNWZiZjBjMWY3NDMzLi5h NGQ1M2YzZDBhMzUgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL3ZmaW8vdmZpb19pb21tdV90eXBl MS5jCj4gPiArKysgYi9kcml2ZXJzL3ZmaW8vdmZpb19pb21tdV90eXBlMS5jCj4gPiBAQCAtNDIx LDcgKzQyMSw3IEBAIHN0YXRpYyBpbnQgZm9sbG93X2ZhdWx0X3BmbihzdHJ1Y3Qgdm1fYXJlYV9z dHJ1Y3QgKnZtYSwgc3RydWN0IG1tX3N0cnVjdCAqbW0sCj4gPiAgewo+ID4gICAgICAgaW50IHJl dDsKPiA+Cj4gPiAtICAgICByZXQgPSBmb2xsb3dfcGZuKHZtYSwgdmFkZHIsIHBmbik7Cj4gPiAr ICAgICByZXQgPSB1bnNhZmVfZm9sbG93X3Bmbih2bWEsIHZhZGRyLCBwZm4pOwo+ID4gICAgICAg aWYgKHJldCkgewo+ID4gICAgICAgICAgICAgICBib29sIHVubG9ja2VkID0gZmFsc2U7Cj4gPgo+ ID4gQEAgLTQzNSw3ICs0MzUsNyBAQCBzdGF0aWMgaW50IGZvbGxvd19mYXVsdF9wZm4oc3RydWN0 IHZtX2FyZWFfc3RydWN0ICp2bWEsIHN0cnVjdCBtbV9zdHJ1Y3QgKm1tLAo+ID4gICAgICAgICAg ICAgICBpZiAocmV0KQo+ID4gICAgICAgICAgICAgICAgICAgICAgIHJldHVybiByZXQ7Cj4gPgo+ ID4gLSAgICAgICAgICAgICByZXQgPSBmb2xsb3dfcGZuKHZtYSwgdmFkZHIsIHBmbik7Cj4gPiAr ICAgICAgICAgICAgIHJldCA9IHVuc2FmZV9mb2xsb3dfcGZuKHZtYSwgdmFkZHIsIHBmbik7Cj4g PiAgICAgICB9Cj4KPiBUaGlzIGlzIGFjdHVhbGx5IGJlaW5nIGNvbW1vbmx5IHVzZWQsIHNvIGl0 IG5lZWRzIGZpeGluZy4KPgo+IFdoZW4gSSB0YWxrZWQgdG8gQWxleCBhYm91dCB0aGlzIGxhc3Qg d2UgaGFkIHdvcmtlZCBvdXQgYSBwYXRjaCBzZXJpZXMKPiB0aGF0IGFkZHMgYSB0ZXN0IG9uIHZt X29wcyB0aGF0IHRoZSB2bWEgY2FtZSBmcm9tIHZmaW8gaW4gdGhlIGZpcnN0Cj4gcGxhY2UuIFRo ZSBWTUEncyBjcmVhdGVkIGJ5IFZGSU8gYXJlICdzYWZlJyBhcyB0aGUgUFRFcyBhcmUgbmV2ZXIg Y2hhbmdlZC4KCkhtLCBidXQgd291bGRuJ3QgbmVlZCB0aGF0IHRoZSBzZW1pLW5hc3R5IHZtYV9v cGVuIHRyaWNrIHRvIG1ha2Ugc3VyZQp0aGF0IHZtYSBkb2Vzbid0IHVudGltZWx5IGRpc2FwcGVh cj8gT3IgaXMgdGhlIGlkZWEgdG8gbG9vayB1cCB0aGUKdW5kZXJseWluZyB2ZmlvIG9iamVjdCwg YW5kIHJlZmNvdW50IHRoYXQgZGlyZWN0bHk/Ci1EYW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29m dHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0t a2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2Vy bmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 948DCC4727E for ; Wed, 7 Oct 2020 18:14:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D3A82168B for ; Wed, 7 Oct 2020 18:14:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="lyjVFBq/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D3A82168B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 270746E972; Wed, 7 Oct 2020 18:14:19 +0000 (UTC) Received: from mail-oo1-xc43.google.com (mail-oo1-xc43.google.com [IPv6:2607:f8b0:4864:20::c43]) by gabe.freedesktop.org (Postfix) with ESMTPS id B904089993 for ; Wed, 7 Oct 2020 18:14:17 +0000 (UTC) Received: by mail-oo1-xc43.google.com with SMTP id 4so844328ooh.11 for ; Wed, 07 Oct 2020 11:14:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cQRYAtP+xjx5WuekS6OE0CV7kqmxj7BYflzO3gWdvvE=; b=lyjVFBq/8C4cx1xV9ChTXnV40ihqdqpwLDP0hKiWG7wMCAY1kcUxadTiFEkVrngi/w V9y6TiR2NUPQYfn7qatcnS2KH2rC4iURG1Imt+VcjCPG3gMt13p5HinunxSiaAfYb6mn oHrygbKnexw8amjrZlMfKtPR5lb/S9ssQU4cU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cQRYAtP+xjx5WuekS6OE0CV7kqmxj7BYflzO3gWdvvE=; b=MHqjBZ2ZWtP6kjwPrvufRtnft5UaV8OJRzJeLxdyjDSpzQ4ZsKN0Kvy5Q0MmcKZC6c bKuTs3433kHjIH5YYsvyjUXf2nmw8KqxzC+/arLoPnQxvV82l23OoYQMoRILN+rvbJRM 2Tk29LIDYcNWuzYqrDfvcuQ2cWnmO1xCENWHqaK6fE+kpOgJr6R9BbqOmhfwPyMCMQcU 0GYLVjV+C9IOazuSOQ8nAL4x8Nrm3QM8RZB+AlZsxJSrFbxSfadkWX5TS4JXnG4mtWuo 0AcqXdEqXnm2aYPuRiVDehi25GjhGa8CvD0xsH9S0sPPd7SXpziSHWdFrc+HzoJgxOYn nPFw== X-Gm-Message-State: AOAM531NRlQfJ0karyJUhK7GchvtTgqCiINaeSTsPCuixtQhzD8bHewh P2cn8x8DGDRFMxyhxFMkXbks/X2Ofb8qGmV1bYPxSQ== X-Google-Smtp-Source: ABdhPJzjOjAMzRbSVSt+lqfvvsdq1EBjj80477iZlPA7zPuN7ej1AyuyFSKWwEDM91Ycyft1zzLM1yCXh0Q5piW4a7o= X-Received: by 2002:a4a:e592:: with SMTP id o18mr2831112oov.28.1602094456975; Wed, 07 Oct 2020 11:14:16 -0700 (PDT) MIME-Version: 1.0 References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch> <20201007164426.1812530-14-daniel.vetter@ffwll.ch> <20201007173911.GX5177@ziepe.ca> In-Reply-To: <20201007173911.GX5177@ziepe.ca> From: Daniel Vetter Date: Wed, 7 Oct 2020 20:14:06 +0200 Message-ID: Subject: Re: [PATCH 13/13] vfio/type1: Mark follow_pfn as unsafe To: Jason Gunthorpe X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, linux-samsung-soc , Jan Kara , Kees Cook , kvm@vger.kernel.org, John Hubbard , Cornelia Huck , LKML , DRI Development , Linux MM , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Alex Williamson , Daniel Vetter , Dan Williams , Andrew Morton , Linux ARM , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCBPY3QgNywgMjAyMCBhdCA3OjM5IFBNIEphc29uIEd1bnRob3JwZSA8amdnQHppZXBl LmNhPiB3cm90ZToKPgo+IE9uIFdlZCwgT2N0IDA3LCAyMDIwIGF0IDA2OjQ0OjI2UE0gKzAyMDAs IERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPiBUaGUgY29kZSBzZWVtcyB0byBzdHVmZiB0aGVzZSBw Zm5zIGludG8gaW9tbXUgcHRzIChvciBzb21ldGhpbmcgbGlrZQo+ID4gdGhhdCwgSSBkaWRuJ3Qg Zm9sbG93KSwgYnV0IHRoZXJlJ3Mgbm8gbW11X25vdGlmaWVyIHRvIGVuc3VyZSB0aGF0Cj4gPiBh Y2Nlc3MgaXMgc3luY2hyb25pemVkIHdpdGggcHRlIHVwZGF0ZXMuCj4gPgo+ID4gSGVuY2UgbWFy ayB0aGVzZSBhcyB1bnNhZmUuIFRoaXMgbWVhbnMgdGhhdCB3aXRoCj4gPiBDT05GSUdfU1RSSUNU X0ZPTExPV19QRk4sIHRoZXNlIHdpbGwgYmUgcmVqZWN0ZWQuCj4gPgo+ID4gUmVhbCBmaXggaXMg dG8gd2lyZSB1cCBhbiBtbXVfbm90aWZpZXIgLi4uIHNvbWVob3cuIFByb2JhYmx5IG1lYW5zIGFu eQo+ID4gaW52YWxpZGF0ZSBpcyBhIGZhdGFsIGZhdWx0IGZvciB0aGlzIHZmaW8gZGV2aWNlLCBi dXQgdGhlbiB0aGlzCj4gPiBzaG91bGRuJ3QgZXZlciBoYXBwZW4gaWYgdXNlcnNwYWNlIGlzIHJl YXNvbmFibGUuCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZl dHRlckBpbnRlbC5jb20+Cj4gPiBDYzogSmFzb24gR3VudGhvcnBlIDxqZ2dAemllcGUuY2E+Cj4g PiBDYzogS2VlcyBDb29rIDxrZWVzY29va0BjaHJvbWl1bS5vcmc+Cj4gPiBDYzogRGFuIFdpbGxp YW1zIDxkYW4uai53aWxsaWFtc0BpbnRlbC5jb20+Cj4gPiBDYzogQW5kcmV3IE1vcnRvbiA8YWtw bUBsaW51eC1mb3VuZGF0aW9uLm9yZz4KPiA+IENjOiBKb2huIEh1YmJhcmQgPGpodWJiYXJkQG52 aWRpYS5jb20+Cj4gPiBDYzogSsOpcsO0bWUgR2xpc3NlIDxqZ2xpc3NlQHJlZGhhdC5jb20+Cj4g PiBDYzogSmFuIEthcmEgPGphY2tAc3VzZS5jej4KPiA+IENjOiBEYW4gV2lsbGlhbXMgPGRhbi5q LndpbGxpYW1zQGludGVsLmNvbT4KPiA+IENjOiBsaW51eC1tbUBrdmFjay5vcmcKPiA+IENjOiBs aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKPiA+IENjOiBsaW51eC1zYW1zdW5n LXNvY0B2Z2VyLmtlcm5lbC5vcmcKPiA+IENjOiBsaW51eC1tZWRpYUB2Z2VyLmtlcm5lbC5vcmcK PiA+IENjOiBBbGV4IFdpbGxpYW1zb24gPGFsZXgud2lsbGlhbXNvbkByZWRoYXQuY29tPgo+ID4g Q2M6IENvcm5lbGlhIEh1Y2sgPGNvaHVja0ByZWRoYXQuY29tPgo+ID4gQ2M6IGt2bUB2Z2VyLmtl cm5lbC5vcmcKPiA+IC0tLQo+ID4gIGRyaXZlcnMvdmZpby92ZmlvX2lvbW11X3R5cGUxLmMgfCA0 ICsrLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygt KQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3ZmaW8vdmZpb19pb21tdV90eXBlMS5jIGIv ZHJpdmVycy92ZmlvL3ZmaW9faW9tbXVfdHlwZTEuYwo+ID4gaW5kZXggNWZiZjBjMWY3NDMzLi5h NGQ1M2YzZDBhMzUgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL3ZmaW8vdmZpb19pb21tdV90eXBl MS5jCj4gPiArKysgYi9kcml2ZXJzL3ZmaW8vdmZpb19pb21tdV90eXBlMS5jCj4gPiBAQCAtNDIx LDcgKzQyMSw3IEBAIHN0YXRpYyBpbnQgZm9sbG93X2ZhdWx0X3BmbihzdHJ1Y3Qgdm1fYXJlYV9z dHJ1Y3QgKnZtYSwgc3RydWN0IG1tX3N0cnVjdCAqbW0sCj4gPiAgewo+ID4gICAgICAgaW50IHJl dDsKPiA+Cj4gPiAtICAgICByZXQgPSBmb2xsb3dfcGZuKHZtYSwgdmFkZHIsIHBmbik7Cj4gPiAr ICAgICByZXQgPSB1bnNhZmVfZm9sbG93X3Bmbih2bWEsIHZhZGRyLCBwZm4pOwo+ID4gICAgICAg aWYgKHJldCkgewo+ID4gICAgICAgICAgICAgICBib29sIHVubG9ja2VkID0gZmFsc2U7Cj4gPgo+ ID4gQEAgLTQzNSw3ICs0MzUsNyBAQCBzdGF0aWMgaW50IGZvbGxvd19mYXVsdF9wZm4oc3RydWN0 IHZtX2FyZWFfc3RydWN0ICp2bWEsIHN0cnVjdCBtbV9zdHJ1Y3QgKm1tLAo+ID4gICAgICAgICAg ICAgICBpZiAocmV0KQo+ID4gICAgICAgICAgICAgICAgICAgICAgIHJldHVybiByZXQ7Cj4gPgo+ ID4gLSAgICAgICAgICAgICByZXQgPSBmb2xsb3dfcGZuKHZtYSwgdmFkZHIsIHBmbik7Cj4gPiAr ICAgICAgICAgICAgIHJldCA9IHVuc2FmZV9mb2xsb3dfcGZuKHZtYSwgdmFkZHIsIHBmbik7Cj4g PiAgICAgICB9Cj4KPiBUaGlzIGlzIGFjdHVhbGx5IGJlaW5nIGNvbW1vbmx5IHVzZWQsIHNvIGl0 IG5lZWRzIGZpeGluZy4KPgo+IFdoZW4gSSB0YWxrZWQgdG8gQWxleCBhYm91dCB0aGlzIGxhc3Qg d2UgaGFkIHdvcmtlZCBvdXQgYSBwYXRjaCBzZXJpZXMKPiB0aGF0IGFkZHMgYSB0ZXN0IG9uIHZt X29wcyB0aGF0IHRoZSB2bWEgY2FtZSBmcm9tIHZmaW8gaW4gdGhlIGZpcnN0Cj4gcGxhY2UuIFRo ZSBWTUEncyBjcmVhdGVkIGJ5IFZGSU8gYXJlICdzYWZlJyBhcyB0aGUgUFRFcyBhcmUgbmV2ZXIg Y2hhbmdlZC4KCkhtLCBidXQgd291bGRuJ3QgbmVlZCB0aGF0IHRoZSBzZW1pLW5hc3R5IHZtYV9v cGVuIHRyaWNrIHRvIG1ha2Ugc3VyZQp0aGF0IHZtYSBkb2Vzbid0IHVudGltZWx5IGRpc2FwcGVh cj8gT3IgaXMgdGhlIGlkZWEgdG8gbG9vayB1cCB0aGUKdW5kZXJseWluZyB2ZmlvIG9iamVjdCwg YW5kIHJlZmNvdW50IHRoYXQgZGlyZWN0bHk/Ci1EYW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29m dHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=