From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] [RFC] drm/i915: Generate a hang error code Date: Tue, 4 Feb 2014 13:43:27 +0100 Message-ID: References: <1391516335-2723-1-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ig0-f182.google.com (mail-ig0-f182.google.com [209.85.213.182]) by gabe.freedesktop.org (Postfix) with ESMTP id D1051106793 for ; Tue, 4 Feb 2014 04:43:28 -0800 (PST) Received: by mail-ig0-f182.google.com with SMTP id uy17so7526419igb.3 for ; Tue, 04 Feb 2014 04:43:28 -0800 (PST) In-Reply-To: <1391516335-2723-1-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Tue, Feb 4, 2014 at 1:18 PM, Ben Widawsky wrote: > We get a large number of bugs which have a, "hey I have that too" > because they see a GPU hang in dmesg. While two machines of the same > model having a GPU hang is indeed a coincidence, it is far from enough > evidence to suggest they are the same. > > In order to reduce this effect, and hopefully get people to file new bug > reports, clearly the error message itself has been insufficient (see ref > at the bottom for a new bug report with this characteristic). > > The algorithm is purposely pretty naive. I don't think we need much in > order to avoid the problem I am trying to solve, and keeping it naive > gives us some ability to make a decent test case. > > Cc: Jesse Barnes > References: https://bugs.freedesktop.org/show_bug.cgi?id=73276 I think most of this can be avoided by actually renaming bugs to have sane summaries - of course people will go "me, too" if the summary is "ubuntu gpu hangs". For everything else I think if users aren't capable of the rather verbose "pls file new bug report, don't me-too" we dump into dmesg nothing else will help. And for developers it's imo better to smash such things into our error state decoder, similar to some of the other analysis steps we already do (like decoding the HEAD pointer). So not convinced really. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch