From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756316AbaGWKwx (ORCPT ); Wed, 23 Jul 2014 06:52:53 -0400 Received: from mail-ig0-f173.google.com ([209.85.213.173]:49580 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755342AbaGWKwv convert rfc822-to-8bit (ORCPT ); Wed, 23 Jul 2014 06:52:51 -0400 MIME-Version: 1.0 X-Originating-IP: [84.73.67.144] In-Reply-To: <53CF8AB1.2000009@amd.com> References: <20140709093124.11354.3774.stgit@patser> <53CE8A57.2000803@vodafone.de> <53CF58FB.8070609@canonical.com> <53CF5B9F.1050800@amd.com> <53CF5EFE.6070307@canonical.com> <53CF63C2.7070407@vodafone.de> <53CF6622.6060803@amd.com> <53CF699D.9070902@canonical.com> <53CF6B18.5070107@vodafone.de> <53CF7035.2060808@amd.com> <53CF7191.2090008@canonical.com> <53CF765E.7020802@vodafone.de> <53CF8010.9060809@amd.com> <53CF822E.7050601@amd.com> <53CF84C7.2020507@vodafone.de> <53CF8693.1040006@canonical.com> <53CF8AB1.2000009@amd.com> Date: Wed, 23 Jul 2014 12:52:50 +0200 Message-ID: Subject: Re: [Nouveau] [PATCH 09/17] drm/radeon: use common fence implementation for fences From: Daniel Vetter To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Maarten Lankhorst , =?UTF-8?Q?Christian_K=C3=B6nig?= , Thomas Hellstrom , nouveau , LKML , dri-devel , Ben Skeggs , "Deucher, Alexander" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 23, 2014 at 12:13 PM, Christian König wrote: > >> And the dma-buf would still have fences belonging to both drivers, and it >> would still call from outside the driver. > > > Calling from outside the driver is fine as long as the driver can do > everything necessary to complete it's work and isn't forced into any ugly > hacks and things that are not 100% reliable. > > So I don't see much other approach as integrating recovery code for not > firing interrupts and some kind of lockup handling into the fence code as > well. That approach doesn't really work at that well since every driver has it's own reset semantics. And we're trying to move away from global reset to fine-grained reset. So stop-the-world reset is out of fashion, at least for i915. As you said, reset is normal in gpus and we're trying to make reset less invasive. I really don't see a point in imposing a reset scheme upon all drivers and I think you have about as much motivation to convert radeon to the scheme used by i915 as I'll have for converting to the one used by radeon. If it would fit at all. I guess for radeon we just have to add tons of insulation by punting all callbacks to work items so that radeon can do whatever it wants. Plus start a delayed_work based fallback when ->enable_signalling is called to make sure we work on platforms that lack interrupts. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Nouveau] [PATCH 09/17] drm/radeon: use common fence implementation for fences Date: Wed, 23 Jul 2014 12:52:50 +0200 Message-ID: References: <20140709093124.11354.3774.stgit@patser> <53CE8A57.2000803@vodafone.de> <53CF58FB.8070609@canonical.com> <53CF5B9F.1050800@amd.com> <53CF5EFE.6070307@canonical.com> <53CF63C2.7070407@vodafone.de> <53CF6622.6060803@amd.com> <53CF699D.9070902@canonical.com> <53CF6B18.5070107@vodafone.de> <53CF7035.2060808@amd.com> <53CF7191.2090008@canonical.com> <53CF765E.7020802@vodafone.de> <53CF8010.9060809@amd.com> <53CF822E.7050601@amd.com> <53CF84C7.2020507@vodafone.de> <53CF8693.1040006@canonical.com> <53CF8AB1.2000009@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <53CF8AB1.2000009@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Thomas Hellstrom , nouveau , LKML , dri-devel , "Deucher, Alexander" , Ben Skeggs List-Id: nouveau.vger.kernel.org T24gV2VkLCBKdWwgMjMsIDIwMTQgYXQgMTI6MTMgUE0sIENocmlzdGlhbiBLw7ZuaWcKPGNocmlz dGlhbi5rb2VuaWdAYW1kLmNvbT4gd3JvdGU6Cj4KPj4gQW5kIHRoZSBkbWEtYnVmIHdvdWxkIHN0 aWxsIGhhdmUgZmVuY2VzIGJlbG9uZ2luZyB0byBib3RoIGRyaXZlcnMsIGFuZCBpdAo+PiB3b3Vs ZCBzdGlsbCBjYWxsIGZyb20gb3V0c2lkZSB0aGUgZHJpdmVyLgo+Cj4KPiBDYWxsaW5nIGZyb20g b3V0c2lkZSB0aGUgZHJpdmVyIGlzIGZpbmUgYXMgbG9uZyBhcyB0aGUgZHJpdmVyIGNhbiBkbwo+ IGV2ZXJ5dGhpbmcgbmVjZXNzYXJ5IHRvIGNvbXBsZXRlIGl0J3Mgd29yayBhbmQgaXNuJ3QgZm9y Y2VkIGludG8gYW55IHVnbHkKPiBoYWNrcyBhbmQgdGhpbmdzIHRoYXQgYXJlIG5vdCAxMDAlIHJl bGlhYmxlLgo+Cj4gU28gSSBkb24ndCBzZWUgbXVjaCBvdGhlciBhcHByb2FjaCBhcyBpbnRlZ3Jh dGluZyByZWNvdmVyeSBjb2RlIGZvciBub3QKPiBmaXJpbmcgaW50ZXJydXB0cyBhbmQgc29tZSBr aW5kIG9mIGxvY2t1cCBoYW5kbGluZyBpbnRvIHRoZSBmZW5jZSBjb2RlIGFzCj4gd2VsbC4KClRo YXQgYXBwcm9hY2ggZG9lc24ndCByZWFsbHkgd29yayBhdCB0aGF0IHdlbGwgc2luY2UgZXZlcnkg ZHJpdmVyIGhhcwppdCdzIG93biByZXNldCBzZW1hbnRpY3MuIEFuZCB3ZSdyZSB0cnlpbmcgdG8g bW92ZSBhd2F5IGZyb20gZ2xvYmFsCnJlc2V0IHRvIGZpbmUtZ3JhaW5lZCByZXNldC4gU28gc3Rv cC10aGUtd29ybGQgcmVzZXQgaXMgb3V0IG9mCmZhc2hpb24sIGF0IGxlYXN0IGZvciBpOTE1LiBB cyB5b3Ugc2FpZCwgcmVzZXQgaXMgbm9ybWFsIGluIGdwdXMgYW5kCndlJ3JlIHRyeWluZyB0byBt YWtlIHJlc2V0IGxlc3MgaW52YXNpdmUuIEkgcmVhbGx5IGRvbid0IHNlZSBhIHBvaW50CmluIGlt cG9zaW5nIGEgcmVzZXQgc2NoZW1lIHVwb24gYWxsIGRyaXZlcnMgYW5kIEkgdGhpbmsgeW91IGhh dmUgYWJvdXQKYXMgbXVjaCBtb3RpdmF0aW9uIHRvIGNvbnZlcnQgcmFkZW9uIHRvIHRoZSBzY2hl bWUgdXNlZCBieSBpOTE1IGFzCkknbGwgaGF2ZSBmb3IgY29udmVydGluZyB0byB0aGUgb25lIHVz ZWQgYnkgcmFkZW9uLiBJZiBpdCB3b3VsZCBmaXQgYXQKYWxsLgoKSSBndWVzcyBmb3IgcmFkZW9u IHdlIGp1c3QgaGF2ZSB0byBhZGQgdG9ucyBvZiBpbnN1bGF0aW9uIGJ5IHB1bnRpbmcKYWxsIGNh bGxiYWNrcyB0byB3b3JrIGl0ZW1zIHNvIHRoYXQgcmFkZW9uIGNhbiBkbyB3aGF0ZXZlciBpdCB3 YW50cy4KUGx1cyBzdGFydCBhIGRlbGF5ZWRfd29yayBiYXNlZCBmYWxsYmFjayB3aGVuIC0+ZW5h YmxlX3NpZ25hbGxpbmcgaXMKY2FsbGVkIHRvIG1ha2Ugc3VyZSB3ZSB3b3JrIG9uIHBsYXRmb3Jt cyB0aGF0IGxhY2sgaW50ZXJydXB0cy4KLURhbmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2Fy ZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KKzQxICgwKSA3OSAzNjUgNTcgNDggLSBodHRw Oi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo=