From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D0B3C41604 for ; Wed, 7 Oct 2020 21:32:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 50EA32083B for ; Wed, 7 Oct 2020 21:32:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="EsRG22Ae" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728803AbgJGVcj (ORCPT ); Wed, 7 Oct 2020 17:32:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728782AbgJGVce (ORCPT ); Wed, 7 Oct 2020 17:32:34 -0400 Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32D4FC0613D6 for ; Wed, 7 Oct 2020 14:32:16 -0700 (PDT) Received: by mail-ot1-x343.google.com with SMTP id i12so3665323ota.5 for ; Wed, 07 Oct 2020 14:32:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=01I5VHKcQ0Dg84F8780Uou6AbP019yNjabrXwkN3FWI=; b=EsRG22Aeif0x7Fbzs6uS7UAW1oFsXuKdkNN+DciLkMByiGR6/7rpuHQHKW6/AYGkAn zrXGNaV+G01Fb5dYxCysglSq8utf14bdInT6jX9GxymWnqFGPIlDsp8egMegVyGA9tVd bezdfQ1dOo3mL3oMRvpHXhZ6JlfgpDfbq6e/M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=01I5VHKcQ0Dg84F8780Uou6AbP019yNjabrXwkN3FWI=; b=e0V2yo3adcGpJxAb4xC4Uc5lH8biws9251UN7uU/14CxTeq+J8llrHI+vD8adeg9DA fFutOR8MBWSIwHJ8k5iNjDgEdw14aVo0aF4EiRtnNrb53Z3EqcYeSxY5UvBT4dsCbcXW U0/a/tgVnb5D64RdJYpaKDBDKlTuw9SvTZBpsGdwwS7fbhJRQPpsDQ0frkSr1YgSZE30 OscEdRmVk4s/Yt6n/YDhZwXTwIembOLSbK82Dkq14SRpuQabCmG0lxxHmssGDOh3N8Km yNRE5sIBbovr7odHZsoj5TLkq1txO7rLmA8sUhXHRsn/McaN9gmQplCqUD4UakJ3q2pR 2UZg== X-Gm-Message-State: AOAM530c4GtdVemu6DMaAmZlzqRfk4RVbE48YR8GIGS6tBNFbr4jVBQg MYkl+Bq+Kn5mdza9z+AgFEc/8fnrETG3J2sVm15DWQ== X-Google-Smtp-Source: ABdhPJzxWMICpxSHWZnAhfWjQXFxsNyJBAQQUSj60l2wem5bqozDzlbaSID7bj3+IM7C+O1TUPt7xYaFL4y/8poAm3Q= X-Received: by 2002:a05:6830:1e56:: with SMTP id e22mr2944031otj.303.1602106335551; Wed, 07 Oct 2020 14:32:15 -0700 (PDT) MIME-Version: 1.0 References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch> <20201007164426.1812530-2-daniel.vetter@ffwll.ch> <80718789-b3de-c30a-03c5-7c8cbf41f7d9@nvidia.com> In-Reply-To: <80718789-b3de-c30a-03c5-7c8cbf41f7d9@nvidia.com> From: Daniel Vetter Date: Wed, 7 Oct 2020 23:32:04 +0200 Message-ID: Subject: Re: [PATCH 01/13] drm/exynos: Stop using frame_vector helpers To: John Hubbard Cc: DRI Development , LKML , kvm@vger.kernel.org, Linux MM , Linux ARM , linux-samsung-soc , "open list:DMA BUFFER SHARING FRAMEWORK" , linux-s390@vger.kernel.org, Daniel Vetter , Jason Gunthorpe , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , Andrew Morton , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jan Kara , Dan Williams Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 7, 2020 at 10:33 PM John Hubbard wrote: > > On 10/7/20 9:44 AM, Daniel Vetter wrote: > > All we need are a pages array, pin_user_pages_fast can give us that > > directly. Plus this avoids the entire raw pfn side of get_vaddr_frames. > > > > Signed-off-by: Daniel Vetter > > Cc: Jason Gunthorpe > > Cc: Inki Dae > > Cc: Joonyoung Shim > > Cc: Seung-Woo Kim > > Cc: Kyungmin Park > > Cc: Kukjin Kim > > Cc: Krzysztof Kozlowski > > Cc: Andrew Morton > > Cc: John Hubbard > > Cc: J=C3=A9r=C3=B4me Glisse > > Cc: Jan Kara > > Cc: Dan Williams > > Cc: linux-mm@kvack.org > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-samsung-soc@vger.kernel.org > > Cc: linux-media@vger.kernel.org > > --- > > drivers/gpu/drm/exynos/Kconfig | 1 - > > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 48 ++++++++++++------------= - > > 2 files changed, 22 insertions(+), 27 deletions(-) > > > > diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kc= onfig > > index 6417f374b923..43257ef3c09d 100644 > > --- a/drivers/gpu/drm/exynos/Kconfig > > +++ b/drivers/gpu/drm/exynos/Kconfig > > @@ -88,7 +88,6 @@ comment "Sub-drivers" > > config DRM_EXYNOS_G2D > > bool "G2D" > > depends on VIDEO_SAMSUNG_S5P_G2D=3Dn || COMPILE_TEST > > - select FRAME_VECTOR > > help > > Choose this option if you want to use Exynos G2D for DRM. > > > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/= exynos/exynos_drm_g2d.c > > index 967a5cdc120e..c83f6faac9de 100644 > > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c > > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > > @@ -205,7 +205,8 @@ struct g2d_cmdlist_userptr { > > dma_addr_t dma_addr; > > unsigned long userptr; > > unsigned long size; > > - struct frame_vector *vec; > > + struct page **pages; > > + unsigned int npages; > > struct sg_table *sgt; > > atomic_t refcount; > > bool in_pool; > > @@ -378,7 +379,7 @@ static void g2d_userptr_put_dma_addr(struct g2d_dat= a *g2d, > > bool force) > > { > > struct g2d_cmdlist_userptr *g2d_userptr =3D obj; > > - struct page **pages; > > + int i; > > The above line can also be deleted, see below. > > > > > if (!obj) > > return; > > @@ -398,15 +399,11 @@ static void g2d_userptr_put_dma_addr(struct g2d_d= ata *g2d, > > dma_unmap_sgtable(to_dma_dev(g2d->drm_dev), g2d_userptr->sgt, > > DMA_BIDIRECTIONAL, 0); > > > > - pages =3D frame_vector_pages(g2d_userptr->vec); > > - if (!IS_ERR(pages)) { > > - int i; > > + for (i =3D 0; i < g2d_userptr->npages; i++) > > + set_page_dirty_lock(g2d_userptr->pages[i]); > > > > - for (i =3D 0; i < frame_vector_count(g2d_userptr->vec); i= ++) > > - set_page_dirty_lock(pages[i]); > > - } > > - put_vaddr_frames(g2d_userptr->vec); > > - frame_vector_destroy(g2d_userptr->vec); > > + unpin_user_pages(g2d_userptr->pages, g2d_userptr->npages); > > + kvfree(g2d_userptr->pages); > > You can avoid writing your own loop, and just simplify the whole thing do= wn to > two lines: > > unpin_user_pages_dirty_lock(g2d_userptr->pages, g2d_userptr->npag= es, > true); > kvfree(g2d_userptr->pages); Oh nice, this is neat. I'll also roll it out in the habanalabs patch, that has the same thing. Well almost, it only uses set_page_dirty, not the _lock variant. But I have no idea whether that matters or not? -Daniel > > > > > > if (!g2d_userptr->out_of_list) > > list_del_init(&g2d_userptr->list); > > @@ -474,35 +471,34 @@ static dma_addr_t *g2d_userptr_get_dma_addr(struc= t g2d_data *g2d, > > offset =3D userptr & ~PAGE_MASK; > > end =3D PAGE_ALIGN(userptr + size); > > npages =3D (end - start) >> PAGE_SHIFT; > > - g2d_userptr->vec =3D frame_vector_create(npages); > > - if (!g2d_userptr->vec) { > > + g2d_userptr->pages =3D kvmalloc_array(npages, sizeof(*g2d_userptr= ->pages), > > + GFP_KERNEL); > > + if (!g2d_userptr->pages) { > > ret =3D -ENOMEM; > > goto err_free; > > } > > > > - ret =3D get_vaddr_frames(start, npages, FOLL_FORCE | FOLL_WRITE, > > - g2d_userptr->vec); > > + ret =3D pin_user_pages_fast(start, npages, FOLL_FORCE | FOLL_WRIT= E, > > + g2d_userptr->pages); > > if (ret !=3D npages) { > > DRM_DEV_ERROR(g2d->dev, > > "failed to get user pages from userptr.\n")= ; > > if (ret < 0) > > - goto err_destroy_framevec; > > - ret =3D -EFAULT; > > - goto err_put_framevec; > > - } > > - if (frame_vector_to_pages(g2d_userptr->vec) < 0) { > > + goto err_destroy_pages; > > + npages =3D ret; > > ret =3D -EFAULT; > > - goto err_put_framevec; > > + goto err_unpin_pages; > > } > > + g2d_userptr->npages =3D npages; > > > > sgt =3D kzalloc(sizeof(*sgt), GFP_KERNEL); > > if (!sgt) { > > ret =3D -ENOMEM; > > - goto err_put_framevec; > > + goto err_unpin_pages; > > } > > > > ret =3D sg_alloc_table_from_pages(sgt, > > - frame_vector_pages(g2d_userptr->v= ec), > > + g2d_userptr->pages, > > npages, offset, size, GFP_KERNEL)= ; > > if (ret < 0) { > > DRM_DEV_ERROR(g2d->dev, "failed to get sgt from pages.\n"= ); > > @@ -538,11 +534,11 @@ static dma_addr_t *g2d_userptr_get_dma_addr(struc= t g2d_data *g2d, > > err_free_sgt: > > kfree(sgt); > > > > -err_put_framevec: > > - put_vaddr_frames(g2d_userptr->vec); > > +err_unpin_pages: > > + unpin_user_pages(g2d_userptr->pages, npages); > > > > -err_destroy_framevec: > > - frame_vector_destroy(g2d_userptr->vec); > > +err_destroy_pages: > > + kvfree(g2d_userptr->pages); > > > > err_free: > > kfree(g2d_userptr); > > > > The rest all looks good, you've avoided the usual API pitfalls. :) > > thanks, > -- > John Hubbard > NVIDIA --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08D20C4363D for ; Wed, 7 Oct 2020 21:33:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DE392083B for ; Wed, 7 Oct 2020 21:33:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="L5APxWG8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="EsRG22Ae" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DE392083B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=y2gryagw/0l17bbJKWLcBcknjw7YIDyem/hdKDh6uvk=; b=L5APxWG8gPhRgVeuVOUMR2qEX fLDhY2+uk+jMJnQybvf8Wp1zh6kJoT58qsvDZgJRp9Cve8pysfb0YdloUp8x702RbdyGs2ntEMpNy vL4ESO/cl3eeJje/sjb4BN5juhZmfxaCK6R5BlAR/D1b03m7GwMNLltUXZKndEL7EmLLLnJsaJ71y oj0nW+pAwVImcEi6hY/RlX+nVmCUcjWlPRElt+Boq+VJRzk6QQC8t8N795om/I0ISHsiktRNbP0HM siRFCAi6pYvEVewdai8zjvcGyYGGO/Z3BGP+XQbE6UgjdUipjHHCgYwCdicxcKOzaB5q6p513Ylha zMJItT1HA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQH2r-000869-Iu; Wed, 07 Oct 2020 21:32:21 +0000 Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQH2n-00084r-E4 for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2020 21:32:18 +0000 Received: by mail-ot1-x341.google.com with SMTP id l4so3644055ota.7 for ; Wed, 07 Oct 2020 14:32:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=01I5VHKcQ0Dg84F8780Uou6AbP019yNjabrXwkN3FWI=; b=EsRG22Aeif0x7Fbzs6uS7UAW1oFsXuKdkNN+DciLkMByiGR6/7rpuHQHKW6/AYGkAn zrXGNaV+G01Fb5dYxCysglSq8utf14bdInT6jX9GxymWnqFGPIlDsp8egMegVyGA9tVd bezdfQ1dOo3mL3oMRvpHXhZ6JlfgpDfbq6e/M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=01I5VHKcQ0Dg84F8780Uou6AbP019yNjabrXwkN3FWI=; b=pNTGDgPKkgujuN90QDFNXfotprFe4QeKvLa4i5eCVCGQybqhiIhjalEGgdLQfDM4ae iyJqYRly90kNO0OVaHKoywGX4le7u7AYC890ABrXGRTo7oxQZB8y4/fuUYmRMwHYcKF2 bYGE8xINeDhOKANVPadCI8gpV3Q7tRhvTmb4YbY7p4n6dZRz0GbjmqAHClVkCHtw0C1y /CBKNSequ+7SyaXVI3xGAdPvyFJLk3ns8blyVdAQZ1IPAYITz17F1axrW2RSzvrXfXI0 VeybXqySrze1SUjfJbdBBAq4ufxR0EnxfKEiL28IGldnPVIQV2JhtWKYQNKfF+5aMu/G Ms9A== X-Gm-Message-State: AOAM532LvqTRZRlkaEwDV4ltwKHQfrBH4vJvcCTdW1OllFlnGD9rr4gS Dx7ktBhPFK10d3UymEu0ONvebEfIlokkHFYC2vC6iw== X-Google-Smtp-Source: ABdhPJzxWMICpxSHWZnAhfWjQXFxsNyJBAQQUSj60l2wem5bqozDzlbaSID7bj3+IM7C+O1TUPt7xYaFL4y/8poAm3Q= X-Received: by 2002:a05:6830:1e56:: with SMTP id e22mr2944031otj.303.1602106335551; Wed, 07 Oct 2020 14:32:15 -0700 (PDT) MIME-Version: 1.0 References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch> <20201007164426.1812530-2-daniel.vetter@ffwll.ch> <80718789-b3de-c30a-03c5-7c8cbf41f7d9@nvidia.com> In-Reply-To: <80718789-b3de-c30a-03c5-7c8cbf41f7d9@nvidia.com> From: Daniel Vetter Date: Wed, 7 Oct 2020 23:32:04 +0200 Message-ID: Subject: Re: [PATCH 01/13] drm/exynos: Stop using frame_vector helpers To: John Hubbard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201007_173217_501072_D61BC149 X-CRM114-Status: GOOD ( 31.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , linux-s390@vger.kernel.org, linux-samsung-soc , Jan Kara , Joonyoung Shim , kvm@vger.kernel.org, Jason Gunthorpe , Seung-Woo Kim , LKML , DRI Development , Inki Dae , Linux MM , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , Daniel Vetter , Andrew Morton , Dan Williams , Linux ARM , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBPY3QgNywgMjAyMCBhdCAxMDozMyBQTSBKb2huIEh1YmJhcmQgPGpodWJiYXJkQG52 aWRpYS5jb20+IHdyb3RlOgo+Cj4gT24gMTAvNy8yMCA5OjQ0IEFNLCBEYW5pZWwgVmV0dGVyIHdy b3RlOgo+ID4gQWxsIHdlIG5lZWQgYXJlIGEgcGFnZXMgYXJyYXksIHBpbl91c2VyX3BhZ2VzX2Zh c3QgY2FuIGdpdmUgdXMgdGhhdAo+ID4gZGlyZWN0bHkuIFBsdXMgdGhpcyBhdm9pZHMgdGhlIGVu dGlyZSByYXcgcGZuIHNpZGUgb2YgZ2V0X3ZhZGRyX2ZyYW1lcy4KPiA+Cj4gPiBTaWduZWQtb2Zm LWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KPiA+IENjOiBKYXNv biBHdW50aG9ycGUgPGpnZ0B6aWVwZS5jYT4KPiA+IENjOiBJbmtpIERhZSA8aW5raS5kYWVAc2Ft c3VuZy5jb20+Cj4gPiBDYzogSm9vbnlvdW5nIFNoaW0gPGp5MDkyMi5zaGltQHNhbXN1bmcuY29t Pgo+ID4gQ2M6IFNldW5nLVdvbyBLaW0gPHN3MDMxMi5raW1Ac2Ftc3VuZy5jb20+Cj4gPiBDYzog S3l1bmdtaW4gUGFyayA8a3l1bmdtaW4ucGFya0BzYW1zdW5nLmNvbT4KPiA+IENjOiBLdWtqaW4g S2ltIDxrZ2VuZUBrZXJuZWwub3JnPgo+ID4gQ2M6IEtyenlzenRvZiBLb3psb3dza2kgPGtyemtA a2VybmVsLm9yZz4KPiA+IENjOiBBbmRyZXcgTW9ydG9uIDxha3BtQGxpbnV4LWZvdW5kYXRpb24u b3JnPgo+ID4gQ2M6IEpvaG4gSHViYmFyZCA8amh1YmJhcmRAbnZpZGlhLmNvbT4KPiA+IENjOiBK w6lyw7RtZSBHbGlzc2UgPGpnbGlzc2VAcmVkaGF0LmNvbT4KPiA+IENjOiBKYW4gS2FyYSA8amFj a0BzdXNlLmN6Pgo+ID4gQ2M6IERhbiBXaWxsaWFtcyA8ZGFuLmoud2lsbGlhbXNAaW50ZWwuY29t Pgo+ID4gQ2M6IGxpbnV4LW1tQGt2YWNrLm9yZwo+ID4gQ2M6IGxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwo+ID4gQ2M6IGxpbnV4LXNhbXN1bmctc29jQHZnZXIua2VybmVsLm9y Zwo+ID4gQ2M6IGxpbnV4LW1lZGlhQHZnZXIua2VybmVsLm9yZwo+ID4gLS0tCj4gPiAgIGRyaXZl cnMvZ3B1L2RybS9leHlub3MvS2NvbmZpZyAgICAgICAgICB8ICAxIC0KPiA+ICAgZHJpdmVycy9n cHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2cyZC5jIHwgNDggKysrKysrKysrKysrLS0tLS0tLS0t LS0tLQo+ID4gICAyIGZpbGVzIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDI3IGRlbGV0aW9u cygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL0tjb25maWcg Yi9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL0tjb25maWcKPiA+IGluZGV4IDY0MTdmMzc0YjkyMy4u NDMyNTdlZjNjMDlkIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9LY29u ZmlnCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL0tjb25maWcKPiA+IEBAIC04OCw3 ICs4OCw2IEBAIGNvbW1lbnQgIlN1Yi1kcml2ZXJzIgo+ID4gICBjb25maWcgRFJNX0VYWU5PU19H MkQKPiA+ICAgICAgIGJvb2wgIkcyRCIKPiA+ICAgICAgIGRlcGVuZHMgb24gVklERU9fU0FNU1VO R19TNVBfRzJEPW4gfHwgQ09NUElMRV9URVNUCj4gPiAtICAgICBzZWxlY3QgRlJBTUVfVkVDVE9S Cj4gPiAgICAgICBoZWxwCj4gPiAgICAgICAgIENob29zZSB0aGlzIG9wdGlvbiBpZiB5b3Ugd2Fu dCB0byB1c2UgRXh5bm9zIEcyRCBmb3IgRFJNLgo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZzJkLmMgYi9kcml2ZXJzL2dwdS9kcm0vZXh5bm9z L2V4eW5vc19kcm1fZzJkLmMKPiA+IGluZGV4IDk2N2E1Y2RjMTIwZS4uYzgzZjZmYWFjOWRlIDEw MDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2cyZC5jCj4g PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZzJkLmMKPiA+IEBAIC0y MDUsNyArMjA1LDggQEAgc3RydWN0IGcyZF9jbWRsaXN0X3VzZXJwdHIgewo+ID4gICAgICAgZG1h X2FkZHJfdCAgICAgICAgICAgICAgZG1hX2FkZHI7Cj4gPiAgICAgICB1bnNpZ25lZCBsb25nICAg ICAgICAgICB1c2VycHRyOwo+ID4gICAgICAgdW5zaWduZWQgbG9uZyAgICAgICAgICAgc2l6ZTsK PiA+IC0gICAgIHN0cnVjdCBmcmFtZV92ZWN0b3IgICAgICp2ZWM7Cj4gPiArICAgICBzdHJ1Y3Qg cGFnZSAgICAgICAgICAgICAqKnBhZ2VzOwo+ID4gKyAgICAgdW5zaWduZWQgaW50ICAgICAgICAg ICAgbnBhZ2VzOwo+ID4gICAgICAgc3RydWN0IHNnX3RhYmxlICAgICAgICAgKnNndDsKPiA+ICAg ICAgIGF0b21pY190ICAgICAgICAgICAgICAgIHJlZmNvdW50Owo+ID4gICAgICAgYm9vbCAgICAg ICAgICAgICAgICAgICAgaW5fcG9vbDsKPiA+IEBAIC0zNzgsNyArMzc5LDcgQEAgc3RhdGljIHZv aWQgZzJkX3VzZXJwdHJfcHV0X2RtYV9hZGRyKHN0cnVjdCBnMmRfZGF0YSAqZzJkLAo+ID4gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBib29sIGZvcmNlKQo+ID4gICB7Cj4g PiAgICAgICBzdHJ1Y3QgZzJkX2NtZGxpc3RfdXNlcnB0ciAqZzJkX3VzZXJwdHIgPSBvYmo7Cj4g PiAtICAgICBzdHJ1Y3QgcGFnZSAqKnBhZ2VzOwo+ID4gKyAgICAgaW50IGk7Cj4KPiBUaGUgYWJv dmUgbGluZSBjYW4gYWxzbyBiZSBkZWxldGVkLCBzZWUgYmVsb3cuCj4KPiA+Cj4gPiAgICAgICBp ZiAoIW9iaikKPiA+ICAgICAgICAgICAgICAgcmV0dXJuOwo+ID4gQEAgLTM5OCwxNSArMzk5LDEx IEBAIHN0YXRpYyB2b2lkIGcyZF91c2VycHRyX3B1dF9kbWFfYWRkcihzdHJ1Y3QgZzJkX2RhdGEg KmcyZCwKPiA+ICAgICAgIGRtYV91bm1hcF9zZ3RhYmxlKHRvX2RtYV9kZXYoZzJkLT5kcm1fZGV2 KSwgZzJkX3VzZXJwdHItPnNndCwKPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIERNQV9CSURJ UkVDVElPTkFMLCAwKTsKPiA+Cj4gPiAtICAgICBwYWdlcyA9IGZyYW1lX3ZlY3Rvcl9wYWdlcyhn MmRfdXNlcnB0ci0+dmVjKTsKPiA+IC0gICAgIGlmICghSVNfRVJSKHBhZ2VzKSkgewo+ID4gLSAg ICAgICAgICAgICBpbnQgaTsKPiA+ICsgICAgIGZvciAoaSA9IDA7IGkgPCBnMmRfdXNlcnB0ci0+ bnBhZ2VzOyBpKyspCj4gPiArICAgICAgICAgICAgIHNldF9wYWdlX2RpcnR5X2xvY2soZzJkX3Vz ZXJwdHItPnBhZ2VzW2ldKTsKPiA+Cj4gPiAtICAgICAgICAgICAgIGZvciAoaSA9IDA7IGkgPCBm cmFtZV92ZWN0b3JfY291bnQoZzJkX3VzZXJwdHItPnZlYyk7IGkrKykKPiA+IC0gICAgICAgICAg ICAgICAgICAgICBzZXRfcGFnZV9kaXJ0eV9sb2NrKHBhZ2VzW2ldKTsKPiA+IC0gICAgIH0KPiA+ IC0gICAgIHB1dF92YWRkcl9mcmFtZXMoZzJkX3VzZXJwdHItPnZlYyk7Cj4gPiAtICAgICBmcmFt ZV92ZWN0b3JfZGVzdHJveShnMmRfdXNlcnB0ci0+dmVjKTsKPiA+ICsgICAgIHVucGluX3VzZXJf cGFnZXMoZzJkX3VzZXJwdHItPnBhZ2VzLCBnMmRfdXNlcnB0ci0+bnBhZ2VzKTsKPiA+ICsgICAg IGt2ZnJlZShnMmRfdXNlcnB0ci0+cGFnZXMpOwo+Cj4gWW91IGNhbiBhdm9pZCB3cml0aW5nIHlv dXIgb3duIGxvb3AsIGFuZCBqdXN0IHNpbXBsaWZ5IHRoZSB3aG9sZSB0aGluZyBkb3duIHRvCj4g dHdvIGxpbmVzOgo+Cj4gICAgICAgICB1bnBpbl91c2VyX3BhZ2VzX2RpcnR5X2xvY2soZzJkX3Vz ZXJwdHItPnBhZ2VzLCBnMmRfdXNlcnB0ci0+bnBhZ2VzLAo+ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHRydWUpOwo+ICAgICAgICAga3ZmcmVlKGcyZF91c2VycHRyLT5wYWdl cyk7CgpPaCBuaWNlLCB0aGlzIGlzIG5lYXQuIEknbGwgYWxzbyByb2xsIGl0IG91dCBpbiB0aGUg aGFiYW5hbGFicyBwYXRjaCwKdGhhdCBoYXMgdGhlIHNhbWUgdGhpbmcuIFdlbGwgYWxtb3N0LCBp dCBvbmx5IHVzZXMgc2V0X3BhZ2VfZGlydHksIG5vdAp0aGUgX2xvY2sgdmFyaWFudC4gQnV0IEkg aGF2ZSBubyBpZGVhIHdoZXRoZXIgdGhhdCBtYXR0ZXJzIG9yIG5vdD8KLURhbmllbAoKPgo+Cj4g Pgo+ID4gICAgICAgaWYgKCFnMmRfdXNlcnB0ci0+b3V0X29mX2xpc3QpCj4gPiAgICAgICAgICAg ICAgIGxpc3RfZGVsX2luaXQoJmcyZF91c2VycHRyLT5saXN0KTsKPiA+IEBAIC00NzQsMzUgKzQ3 MSwzNCBAQCBzdGF0aWMgZG1hX2FkZHJfdCAqZzJkX3VzZXJwdHJfZ2V0X2RtYV9hZGRyKHN0cnVj dCBnMmRfZGF0YSAqZzJkLAo+ID4gICAgICAgb2Zmc2V0ID0gdXNlcnB0ciAmIH5QQUdFX01BU0s7 Cj4gPiAgICAgICBlbmQgPSBQQUdFX0FMSUdOKHVzZXJwdHIgKyBzaXplKTsKPiA+ICAgICAgIG5w YWdlcyA9IChlbmQgLSBzdGFydCkgPj4gUEFHRV9TSElGVDsKPiA+IC0gICAgIGcyZF91c2VycHRy LT52ZWMgPSBmcmFtZV92ZWN0b3JfY3JlYXRlKG5wYWdlcyk7Cj4gPiAtICAgICBpZiAoIWcyZF91 c2VycHRyLT52ZWMpIHsKPiA+ICsgICAgIGcyZF91c2VycHRyLT5wYWdlcyA9IGt2bWFsbG9jX2Fy cmF5KG5wYWdlcywgc2l6ZW9mKCpnMmRfdXNlcnB0ci0+cGFnZXMpLAo+ID4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgR0ZQX0tFUk5FTCk7Cj4gPiArICAgICBpZiAo IWcyZF91c2VycHRyLT5wYWdlcykgewo+ID4gICAgICAgICAgICAgICByZXQgPSAtRU5PTUVNOwo+ ID4gICAgICAgICAgICAgICBnb3RvIGVycl9mcmVlOwo+ID4gICAgICAgfQo+ID4KPiA+IC0gICAg IHJldCA9IGdldF92YWRkcl9mcmFtZXMoc3RhcnQsIG5wYWdlcywgRk9MTF9GT1JDRSB8IEZPTExf V1JJVEUsCj4gPiAtICAgICAgICAgICAgIGcyZF91c2VycHRyLT52ZWMpOwo+ID4gKyAgICAgcmV0 ID0gcGluX3VzZXJfcGFnZXNfZmFzdChzdGFydCwgbnBhZ2VzLCBGT0xMX0ZPUkNFIHwgRk9MTF9X UklURSwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZzJkX3VzZXJwdHItPnBh Z2VzKTsKPiA+ICAgICAgIGlmIChyZXQgIT0gbnBhZ2VzKSB7Cj4gPiAgICAgICAgICAgICAgIERS TV9ERVZfRVJST1IoZzJkLT5kZXYsCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImZh aWxlZCB0byBnZXQgdXNlciBwYWdlcyBmcm9tIHVzZXJwdHIuXG4iKTsKPiA+ICAgICAgICAgICAg ICAgaWYgKHJldCA8IDApCj4gPiAtICAgICAgICAgICAgICAgICAgICAgZ290byBlcnJfZGVzdHJv eV9mcmFtZXZlYzsKPiA+IC0gICAgICAgICAgICAgcmV0ID0gLUVGQVVMVDsKPiA+IC0gICAgICAg ICAgICAgZ290byBlcnJfcHV0X2ZyYW1ldmVjOwo+ID4gLSAgICAgfQo+ID4gLSAgICAgaWYgKGZy YW1lX3ZlY3Rvcl90b19wYWdlcyhnMmRfdXNlcnB0ci0+dmVjKSA8IDApIHsKPiA+ICsgICAgICAg ICAgICAgICAgICAgICBnb3RvIGVycl9kZXN0cm95X3BhZ2VzOwo+ID4gKyAgICAgICAgICAgICBu cGFnZXMgPSByZXQ7Cj4gPiAgICAgICAgICAgICAgIHJldCA9IC1FRkFVTFQ7Cj4gPiAtICAgICAg ICAgICAgIGdvdG8gZXJyX3B1dF9mcmFtZXZlYzsKPiA+ICsgICAgICAgICAgICAgZ290byBlcnJf dW5waW5fcGFnZXM7Cj4gPiAgICAgICB9Cj4gPiArICAgICBnMmRfdXNlcnB0ci0+bnBhZ2VzID0g bnBhZ2VzOwo+ID4KPiA+ICAgICAgIHNndCA9IGt6YWxsb2Moc2l6ZW9mKCpzZ3QpLCBHRlBfS0VS TkVMKTsKPiA+ICAgICAgIGlmICghc2d0KSB7Cj4gPiAgICAgICAgICAgICAgIHJldCA9IC1FTk9N RU07Cj4gPiAtICAgICAgICAgICAgIGdvdG8gZXJyX3B1dF9mcmFtZXZlYzsKPiA+ICsgICAgICAg ICAgICAgZ290byBlcnJfdW5waW5fcGFnZXM7Cj4gPiAgICAgICB9Cj4gPgo+ID4gICAgICAgcmV0 ID0gc2dfYWxsb2NfdGFibGVfZnJvbV9wYWdlcyhzZ3QsCj4gPiAtICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGZyYW1lX3ZlY3Rvcl9wYWdlcyhnMmRfdXNlcnB0ci0+dmVjKSwK PiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZzJkX3VzZXJwdHItPnBh Z2VzLAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBucGFnZXMsIG9m ZnNldCwgc2l6ZSwgR0ZQX0tFUk5FTCk7Cj4gPiAgICAgICBpZiAocmV0IDwgMCkgewo+ID4gICAg ICAgICAgICAgICBEUk1fREVWX0VSUk9SKGcyZC0+ZGV2LCAiZmFpbGVkIHRvIGdldCBzZ3QgZnJv bSBwYWdlcy5cbiIpOwo+ID4gQEAgLTUzOCwxMSArNTM0LDExIEBAIHN0YXRpYyBkbWFfYWRkcl90 ICpnMmRfdXNlcnB0cl9nZXRfZG1hX2FkZHIoc3RydWN0IGcyZF9kYXRhICpnMmQsCj4gPiAgIGVy cl9mcmVlX3NndDoKPiA+ICAgICAgIGtmcmVlKHNndCk7Cj4gPgo+ID4gLWVycl9wdXRfZnJhbWV2 ZWM6Cj4gPiAtICAgICBwdXRfdmFkZHJfZnJhbWVzKGcyZF91c2VycHRyLT52ZWMpOwo+ID4gK2Vy cl91bnBpbl9wYWdlczoKPiA+ICsgICAgIHVucGluX3VzZXJfcGFnZXMoZzJkX3VzZXJwdHItPnBh Z2VzLCBucGFnZXMpOwo+ID4KPiA+IC1lcnJfZGVzdHJveV9mcmFtZXZlYzoKPiA+IC0gICAgIGZy YW1lX3ZlY3Rvcl9kZXN0cm95KGcyZF91c2VycHRyLT52ZWMpOwo+ID4gK2Vycl9kZXN0cm95X3Bh Z2VzOgo+ID4gKyAgICAga3ZmcmVlKGcyZF91c2VycHRyLT5wYWdlcyk7Cj4gPgo+ID4gICBlcnJf ZnJlZToKPiA+ICAgICAgIGtmcmVlKGcyZF91c2VycHRyKTsKPiA+Cj4KPiBUaGUgcmVzdCBhbGwg bG9va3MgZ29vZCwgeW91J3ZlIGF2b2lkZWQgdGhlIHVzdWFsIEFQSSBwaXRmYWxscy4gOikKPgo+ IHRoYW5rcywKPiAtLQo+IEpvaG4gSHViYmFyZAo+IE5WSURJQQoKCgotLSAKRGFuaWVsIFZldHRl cgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwu Y2gKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFy bS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07242C4727F for ; Wed, 7 Oct 2020 21:32:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B896820872 for ; Wed, 7 Oct 2020 21:32:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="EsRG22Ae" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B896820872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B2F46E9B7; Wed, 7 Oct 2020 21:32:18 +0000 (UTC) Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C5B56E9B7 for ; Wed, 7 Oct 2020 21:32:16 +0000 (UTC) Received: by mail-ot1-x343.google.com with SMTP id d28so3687961ote.1 for ; Wed, 07 Oct 2020 14:32:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=01I5VHKcQ0Dg84F8780Uou6AbP019yNjabrXwkN3FWI=; b=EsRG22Aeif0x7Fbzs6uS7UAW1oFsXuKdkNN+DciLkMByiGR6/7rpuHQHKW6/AYGkAn zrXGNaV+G01Fb5dYxCysglSq8utf14bdInT6jX9GxymWnqFGPIlDsp8egMegVyGA9tVd bezdfQ1dOo3mL3oMRvpHXhZ6JlfgpDfbq6e/M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=01I5VHKcQ0Dg84F8780Uou6AbP019yNjabrXwkN3FWI=; b=Gq0ISHyGYedEzrkPS3CWBmQanICY2wilHw2Bx+eJDf5GPA/dMRNMkp5DBLyUPPMq3T vZlDImVOtcyw3jAxi2/IpovJAYT+4FggO/NSSIt37iUsKBqccEa4peZsiNQF/5A5hl94 A4TAhqQNBXhq4/Ftss+vw4Nh7McHf1zPX97DjAuQTXwy6MzTgpillqn8Z0TXY12s76so +1+yIMiuGSbIeEiKkBPA5sgtuaHWvg6gg5gwzG2y+0BBNc20ur8yfTkKgzplusGMA5sR CVI8uxua59kY8epfg6gVGbAPnSTAsmCs/LGaSRAvdpvXx0f/mzbFFTqRTWkUpWC0bEGi 6Zgg== X-Gm-Message-State: AOAM533mtt7yvHotyEK16PtGlELavVMtrqBqNVm5eZ7A5PPvg977YBbw f8EoxN9evYYrjCzv81/OPUm9HH5BoeAV/g7nE7R0Zw== X-Google-Smtp-Source: ABdhPJzxWMICpxSHWZnAhfWjQXFxsNyJBAQQUSj60l2wem5bqozDzlbaSID7bj3+IM7C+O1TUPt7xYaFL4y/8poAm3Q= X-Received: by 2002:a05:6830:1e56:: with SMTP id e22mr2944031otj.303.1602106335551; Wed, 07 Oct 2020 14:32:15 -0700 (PDT) MIME-Version: 1.0 References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch> <20201007164426.1812530-2-daniel.vetter@ffwll.ch> <80718789-b3de-c30a-03c5-7c8cbf41f7d9@nvidia.com> In-Reply-To: <80718789-b3de-c30a-03c5-7c8cbf41f7d9@nvidia.com> From: Daniel Vetter Date: Wed, 7 Oct 2020 23:32:04 +0200 Message-ID: Subject: Re: [PATCH 01/13] drm/exynos: Stop using frame_vector helpers To: John Hubbard X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , linux-s390@vger.kernel.org, linux-samsung-soc , Jan Kara , Joonyoung Shim , kvm@vger.kernel.org, Jason Gunthorpe , Seung-Woo Kim , LKML , DRI Development , Linux MM , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , Daniel Vetter , Andrew Morton , Dan Williams , Linux ARM , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCBPY3QgNywgMjAyMCBhdCAxMDozMyBQTSBKb2huIEh1YmJhcmQgPGpodWJiYXJkQG52 aWRpYS5jb20+IHdyb3RlOgo+Cj4gT24gMTAvNy8yMCA5OjQ0IEFNLCBEYW5pZWwgVmV0dGVyIHdy b3RlOgo+ID4gQWxsIHdlIG5lZWQgYXJlIGEgcGFnZXMgYXJyYXksIHBpbl91c2VyX3BhZ2VzX2Zh c3QgY2FuIGdpdmUgdXMgdGhhdAo+ID4gZGlyZWN0bHkuIFBsdXMgdGhpcyBhdm9pZHMgdGhlIGVu dGlyZSByYXcgcGZuIHNpZGUgb2YgZ2V0X3ZhZGRyX2ZyYW1lcy4KPiA+Cj4gPiBTaWduZWQtb2Zm LWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KPiA+IENjOiBKYXNv biBHdW50aG9ycGUgPGpnZ0B6aWVwZS5jYT4KPiA+IENjOiBJbmtpIERhZSA8aW5raS5kYWVAc2Ft c3VuZy5jb20+Cj4gPiBDYzogSm9vbnlvdW5nIFNoaW0gPGp5MDkyMi5zaGltQHNhbXN1bmcuY29t Pgo+ID4gQ2M6IFNldW5nLVdvbyBLaW0gPHN3MDMxMi5raW1Ac2Ftc3VuZy5jb20+Cj4gPiBDYzog S3l1bmdtaW4gUGFyayA8a3l1bmdtaW4ucGFya0BzYW1zdW5nLmNvbT4KPiA+IENjOiBLdWtqaW4g S2ltIDxrZ2VuZUBrZXJuZWwub3JnPgo+ID4gQ2M6IEtyenlzenRvZiBLb3psb3dza2kgPGtyemtA a2VybmVsLm9yZz4KPiA+IENjOiBBbmRyZXcgTW9ydG9uIDxha3BtQGxpbnV4LWZvdW5kYXRpb24u b3JnPgo+ID4gQ2M6IEpvaG4gSHViYmFyZCA8amh1YmJhcmRAbnZpZGlhLmNvbT4KPiA+IENjOiBK w6lyw7RtZSBHbGlzc2UgPGpnbGlzc2VAcmVkaGF0LmNvbT4KPiA+IENjOiBKYW4gS2FyYSA8amFj a0BzdXNlLmN6Pgo+ID4gQ2M6IERhbiBXaWxsaWFtcyA8ZGFuLmoud2lsbGlhbXNAaW50ZWwuY29t Pgo+ID4gQ2M6IGxpbnV4LW1tQGt2YWNrLm9yZwo+ID4gQ2M6IGxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwo+ID4gQ2M6IGxpbnV4LXNhbXN1bmctc29jQHZnZXIua2VybmVsLm9y Zwo+ID4gQ2M6IGxpbnV4LW1lZGlhQHZnZXIua2VybmVsLm9yZwo+ID4gLS0tCj4gPiAgIGRyaXZl cnMvZ3B1L2RybS9leHlub3MvS2NvbmZpZyAgICAgICAgICB8ICAxIC0KPiA+ICAgZHJpdmVycy9n cHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2cyZC5jIHwgNDggKysrKysrKysrKysrLS0tLS0tLS0t LS0tLQo+ID4gICAyIGZpbGVzIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDI3IGRlbGV0aW9u cygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL0tjb25maWcg Yi9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL0tjb25maWcKPiA+IGluZGV4IDY0MTdmMzc0YjkyMy4u NDMyNTdlZjNjMDlkIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9LY29u ZmlnCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL0tjb25maWcKPiA+IEBAIC04OCw3 ICs4OCw2IEBAIGNvbW1lbnQgIlN1Yi1kcml2ZXJzIgo+ID4gICBjb25maWcgRFJNX0VYWU5PU19H MkQKPiA+ICAgICAgIGJvb2wgIkcyRCIKPiA+ICAgICAgIGRlcGVuZHMgb24gVklERU9fU0FNU1VO R19TNVBfRzJEPW4gfHwgQ09NUElMRV9URVNUCj4gPiAtICAgICBzZWxlY3QgRlJBTUVfVkVDVE9S Cj4gPiAgICAgICBoZWxwCj4gPiAgICAgICAgIENob29zZSB0aGlzIG9wdGlvbiBpZiB5b3Ugd2Fu dCB0byB1c2UgRXh5bm9zIEcyRCBmb3IgRFJNLgo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZzJkLmMgYi9kcml2ZXJzL2dwdS9kcm0vZXh5bm9z L2V4eW5vc19kcm1fZzJkLmMKPiA+IGluZGV4IDk2N2E1Y2RjMTIwZS4uYzgzZjZmYWFjOWRlIDEw MDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2cyZC5jCj4g PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZzJkLmMKPiA+IEBAIC0y MDUsNyArMjA1LDggQEAgc3RydWN0IGcyZF9jbWRsaXN0X3VzZXJwdHIgewo+ID4gICAgICAgZG1h X2FkZHJfdCAgICAgICAgICAgICAgZG1hX2FkZHI7Cj4gPiAgICAgICB1bnNpZ25lZCBsb25nICAg ICAgICAgICB1c2VycHRyOwo+ID4gICAgICAgdW5zaWduZWQgbG9uZyAgICAgICAgICAgc2l6ZTsK PiA+IC0gICAgIHN0cnVjdCBmcmFtZV92ZWN0b3IgICAgICp2ZWM7Cj4gPiArICAgICBzdHJ1Y3Qg cGFnZSAgICAgICAgICAgICAqKnBhZ2VzOwo+ID4gKyAgICAgdW5zaWduZWQgaW50ICAgICAgICAg ICAgbnBhZ2VzOwo+ID4gICAgICAgc3RydWN0IHNnX3RhYmxlICAgICAgICAgKnNndDsKPiA+ICAg ICAgIGF0b21pY190ICAgICAgICAgICAgICAgIHJlZmNvdW50Owo+ID4gICAgICAgYm9vbCAgICAg ICAgICAgICAgICAgICAgaW5fcG9vbDsKPiA+IEBAIC0zNzgsNyArMzc5LDcgQEAgc3RhdGljIHZv aWQgZzJkX3VzZXJwdHJfcHV0X2RtYV9hZGRyKHN0cnVjdCBnMmRfZGF0YSAqZzJkLAo+ID4gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBib29sIGZvcmNlKQo+ID4gICB7Cj4g PiAgICAgICBzdHJ1Y3QgZzJkX2NtZGxpc3RfdXNlcnB0ciAqZzJkX3VzZXJwdHIgPSBvYmo7Cj4g PiAtICAgICBzdHJ1Y3QgcGFnZSAqKnBhZ2VzOwo+ID4gKyAgICAgaW50IGk7Cj4KPiBUaGUgYWJv dmUgbGluZSBjYW4gYWxzbyBiZSBkZWxldGVkLCBzZWUgYmVsb3cuCj4KPiA+Cj4gPiAgICAgICBp ZiAoIW9iaikKPiA+ICAgICAgICAgICAgICAgcmV0dXJuOwo+ID4gQEAgLTM5OCwxNSArMzk5LDEx IEBAIHN0YXRpYyB2b2lkIGcyZF91c2VycHRyX3B1dF9kbWFfYWRkcihzdHJ1Y3QgZzJkX2RhdGEg KmcyZCwKPiA+ICAgICAgIGRtYV91bm1hcF9zZ3RhYmxlKHRvX2RtYV9kZXYoZzJkLT5kcm1fZGV2 KSwgZzJkX3VzZXJwdHItPnNndCwKPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIERNQV9CSURJ UkVDVElPTkFMLCAwKTsKPiA+Cj4gPiAtICAgICBwYWdlcyA9IGZyYW1lX3ZlY3Rvcl9wYWdlcyhn MmRfdXNlcnB0ci0+dmVjKTsKPiA+IC0gICAgIGlmICghSVNfRVJSKHBhZ2VzKSkgewo+ID4gLSAg ICAgICAgICAgICBpbnQgaTsKPiA+ICsgICAgIGZvciAoaSA9IDA7IGkgPCBnMmRfdXNlcnB0ci0+ bnBhZ2VzOyBpKyspCj4gPiArICAgICAgICAgICAgIHNldF9wYWdlX2RpcnR5X2xvY2soZzJkX3Vz ZXJwdHItPnBhZ2VzW2ldKTsKPiA+Cj4gPiAtICAgICAgICAgICAgIGZvciAoaSA9IDA7IGkgPCBm cmFtZV92ZWN0b3JfY291bnQoZzJkX3VzZXJwdHItPnZlYyk7IGkrKykKPiA+IC0gICAgICAgICAg ICAgICAgICAgICBzZXRfcGFnZV9kaXJ0eV9sb2NrKHBhZ2VzW2ldKTsKPiA+IC0gICAgIH0KPiA+ IC0gICAgIHB1dF92YWRkcl9mcmFtZXMoZzJkX3VzZXJwdHItPnZlYyk7Cj4gPiAtICAgICBmcmFt ZV92ZWN0b3JfZGVzdHJveShnMmRfdXNlcnB0ci0+dmVjKTsKPiA+ICsgICAgIHVucGluX3VzZXJf cGFnZXMoZzJkX3VzZXJwdHItPnBhZ2VzLCBnMmRfdXNlcnB0ci0+bnBhZ2VzKTsKPiA+ICsgICAg IGt2ZnJlZShnMmRfdXNlcnB0ci0+cGFnZXMpOwo+Cj4gWW91IGNhbiBhdm9pZCB3cml0aW5nIHlv dXIgb3duIGxvb3AsIGFuZCBqdXN0IHNpbXBsaWZ5IHRoZSB3aG9sZSB0aGluZyBkb3duIHRvCj4g dHdvIGxpbmVzOgo+Cj4gICAgICAgICB1bnBpbl91c2VyX3BhZ2VzX2RpcnR5X2xvY2soZzJkX3Vz ZXJwdHItPnBhZ2VzLCBnMmRfdXNlcnB0ci0+bnBhZ2VzLAo+ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHRydWUpOwo+ICAgICAgICAga3ZmcmVlKGcyZF91c2VycHRyLT5wYWdl cyk7CgpPaCBuaWNlLCB0aGlzIGlzIG5lYXQuIEknbGwgYWxzbyByb2xsIGl0IG91dCBpbiB0aGUg aGFiYW5hbGFicyBwYXRjaCwKdGhhdCBoYXMgdGhlIHNhbWUgdGhpbmcuIFdlbGwgYWxtb3N0LCBp dCBvbmx5IHVzZXMgc2V0X3BhZ2VfZGlydHksIG5vdAp0aGUgX2xvY2sgdmFyaWFudC4gQnV0IEkg aGF2ZSBubyBpZGVhIHdoZXRoZXIgdGhhdCBtYXR0ZXJzIG9yIG5vdD8KLURhbmllbAoKPgo+Cj4g Pgo+ID4gICAgICAgaWYgKCFnMmRfdXNlcnB0ci0+b3V0X29mX2xpc3QpCj4gPiAgICAgICAgICAg ICAgIGxpc3RfZGVsX2luaXQoJmcyZF91c2VycHRyLT5saXN0KTsKPiA+IEBAIC00NzQsMzUgKzQ3 MSwzNCBAQCBzdGF0aWMgZG1hX2FkZHJfdCAqZzJkX3VzZXJwdHJfZ2V0X2RtYV9hZGRyKHN0cnVj dCBnMmRfZGF0YSAqZzJkLAo+ID4gICAgICAgb2Zmc2V0ID0gdXNlcnB0ciAmIH5QQUdFX01BU0s7 Cj4gPiAgICAgICBlbmQgPSBQQUdFX0FMSUdOKHVzZXJwdHIgKyBzaXplKTsKPiA+ICAgICAgIG5w YWdlcyA9IChlbmQgLSBzdGFydCkgPj4gUEFHRV9TSElGVDsKPiA+IC0gICAgIGcyZF91c2VycHRy LT52ZWMgPSBmcmFtZV92ZWN0b3JfY3JlYXRlKG5wYWdlcyk7Cj4gPiAtICAgICBpZiAoIWcyZF91 c2VycHRyLT52ZWMpIHsKPiA+ICsgICAgIGcyZF91c2VycHRyLT5wYWdlcyA9IGt2bWFsbG9jX2Fy cmF5KG5wYWdlcywgc2l6ZW9mKCpnMmRfdXNlcnB0ci0+cGFnZXMpLAo+ID4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgR0ZQX0tFUk5FTCk7Cj4gPiArICAgICBpZiAo IWcyZF91c2VycHRyLT5wYWdlcykgewo+ID4gICAgICAgICAgICAgICByZXQgPSAtRU5PTUVNOwo+ ID4gICAgICAgICAgICAgICBnb3RvIGVycl9mcmVlOwo+ID4gICAgICAgfQo+ID4KPiA+IC0gICAg IHJldCA9IGdldF92YWRkcl9mcmFtZXMoc3RhcnQsIG5wYWdlcywgRk9MTF9GT1JDRSB8IEZPTExf V1JJVEUsCj4gPiAtICAgICAgICAgICAgIGcyZF91c2VycHRyLT52ZWMpOwo+ID4gKyAgICAgcmV0 ID0gcGluX3VzZXJfcGFnZXNfZmFzdChzdGFydCwgbnBhZ2VzLCBGT0xMX0ZPUkNFIHwgRk9MTF9X UklURSwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZzJkX3VzZXJwdHItPnBh Z2VzKTsKPiA+ICAgICAgIGlmIChyZXQgIT0gbnBhZ2VzKSB7Cj4gPiAgICAgICAgICAgICAgIERS TV9ERVZfRVJST1IoZzJkLT5kZXYsCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImZh aWxlZCB0byBnZXQgdXNlciBwYWdlcyBmcm9tIHVzZXJwdHIuXG4iKTsKPiA+ICAgICAgICAgICAg ICAgaWYgKHJldCA8IDApCj4gPiAtICAgICAgICAgICAgICAgICAgICAgZ290byBlcnJfZGVzdHJv eV9mcmFtZXZlYzsKPiA+IC0gICAgICAgICAgICAgcmV0ID0gLUVGQVVMVDsKPiA+IC0gICAgICAg ICAgICAgZ290byBlcnJfcHV0X2ZyYW1ldmVjOwo+ID4gLSAgICAgfQo+ID4gLSAgICAgaWYgKGZy YW1lX3ZlY3Rvcl90b19wYWdlcyhnMmRfdXNlcnB0ci0+dmVjKSA8IDApIHsKPiA+ICsgICAgICAg ICAgICAgICAgICAgICBnb3RvIGVycl9kZXN0cm95X3BhZ2VzOwo+ID4gKyAgICAgICAgICAgICBu cGFnZXMgPSByZXQ7Cj4gPiAgICAgICAgICAgICAgIHJldCA9IC1FRkFVTFQ7Cj4gPiAtICAgICAg ICAgICAgIGdvdG8gZXJyX3B1dF9mcmFtZXZlYzsKPiA+ICsgICAgICAgICAgICAgZ290byBlcnJf dW5waW5fcGFnZXM7Cj4gPiAgICAgICB9Cj4gPiArICAgICBnMmRfdXNlcnB0ci0+bnBhZ2VzID0g bnBhZ2VzOwo+ID4KPiA+ICAgICAgIHNndCA9IGt6YWxsb2Moc2l6ZW9mKCpzZ3QpLCBHRlBfS0VS TkVMKTsKPiA+ICAgICAgIGlmICghc2d0KSB7Cj4gPiAgICAgICAgICAgICAgIHJldCA9IC1FTk9N RU07Cj4gPiAtICAgICAgICAgICAgIGdvdG8gZXJyX3B1dF9mcmFtZXZlYzsKPiA+ICsgICAgICAg ICAgICAgZ290byBlcnJfdW5waW5fcGFnZXM7Cj4gPiAgICAgICB9Cj4gPgo+ID4gICAgICAgcmV0 ID0gc2dfYWxsb2NfdGFibGVfZnJvbV9wYWdlcyhzZ3QsCj4gPiAtICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGZyYW1lX3ZlY3Rvcl9wYWdlcyhnMmRfdXNlcnB0ci0+dmVjKSwK PiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZzJkX3VzZXJwdHItPnBh Z2VzLAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBucGFnZXMsIG9m ZnNldCwgc2l6ZSwgR0ZQX0tFUk5FTCk7Cj4gPiAgICAgICBpZiAocmV0IDwgMCkgewo+ID4gICAg ICAgICAgICAgICBEUk1fREVWX0VSUk9SKGcyZC0+ZGV2LCAiZmFpbGVkIHRvIGdldCBzZ3QgZnJv bSBwYWdlcy5cbiIpOwo+ID4gQEAgLTUzOCwxMSArNTM0LDExIEBAIHN0YXRpYyBkbWFfYWRkcl90 ICpnMmRfdXNlcnB0cl9nZXRfZG1hX2FkZHIoc3RydWN0IGcyZF9kYXRhICpnMmQsCj4gPiAgIGVy cl9mcmVlX3NndDoKPiA+ICAgICAgIGtmcmVlKHNndCk7Cj4gPgo+ID4gLWVycl9wdXRfZnJhbWV2 ZWM6Cj4gPiAtICAgICBwdXRfdmFkZHJfZnJhbWVzKGcyZF91c2VycHRyLT52ZWMpOwo+ID4gK2Vy cl91bnBpbl9wYWdlczoKPiA+ICsgICAgIHVucGluX3VzZXJfcGFnZXMoZzJkX3VzZXJwdHItPnBh Z2VzLCBucGFnZXMpOwo+ID4KPiA+IC1lcnJfZGVzdHJveV9mcmFtZXZlYzoKPiA+IC0gICAgIGZy YW1lX3ZlY3Rvcl9kZXN0cm95KGcyZF91c2VycHRyLT52ZWMpOwo+ID4gK2Vycl9kZXN0cm95X3Bh Z2VzOgo+ID4gKyAgICAga3ZmcmVlKGcyZF91c2VycHRyLT5wYWdlcyk7Cj4gPgo+ID4gICBlcnJf ZnJlZToKPiA+ICAgICAgIGtmcmVlKGcyZF91c2VycHRyKTsKPiA+Cj4KPiBUaGUgcmVzdCBhbGwg bG9va3MgZ29vZCwgeW91J3ZlIGF2b2lkZWQgdGhlIHVzdWFsIEFQSSBwaXRmYWxscy4gOikKPgo+ IHRoYW5rcywKPiAtLQo+IEpvaG4gSHViYmFyZAo+IE5WSURJQQoKCgotLSAKRGFuaWVsIFZldHRl cgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwu Y2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==