From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752262AbdGDSML (ORCPT ); Tue, 4 Jul 2017 14:12:11 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:33460 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752162AbdGDSMJ (ORCPT ); Tue, 4 Jul 2017 14:12:09 -0400 MIME-Version: 1.0 X-Originating-IP: [2a02:168:5640:0:960b:2678:e223:c1c6] In-Reply-To: References: <1498057734-14622-1-git-send-email-daniel.vetter@ffwll.ch> <149805863799.15021.15278760577807511996@mail.alporthouse.com> <20170626161630.u4ubdzgxr37o63ip@phenom.ffwll.local> <20170629102559.al74da7xhcdpahbb@phenom.ffwll.local> From: Daniel Vetter Date: Tue, 4 Jul 2017 20:12:08 +0200 X-Google-Sender-Auth: KRJEvIIEM1x6DhcOWZJxn1q-qeo Message-ID: Subject: Re: [PATCH] BUG-REPORT: snd-hda: hacked-together EPROBE_DEFER support To: Takashi Iwai Cc: Chris Wilson , Intel Graphics Development , Guneshwor Singh , Hardik T Shah , Libin Yang , "Subhransu S. Prusty" , Vinod Koul , Julia Lawall , Jaroslav Kysela , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 4, 2017 at 5:28 PM, Takashi Iwai wrote: > On Tue, 04 Jul 2017 17:14:39 +0200, > Daniel Vetter wrote: >> On Thu, Jun 29, 2017 at 12:25 PM, Daniel Vetter wrote: >> >> Now I took a closer look, and this appears rather like a brown paper >> >> bag bug, not about the deferred probe or module dependency. >> >> The fix patch is below. Could you check whether it works? >> > >> > Yay, this works! >> > >> > Tested-by: Daniel Vetter >> >> Next one: i915 module reloading is broken because something is holding >> onto a module reference and doesn't drop it. Didn't check which sets >> of patches introduced this, but iirc this worked last week. Disabling >> hda-intel gets in Kconfig gets rid of the problem, so I assume >> something in the sound driver is leaking that reference ... >> >> It's also causing lots and lots of red in our CI :( If we can't fix >> this we need to disable snd-hda-intel there too. > > I spotted out a typo in my previous patch that leads to the module > reference unbalance. The fix is already in sound.git tree today: > https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?h=for-linus&id=fc18282cdcba984ab89c74d7e844c10114ae0795 > > The bug was introduced after 4.12. Ok, CI over here confirmed that it's all good again. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] BUG-REPORT: snd-hda: hacked-together EPROBE_DEFER support Date: Tue, 4 Jul 2017 20:12:08 +0200 Message-ID: References: <1498057734-14622-1-git-send-email-daniel.vetter@ffwll.ch> <149805863799.15021.15278760577807511996@mail.alporthouse.com> <20170626161630.u4ubdzgxr37o63ip@phenom.ffwll.local> <20170629102559.al74da7xhcdpahbb@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id B8AAE6E332 for ; Tue, 4 Jul 2017 18:12:09 +0000 (UTC) Received: by mail-io0-x242.google.com with SMTP id 84so11929156iop.2 for ; Tue, 04 Jul 2017 11:12:09 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Takashi Iwai Cc: Vinod Koul , Hardik T Shah , Intel Graphics Development , Guneshwor Singh , Linux Kernel Mailing List , Julia Lawall , Jaroslav Kysela , "Subhransu S. Prusty" List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKdWwgNCwgMjAxNyBhdCA1OjI4IFBNLCBUYWthc2hpIEl3YWkgPHRpd2FpQHN1c2Uu ZGU+IHdyb3RlOgo+IE9uIFR1ZSwgMDQgSnVsIDIwMTcgMTc6MTQ6MzkgKzAyMDAsCj4gRGFuaWVs IFZldHRlciB3cm90ZToKPj4gT24gVGh1LCBKdW4gMjksIDIwMTcgYXQgMTI6MjUgUE0sIERhbmll bCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4gd3JvdGU6Cj4+ID4+IE5vdyBJIHRvb2sgYSBjbG9z ZXIgbG9vaywgYW5kIHRoaXMgYXBwZWFycyByYXRoZXIgbGlrZSBhIGJyb3duIHBhcGVyCj4+ID4+ IGJhZyBidWcsIG5vdCBhYm91dCB0aGUgZGVmZXJyZWQgcHJvYmUgb3IgbW9kdWxlIGRlcGVuZGVu Y3kuCj4+ID4+IFRoZSBmaXggcGF0Y2ggaXMgYmVsb3cuICBDb3VsZCB5b3UgY2hlY2sgd2hldGhl ciBpdCB3b3Jrcz8KPj4gPgo+PiA+IFlheSwgdGhpcyB3b3JrcyEKPj4gPgo+PiA+IFRlc3RlZC1i eTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPj4KPj4gTmV4dCBvbmU6 IGk5MTUgbW9kdWxlIHJlbG9hZGluZyBpcyBicm9rZW4gYmVjYXVzZSBzb21ldGhpbmcgaXMgaG9s ZGluZwo+PiBvbnRvIGEgbW9kdWxlIHJlZmVyZW5jZSBhbmQgZG9lc24ndCBkcm9wIGl0LiBEaWRu J3QgY2hlY2sgd2hpY2ggc2V0cwo+PiBvZiBwYXRjaGVzIGludHJvZHVjZWQgdGhpcywgYnV0IGlp cmMgdGhpcyB3b3JrZWQgbGFzdCB3ZWVrLiBEaXNhYmxpbmcKPj4gaGRhLWludGVsIGdldHMgaW4g S2NvbmZpZyBnZXRzIHJpZCBvZiB0aGUgcHJvYmxlbSwgc28gSSBhc3N1bWUKPj4gc29tZXRoaW5n IGluIHRoZSBzb3VuZCBkcml2ZXIgaXMgbGVha2luZyB0aGF0IHJlZmVyZW5jZSAuLi4KPj4KPj4g SXQncyBhbHNvIGNhdXNpbmcgbG90cyBhbmQgbG90cyBvZiByZWQgaW4gb3VyIENJIDooIElmIHdl IGNhbid0IGZpeAo+PiB0aGlzIHdlIG5lZWQgdG8gZGlzYWJsZSBzbmQtaGRhLWludGVsIHRoZXJl IHRvby4KPgo+IEkgc3BvdHRlZCBvdXQgYSB0eXBvIGluIG15IHByZXZpb3VzIHBhdGNoIHRoYXQg bGVhZHMgdG8gdGhlIG1vZHVsZQo+IHJlZmVyZW5jZSB1bmJhbGFuY2UuICBUaGUgZml4IGlzICBh bHJlYWR5IGluIHNvdW5kLmdpdCB0cmVlIHRvZGF5Ogo+ICAgaHR0cHM6Ly9naXQua2VybmVsLm9y Zy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvdGl3YWkvc291bmQuZ2l0L2NvbW1pdC8/aD1mb3It bGludXMmaWQ9ZmMxODI4MmNkY2JhOTg0YWI4OWM3NGQ3ZTg0NGMxMDExNGFlMDc5NQo+Cj4gVGhl IGJ1ZyB3YXMgaW50cm9kdWNlZCBhZnRlciA0LjEyLgoKT2ssIENJIG92ZXIgaGVyZSBjb25maXJt ZWQgdGhhdCBpdCdzIGFsbCBnb29kIGFnYWluLgoKVGhhbmtzLCBEYW5pZWwKLS0gCkRhbmllbCBW ZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCis0MSAoMCkgNzkgMzY1 IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg==