From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A21B7C4727E for ; Wed, 7 Oct 2020 21:30:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5487E20872 for ; Wed, 7 Oct 2020 21:30:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="BaAFboFh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728229AbgJGVaO (ORCPT ); Wed, 7 Oct 2020 17:30:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727798AbgJGVaN (ORCPT ); Wed, 7 Oct 2020 17:30:13 -0400 Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 531E6C061755 for ; Wed, 7 Oct 2020 14:30:13 -0700 (PDT) Received: by mail-ot1-x343.google.com with SMTP id e20so3195349otj.11 for ; Wed, 07 Oct 2020 14:30:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=nNtozmj/MGUZLHZxI3A6qXOhVAeMPho+2jjUlqwzPiY=; b=BaAFboFhzjSDkIsRiKkVY5HnY80F0qFikzkwGLzbiZiDPe/NeBFe6zpt+tRZBXwSlf cldboSnNlcSz1Qnd+/D1yNqcLjwz5qLQP01nnTJ9te1SLWuuX0nGjEu12aT61tF+abrF VMjcmWsESAMRsIG40QQOk22zLTky3pJD0lB9E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nNtozmj/MGUZLHZxI3A6qXOhVAeMPho+2jjUlqwzPiY=; b=HWJFxvVLsq+hncW61VGitwmFQAcWRfat5XD7lBTu63CRSkmW5DhCbYmdOaVLp8AZac CANmy1k4PgV11jMa0CFOg90KcYKOMn8NgW0haRFXcaaeIBQ8NJKUGV0Jt+6gReldkoWj ECB4qHWrSKo7JOyek6HZy6yKRO3uNfL+9heSTAAH+K1TPz3aF/wnUYJ33RCCZepe7WOu axONCWCRr5buNnCpzsZ1feW4gwHgbQETtaeexBoEUMzqcA0AZPE37ejQd34NVr/ZN/v8 HVhnfqD0iRMw5AFjr5Yt1EDvJgAX4wjfh8kE8eWNbdqoRLBeQL0ERDYaQIYCr1r5KHcH FNyA== X-Gm-Message-State: AOAM530a1jYdmQPrzp9oenalx2pFFgFvbL68DNmIOJkM+MRelkBvZPQX kA3HMYS4kQNC+tGiaWALxhHdTxHZp2gn7206vw/FJw== X-Google-Smtp-Source: ABdhPJzDIRAj53qXn+wCstFj7fFAXvpqHS6peJb8d7VCpx3oiEDiFkz29m0ZVMR9QW+s4BR0BiMsr7SeQunifX3iVl4= X-Received: by 2002:a05:6830:1e56:: with SMTP id e22mr2939594otj.303.1602106212518; Wed, 07 Oct 2020 14:30:12 -0700 (PDT) MIME-Version: 1.0 References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch> <20201007164426.1812530-6-daniel.vetter@ffwll.ch> In-Reply-To: From: Daniel Vetter Date: Wed, 7 Oct 2020 23:30:01 +0200 Message-ID: Subject: Re: [PATCH 05/13] mm/frame-vector: Use FOLL_LONGTERM To: John Hubbard , Dan Williams Cc: DRI Development , LKML , kvm@vger.kernel.org, Linux MM , Linux ARM , linux-samsung-soc , "open list:DMA BUFFER SHARING FRAMEWORK" , linux-s390@vger.kernel.org, Daniel Vetter , Jason Gunthorpe , Pawel Osciak , Marek Szyprowski , Kyungmin Park , Tomasz Figa , Mauro Carvalho Chehab , Andrew Morton , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jan Kara Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 7, 2020 at 11:13 PM John Hubbard wrote: > > On 10/7/20 9:44 AM, Daniel Vetter wrote: > > This is used by media/videbuf2 for persistent dma mappings, not just > > for a single dma operation and then freed again, so needs > > FOLL_LONGTERM. > > > > Unfortunately current pup_locked doesn't support FOLL_LONGTERM due to > > locking issues. Rework the code to pull the pup path out from the > > mmap_sem critical section as suggested by Jason. > > > > Signed-off-by: Daniel Vetter > > Cc: Jason Gunthorpe > > Cc: Pawel Osciak > > Cc: Marek Szyprowski > > Cc: Kyungmin Park > > Cc: Tomasz Figa > > Cc: Mauro Carvalho Chehab > > Cc: Andrew Morton > > Cc: John Hubbard > > Cc: J=C3=A9r=C3=B4me Glisse > > Cc: Jan Kara > > Cc: Dan Williams > > Cc: linux-mm@kvack.org > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-samsung-soc@vger.kernel.org > > Cc: linux-media@vger.kernel.org > > --- > > mm/frame_vector.c | 36 +++++++++++------------------------- > > 1 file changed, 11 insertions(+), 25 deletions(-) > > > > diff --git a/mm/frame_vector.c b/mm/frame_vector.c > > index 10f82d5643b6..39db520a51dc 100644 > > --- a/mm/frame_vector.c > > +++ b/mm/frame_vector.c > > @@ -38,7 +38,6 @@ int get_vaddr_frames(unsigned long start, unsigned in= t nr_frames, > > struct vm_area_struct *vma; > > int ret =3D 0; > > int err; > > - int locked; > > > > if (nr_frames =3D=3D 0) > > return 0; > > @@ -48,35 +47,22 @@ int get_vaddr_frames(unsigned long start, unsigned = int nr_frames, > > > > start =3D untagged_addr(start); > > > > + ret =3D pin_user_pages_fast(start, nr_frames, > > + FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM= , > > + (struct page **)(vec->ptrs)); > > + if (ret > 0) { > > + vec->got_ref =3D true; > > + vec->is_pfns =3D false; > > + goto out_unlocked; > > + } > > This part looks good, and changing to _fast is a potential performance im= provement, > too. > > > + > > mmap_read_lock(mm); > > - locked =3D 1; > > vma =3D find_vma_intersection(mm, start, start + 1); > > if (!vma) { > > ret =3D -EFAULT; > > goto out; > > } > > > > - /* > > - * While get_vaddr_frames() could be used for transient (kernel > > - * controlled lifetime) pinning of memory pages all current > > - * users establish long term (userspace controlled lifetime) > > - * page pinning. Treat get_vaddr_frames() like > > - * get_user_pages_longterm() and disallow it for filesystem-dax > > - * mappings. > > - */ > > - if (vma_is_fsdax(vma)) { > > - ret =3D -EOPNOTSUPP; > > - goto out; > > - } > > Are you sure we don't need to check vma_is_fsdax() anymore? Since FOLL_LONGTERM checks for this and can only return struct page backed memory, and explicitly excludes VM_IO | VM_PFNMAP, was assuming this is not needed for follow_pfn. And the get_user_pages_locked this used back then didn't have the same check, hence why it was added (and FOLL_LONGTERM still doesn't work for the _locked versions, as you pointed out on the last round of this discussion). But now that you're asking, I have no idea whether fsdax vma can also be of VM_IO | VM_PFNMAP type. I'm not seeing that set anywhere in fs/dax.c, but that says nothing :-) Dan, you added this check originally, do we need it for VM_SPECIAL vmas too= ? Thanks, Daniel > > > - > > - if (!(vma->vm_flags & (VM_IO | VM_PFNMAP))) { > > - vec->got_ref =3D true; > > - vec->is_pfns =3D false; > > - ret =3D pin_user_pages_locked(start, nr_frames, > > - gup_flags, (struct page **)(vec->ptrs), &locked); > > - goto out; > > - } > > - > > vec->got_ref =3D false; > > vec->is_pfns =3D true; > > do { > > @@ -101,8 +87,8 @@ int get_vaddr_frames(unsigned long start, unsigned i= nt nr_frames, > > vma =3D find_vma_intersection(mm, start, start + 1); > > } while (vma && vma->vm_flags & (VM_IO | VM_PFNMAP)); > > out: > > - if (locked) > > - mmap_read_unlock(mm); > > + mmap_read_unlock(mm); > > +out_unlocked: > > if (!ret) > > ret =3D -EFAULT; > > if (ret > 0) > > > > All of the error handling still looks accurate there. > > thanks, > -- > John Hubbard > NVIDIA --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B2ADC4727E for ; Wed, 7 Oct 2020 21:31:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2957D2075A for ; Wed, 7 Oct 2020 21:31:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="R9NBV3a8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="BaAFboFh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2957D2075A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yR92wObzM+Ey81EqhLeGGHh3U5vKQyPrjfNPFGIvcN4=; b=R9NBV3a8TNcZprAmkR6BTy15o R1atY+JfL0SctjVrpM/4QET++LQXk1maFo9vIhEk2fdyXYDLWUAHEnnPO76oREGxRacRaJclEa3Kq 8r1eSyZmqHNZVGMHdyOnvA8Wf9ZPnyD/pOjgNWK/iDigWrdNIOrVY7ifk9OKzZTd5+MypWu9j7DFN TE/46PJTbW7mY+6luF3ksbbfOUVC93zYb1V9UpMbxZhJrTwqOCdjKZ1GLyhk1f1im4CcU1oEWqZ7c 2tvoLukVKeJx0KHazcBv6smknRcjzhSHOxx1Y7NMwAy+A1NnUngr4MndNLOZvdZTDWd8LJCb7b+AY V27d/W43w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQH0t-0007u3-Dv; Wed, 07 Oct 2020 21:30:19 +0000 Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQH0p-0007t0-VM for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2020 21:30:17 +0000 Received: by mail-ot1-x342.google.com with SMTP id m13so3618773otl.9 for ; Wed, 07 Oct 2020 14:30:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=nNtozmj/MGUZLHZxI3A6qXOhVAeMPho+2jjUlqwzPiY=; b=BaAFboFhzjSDkIsRiKkVY5HnY80F0qFikzkwGLzbiZiDPe/NeBFe6zpt+tRZBXwSlf cldboSnNlcSz1Qnd+/D1yNqcLjwz5qLQP01nnTJ9te1SLWuuX0nGjEu12aT61tF+abrF VMjcmWsESAMRsIG40QQOk22zLTky3pJD0lB9E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nNtozmj/MGUZLHZxI3A6qXOhVAeMPho+2jjUlqwzPiY=; b=Za9gW1Fhnm33i5eCz0JMDggUS4EuTxe6NtXLb513bQZ1kg+g8vKSdll/67SjO9cmxd e8tmfuBkCiouJt0y+LscP/eMXNmUCtvVa9iyG/Ct1qJ6sUcvYsTWG6Jamox4CzBUVsS6 TYnrubAs8wH9iG9rNJ4gqkogS2eoytAZt2KJ6oA+X7EPQLwP2lghf7WgbVwGQS3pTmdJ SzJNQlNeMQNAk6JWJ47SHlB6B8TAtzIGBypJirLP+sCFA2uWw0PPh9p0T6YNldfHtALN F69+ppMNXh5QnMKx75+CMTaUJj0CFWuRyDDqq4HjgauUFYV8nvWk/AST/CzCYcYsdLdz PbIg== X-Gm-Message-State: AOAM531omf0/F+LNQBk52NJUvWf8L+BkcwpLd2fUpmrvtZOFd6BOWEZD Oqkt7BxIkPW6Syg+QugbQVtM/dEifqivVBaDSnegAQ== X-Google-Smtp-Source: ABdhPJzDIRAj53qXn+wCstFj7fFAXvpqHS6peJb8d7VCpx3oiEDiFkz29m0ZVMR9QW+s4BR0BiMsr7SeQunifX3iVl4= X-Received: by 2002:a05:6830:1e56:: with SMTP id e22mr2939594otj.303.1602106212518; Wed, 07 Oct 2020 14:30:12 -0700 (PDT) MIME-Version: 1.0 References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch> <20201007164426.1812530-6-daniel.vetter@ffwll.ch> In-Reply-To: From: Daniel Vetter Date: Wed, 7 Oct 2020 23:30:01 +0200 Message-ID: Subject: Re: [PATCH 05/13] mm/frame-vector: Use FOLL_LONGTERM To: John Hubbard , Dan Williams X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201007_173016_092841_31400EEF X-CRM114-Status: GOOD ( 29.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , linux-s390@vger.kernel.org, linux-samsung-soc , Jan Kara , Pawel Osciak , kvm@vger.kernel.org, Jason Gunthorpe , Mauro Carvalho Chehab , LKML , DRI Development , Tomasz Figa , Linux MM , Kyungmin Park , Daniel Vetter , Andrew Morton , Marek Szyprowski , Linux ARM , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBPY3QgNywgMjAyMCBhdCAxMToxMyBQTSBKb2huIEh1YmJhcmQgPGpodWJiYXJkQG52 aWRpYS5jb20+IHdyb3RlOgo+Cj4gT24gMTAvNy8yMCA5OjQ0IEFNLCBEYW5pZWwgVmV0dGVyIHdy b3RlOgo+ID4gVGhpcyBpcyB1c2VkIGJ5IG1lZGlhL3ZpZGVidWYyIGZvciBwZXJzaXN0ZW50IGRt YSBtYXBwaW5ncywgbm90IGp1c3QKPiA+IGZvciBhIHNpbmdsZSBkbWEgb3BlcmF0aW9uIGFuZCB0 aGVuIGZyZWVkIGFnYWluLCBzbyBuZWVkcwo+ID4gRk9MTF9MT05HVEVSTS4KPiA+Cj4gPiBVbmZv cnR1bmF0ZWx5IGN1cnJlbnQgcHVwX2xvY2tlZCBkb2Vzbid0IHN1cHBvcnQgRk9MTF9MT05HVEVS TSBkdWUgdG8KPiA+IGxvY2tpbmcgaXNzdWVzLiBSZXdvcmsgdGhlIGNvZGUgdG8gcHVsbCB0aGUg cHVwIHBhdGggb3V0IGZyb20gdGhlCj4gPiBtbWFwX3NlbSBjcml0aWNhbCBzZWN0aW9uIGFzIHN1 Z2dlc3RlZCBieSBKYXNvbi4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxk YW5pZWwudmV0dGVyQGludGVsLmNvbT4KPiA+IENjOiBKYXNvbiBHdW50aG9ycGUgPGpnZ0B6aWVw ZS5jYT4KPiA+IENjOiBQYXdlbCBPc2NpYWsgPHBhd2VsQG9zY2lhay5jb20+Cj4gPiBDYzogTWFy ZWsgU3p5cHJvd3NraSA8bS5zenlwcm93c2tpQHNhbXN1bmcuY29tPgo+ID4gQ2M6IEt5dW5nbWlu IFBhcmsgPGt5dW5nbWluLnBhcmtAc2Ftc3VuZy5jb20+Cj4gPiBDYzogVG9tYXN6IEZpZ2EgPHRm aWdhQGNocm9taXVtLm9yZz4KPiA+IENjOiBNYXVybyBDYXJ2YWxobyBDaGVoYWIgPG1jaGVoYWJA a2VybmVsLm9yZz4KPiA+IENjOiBBbmRyZXcgTW9ydG9uIDxha3BtQGxpbnV4LWZvdW5kYXRpb24u b3JnPgo+ID4gQ2M6IEpvaG4gSHViYmFyZCA8amh1YmJhcmRAbnZpZGlhLmNvbT4KPiA+IENjOiBK w6lyw7RtZSBHbGlzc2UgPGpnbGlzc2VAcmVkaGF0LmNvbT4KPiA+IENjOiBKYW4gS2FyYSA8amFj a0BzdXNlLmN6Pgo+ID4gQ2M6IERhbiBXaWxsaWFtcyA8ZGFuLmoud2lsbGlhbXNAaW50ZWwuY29t Pgo+ID4gQ2M6IGxpbnV4LW1tQGt2YWNrLm9yZwo+ID4gQ2M6IGxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwo+ID4gQ2M6IGxpbnV4LXNhbXN1bmctc29jQHZnZXIua2VybmVsLm9y Zwo+ID4gQ2M6IGxpbnV4LW1lZGlhQHZnZXIua2VybmVsLm9yZwo+ID4gLS0tCj4gPiAgIG1tL2Zy YW1lX3ZlY3Rvci5jIHwgMzYgKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4g PiAgIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAyNSBkZWxldGlvbnMoLSkKPiA+ Cj4gPiBkaWZmIC0tZ2l0IGEvbW0vZnJhbWVfdmVjdG9yLmMgYi9tbS9mcmFtZV92ZWN0b3IuYwo+ ID4gaW5kZXggMTBmODJkNTY0M2I2Li4zOWRiNTIwYTUxZGMgMTAwNjQ0Cj4gPiAtLS0gYS9tbS9m cmFtZV92ZWN0b3IuYwo+ID4gKysrIGIvbW0vZnJhbWVfdmVjdG9yLmMKPiA+IEBAIC0zOCw3ICsz OCw2IEBAIGludCBnZXRfdmFkZHJfZnJhbWVzKHVuc2lnbmVkIGxvbmcgc3RhcnQsIHVuc2lnbmVk IGludCBucl9mcmFtZXMsCj4gPiAgICAgICBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYTsKPiA+ ICAgICAgIGludCByZXQgPSAwOwo+ID4gICAgICAgaW50IGVycjsKPiA+IC0gICAgIGludCBsb2Nr ZWQ7Cj4gPgo+ID4gICAgICAgaWYgKG5yX2ZyYW1lcyA9PSAwKQo+ID4gICAgICAgICAgICAgICBy ZXR1cm4gMDsKPiA+IEBAIC00OCwzNSArNDcsMjIgQEAgaW50IGdldF92YWRkcl9mcmFtZXModW5z aWduZWQgbG9uZyBzdGFydCwgdW5zaWduZWQgaW50IG5yX2ZyYW1lcywKPiA+Cj4gPiAgICAgICBz dGFydCA9IHVudGFnZ2VkX2FkZHIoc3RhcnQpOwo+ID4KPiA+ICsgICAgIHJldCA9IHBpbl91c2Vy X3BhZ2VzX2Zhc3Qoc3RhcnQsIG5yX2ZyYW1lcywKPiA+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgRk9MTF9GT1JDRSB8IEZPTExfV1JJVEUgfCBGT0xMX0xPTkdURVJNLAo+ID4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoc3RydWN0IHBhZ2UgKiopKHZlYy0+cHRycykp Owo+ID4gKyAgICAgaWYgKHJldCA+IDApIHsKPiA+ICsgICAgICAgICAgICAgdmVjLT5nb3RfcmVm ID0gdHJ1ZTsKPiA+ICsgICAgICAgICAgICAgdmVjLT5pc19wZm5zID0gZmFsc2U7Cj4gPiArICAg ICAgICAgICAgIGdvdG8gb3V0X3VubG9ja2VkOwo+ID4gKyAgICAgfQo+Cj4gVGhpcyBwYXJ0IGxv b2tzIGdvb2QsIGFuZCBjaGFuZ2luZyB0byBfZmFzdCBpcyBhIHBvdGVudGlhbCBwZXJmb3JtYW5j ZSBpbXByb3ZlbWVudCwKPiB0b28uCj4KPiA+ICsKPiA+ICAgICAgIG1tYXBfcmVhZF9sb2NrKG1t KTsKPiA+IC0gICAgIGxvY2tlZCA9IDE7Cj4gPiAgICAgICB2bWEgPSBmaW5kX3ZtYV9pbnRlcnNl Y3Rpb24obW0sIHN0YXJ0LCBzdGFydCArIDEpOwo+ID4gICAgICAgaWYgKCF2bWEpIHsKPiA+ICAg ICAgICAgICAgICAgcmV0ID0gLUVGQVVMVDsKPiA+ICAgICAgICAgICAgICAgZ290byBvdXQ7Cj4g PiAgICAgICB9Cj4gPgo+ID4gLSAgICAgLyoKPiA+IC0gICAgICAqIFdoaWxlIGdldF92YWRkcl9m cmFtZXMoKSBjb3VsZCBiZSB1c2VkIGZvciB0cmFuc2llbnQgKGtlcm5lbAo+ID4gLSAgICAgICog Y29udHJvbGxlZCBsaWZldGltZSkgcGlubmluZyBvZiBtZW1vcnkgcGFnZXMgYWxsIGN1cnJlbnQK PiA+IC0gICAgICAqIHVzZXJzIGVzdGFibGlzaCBsb25nIHRlcm0gKHVzZXJzcGFjZSBjb250cm9s bGVkIGxpZmV0aW1lKQo+ID4gLSAgICAgICogcGFnZSBwaW5uaW5nLiBUcmVhdCBnZXRfdmFkZHJf ZnJhbWVzKCkgbGlrZQo+ID4gLSAgICAgICogZ2V0X3VzZXJfcGFnZXNfbG9uZ3Rlcm0oKSBhbmQg ZGlzYWxsb3cgaXQgZm9yIGZpbGVzeXN0ZW0tZGF4Cj4gPiAtICAgICAgKiBtYXBwaW5ncy4KPiA+ IC0gICAgICAqLwo+ID4gLSAgICAgaWYgKHZtYV9pc19mc2RheCh2bWEpKSB7Cj4gPiAtICAgICAg ICAgICAgIHJldCA9IC1FT1BOT1RTVVBQOwo+ID4gLSAgICAgICAgICAgICBnb3RvIG91dDsKPiA+ IC0gICAgIH0KPgo+IEFyZSB5b3Ugc3VyZSB3ZSBkb24ndCBuZWVkIHRvIGNoZWNrIHZtYV9pc19m c2RheCgpIGFueW1vcmU/CgpTaW5jZSBGT0xMX0xPTkdURVJNIGNoZWNrcyBmb3IgdGhpcyBhbmQg Y2FuIG9ubHkgcmV0dXJuIHN0cnVjdCBwYWdlCmJhY2tlZCBtZW1vcnksIGFuZCBleHBsaWNpdGx5 IGV4Y2x1ZGVzIFZNX0lPIHwgVk1fUEZOTUFQLCB3YXMgYXNzdW1pbmcKdGhpcyBpcyBub3QgbmVl ZGVkIGZvciBmb2xsb3dfcGZuLiBBbmQgdGhlIGdldF91c2VyX3BhZ2VzX2xvY2tlZCB0aGlzCnVz ZWQgYmFjayB0aGVuIGRpZG4ndCBoYXZlIHRoZSBzYW1lIGNoZWNrLCBoZW5jZSB3aHkgaXQgd2Fz IGFkZGVkIChhbmQKRk9MTF9MT05HVEVSTSBzdGlsbCBkb2Vzbid0IHdvcmsgZm9yIHRoZSBfbG9j a2VkIHZlcnNpb25zLCBhcyB5b3UKcG9pbnRlZCBvdXQgb24gdGhlIGxhc3Qgcm91bmQgb2YgdGhp cyBkaXNjdXNzaW9uKS4KCkJ1dCBub3cgdGhhdCB5b3UncmUgYXNraW5nLCBJIGhhdmUgbm8gaWRl YSB3aGV0aGVyIGZzZGF4IHZtYSBjYW4gYWxzbwpiZSBvZiBWTV9JTyB8IFZNX1BGTk1BUCB0eXBl LiBJJ20gbm90IHNlZWluZyB0aGF0IHNldCBhbnl3aGVyZSBpbgpmcy9kYXguYywgYnV0IHRoYXQg c2F5cyBub3RoaW5nIDotKQoKRGFuLCB5b3UgYWRkZWQgdGhpcyBjaGVjayBvcmlnaW5hbGx5LCBk byB3ZSBuZWVkIGl0IGZvciBWTV9TUEVDSUFMIHZtYXMgdG9vPwoKVGhhbmtzLCBEYW5pZWwKCj4K PiA+IC0KPiA+IC0gICAgIGlmICghKHZtYS0+dm1fZmxhZ3MgJiAoVk1fSU8gfCBWTV9QRk5NQVAp KSkgewo+ID4gLSAgICAgICAgICAgICB2ZWMtPmdvdF9yZWYgPSB0cnVlOwo+ID4gLSAgICAgICAg ICAgICB2ZWMtPmlzX3BmbnMgPSBmYWxzZTsKPiA+IC0gICAgICAgICAgICAgcmV0ID0gcGluX3Vz ZXJfcGFnZXNfbG9ja2VkKHN0YXJ0LCBucl9mcmFtZXMsCj4gPiAtICAgICAgICAgICAgICAgICAg ICAgZ3VwX2ZsYWdzLCAoc3RydWN0IHBhZ2UgKiopKHZlYy0+cHRycyksICZsb2NrZWQpOwo+ID4g LSAgICAgICAgICAgICBnb3RvIG91dDsKPiA+IC0gICAgIH0KPiA+IC0KPiA+ICAgICAgIHZlYy0+ Z290X3JlZiA9IGZhbHNlOwo+ID4gICAgICAgdmVjLT5pc19wZm5zID0gdHJ1ZTsKPiA+ICAgICAg IGRvIHsKPiA+IEBAIC0xMDEsOCArODcsOCBAQCBpbnQgZ2V0X3ZhZGRyX2ZyYW1lcyh1bnNpZ25l ZCBsb25nIHN0YXJ0LCB1bnNpZ25lZCBpbnQgbnJfZnJhbWVzLAo+ID4gICAgICAgICAgICAgICB2 bWEgPSBmaW5kX3ZtYV9pbnRlcnNlY3Rpb24obW0sIHN0YXJ0LCBzdGFydCArIDEpOwo+ID4gICAg ICAgfSB3aGlsZSAodm1hICYmIHZtYS0+dm1fZmxhZ3MgJiAoVk1fSU8gfCBWTV9QRk5NQVApKTsK PiA+ICAgb3V0Ogo+ID4gLSAgICAgaWYgKGxvY2tlZCkKPiA+IC0gICAgICAgICAgICAgbW1hcF9y ZWFkX3VubG9jayhtbSk7Cj4gPiArICAgICBtbWFwX3JlYWRfdW5sb2NrKG1tKTsKPiA+ICtvdXRf dW5sb2NrZWQ6Cj4gPiAgICAgICBpZiAoIXJldCkKPiA+ICAgICAgICAgICAgICAgcmV0ID0gLUVG QVVMVDsKPiA+ICAgICAgIGlmIChyZXQgPiAwKQo+ID4KPgo+IEFsbCBvZiB0aGUgZXJyb3IgaGFu ZGxpbmcgc3RpbGwgbG9va3MgYWNjdXJhdGUgdGhlcmUuCj4KPiB0aGFua3MsCj4gLS0KPiBKb2hu IEh1YmJhcmQKPiBOVklESUEKCgoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIs IEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CFE8C41604 for ; Wed, 7 Oct 2020 21:30:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9049020B1F for ; Wed, 7 Oct 2020 21:30:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="BaAFboFh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9049020B1F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A31646E9B8; Wed, 7 Oct 2020 21:30:14 +0000 (UTC) Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 85FD16E9B8 for ; Wed, 7 Oct 2020 21:30:13 +0000 (UTC) Received: by mail-ot1-x341.google.com with SMTP id t15so3687490otk.0 for ; Wed, 07 Oct 2020 14:30:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=nNtozmj/MGUZLHZxI3A6qXOhVAeMPho+2jjUlqwzPiY=; b=BaAFboFhzjSDkIsRiKkVY5HnY80F0qFikzkwGLzbiZiDPe/NeBFe6zpt+tRZBXwSlf cldboSnNlcSz1Qnd+/D1yNqcLjwz5qLQP01nnTJ9te1SLWuuX0nGjEu12aT61tF+abrF VMjcmWsESAMRsIG40QQOk22zLTky3pJD0lB9E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nNtozmj/MGUZLHZxI3A6qXOhVAeMPho+2jjUlqwzPiY=; b=dzcj+FczfOtzXDzFh7xJ700rDxUW9HDek1K8DrFemBaU3B3/kVUjqXwD0FDWhKsr72 k80MQ8YDNoNVKIyhfgyWYa2QfSXUmacmapgBk6Jh2j1qcvF9tee/np4Stg/XDff5G7MB Lf1X2oQBsKnb9Ji5PLWTr9nJsU2NxY5IXUq/BUoI9PQFmV3nCj/y/pG4F2gVdTZOBTnG iE4JnEu3/eDCyP2qGQ9jKtKEfMxZ4Y9tpPDH9UK0VIEn1O4b+gsIBLl/ynvwZL0WsD8Q phuUWPeg+FSDIUU94pBLQaVgwX6w9OnYYDKYM4Q1zFz3WYN96ttZxhs3OE5Ur/aTjgbc 3x2g== X-Gm-Message-State: AOAM533rslQfmnU36RzK+nojETdZdzeO2qpOghg3pOo9saOko9Wx76Yt lE5ioiUAUdiATIRWQGhAxzX+vBjmwjNzkTB0KUA+eg== X-Google-Smtp-Source: ABdhPJzDIRAj53qXn+wCstFj7fFAXvpqHS6peJb8d7VCpx3oiEDiFkz29m0ZVMR9QW+s4BR0BiMsr7SeQunifX3iVl4= X-Received: by 2002:a05:6830:1e56:: with SMTP id e22mr2939594otj.303.1602106212518; Wed, 07 Oct 2020 14:30:12 -0700 (PDT) MIME-Version: 1.0 References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch> <20201007164426.1812530-6-daniel.vetter@ffwll.ch> In-Reply-To: From: Daniel Vetter Date: Wed, 7 Oct 2020 23:30:01 +0200 Message-ID: Subject: Re: [PATCH 05/13] mm/frame-vector: Use FOLL_LONGTERM To: John Hubbard , Dan Williams X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , linux-s390@vger.kernel.org, linux-samsung-soc , Jan Kara , Pawel Osciak , kvm@vger.kernel.org, Jason Gunthorpe , Mauro Carvalho Chehab , LKML , DRI Development , Tomasz Figa , Linux MM , Kyungmin Park , Daniel Vetter , Andrew Morton , Marek Szyprowski , Linux ARM , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCBPY3QgNywgMjAyMCBhdCAxMToxMyBQTSBKb2huIEh1YmJhcmQgPGpodWJiYXJkQG52 aWRpYS5jb20+IHdyb3RlOgo+Cj4gT24gMTAvNy8yMCA5OjQ0IEFNLCBEYW5pZWwgVmV0dGVyIHdy b3RlOgo+ID4gVGhpcyBpcyB1c2VkIGJ5IG1lZGlhL3ZpZGVidWYyIGZvciBwZXJzaXN0ZW50IGRt YSBtYXBwaW5ncywgbm90IGp1c3QKPiA+IGZvciBhIHNpbmdsZSBkbWEgb3BlcmF0aW9uIGFuZCB0 aGVuIGZyZWVkIGFnYWluLCBzbyBuZWVkcwo+ID4gRk9MTF9MT05HVEVSTS4KPiA+Cj4gPiBVbmZv cnR1bmF0ZWx5IGN1cnJlbnQgcHVwX2xvY2tlZCBkb2Vzbid0IHN1cHBvcnQgRk9MTF9MT05HVEVS TSBkdWUgdG8KPiA+IGxvY2tpbmcgaXNzdWVzLiBSZXdvcmsgdGhlIGNvZGUgdG8gcHVsbCB0aGUg cHVwIHBhdGggb3V0IGZyb20gdGhlCj4gPiBtbWFwX3NlbSBjcml0aWNhbCBzZWN0aW9uIGFzIHN1 Z2dlc3RlZCBieSBKYXNvbi4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxk YW5pZWwudmV0dGVyQGludGVsLmNvbT4KPiA+IENjOiBKYXNvbiBHdW50aG9ycGUgPGpnZ0B6aWVw ZS5jYT4KPiA+IENjOiBQYXdlbCBPc2NpYWsgPHBhd2VsQG9zY2lhay5jb20+Cj4gPiBDYzogTWFy ZWsgU3p5cHJvd3NraSA8bS5zenlwcm93c2tpQHNhbXN1bmcuY29tPgo+ID4gQ2M6IEt5dW5nbWlu IFBhcmsgPGt5dW5nbWluLnBhcmtAc2Ftc3VuZy5jb20+Cj4gPiBDYzogVG9tYXN6IEZpZ2EgPHRm aWdhQGNocm9taXVtLm9yZz4KPiA+IENjOiBNYXVybyBDYXJ2YWxobyBDaGVoYWIgPG1jaGVoYWJA a2VybmVsLm9yZz4KPiA+IENjOiBBbmRyZXcgTW9ydG9uIDxha3BtQGxpbnV4LWZvdW5kYXRpb24u b3JnPgo+ID4gQ2M6IEpvaG4gSHViYmFyZCA8amh1YmJhcmRAbnZpZGlhLmNvbT4KPiA+IENjOiBK w6lyw7RtZSBHbGlzc2UgPGpnbGlzc2VAcmVkaGF0LmNvbT4KPiA+IENjOiBKYW4gS2FyYSA8amFj a0BzdXNlLmN6Pgo+ID4gQ2M6IERhbiBXaWxsaWFtcyA8ZGFuLmoud2lsbGlhbXNAaW50ZWwuY29t Pgo+ID4gQ2M6IGxpbnV4LW1tQGt2YWNrLm9yZwo+ID4gQ2M6IGxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwo+ID4gQ2M6IGxpbnV4LXNhbXN1bmctc29jQHZnZXIua2VybmVsLm9y Zwo+ID4gQ2M6IGxpbnV4LW1lZGlhQHZnZXIua2VybmVsLm9yZwo+ID4gLS0tCj4gPiAgIG1tL2Zy YW1lX3ZlY3Rvci5jIHwgMzYgKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4g PiAgIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAyNSBkZWxldGlvbnMoLSkKPiA+ Cj4gPiBkaWZmIC0tZ2l0IGEvbW0vZnJhbWVfdmVjdG9yLmMgYi9tbS9mcmFtZV92ZWN0b3IuYwo+ ID4gaW5kZXggMTBmODJkNTY0M2I2Li4zOWRiNTIwYTUxZGMgMTAwNjQ0Cj4gPiAtLS0gYS9tbS9m cmFtZV92ZWN0b3IuYwo+ID4gKysrIGIvbW0vZnJhbWVfdmVjdG9yLmMKPiA+IEBAIC0zOCw3ICsz OCw2IEBAIGludCBnZXRfdmFkZHJfZnJhbWVzKHVuc2lnbmVkIGxvbmcgc3RhcnQsIHVuc2lnbmVk IGludCBucl9mcmFtZXMsCj4gPiAgICAgICBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYTsKPiA+ ICAgICAgIGludCByZXQgPSAwOwo+ID4gICAgICAgaW50IGVycjsKPiA+IC0gICAgIGludCBsb2Nr ZWQ7Cj4gPgo+ID4gICAgICAgaWYgKG5yX2ZyYW1lcyA9PSAwKQo+ID4gICAgICAgICAgICAgICBy ZXR1cm4gMDsKPiA+IEBAIC00OCwzNSArNDcsMjIgQEAgaW50IGdldF92YWRkcl9mcmFtZXModW5z aWduZWQgbG9uZyBzdGFydCwgdW5zaWduZWQgaW50IG5yX2ZyYW1lcywKPiA+Cj4gPiAgICAgICBz dGFydCA9IHVudGFnZ2VkX2FkZHIoc3RhcnQpOwo+ID4KPiA+ICsgICAgIHJldCA9IHBpbl91c2Vy X3BhZ2VzX2Zhc3Qoc3RhcnQsIG5yX2ZyYW1lcywKPiA+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgRk9MTF9GT1JDRSB8IEZPTExfV1JJVEUgfCBGT0xMX0xPTkdURVJNLAo+ID4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoc3RydWN0IHBhZ2UgKiopKHZlYy0+cHRycykp Owo+ID4gKyAgICAgaWYgKHJldCA+IDApIHsKPiA+ICsgICAgICAgICAgICAgdmVjLT5nb3RfcmVm ID0gdHJ1ZTsKPiA+ICsgICAgICAgICAgICAgdmVjLT5pc19wZm5zID0gZmFsc2U7Cj4gPiArICAg ICAgICAgICAgIGdvdG8gb3V0X3VubG9ja2VkOwo+ID4gKyAgICAgfQo+Cj4gVGhpcyBwYXJ0IGxv b2tzIGdvb2QsIGFuZCBjaGFuZ2luZyB0byBfZmFzdCBpcyBhIHBvdGVudGlhbCBwZXJmb3JtYW5j ZSBpbXByb3ZlbWVudCwKPiB0b28uCj4KPiA+ICsKPiA+ICAgICAgIG1tYXBfcmVhZF9sb2NrKG1t KTsKPiA+IC0gICAgIGxvY2tlZCA9IDE7Cj4gPiAgICAgICB2bWEgPSBmaW5kX3ZtYV9pbnRlcnNl Y3Rpb24obW0sIHN0YXJ0LCBzdGFydCArIDEpOwo+ID4gICAgICAgaWYgKCF2bWEpIHsKPiA+ICAg ICAgICAgICAgICAgcmV0ID0gLUVGQVVMVDsKPiA+ICAgICAgICAgICAgICAgZ290byBvdXQ7Cj4g PiAgICAgICB9Cj4gPgo+ID4gLSAgICAgLyoKPiA+IC0gICAgICAqIFdoaWxlIGdldF92YWRkcl9m cmFtZXMoKSBjb3VsZCBiZSB1c2VkIGZvciB0cmFuc2llbnQgKGtlcm5lbAo+ID4gLSAgICAgICog Y29udHJvbGxlZCBsaWZldGltZSkgcGlubmluZyBvZiBtZW1vcnkgcGFnZXMgYWxsIGN1cnJlbnQK PiA+IC0gICAgICAqIHVzZXJzIGVzdGFibGlzaCBsb25nIHRlcm0gKHVzZXJzcGFjZSBjb250cm9s bGVkIGxpZmV0aW1lKQo+ID4gLSAgICAgICogcGFnZSBwaW5uaW5nLiBUcmVhdCBnZXRfdmFkZHJf ZnJhbWVzKCkgbGlrZQo+ID4gLSAgICAgICogZ2V0X3VzZXJfcGFnZXNfbG9uZ3Rlcm0oKSBhbmQg ZGlzYWxsb3cgaXQgZm9yIGZpbGVzeXN0ZW0tZGF4Cj4gPiAtICAgICAgKiBtYXBwaW5ncy4KPiA+ IC0gICAgICAqLwo+ID4gLSAgICAgaWYgKHZtYV9pc19mc2RheCh2bWEpKSB7Cj4gPiAtICAgICAg ICAgICAgIHJldCA9IC1FT1BOT1RTVVBQOwo+ID4gLSAgICAgICAgICAgICBnb3RvIG91dDsKPiA+ IC0gICAgIH0KPgo+IEFyZSB5b3Ugc3VyZSB3ZSBkb24ndCBuZWVkIHRvIGNoZWNrIHZtYV9pc19m c2RheCgpIGFueW1vcmU/CgpTaW5jZSBGT0xMX0xPTkdURVJNIGNoZWNrcyBmb3IgdGhpcyBhbmQg Y2FuIG9ubHkgcmV0dXJuIHN0cnVjdCBwYWdlCmJhY2tlZCBtZW1vcnksIGFuZCBleHBsaWNpdGx5 IGV4Y2x1ZGVzIFZNX0lPIHwgVk1fUEZOTUFQLCB3YXMgYXNzdW1pbmcKdGhpcyBpcyBub3QgbmVl ZGVkIGZvciBmb2xsb3dfcGZuLiBBbmQgdGhlIGdldF91c2VyX3BhZ2VzX2xvY2tlZCB0aGlzCnVz ZWQgYmFjayB0aGVuIGRpZG4ndCBoYXZlIHRoZSBzYW1lIGNoZWNrLCBoZW5jZSB3aHkgaXQgd2Fz IGFkZGVkIChhbmQKRk9MTF9MT05HVEVSTSBzdGlsbCBkb2Vzbid0IHdvcmsgZm9yIHRoZSBfbG9j a2VkIHZlcnNpb25zLCBhcyB5b3UKcG9pbnRlZCBvdXQgb24gdGhlIGxhc3Qgcm91bmQgb2YgdGhp cyBkaXNjdXNzaW9uKS4KCkJ1dCBub3cgdGhhdCB5b3UncmUgYXNraW5nLCBJIGhhdmUgbm8gaWRl YSB3aGV0aGVyIGZzZGF4IHZtYSBjYW4gYWxzbwpiZSBvZiBWTV9JTyB8IFZNX1BGTk1BUCB0eXBl LiBJJ20gbm90IHNlZWluZyB0aGF0IHNldCBhbnl3aGVyZSBpbgpmcy9kYXguYywgYnV0IHRoYXQg c2F5cyBub3RoaW5nIDotKQoKRGFuLCB5b3UgYWRkZWQgdGhpcyBjaGVjayBvcmlnaW5hbGx5LCBk byB3ZSBuZWVkIGl0IGZvciBWTV9TUEVDSUFMIHZtYXMgdG9vPwoKVGhhbmtzLCBEYW5pZWwKCj4K PiA+IC0KPiA+IC0gICAgIGlmICghKHZtYS0+dm1fZmxhZ3MgJiAoVk1fSU8gfCBWTV9QRk5NQVAp KSkgewo+ID4gLSAgICAgICAgICAgICB2ZWMtPmdvdF9yZWYgPSB0cnVlOwo+ID4gLSAgICAgICAg ICAgICB2ZWMtPmlzX3BmbnMgPSBmYWxzZTsKPiA+IC0gICAgICAgICAgICAgcmV0ID0gcGluX3Vz ZXJfcGFnZXNfbG9ja2VkKHN0YXJ0LCBucl9mcmFtZXMsCj4gPiAtICAgICAgICAgICAgICAgICAg ICAgZ3VwX2ZsYWdzLCAoc3RydWN0IHBhZ2UgKiopKHZlYy0+cHRycyksICZsb2NrZWQpOwo+ID4g LSAgICAgICAgICAgICBnb3RvIG91dDsKPiA+IC0gICAgIH0KPiA+IC0KPiA+ICAgICAgIHZlYy0+ Z290X3JlZiA9IGZhbHNlOwo+ID4gICAgICAgdmVjLT5pc19wZm5zID0gdHJ1ZTsKPiA+ICAgICAg IGRvIHsKPiA+IEBAIC0xMDEsOCArODcsOCBAQCBpbnQgZ2V0X3ZhZGRyX2ZyYW1lcyh1bnNpZ25l ZCBsb25nIHN0YXJ0LCB1bnNpZ25lZCBpbnQgbnJfZnJhbWVzLAo+ID4gICAgICAgICAgICAgICB2 bWEgPSBmaW5kX3ZtYV9pbnRlcnNlY3Rpb24obW0sIHN0YXJ0LCBzdGFydCArIDEpOwo+ID4gICAg ICAgfSB3aGlsZSAodm1hICYmIHZtYS0+dm1fZmxhZ3MgJiAoVk1fSU8gfCBWTV9QRk5NQVApKTsK PiA+ICAgb3V0Ogo+ID4gLSAgICAgaWYgKGxvY2tlZCkKPiA+IC0gICAgICAgICAgICAgbW1hcF9y ZWFkX3VubG9jayhtbSk7Cj4gPiArICAgICBtbWFwX3JlYWRfdW5sb2NrKG1tKTsKPiA+ICtvdXRf dW5sb2NrZWQ6Cj4gPiAgICAgICBpZiAoIXJldCkKPiA+ICAgICAgICAgICAgICAgcmV0ID0gLUVG QVVMVDsKPiA+ICAgICAgIGlmIChyZXQgPiAwKQo+ID4KPgo+IEFsbCBvZiB0aGUgZXJyb3IgaGFu ZGxpbmcgc3RpbGwgbG9va3MgYWNjdXJhdGUgdGhlcmUuCj4KPiB0aGFua3MsCj4gLS0KPiBKb2hu IEh1YmJhcmQKPiBOVklESUEKCgoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIs IEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=