Request for commit rights on libdrm

Request for commit rights on libdrm

[Lucas De Marchi]

Hey,

I'm contributing to libdrm and plan to continue doing so. Reading the
CONTRIBUTING file I understand I can already request commit rights due
to my past contributions to libdrm, kernel and i-g-t. I also have a
pending patch series waiting for more reviews/acks I'd be able to merge
by myself.

Thanks
Lucas De Marchi
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Request for commit rights on libdrm

[Daniel Vetter]

On Fri, Sep 14, 2018 at 8:24 PM, Lucas De Marchi
<lucas.demarchi@intel.com> wrote:
> Hey,
>
> I'm contributing to libdrm and plan to continue doing so. Reading the
> CONTRIBUTING file I understand I can already request commit rights due
> to my past contributions to libdrm, kernel and i-g-t. I also have a
> pending patch series waiting for more reviews/acks I'd be able to merge
> by myself.

https://gitlab.freedesktop.org/mesa/drm/project_members?sort=access_level_desc

^^ Anyone who's an Owner can add you. Probably simplest if you just
ask one of the Intel folks listed.

Cheers, Daniel

> Thanks
> Lucas De Marchi



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Request for commit rights on libdrm

[Lucas De Marchi]

On Fri, Sep 14, 2018 at 08:27:34PM +0200, Daniel Vetter wrote:
> On Fri, Sep 14, 2018 at 8:24 PM, Lucas De Marchi
> <lucas.demarchi@intel.com> wrote:
> > Hey,
> >
> > I'm contributing to libdrm and plan to continue doing so. Reading the
> > CONTRIBUTING file I understand I can already request commit rights due
> > to my past contributions to libdrm, kernel and i-g-t. I also have a
> > pending patch series waiting for more reviews/acks I'd be able to merge
> > by myself.
> 
> https://gitlab.freedesktop.org/mesa/drm/project_members?sort=access_level_desc
> 
> ^^ Anyone who's an Owner can add you. Probably simplest if you just
> ask one of the Intel folks listed.

I had the impression the CONTRIBUTING file stated to send an email to
dri-devel due to needing a review of some kind.

Lucas De Marchi

> 
> Cheers, Daniel
> 
> > Thanks
> > Lucas De Marchi
> 
> 
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH libdrm] CONTRIBUTING: clarify how to request a Developer role

[Lucas De Marchi]

While requesting a Developer role I was pointed to this url and check
those with "owner" role. So add it to our documentation.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 CONTRIBUTING | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/CONTRIBUTING b/CONTRIBUTING
index 96f1e4fb..487a5c36 100644
--- a/CONTRIBUTING
+++ b/CONTRIBUTING
@@ -78,9 +78,10 @@ below criteria:
 - Agrees to use their commit rights in accordance with the documented merge
   criteria, tools, and processes.
 
-To apply for commit rights ("Developer" role in gitlab) send a mail to
-dri-devel@lists.freedesktop.org and please ping the maintainers if your request
-is stuck.
+To apply for commit rights ("Developer" role in gitlab), check project
+members who have the "owner" role at
+https://gitlab.freedesktop.org/mesa/drm/project_members?sort=access_level_desc.
+Any of them can add new developers.
 
 Committers are encouraged to request their commit rights get removed when they
 no longer contribute to the project. Commit rights will be reinstated when they
-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH libdrm] CONTRIBUTING: clarify how to request a Developer role

[Daniel Stone]

Hi,

On Sat, 15 Sep 2018 at 00:56, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> -To apply for commit rights ("Developer" role in gitlab) send a mail to
> -dri-devel@lists.freedesktop.org and please ping the maintainers if your request
> -is stuck.
> +To apply for commit rights ("Developer" role in gitlab), check project
> +members who have the "owner" role at
> +https://gitlab.freedesktop.org/mesa/drm/project_members?sort=access_level_desc.
> +Any of them can add new developers.

I think it still makes sense to discuss it publicly, either on the
list or through a bug tracker. Having an audit log of who's there and
why is pretty important. I would suggest the process be to email
dri-devel@ and request it, then if nothing happens ping one of the
people listed there as an owner.

Cheers,
Daniel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH libdrm] CONTRIBUTING: clarify how to request a Developer role

[Sean Paul]

On Mon, Sep 17, 2018 at 11:01:15AM +0100, Daniel Stone wrote:
> Hi,
> 
> On Sat, 15 Sep 2018 at 00:56, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> > -To apply for commit rights ("Developer" role in gitlab) send a mail to
> > -dri-devel@lists.freedesktop.org and please ping the maintainers if your request
> > -is stuck.
> > +To apply for commit rights ("Developer" role in gitlab), check project
> > +members who have the "owner" role at
> > +https://gitlab.freedesktop.org/mesa/drm/project_members?sort=access_level_desc.
> > +Any of them can add new developers.
> 
> I think it still makes sense to discuss it publicly, either on the
> list or through a bug tracker. Having an audit log of who's there and
> why is pretty important. I would suggest the process be to email
> dri-devel@ and request it, then if nothing happens ping one of the
> people listed there as an owner.

Or file a GL issue, perhaps?

Sean

> 
> Cheers,
> Daniel
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH libdrm v2] CONTRIBUTING: clarify how to request a Developer role

[Lucas De Marchi]

While requesting a Developer role I was pointed to this url and check
those with "owner" role. So add it to our documentation.

v2: rollback previous text, but add a link to gitlab's page
    showing project members.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 CONTRIBUTING | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/CONTRIBUTING b/CONTRIBUTING
index 96f1e4fb..5d38e5e9 100644
--- a/CONTRIBUTING
+++ b/CONTRIBUTING
@@ -80,7 +80,9 @@ below criteria:
 
 To apply for commit rights ("Developer" role in gitlab) send a mail to
 dri-devel@lists.freedesktop.org and please ping the maintainers if your request
-is stuck.
+is stuck: any member with "owner" role in
+https://gitlab.freedesktop.org/mesa/drm/project_members?sort=access_level_desc
+can give you access.
 
 Committers are encouraged to request their commit rights get removed when they
 no longer contribute to the project. Commit rights will be reinstated when they
-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH libdrm v2] CONTRIBUTING: clarify how to request a Developer role

[Rodrigo Vivi]

On Wed, Sep 19, 2018 at 04:27:22PM -0700, Lucas De Marchi wrote:
> While requesting a Developer role I was pointed to this url and check
> those with "owner" role. So add it to our documentation.
> 
> v2: rollback previous text, but add a link to gitlab's page
>     showing project members.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
>  CONTRIBUTING | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/CONTRIBUTING b/CONTRIBUTING
> index 96f1e4fb..5d38e5e9 100644
> --- a/CONTRIBUTING
> +++ b/CONTRIBUTING
> @@ -80,7 +80,9 @@ below criteria:
>  
>  To apply for commit rights ("Developer" role in gitlab) send a mail to
>  dri-devel@lists.freedesktop.org and please ping the maintainers if your request

I believe we need something like this:

-  dri-devel@lists.freedesktop.org and please ping the maintainers if your request
+  dri-devel@lists.freedesktop.org and if your request is stuck ping any member with
+  "owner" role in [link]

> -is stuck.
> +is stuck: any member with "owner" role in
> +https://gitlab.freedesktop.org/mesa/drm/project_members?sort=access_level_desc
> +can give you access.
>  
>  Committers are encouraged to request their commit rights get removed when they
>  no longer contribute to the project. Commit rights will be reinstated when they
> -- 
> 2.17.1
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH libdrm v3] CONTRIBUTING: clarify how to request a Developer role

[Lucas De Marchi]

While requesting a Developer role I was pointed to this url and check
those with "owner" role. So add it to our documentation.

v2: rollback previous text, but add a link to gitlab's page
    showing project members.
v3: reprhase paragraph adding link to members page

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 CONTRIBUTING | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/CONTRIBUTING b/CONTRIBUTING
index 96f1e4fb..1c42750f 100644
--- a/CONTRIBUTING
+++ b/CONTRIBUTING
@@ -79,8 +79,9 @@ below criteria:
   criteria, tools, and processes.
 
 To apply for commit rights ("Developer" role in gitlab) send a mail to
-dri-devel@lists.freedesktop.org and please ping the maintainers if your request
-is stuck.
+dri-devel@lists.freedesktop.org and if your request is stuck ping any member
+with "owner" role in
+https://gitlab.freedesktop.org/mesa/drm/project_members?sort=access_level_desc
 
 Committers are encouraged to request their commit rights get removed when they
 no longer contribute to the project. Commit rights will be reinstated when they
-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH libdrm v3] CONTRIBUTING: clarify how to request a Developer role

[Eric Engestrom]

On Wednesday, 2018-09-19 22:54:40 -0700, Lucas De Marchi wrote:
> While requesting a Developer role I was pointed to this url and check
> those with "owner" role. So add it to our documentation.
> 
> v2: rollback previous text, but add a link to gitlab's page
>     showing project members.
> v3: reprhase paragraph adding link to members page
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Looks good to me; thanks!
Reviewed-by: Eric Engestrom <eric.engestrom@intel.com>

> ---
>  CONTRIBUTING | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/CONTRIBUTING b/CONTRIBUTING
> index 96f1e4fb..1c42750f 100644
> --- a/CONTRIBUTING
> +++ b/CONTRIBUTING
> @@ -79,8 +79,9 @@ below criteria:
>    criteria, tools, and processes.
>  
>  To apply for commit rights ("Developer" role in gitlab) send a mail to
> -dri-devel@lists.freedesktop.org and please ping the maintainers if your request
> -is stuck.
> +dri-devel@lists.freedesktop.org and if your request is stuck ping any member
> +with "owner" role in
> +https://gitlab.freedesktop.org/mesa/drm/project_members?sort=access_level_desc
>  
>  Committers are encouraged to request their commit rights get removed when they
>  no longer contribute to the project. Commit rights will be reinstated when they
> -- 
> 2.17.1
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH libdrm] CONTRIBUTING: clarify how to request a Developer role

[Emil Velikov]

On 17 September 2018 at 11:01, Daniel Stone <daniel@fooishbar.org> wrote:
> Hi,
>
> On Sat, 15 Sep 2018 at 00:56, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
>> -To apply for commit rights ("Developer" role in gitlab) send a mail to
>> -dri-devel@lists.freedesktop.org and please ping the maintainers if your request
>> -is stuck.
>> +To apply for commit rights ("Developer" role in gitlab), check project
>> +members who have the "owner" role at
>> +https://gitlab.freedesktop.org/mesa/drm/project_members?sort=access_level_desc.
>> +Any of them can add new developers.
>
> I think it still makes sense to discuss it publicly, either on the
> list or through a bug tracker. Having an audit log of who's there and
> why is pretty important. I would suggest the process be to email
> dri-devel@ and request it, then if nothing happens ping one of the
> people listed there as an owner.
>
Fully agreed on that - transparency is essential.
I wonder if gitlab will get some logging for project specifics -
people added/removed, changing the repo public <> private.

-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel