From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CCDFC433E6 for ; Thu, 21 Jan 2021 11:28:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39C7A2395B for ; Thu, 21 Jan 2021 11:28:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728124AbhAUL2I (ORCPT ); Thu, 21 Jan 2021 06:28:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729539AbhAULYB (ORCPT ); Thu, 21 Jan 2021 06:24:01 -0500 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AA66C061575 for ; Thu, 21 Jan 2021 03:23:18 -0800 (PST) Received: by mail-ot1-x331.google.com with SMTP id h14so1251551otr.4 for ; Thu, 21 Jan 2021 03:23:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b2rMzfq0UH/F+eLfm27e8RT4cWjxNkuh3W9X3FO/pmE=; b=BAG2wgYYSoqHd+DzOqnaf2XloG6h8bisgVdttJVNDSeHpO2T60TTr7oftDgacbG++z FWPFJ7hdHVj7asQbzl1FiKoOBR4iGZhMKOoPDtWwob5eImQXBXeKj3EvrZWVEkeJQQKj fuvuKpu9YR6biF7ybZJEkp7YQ/ov/XcCHaV6I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b2rMzfq0UH/F+eLfm27e8RT4cWjxNkuh3W9X3FO/pmE=; b=o/+r8zcOm3qB5QweHMCORmlXrWPhQleIhRgdW+9oPBwtYJgmNL6aU71PBpXlezggoc tOjOGgPknKV/mweN1ziDEaYzUHfPQ4rOY+sggosAoxkCcfLtiwhUhJKAQQU2JghFMY6a crYkPrTY52CAe9euGZyp1t5t0XEL/XOYf+zqetOTAKS0pU63smwU/PYsyAWKi3jPseDD UPUm+z/5fW8DJOwKnAJhsJsK190Kc8UvYVwITE0x2RwyE2HpXGwnbwtk7uy+vbz9dLd6 TXsnRD+BzrB71dgn2ZSzVGmYDxOK+uqwP6gqs4thEgV6zkoIFfq8+Tkmx5edi2t7oRNf 62Jg== X-Gm-Message-State: AOAM533LLruOyCFBJrtw0BhBnMs+iiFPNWwcAEYOXuhyD4xR6FaE3Tnf P4xJ0a8bAZSQbEnRr9MZxKydbNQ0wnfUW87W0mSOJrhqYTfNXw== X-Google-Smtp-Source: ABdhPJwuTGzWQAuFKkuYSb3G3c5sxDjEUQ9z8aWWFLseIzCwQa2p+C86ONLqWh5bBBra+SI82M1uIeUTsaA8ArqC1t0= X-Received: by 2002:a05:6830:1bef:: with SMTP id k15mr9879029otb.303.1611228197779; Thu, 21 Jan 2021 03:23:17 -0800 (PST) MIME-Version: 1.0 References: <20210121030909.1126643-1-zhangzhijie@loongson.cn> In-Reply-To: <20210121030909.1126643-1-zhangzhijie@loongson.cn> From: Daniel Vetter Date: Thu, 21 Jan 2021 12:23:07 +0100 Message-ID: Subject: Re: [PATCH v4] drm: Improve the output_poll_changed description To: "ZhiJie.Zhang" Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Dave Airlie , dri-devel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 21, 2021 at 4:09 AM ZhiJie.Zhang wrote: > > From: zhangzhijie > > this callback was used by drm_kms_helper_hotplug_event() > > V2: (Thanks for Daniel's suggestions) > - remove the FIXME below.since with the drm_client > - infrastructure and the generic fbdev emulation we've > - resolved this all very neatly now. > > V3: Add comments that This hook is deprecated > - new implementation methods instead of this hook > > Signed-off-by: ZhiJie.Zhang > --- > include/drm/drm_mode_config.h | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h > index ab424ddd7665..fbc0da25d7c5 100644 > --- a/include/drm/drm_mode_config.h > +++ b/include/drm/drm_mode_config.h > @@ -103,14 +103,13 @@ struct drm_mode_config_funcs { > * Callback used by helpers to inform the driver of output configuration > * changes. > * > - * Drivers implementing fbdev emulation with the helpers can call > - * drm_fb_helper_hotplug_changed from this hook to inform the fbdev > - * helper of output changes. Not sure why this isn't clear, but the above is important information that we should keep. Maybe good to fix up the formatting to make it a hyperlink, and your addition here is fine too, but the above is the important part really. -Daniel > + * Drivers implementing fbdev emulation use drm_kms_helper_hotplug_event() > + * to call this hook to inform the fbdev helper of output changes. > * > - * FIXME: > - * > - * Except that there's no vtable for device-level helper callbacks > - * there's no reason this is a core function. > + * This hook is deprecated, drivers should instead use > + * drm_fbdev_generic_setup() which takes care of any necessary > + * hotplug event forwarding already without further involvement by > + * the driver. > */ > void (*output_poll_changed)(struct drm_device *dev); > > -- > 2.29.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25B62C433DB for ; Thu, 21 Jan 2021 11:23:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56F8C238E1 for ; Thu, 21 Jan 2021 11:23:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56F8C238E1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A4E506E52D; Thu, 21 Jan 2021 11:23:19 +0000 (UTC) Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6DA216E52D for ; Thu, 21 Jan 2021 11:23:18 +0000 (UTC) Received: by mail-ot1-x335.google.com with SMTP id 34so1253550otd.5 for ; Thu, 21 Jan 2021 03:23:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b2rMzfq0UH/F+eLfm27e8RT4cWjxNkuh3W9X3FO/pmE=; b=BAG2wgYYSoqHd+DzOqnaf2XloG6h8bisgVdttJVNDSeHpO2T60TTr7oftDgacbG++z FWPFJ7hdHVj7asQbzl1FiKoOBR4iGZhMKOoPDtWwob5eImQXBXeKj3EvrZWVEkeJQQKj fuvuKpu9YR6biF7ybZJEkp7YQ/ov/XcCHaV6I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b2rMzfq0UH/F+eLfm27e8RT4cWjxNkuh3W9X3FO/pmE=; b=gTvV3eOkXPhVvGhFMGBRuU7A5ffZyEf9aGvdFoUHSQ5vluohxMOhsD9jJ59PaX+p6O G2Im9brIMKe5pjLHfznGBlJiA86FWe+niSf9aUl9zipv9g6wg67jD+NTLD8KEOfmdpnH TOuYuHUtmsbTN+qQr6eHWWqUpR1saSuBayY1rSlpqiu110LWZMKR/g07HN+MqGfygxi1 FECGbqzt/0Z2lAkgdNRyCecLZGPkfffc00bZeF0ZgIQzVFU9uZUGczqKPwGouf/itmvU Q5hboOeuu6YOe5QgMX/tZ48P6+vV11MRWcMcsNYPIkzY+cHnfp0amjPpuj8ZlA5fuSlx 5Fxg== X-Gm-Message-State: AOAM530z4zQX3XsK9ju+ttxqDNHva55WeH7itNtvQPBXI1Nb/teokFCH XfJsJq8K42KEol8J0ehtBUrexG+Tra/tyN9jpoRrHQ== X-Google-Smtp-Source: ABdhPJwuTGzWQAuFKkuYSb3G3c5sxDjEUQ9z8aWWFLseIzCwQa2p+C86ONLqWh5bBBra+SI82M1uIeUTsaA8ArqC1t0= X-Received: by 2002:a05:6830:1bef:: with SMTP id k15mr9879029otb.303.1611228197779; Thu, 21 Jan 2021 03:23:17 -0800 (PST) MIME-Version: 1.0 References: <20210121030909.1126643-1-zhangzhijie@loongson.cn> In-Reply-To: <20210121030909.1126643-1-zhangzhijie@loongson.cn> From: Daniel Vetter Date: Thu, 21 Jan 2021 12:23:07 +0100 Message-ID: Subject: Re: [PATCH v4] drm: Improve the output_poll_changed description To: "ZhiJie.Zhang" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Airlie , Linux Kernel Mailing List , dri-devel , Thomas Zimmermann Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jan 21, 2021 at 4:09 AM ZhiJie.Zhang wrote: > > From: zhangzhijie > > this callback was used by drm_kms_helper_hotplug_event() > > V2: (Thanks for Daniel's suggestions) > - remove the FIXME below.since with the drm_client > - infrastructure and the generic fbdev emulation we've > - resolved this all very neatly now. > > V3: Add comments that This hook is deprecated > - new implementation methods instead of this hook > > Signed-off-by: ZhiJie.Zhang > --- > include/drm/drm_mode_config.h | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h > index ab424ddd7665..fbc0da25d7c5 100644 > --- a/include/drm/drm_mode_config.h > +++ b/include/drm/drm_mode_config.h > @@ -103,14 +103,13 @@ struct drm_mode_config_funcs { > * Callback used by helpers to inform the driver of output configuration > * changes. > * > - * Drivers implementing fbdev emulation with the helpers can call > - * drm_fb_helper_hotplug_changed from this hook to inform the fbdev > - * helper of output changes. Not sure why this isn't clear, but the above is important information that we should keep. Maybe good to fix up the formatting to make it a hyperlink, and your addition here is fine too, but the above is the important part really. -Daniel > + * Drivers implementing fbdev emulation use drm_kms_helper_hotplug_event() > + * to call this hook to inform the fbdev helper of output changes. > * > - * FIXME: > - * > - * Except that there's no vtable for device-level helper callbacks > - * there's no reason this is a core function. > + * This hook is deprecated, drivers should instead use > + * drm_fbdev_generic_setup() which takes care of any necessary > + * hotplug event forwarding already without further involvement by > + * the driver. > */ > void (*output_poll_changed)(struct drm_device *dev); > > -- > 2.29.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel