From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 04/14] drm/i915: add MIPI DSI register definitions Date: Thu, 15 Aug 2013 16:08:32 +0200 Message-ID: References: <251e691483fac288b6c33dadfa811c53ecbca81d.1376397804.git.jani.nikula@intel.com> <20130815133821.GA10572@strange.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ie0-f171.google.com (mail-ie0-f171.google.com [209.85.223.171]) by gabe.freedesktop.org (Postfix) with ESMTP id 955DFE82D5 for ; Thu, 15 Aug 2013 07:08:32 -0700 (PDT) Received: by mail-ie0-f171.google.com with SMTP id 10so1273043ied.16 for ; Thu, 15 Aug 2013 07:08:32 -0700 (PDT) In-Reply-To: <20130815133821.GA10572@strange.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Damien Lespiau Cc: Jani Nikula , intel-gfx , yogesh.mohan.marimuthu@intel.com List-Id: intel-gfx@lists.freedesktop.org On Thu, Aug 15, 2013 at 3:38 PM, Damien Lespiau wrote: > On Tue, Aug 13, 2013 at 04:29:43PM +0300, Jani Nikula wrote: >> Add definitions for VLV MIPI DSI registers. >> >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/i915_reg.h | 409 +++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 409 insertions(+) > > I wonder if it'd be the right time to spawn another header instead of > adding more to i915_reg.h? or people are fine with that big i915_reg.h? cscope can still keep track of it, so imo it's ok. Stuff we care more about (function declarations, structs, ...) are already in other files, so personally I don't mind really. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch