From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 1/1] drm/i915: Fix VGA handling using stop_machine() or mmio Date: Mon, 7 Oct 2013 09:34:25 +0200 Message-ID: References: <1380550111-31590-1-git-send-email-ville.syrjala@linux.intel.com> <1380550111-31590-2-git-send-email-ville.syrjala@linux.intel.com> <20130930142437.GI744@nuc-i3427.alporthouse.com> <1380566223.2674.200.camel@ul30vt.home> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ie0-f174.google.com (mail-ie0-f174.google.com [209.85.223.174]) by gabe.freedesktop.org (Postfix) with ESMTP id 9BC44E700F for ; Mon, 7 Oct 2013 00:34:27 -0700 (PDT) Received: by mail-ie0-f174.google.com with SMTP id u16so14885657iet.33 for ; Mon, 07 Oct 2013 00:34:26 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Dave Airlie Cc: Dave Airlie , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Mon, Oct 7, 2013 at 2:23 AM, Dave Airlie wrote: > I'm think I'm going to make an executive decision to merge Ville's > latest patch to avoid the regression, the other option being just to > revert everything back to the status quo by reverting all the patches > from the past few months, if people are happier with that then maybe > we should just do that for now and try and design our way out of it > properly by reengineering userspace and plan to avoid the regression > next time. Ack on merging Ville's hack. Longer-term we could beautify the pig a bit by moving it into vgaarb.c and avoiding the stop_machine if no one else has a vga lock. And I think in next we could try to limit the vga redisable hack in the lid notifier a bit on more modern platforms to avoid the dreaded stop_machine at runtime and relegate it to just resume/driver load. Really long term (once broken X servers have died) we can try to rip this hack out again. Or maybe intel hw engineers get their act together beforehand ;-) So can you directly pick it up since I've just flushed out my -fixes queue? Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch