From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932312AbcDVRgH (ORCPT ); Fri, 22 Apr 2016 13:36:07 -0400 Received: from mail-oi0-f50.google.com ([209.85.218.50]:35397 "EHLO mail-oi0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754524AbcDVRgF convert rfc822-to-8bit (ORCPT ); Fri, 22 Apr 2016 13:36:05 -0400 MIME-Version: 1.0 X-Originating-IP: [2a02:168:56b5:0:ac27:b86c:7764:9429] In-Reply-To: <571A5F31.8050301@tronnes.org> References: <1461165929-11344-1-git-send-email-noralf@tronnes.org> <1461165929-11344-5-git-send-email-noralf@tronnes.org> <571921F5.2080007@tronnes.org> <20160422082719.GH2510@phenom.ffwll.local> <571A326A.9070407@tronnes.org> <20160422170501.GE2510@phenom.ffwll.local> <571A5F31.8050301@tronnes.org> Date: Fri, 22 Apr 2016 19:36:03 +0200 X-Google-Sender-Auth: Vq-GQ-Y8I5cr2O4GZxKccEKg-n4 Message-ID: Subject: Re: [PATCH 4/8] drm/fb-helper: Add fb_deferred_io support From: Daniel Vetter To: =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= Cc: dri-devel , Linux Fbdev development list , Laurent Pinchart , Tomi Valkeinen , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 22, 2016 at 7:28 PM, Noralf Trønnes wrote: > This patch extend the use of the fbdev deferred_io worker to also handle > the fbdev drawing operations, which can happen in atomic context. > The qxl driver adds an extra worker (struct qxl_device).fb_work which is > used to flush the framebuffer. Both the mmap deferred_io (qxl_deferred_io()) > code which is run by the deferred io worker and the fbdev drawing operations > (qxl_fb_fillrect() etc.) schedule this fb_work worker. > > So this patch uses 1 worker, qxl uses 2 workers. Oh, I didn't realize that you're reusing the same worker for both things. 2 workers indeed make sense, since the mmap one must have a built-in delay (to coalesce a bunch of writes), whereas the other one probably should be run right away, after each op. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Fri, 22 Apr 2016 17:36:03 +0000 Subject: Re: [PATCH 4/8] drm/fb-helper: Add fb_deferred_io support Message-Id: List-Id: References: <1461165929-11344-1-git-send-email-noralf@tronnes.org> <1461165929-11344-5-git-send-email-noralf@tronnes.org> <571921F5.2080007@tronnes.org> <20160422082719.GH2510@phenom.ffwll.local> <571A326A.9070407@tronnes.org> <20160422170501.GE2510@phenom.ffwll.local> <571A5F31.8050301@tronnes.org> In-Reply-To: <571A5F31.8050301@tronnes.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= Cc: Linux Fbdev development list , Tomi Valkeinen , Laurent Pinchart , dri-devel , Linux Kernel Mailing List On Fri, Apr 22, 2016 at 7:28 PM, Noralf Tr=C3=B8nnes w= rote: > This patch extend the use of the fbdev deferred_io worker to also handle > the fbdev drawing operations, which can happen in atomic context. > The qxl driver adds an extra worker (struct qxl_device).fb_work which is > used to flush the framebuffer. Both the mmap deferred_io (qxl_deferred_io= ()) > code which is run by the deferred io worker and the fbdev drawing operati= ons > (qxl_fb_fillrect() etc.) schedule this fb_work worker. > > So this patch uses 1 worker, qxl uses 2 workers. Oh, I didn't realize that you're reusing the same worker for both things. 2 workers indeed make sense, since the mmap one must have a built-in delay (to coalesce a bunch of writes), whereas the other one probably should be run right away, after each op. -Daniel --=20 Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 4/8] drm/fb-helper: Add fb_deferred_io support Date: Fri, 22 Apr 2016 19:36:03 +0200 Message-ID: References: <1461165929-11344-1-git-send-email-noralf@tronnes.org> <1461165929-11344-5-git-send-email-noralf@tronnes.org> <571921F5.2080007@tronnes.org> <20160422082719.GH2510@phenom.ffwll.local> <571A326A.9070407@tronnes.org> <20160422170501.GE2510@phenom.ffwll.local> <571A5F31.8050301@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-oi0-x22d.google.com (mail-oi0-x22d.google.com [IPv6:2607:f8b0:4003:c06::22d]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC5136EF41 for ; Fri, 22 Apr 2016 17:36:04 +0000 (UTC) Received: by mail-oi0-x22d.google.com with SMTP id x201so123392138oif.3 for ; Fri, 22 Apr 2016 10:36:04 -0700 (PDT) In-Reply-To: <571A5F31.8050301@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= Cc: Linux Fbdev development list , Tomi Valkeinen , Laurent Pinchart , dri-devel , Linux Kernel Mailing List List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBBcHIgMjIsIDIwMTYgYXQgNzoyOCBQTSwgTm9yYWxmIFRyw7hubmVzIDxub3JhbGZA dHJvbm5lcy5vcmc+IHdyb3RlOgo+IFRoaXMgcGF0Y2ggZXh0ZW5kIHRoZSB1c2Ugb2YgdGhlIGZi ZGV2IGRlZmVycmVkX2lvIHdvcmtlciB0byBhbHNvIGhhbmRsZQo+IHRoZSBmYmRldiBkcmF3aW5n IG9wZXJhdGlvbnMsIHdoaWNoIGNhbiBoYXBwZW4gaW4gYXRvbWljIGNvbnRleHQuCj4gVGhlIHF4 bCBkcml2ZXIgYWRkcyBhbiBleHRyYSB3b3JrZXIgKHN0cnVjdCBxeGxfZGV2aWNlKS5mYl93b3Jr IHdoaWNoIGlzCj4gdXNlZCB0byBmbHVzaCB0aGUgZnJhbWVidWZmZXIuIEJvdGggdGhlIG1tYXAg ZGVmZXJyZWRfaW8gKHF4bF9kZWZlcnJlZF9pbygpKQo+IGNvZGUgd2hpY2ggaXMgcnVuIGJ5IHRo ZSBkZWZlcnJlZCBpbyB3b3JrZXIgYW5kIHRoZSBmYmRldiBkcmF3aW5nIG9wZXJhdGlvbnMKPiAo cXhsX2ZiX2ZpbGxyZWN0KCkgZXRjLikgc2NoZWR1bGUgdGhpcyBmYl93b3JrIHdvcmtlci4KPgo+ IFNvIHRoaXMgcGF0Y2ggdXNlcyAxIHdvcmtlciwgcXhsIHVzZXMgMiB3b3JrZXJzLgoKT2gsIEkg ZGlkbid0IHJlYWxpemUgdGhhdCB5b3UncmUgcmV1c2luZyB0aGUgc2FtZSB3b3JrZXIgZm9yIGJv dGgKdGhpbmdzLiAyIHdvcmtlcnMgaW5kZWVkIG1ha2Ugc2Vuc2UsIHNpbmNlIHRoZSBtbWFwIG9u ZSBtdXN0IGhhdmUgYQpidWlsdC1pbiBkZWxheSAodG8gY29hbGVzY2UgYSBidW5jaCBvZiB3cml0 ZXMpLCB3aGVyZWFzIHRoZSBvdGhlciBvbmUKcHJvYmFibHkgc2hvdWxkIGJlIHJ1biByaWdodCBh d2F5LCBhZnRlciBlYWNoIG9wLgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVu Z2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgorNDEgKDApIDc5IDM2NSA1NyA0OCAtIGh0dHA6Ly9i bG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo=