From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7885FECE564 for ; Tue, 18 Sep 2018 15:19:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32FCD214DD for ; Tue, 18 Sep 2018 15:19:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="EtPW62WR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32FCD214DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729973AbeIRUwM (ORCPT ); Tue, 18 Sep 2018 16:52:12 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:40321 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727756AbeIRUwM (ORCPT ); Tue, 18 Sep 2018 16:52:12 -0400 Received: by mail-it0-f65.google.com with SMTP id h23-v6so3483223ita.5 for ; Tue, 18 Sep 2018 08:19:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=5qIoN0hYeaglc05BP/qdQbwQQKHfCj5ZpaJkz8LE2/4=; b=EtPW62WRxQN6dQyB2Xt96G180BwVS3Rvy26aNe2lBI8LeLYAb+Z2KKDPTSXaHUNSkD 2ZzOWiCgR2zwxluBGMr6+YOvmX5H9wFvU4zAHODQ6/29tao5Zm3IRoLyxO/FRKU8z+Wh ETacrOv/nTy6XKWnn6O0Sgitbkup82P5Wiap0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=5qIoN0hYeaglc05BP/qdQbwQQKHfCj5ZpaJkz8LE2/4=; b=Wfwu4QLnfMqgTFsByYIHeOL+wKE3xi+9oMf+hV+jSWRmVI9kK5xlUSjNvTc0WBfCYy uq1ec4harSqs6dfqhxSNPYAYnDcBoDikv2PZ89CN0ORFpdgNHHYzIwUZroppl7iem2/4 pLK3s/ObtpOQGtnOmUtH0GAL/fkLJxiKS5pC9NwO3GN5AQkI8YWGafdYWQOopyHxrjoL BlDnmRnfSfY0Q9PAE4/kM3gn7S3/XRNIT0NXJDJc6fqsayl7CiILYzUFb2Q8MKs2R/wq EqBvBPP6TpWOoNT88qsoADOgnOTEF1fJU1dZx7+FpKqTkr8AwHnmLUKMNJ86DUfqSRiv 6tag== X-Gm-Message-State: APzg51Ae7qtBmbzMcgQMZnQ+LVvA92RZ1IvuQHQwtUi7oNCwyxENJf5o fXnWbS8vxfWkQ8M1pPO9ckg9euZbnfFm4+hHSeexsjMoE+U= X-Google-Smtp-Source: ANB0VdZAt5XOXxELa6f6y8N8kZtoLq/CMJEp9xM3QTE1DqP1hGLzWAFIXQJRnzTNZeCXI+dh99kKU9lOPB/HBmcH4nw= X-Received: by 2002:a02:b38c:: with SMTP id p12-v6mr26558141jan.79.1537283949508; Tue, 18 Sep 2018 08:19:09 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4f:6cc5:0:0:0:0:0 with HTTP; Tue, 18 Sep 2018 08:19:09 -0700 (PDT) X-Originating-IP: [2a02:168:569e:0:3106:d637:d723:e855] In-Reply-To: <20180827071824.GG3850@dragon> References: <1534472646-10368-1-git-send-email-zhongjiang@huawei.com> <20180827071824.GG3850@dragon> From: Daniel Vetter Date: Tue, 18 Sep 2018 17:19:09 +0200 X-Google-Sender-Auth: KrqEDgVS1HulppUMudA-xSag9Dg Message-ID: Subject: Re: [PATCH] gpu: do not double put device node in zx_drm_probe To: Shawn Guo Cc: zhong jiang , Dave Airlie , Linux Kernel Mailing List , dri-devel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 27, 2018 at 9:18 AM, Shawn Guo wrote: > On Fri, Aug 17, 2018 at 10:24:06AM +0800, zhong jiang wrote: >> for_each_available_child_of_node will get and put the node properly, >> the following of_node_put will lead to the double put. So just >> remove it. >> >> Signed-off-by: zhong jiang > > Acked-by: Shawn Guo Shawn, I'm assuming you'll push this to drm-misc-next? You're the maintainer with commit rights after all. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] gpu: do not double put device node in zx_drm_probe Date: Tue, 18 Sep 2018 17:19:09 +0200 Message-ID: References: <1534472646-10368-1-git-send-email-zhongjiang@huawei.com> <20180827071824.GG3850@dragon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C8AB6E1B3 for ; Tue, 18 Sep 2018 15:19:10 +0000 (UTC) Received: by mail-it0-x242.google.com with SMTP id h20-v6so3508855itf.2 for ; Tue, 18 Sep 2018 08:19:10 -0700 (PDT) In-Reply-To: <20180827071824.GG3850@dragon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Shawn Guo Cc: Dave Airlie , zhong jiang , Linux Kernel Mailing List , dri-devel List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBBdWcgMjcsIDIwMTggYXQgOToxOCBBTSwgU2hhd24gR3VvIDxzaGF3bmd1b0BrZXJu ZWwub3JnPiB3cm90ZToKPiBPbiBGcmksIEF1ZyAxNywgMjAxOCBhdCAxMDoyNDowNkFNICswODAw LCB6aG9uZyBqaWFuZyB3cm90ZToKPj4gZm9yX2VhY2hfYXZhaWxhYmxlX2NoaWxkX29mX25vZGUg d2lsbCBnZXQgYW5kIHB1dCB0aGUgbm9kZSBwcm9wZXJseSwKPj4gdGhlIGZvbGxvd2luZyBvZl9u b2RlX3B1dCB3aWxsIGxlYWQgdG8gdGhlIGRvdWJsZSBwdXQuIFNvIGp1c3QKPj4gcmVtb3ZlIGl0 Lgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiB6aG9uZyBqaWFuZyA8emhvbmdqaWFuZ0BodWF3ZWkuY29t Pgo+Cj4gQWNrZWQtYnk6IFNoYXduIEd1byA8c2hhd25ndW9Aa2VybmVsLm9yZz4KClNoYXduLCBJ J20gYXNzdW1pbmcgeW91J2xsIHB1c2ggdGhpcyB0byBkcm0tbWlzYy1uZXh0PyBZb3UncmUgdGhl Cm1haW50YWluZXIgd2l0aCBjb21taXQgcmlnaHRzIGFmdGVyIGFsbC4KLURhbmllbAotLSAKRGFu aWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KKzQxICgwKSA3 OSAzNjUgNTcgNDggLSBodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK