From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752071AbcDOLoF (ORCPT ); Fri, 15 Apr 2016 07:44:05 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:36098 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751210AbcDOLoD convert rfc822-to-8bit (ORCPT ); Fri, 15 Apr 2016 07:44:03 -0400 MIME-Version: 1.0 X-Originating-IP: [2a02:168:56b5:0:ac27:b86c:7764:9429] In-Reply-To: <5710AE61.9040308@amd.com> References: <1460683781-22535-1-git-send-email-gustavo@padovan.org> <1460683781-22535-2-git-send-email-gustavo@padovan.org> <20160415080254.GQ2510@phenom.ffwll.local> <5710AE61.9040308@amd.com> Date: Fri, 15 Apr 2016 13:44:01 +0200 X-Google-Sender-Auth: RhU4Plo1MRH_0G70rvJyXalDLdE Message-ID: Subject: Re: [RFC 1/8] dma-buf/fence: add fence_collection fences From: Daniel Vetter To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Gustavo Padovan , dri-devel , Linux Kernel Mailing List , Daniel Stone , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Riley Andrews , Rob Clark , Greg Hackmann , John Harrison , Laurent Pinchart , Sean Paul , =?UTF-8?Q?St=C3=A9phane_Marchesin?= , m.chehab@samsung.com, Maarten Lankhorst , Gustavo Padovan Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 15, 2016 at 11:03 AM, Christian König wrote: > Might be that how amdgpu uses the fence context and sequence number is a bit > questionable, but this will completely break it. You mean it tries to qualesce fences in the same context down to just the last one? That's how it's supposed to be done, and fence_collections do break this somewhat. Without fixing up fence_is_later and friends. Sounds like amdgpu is a good use case to make sure the changes in semantics in these functions result in sensible code. In a way a fence_collection is a fence where the timeline never matches with any other timeline (since it's a combiation). And yeah I think fence_collection should probably compress down the fences to 1 per timeline. But then that's just an implementation detail we can fix later on. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC 1/8] dma-buf/fence: add fence_collection fences Date: Fri, 15 Apr 2016 13:44:01 +0200 Message-ID: References: <1460683781-22535-1-git-send-email-gustavo@padovan.org> <1460683781-22535-2-git-send-email-gustavo@padovan.org> <20160415080254.GQ2510@phenom.ffwll.local> <5710AE61.9040308@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-oi0-x236.google.com (mail-oi0-x236.google.com [IPv6:2607:f8b0:4003:c06::236]) by gabe.freedesktop.org (Postfix) with ESMTPS id CD3596EC23 for ; Fri, 15 Apr 2016 11:44:02 +0000 (UTC) Received: by mail-oi0-x236.google.com with SMTP id p188so121195446oih.2 for ; Fri, 15 Apr 2016 04:44:02 -0700 (PDT) In-Reply-To: <5710AE61.9040308@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: =?UTF-8?Q?St=C3=A9phane_Marchesin?= , Daniel Stone , Sean Paul , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , dri-devel , Linux Kernel Mailing List , Riley Andrews , m.chehab@samsung.com, Gustavo Padovan , John Harrison , Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBBcHIgMTUsIDIwMTYgYXQgMTE6MDMgQU0sIENocmlzdGlhbiBLw7ZuaWcKPGNocmlz dGlhbi5rb2VuaWdAYW1kLmNvbT4gd3JvdGU6Cj4gTWlnaHQgYmUgdGhhdCBob3cgYW1kZ3B1IHVz ZXMgdGhlIGZlbmNlIGNvbnRleHQgYW5kIHNlcXVlbmNlIG51bWJlciBpcyBhIGJpdAo+IHF1ZXN0 aW9uYWJsZSwgYnV0IHRoaXMgd2lsbCBjb21wbGV0ZWx5IGJyZWFrIGl0LgoKWW91IG1lYW4gaXQg dHJpZXMgdG8gcXVhbGVzY2UgZmVuY2VzIGluIHRoZSBzYW1lIGNvbnRleHQgZG93biB0byBqdXN0 CnRoZSBsYXN0IG9uZT8gVGhhdCdzIGhvdyBpdCdzIHN1cHBvc2VkIHRvIGJlIGRvbmUsIGFuZApm ZW5jZV9jb2xsZWN0aW9ucyBkbyBicmVhayB0aGlzIHNvbWV3aGF0LiBXaXRob3V0IGZpeGluZyB1 cApmZW5jZV9pc19sYXRlciBhbmQgZnJpZW5kcy4gU291bmRzIGxpa2UgYW1kZ3B1IGlzIGEgZ29v ZCB1c2UgY2FzZSB0bwptYWtlIHN1cmUgdGhlIGNoYW5nZXMgaW4gc2VtYW50aWNzIGluIHRoZXNl IGZ1bmN0aW9ucyByZXN1bHQgaW4Kc2Vuc2libGUgY29kZS4gSW4gYSB3YXkgYSBmZW5jZV9jb2xs ZWN0aW9uIGlzIGEgZmVuY2Ugd2hlcmUgdGhlCnRpbWVsaW5lIG5ldmVyIG1hdGNoZXMgd2l0aCBh bnkgb3RoZXIgdGltZWxpbmUgKHNpbmNlIGl0J3MgYQpjb21iaWF0aW9uKS4KCkFuZCB5ZWFoIEkg dGhpbmsgZmVuY2VfY29sbGVjdGlvbiBzaG91bGQgcHJvYmFibHkgY29tcHJlc3MgZG93biB0aGUK ZmVuY2VzIHRvIDEgcGVyIHRpbWVsaW5lLiBCdXQgdGhlbiB0aGF0J3MganVzdCBhbiBpbXBsZW1l bnRhdGlvbgpkZXRhaWwgd2UgY2FuIGZpeCBsYXRlciBvbi4KLURhbmllbAotLSAKRGFuaWVsIFZl dHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KKzQxICgwKSA3OSAzNjUg NTcgNDggLSBodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK