From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: IGT development <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_gt: Move assert with setting 'reset' parameter after IGT env check
Date: Wed, 23 Jan 2019 17:54:01 +0100 [thread overview]
Message-ID: <CAKMK7uFcivmgFaGsi693Og9r4YqP2sx9ODjzjVyS27rQwoACRg@mail.gmail.com> (raw)
In-Reply-To: <154825274792.693.9396190037053540099@skylake-alporthouse-com>
On Wed, Jan 23, 2019 at 3:12 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Quoting Katarzyna Dec (2019-01-23 14:04:04)
> > We are trying to set reset parameter earlier than checking IGT env.
> > Let's move it after checking IGT env to avoid setting reset parameter
> > when hang injection is disabled.
> >
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com>
>
> I can see the sense in that. Can we kill the env var though?
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> If the system is not suitable for reset tests, can we not derive that
> from querying the system rather than rely on the user? We have better
> means of test selection now than just setting env var (and if not, why
> not) so afaik CI is not using it.
Yeah I thought the plan for these was to add some kernel patch (in
drm-intel-internal only ofc) which tells igt that reset isn't a thing.
We've definitely had this years ago, when there was no reset on gen2.
But maybe the wheels fell off on that one due to lack of use, dunno.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-01-23 16:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 14:04 [igt-dev] [PATCH i-g-t] lib/igt_gt: Move assert with setting 'reset' parameter after IGT env check Katarzyna Dec
2019-01-23 14:12 ` Chris Wilson
2019-01-23 16:54 ` Daniel Vetter [this message]
2019-01-23 15:17 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-23 17:59 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKMK7uFcivmgFaGsi693Og9r4YqP2sx9ODjzjVyS27rQwoACRg@mail.gmail.com \
--to=daniel.vetter@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.