From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC] GPU reset notification interface Date: Wed, 18 Jul 2012 18:42:05 +0200 Message-ID: References: <5005E433.40200@freedesktop.org> <20120718092014.GA5348@phenom.ffwll.local> <5006E312.3010103@freedesktop.org> <1342629383.3590.35.camel@atropine> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-qa0-f49.google.com (mail-qa0-f49.google.com [209.85.216.49]) by gabe.freedesktop.org (Postfix) with ESMTP id D2CDCA0DCB for ; Wed, 18 Jul 2012 09:42:47 -0700 (PDT) Received: by qabj40 with SMTP id j40so1054670qab.15 for ; Wed, 18 Jul 2012 09:42:47 -0700 (PDT) In-Reply-To: <1342629383.3590.35.camel@atropine> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Adam Jackson Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Wed, Jul 18, 2012 at 6:36 PM, Adam Jackson wrote: > On Wed, 2012-07-18 at 09:23 -0700, Ian Romanick wrote: >> On 07/18/2012 02:20 AM, Daniel Vetter wrote: >> > A few things: >> > - I agree with Chris that reset_in_progress should go, if userspace can >> > sneak in and witness a reset event, we have a bug in the kernel. Since >> > very recently, we actually have a few bugs less in that area ;-) >> >> I'm operating under the assumption that, from user space's perspective, >> resets are not instantaneous. If resets are instantaneous, that may >> change things. > > Do they need to be instantaneous, or do they merely need to be > atomic-and-reasonably-quick? Could just block new ioctl submission > until the reset completes. That's actually what we already do, that "block ioctls until reset completes thing" ;-) -Daniel -- Daniel Vetter daniel.vetter@ffwll.ch - +41 (0) 79 364 57 48 - http://blog.ffwll.ch