From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDD38C433DB for ; Tue, 19 Jan 2021 07:00:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BE9A2312B for ; Tue, 19 Jan 2021 07:00:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BE9A2312B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 25B3D6E827; Tue, 19 Jan 2021 07:00:32 +0000 (UTC) Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by gabe.freedesktop.org (Postfix) with ESMTPS id A936E6E827 for ; Tue, 19 Jan 2021 07:00:31 +0000 (UTC) Received: by mail-ot1-x329.google.com with SMTP id f6so9627763ots.9 for ; Mon, 18 Jan 2021 23:00:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TB6FTIfittFs99dug22EPlbke7plMpi7fTZPZrg+0CE=; b=UfFuyUq4YZunDhcSrPRGQWTcnz0pmPg4Uvk+3+WFFn8kejqKwQngot05xy/ZfWXo1n tQjn3xm0qNwH0VJ/lrvp20l5Gp/ncfSUrdFS8uGr+KpTxUhp+hodDqDjkHZTeAJ8lJDT FbGa3LddeIelpkFa8UvSjmvPx/nRiDgj3/r/s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TB6FTIfittFs99dug22EPlbke7plMpi7fTZPZrg+0CE=; b=ii75LKn9VuxHpgGMIEY1GmgL3bcr+TSDhYu9EMye1dY0dOrn8ik/PTk/N86d0j7H3X 1kUKJ5By0nH/60jEyQZ1yY4B132OOe+qEPsO193tkJya979qr5kaoTXDnZSvcD4tfrNT yY4a2quPLVzuQPUtjucc4gHFgtYdfIdwD7znWiAv9Ofyxw64HKknRXCu2x4uUEemf9xk kk2K64w2Sc5taZVyEe1rxoNWlUTdiqWJic+ZSb7Zlss6G26l84bQvED3WJ6AvSZ76WI4 U32gWDBK55OfKa0Fu7xj2fgx6FjyT7Xxpkx8ee50tGgEv2/O20B7KkSuJWTUox4SMSMf mLHQ== X-Gm-Message-State: AOAM532TCD4YInx2JwyL+ENoMn8dHRJuz2BLu6qQ5kyYMd6rk9cGwb6P MZUTLzRkjgLhdX+mtc3ysaarH9ViPJV5TQvC5WwFBw== X-Google-Smtp-Source: ABdhPJxXid5tfYESEzvOWaKE8HbioQrlcSyKOGoWm/5iR/86kHI6lj4Dy2chyY/WDn6CPSrHjhUv7s+NFTpNllHybSw= X-Received: by 2002:a9d:ea6:: with SMTP id 35mr2452410otj.188.1611039631002; Mon, 18 Jan 2021 23:00:31 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Daniel Vetter Date: Tue, 19 Jan 2021 08:00:19 +0100 Message-ID: Subject: Re: Reboot crash at msm_atomic_commit_tail To: Fabio Estevam X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jonathan Marek , Sean Paul , DRI mailing list , Bjorn Andersson , Sascha Hauer , "open list:DRM DRIVER FOR MSM ADRENO GPU" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Jan 18, 2021 at 11:00 PM Fabio Estevam wrote: > > On Mon, Jan 18, 2021 at 6:44 PM Fabio Estevam wrote: > > > > Adding some more folks in case anyone has any suggestions to fix this > > reboot hang. > > Not sure if this is a valid fix, but the change below makes reboot > works correctly. > > kmscube still works. > > --- a/drivers/gpu/drm/msm/msm_atomic.c > +++ b/drivers/gpu/drm/msm/msm_atomic.c > @@ -207,8 +207,12 @@ void msm_atomic_commit_tail(struct drm_atomic_state *state) > struct msm_kms *kms = priv->kms; > struct drm_crtc *async_crtc = NULL; > unsigned crtc_mask = get_crtc_mask(state); > - bool async = kms->funcs->vsync_time && > - can_do_async(state, &async_crtc); > + bool async; > + > + if (!kms) > + return; That looks a bit like a hack papering over the real issue. >From your report it sounds like earlier kernels worked, did you attempt bisecting? Also for regressions put regressions into the subject, it's the magic work that gets much more attention. -Daniel > + > + async = kms->funcs->vsync_time && can_do_async(state, &async_crtc); > > trace_msm_atomic_commit_tail_start(async, crtc_mask); > > Any comments? > > Thanks > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel